Re: [PATCH i-g-t] tests/intel/xe_eu_stall: Skip test on SR-IOV VF

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 23 May 2025 06:56:52 -0700, Bernatowicz, Marcin wrote:
>
>
>
> On 5/23/2025 3:11 PM, Bernatowicz, Marcin wrote:
> > Hi Jakub,
> >
> > On 5/23/2025 2:23 PM, Kolakowski, Jakub1 wrote:
> >> Hi Marcin,
> >> I was trying to align the code of the IGT test with kernel code, where
> >> we have an explicit check for SR-IOV VF.
> >> See https://gitlab.freedesktop.org/drm/tip/-/
> >> commit/1d622a4fe2b9a30cd4af2e858d793d05f8a82774
> >>
> And with this approach, the kernel check itself isn't really being tested ;)
> --
> marcin>> Jakub

Marcin is correct. This patch is wrong, IGT should check for -ENODEV
returned from kernel.

Both opening a stream as well as the EU stall query will return -ENODEV on
SRIOV VF.

@Chegondi, Harish: weren't you adding something for EU stall query if it's
not there?

> >
> > Still, I wonder if relying on VF checks is the best long-term approach -
> > we might enable the feature on a VF at some point, and the test would
> > keep skipping.
> > What about other apps using this feature - how should they detect
> > availability?
> > If they just try to use it on a VF, do they get ENODEV or something else?
> > Wouldn’t it be more robust to base this on a real feature check from
> > userspace if possible?
> > --
> > marcin