public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/gem_exec_gttfill: MMAP_OFFSET related refresh
@ 2020-03-05 17:53 Janusz Krzysztofik
  2020-03-05 18:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Janusz Krzysztofik @ 2020-03-05 17:53 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx

The test already tried to use a working mapping by first trying legacy
WC, then GTT.  Use gem_mmap__device_coherent() helper instead of
approaching its implementation locally.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
 tests/i915/gem_exec_gttfill.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
index f810dafd1..27277df48 100644
--- a/tests/i915/gem_exec_gttfill.c
+++ b/tests/i915/gem_exec_gttfill.c
@@ -155,15 +155,10 @@ static void fillgtt(int fd, unsigned ring, int timeout)
 	igt_assert(batches);
 	for (unsigned i = 0; i < count; i++) {
 		batches[i].handle = gem_create(fd, BATCH_SIZE);
-		batches[i].ptr =
-			__gem_mmap__wc(fd, batches[i].handle,
-				       0, BATCH_SIZE, PROT_WRITE);
-		if (!batches[i].ptr) {
-			batches[i].ptr =
-				__gem_mmap__gtt(fd, batches[i].handle,
-						BATCH_SIZE, PROT_WRITE);
-		}
-		igt_require(batches[i].ptr);
+		batches[i].ptr = gem_mmap__device_coherent(fd,
+							   batches[i].handle, 0,
+							   BATCH_SIZE,
+							   PROT_WRITE);
 	}
 
 	/* Flush all memory before we start the timer */
-- 
2.21.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-16  8:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-05 17:53 [igt-dev] [PATCH i-g-t] tests/gem_exec_gttfill: MMAP_OFFSET related refresh Janusz Krzysztofik
2020-03-05 18:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-06  8:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-03-16  8:09 ` [igt-dev] [PATCH i-g-t] " Janusz Krzysztofik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox