Re: [igt-dev] [PATCH i-g-t] tests/kms-hdr: Fix HDMI_STATIC_METADATA_TYPE1.

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Feb 12, 2021 at 06:44:47AM +0100, Mario Kleiner wrote:
> According to the CTA 861.G specification, table 44
> in section 6.9 and also specifically section 6.9.1,
> the value of the constant must be 0, not 1, so fix
> this.
> 
> An identical fix has been submitted for inclusion into
> the kernel headers (this is not exposed uapi). See:
> 
> https://lists.freedesktop.org/archives/dri-devel/2021-February/297233.html
> 
> Fixing this constant for Kodi also fixed some HDR TVs,
> so the wrong constant has real world consequences on
> some display hardware. See:
> 
> https://github.com/xbmc/xbmc/pull/19129
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> Cc: Simon Ser <contact@emersion.fr>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks. Pushed.

> ---
>  tests/kms_hdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index aa7e685b..e9dd7f27 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -35,7 +35,7 @@ IGT_TEST_DESCRIPTION("Test HDR metadata interfaces and bpc switch");
>  
>  /* DRM HDR definitions. Not in the UAPI header, unfortunately. */
>  enum hdmi_metadata_type {
> -	HDMI_STATIC_METADATA_TYPE1 = 1,
> +	HDMI_STATIC_METADATA_TYPE1 = 0,
>  };
>  
>  enum hdmi_eotf {
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev