Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms-hdr: Fix HDMI_STATIC_METADATA_TYPE1.
@ 2021-02-12  5:44 Mario Kleiner
  2021-02-12  6:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mario Kleiner @ 2021-02-12  5:44 UTC (permalink / raw)
  To: igt-dev; +Cc: Simon Ser, mario.kleiner.de

According to the CTA 861.G specification, table 44
in section 6.9 and also specifically section 6.9.1,
the value of the constant must be 0, not 1, so fix
this.

An identical fix has been submitted for inclusion into
the kernel headers (this is not exposed uapi). See:

https://lists.freedesktop.org/archives/dri-devel/2021-February/297233.html

Fixing this constant for Kodi also fixed some HDR TVs,
so the wrong constant has real world consequences on
some display hardware. See:

https://github.com/xbmc/xbmc/pull/19129

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Simon Ser <contact@emersion.fr>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_hdr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index aa7e685b..e9dd7f27 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -35,7 +35,7 @@ IGT_TEST_DESCRIPTION("Test HDR metadata interfaces and bpc switch");
 
 /* DRM HDR definitions. Not in the UAPI header, unfortunately. */
 enum hdmi_metadata_type {
-	HDMI_STATIC_METADATA_TYPE1 = 1,
+	HDMI_STATIC_METADATA_TYPE1 = 0,
 };
 
 enum hdmi_eotf {
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-12 14:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-12  5:44 [igt-dev] [PATCH i-g-t] tests/kms-hdr: Fix HDMI_STATIC_METADATA_TYPE1 Mario Kleiner
2021-02-12  6:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-12  7:25 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-12 14:31 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox