* [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work
@ 2021-03-17 22:49 Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
` (10 more replies)
0 siblings, 11 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
These are just a couple of small fixes that didn't seem important
enough to stick in their own patch series, but were various issues with
igt that I found along the way during my recent nouveau igt work.
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
Lyude Paul (7):
lib/drmtest: Use igt_assert_eq() for do_or_die()
lib/drmtest: And use do_or_die() in do_ioctl()
lib/drmtest: Remove i915 refs in do_ioctl*() docs
lib/igt_fb: Remove domain from igt_fb
lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame
lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress()
lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs
lib/drmtest.h | 8 ++++----
lib/igt_aux.c | 2 +-
lib/igt_debugfs.c | 2 +-
lib/igt_debugfs.h | 3 ++-
lib/igt_fb.c | 3 ---
lib/igt_fb.h | 2 --
6 files changed, 8 insertions(+), 12 deletions(-)
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die()
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-18 9:32 ` Petri Latvala
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 2/7] lib/drmtest: And use do_or_die() in do_ioctl() Lyude
` (9 subsequent siblings)
10 siblings, 1 reply; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres, Ben Skeggs
From: Lyude Paul <lyude@redhat.com>
Noticed this while working on some nouveau tests, if we use igt_assert_eq()
here we'll output both the expected and returned value instead of just the
expected value.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/drmtest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.h b/lib/drmtest.h
index d393dbf1..789452ea 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -113,7 +113,7 @@ bool is_vc4_device(int fd);
* that in any failure case the return value is non-zero and a precise error is
* logged into errno. Uses igt_assert() internally.
*/
-#define do_or_die(x) igt_assert((x) == 0)
+#define do_or_die(x) igt_assert_eq((x), 0)
/**
* do_ioctl:
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 2/7] lib/drmtest: And use do_or_die() in do_ioctl()
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 3/7] lib/drmtest: Remove i915 refs in do_ioctl*() docs Lyude
` (8 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres, Ben Skeggs
From: Lyude Paul <lyude@redhat.com>
No need to use igt_assert_eq() here now that do_or_die() uses
igt_assert_eq()
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/drmtest.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.h b/lib/drmtest.h
index 789452ea..c4b15a26 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -125,7 +125,7 @@ bool is_vc4_device(int fd);
* successfully executed.
*/
#define do_ioctl(fd, ioc, ioc_data) do { \
- igt_assert_eq(igt_ioctl((fd), (ioc), (ioc_data)), 0); \
+ do_or_die(igt_ioctl((fd), (ioc), (ioc_data))); \
errno = 0; \
} while (0)
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 3/7] lib/drmtest: Remove i915 refs in do_ioctl*() docs
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 2/7] lib/drmtest: And use do_or_die() in do_ioctl() Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb Lyude
` (7 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
These aren't i915 specific, looks like some historical junk.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/drmtest.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/drmtest.h b/lib/drmtest.h
index c4b15a26..b933f76a 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -117,7 +117,7 @@ bool is_vc4_device(int fd);
/**
* do_ioctl:
- * @fd: open i915 drm file descriptor
+ * @fd: open drm file descriptor
* @ioc: ioctl op definition from drm headers
* @ioc_data: data pointer for the ioctl operation
*
@@ -131,7 +131,7 @@ bool is_vc4_device(int fd);
/**
* do_ioctl_err:
- * @fd: open i915 drm file descriptor
+ * @fd: open drm file descriptor
* @ioc: ioctl op definition from drm headers
* @ioc_data: data pointer for the ioctl operation
* @err: value to expect in errno
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (2 preceding siblings ...)
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 3/7] lib/drmtest: Remove i915 refs in do_ioctl*() docs Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-18 12:49 ` Ville Syrjälä
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 5/7] lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame Lyude
` (6 subsequent siblings)
10 siblings, 1 reply; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
It doesn't look like that this is used by i915 for anything these days, so
let's just remove this while we're at it.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/igt_fb.c | 3 ---
lib/igt_fb.h | 2 --
2 files changed, 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f0fcd1a7..2b478887 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2491,7 +2491,6 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb)
cairo_format,
fb->width, fb->height,
blit->linear.fb.strides[0]);
- fb->domain = I915_GEM_DOMAIN_GTT;
cairo_surface_set_user_data(fb->cairo_surface,
(cairo_user_data_key_t *)create_cairo_surface__gpu,
@@ -2571,8 +2570,6 @@ static void create_cairo_surface__gtt(int fd, struct igt_fb *fb)
"Unable to create a cairo surface: %s\n",
cairo_status_to_string(cairo_surface_status(fb->cairo_surface)));
- fb->domain = I915_GEM_DOMAIN_GTT;
-
cairo_surface_set_user_data(fb->cairo_surface,
(cairo_user_data_key_t *)create_cairo_surface__gtt,
fb, destroy_cairo_surface__gtt);
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 0d64898a..e4f8b2b1 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -64,7 +64,6 @@ struct buf_ops;
* @modifier: tiling mode as a DRM framebuffer modifier
* @size: size in bytes of the underlying backing storage
* @cairo_surface: optionally attached cairo drawing surface
- * @domain: current domain for cache flushing tracking on i915.ko
* @num_planes: Amount of planes on this fb. >1 for planar formats.
* @strides: line stride for each plane in bytes
* @offsets: Offset for each plane in bytes.
@@ -87,7 +86,6 @@ typedef struct igt_fb {
uint64_t modifier;
uint64_t size;
cairo_surface_t *cairo_surface;
- unsigned int domain;
unsigned int num_planes;
uint32_t strides[4];
uint32_t offsets[4];
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 5/7] lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (3 preceding siblings ...)
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 6/7] lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress() Lyude
` (5 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
Looks like this never got updated when has_valid_frame got added.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/igt_debugfs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h
index d43ba6c6..97cbaa1c 100644
--- a/lib/igt_debugfs.h
+++ b/lib/igt_debugfs.h
@@ -70,10 +70,11 @@ typedef struct _igt_pipe_crc igt_pipe_crc_t;
/**
* igt_crc_t:
* @frame: frame number of the capture CRC
+ * @has_valid_frame: whether this CRC entry has a valid frame counter
* @n_words: internal field, don't access
* @crc: internal field, don't access
*
- * Pipe CRC value. All other members than @frame are private and should not be
+ * Pipe CRC value. All other members than @frame and @has_valid_frame are private and should not be
* inspected by testcases.
*/
typedef struct {
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 6/7] lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress()
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (4 preceding siblings ...)
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 5/7] lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 7/7] lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs Lyude
` (4 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/igt_aux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 1217f5e8..0ab51124 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -997,7 +997,7 @@ void igt_debug_wait_for_keypress(const char *var)
!strstr(igt_interactive_debug, "all"))
return;
- igt_info("Press any key to continue ...\n");
+ igt_info("Hit interactive debug var %s, press any key to continue...\n", var);
tcgetattr ( STDIN_FILENO, &oldt );
newt = oldt;
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH i-g-t 7/7] lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (5 preceding siblings ...)
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 6/7] lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress() Lyude
@ 2021-03-17 22:49 ` Lyude
2021-03-18 1:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Miscellaneous cleanups from nouveau work Patchwork
` (3 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Lyude @ 2021-03-17 22:49 UTC (permalink / raw)
To: nouveau, igt-dev; +Cc: Martin Peres
From: Lyude Paul <lyude@redhat.com>
Looks like this got broken in ab405a405
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Martin Peres <martin.peres@free.fr>
Cc: Jeremy Cline <jcline@redhat.com>
---
lib/igt_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 2f58519a..a9f1cf40 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -972,7 +972,7 @@ void igt_pipe_crc_get_single(igt_pipe_crc_t *pipe_crc, igt_crc_t *crc)
}
/**
- * igt_pipe_crc_get_current:
+ * igt_pipe_crc_get_for_frame:
* @drm_fd: Pointer to drm fd for vblank counter
* @pipe_crc: pipe CRC object
* @vblank: frame counter value we're looking for
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Miscellaneous cleanups from nouveau work
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (6 preceding siblings ...)
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 7/7] lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs Lyude
@ 2021-03-18 1:33 ` Patchwork
2021-03-18 5:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-03-18 1:33 UTC (permalink / raw)
To: Lyude Paul; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 3377 bytes --]
== Series Details ==
Series: lib: Miscellaneous cleanups from nouveau work
URL : https://patchwork.freedesktop.org/series/88081/
State : success
== Summary ==
CI Bug Log - changes from IGT_6035 -> IGTPW_5616
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/index.html
Known issues
------------
Here are the changes found in IGTPW_5616 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> [DMESG-WARN][2] ([i915#2947])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-kbl-8809g/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@runner@aborted:
- fi-kbl-8809g: NOTRUN -> [FAIL][3] ([i915#2947])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-kbl-8809g/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_linear_blits@basic:
- fi-kbl-8809g: [TIMEOUT][4] ([i915#2502] / [i915#3145]) -> [PASS][5] +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/fi-kbl-8809g/igt@gem_linear_blits@basic.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-kbl-8809g/igt@gem_linear_blits@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][6] ([i915#2940]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][8] ([i915#1982] / [i915#3143]) -> [DMESG-WARN][9] ([i915#3143])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#2947]: https://gitlab.freedesktop.org/drm/intel/issues/2947
[i915#3143]: https://gitlab.freedesktop.org/drm/intel/issues/3143
[i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6035 -> IGTPW_5616
CI-20190529: 20190529
CI_DRM_9867: 5f7383f6c1c95be9758792da71084f8f2c0c5953 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5616: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/index.html
IGT_6035: ad5eb02eb3f10a41d0f1feba7efc02db87cd06b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/index.html
[-- Attachment #1.2: Type: text/html, Size: 4241 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Miscellaneous cleanups from nouveau work
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (7 preceding siblings ...)
2021-03-18 1:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Miscellaneous cleanups from nouveau work Patchwork
@ 2021-03-18 5:18 ` Patchwork
2021-03-18 6:48 ` [igt-dev] [PATCH i-g-t 0/7] " Martin Peres
2021-03-18 9:38 ` Petri Latvala
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2021-03-18 5:18 UTC (permalink / raw)
To: Lyude Paul; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30263 bytes --]
== Series Details ==
Series: lib: Miscellaneous cleanups from nouveau work
URL : https://patchwork.freedesktop.org/series/88081/
State : success
== Summary ==
CI Bug Log - changes from IGT_6035_full -> IGTPW_5616_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_5616_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5616_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5616_full:
### IGT changes ###
#### Warnings ####
* igt@kms_content_protection@content_type_change:
- shard-iclb: [SKIP][1] ([fdo#109300] / [fdo#111066]) -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb8/igt@kms_content_protection@content_type_change.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb1/igt@kms_content_protection@content_type_change.html
Known issues
------------
Here are the changes found in IGTPW_5616_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][3] ([i915#3002]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@gem_create@create-massive.html
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][4] ([fdo#109314])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb7/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl6/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk9/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb4/igt@gem_exec_fair@basic-pace@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb3/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#2849])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@no-vebox:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@gem_exec_params@no-vebox.html
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109283])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb8/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_params@secure-non-master:
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#112283])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb3/igt@gem_exec_params@secure-non-master.html
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#112283])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb8/igt@gem_exec_params@secure-non-master.html
* igt@gem_exec_reloc@basic-many-active@vcs0:
- shard-kbl: NOTRUN -> [FAIL][25] ([i915#2389]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl2/igt@gem_exec_reloc@basic-many-active@vcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][26] ([i915#2389]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb7/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][27] -> [DMESG-WARN][28] ([i915#118] / [i915#95])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk4/igt@gem_exec_whisper@basic-forked-all.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#2190])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl7/igt@gem_huc_copy@huc-copy.html
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#2190])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk5/igt@gem_huc_copy@huc-copy.html
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2190])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb8/igt@gem_huc_copy@huc-copy.html
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2190])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl4/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@big-copy:
- shard-glk: NOTRUN -> [FAIL][33] ([i915#307]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk3/igt@gem_mmap_gtt@big-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][34] -> [FAIL][35] ([i915#307]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][36] ([i915#2658])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#768]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb5/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html
* igt@gem_userptr_blits@input-checking:
- shard-tglb: NOTRUN -> [DMESG-WARN][38] ([i915#3002]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@gem_userptr_blits@input-checking.html
- shard-apl: NOTRUN -> [DMESG-WARN][39] ([i915#3002])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl1/igt@gem_userptr_blits@input-checking.html
- shard-glk: NOTRUN -> [DMESG-WARN][40] ([i915#3002])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk7/igt@gem_userptr_blits@input-checking.html
- shard-kbl: NOTRUN -> [DMESG-WARN][41] ([i915#3002])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@process-exit-mmap-busy@wc:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#1699]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl1/igt@gem_userptr_blits@process-exit-mmap-busy@wc.html
* igt@gen3_mixed_blits:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109289])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@gen3_mixed_blits.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#112306])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb5/igt@gen9_exec_parse@basic-rejected-ctx-param.html
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#112306])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb4/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@bb-oversize:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#2527])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb7/igt@gen9_exec_parse@bb-oversize.html
- shard-iclb: NOTRUN -> [SKIP][47] ([i915#2527])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb7/igt@gen9_exec_parse@bb-oversize.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][48] ([i915#2782])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111614])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#111615]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb5/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +28 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb3/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb4/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-glk: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +9 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk5/igt@kms_color_chamelium@pipe-d-degamma.html
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +10 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb5/igt@kms_color_chamelium@pipe-d-degamma.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +25 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb5/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@atomic-dpms:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#111828]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@lic:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109300] / [fdo#111066]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb5/igt@kms_content_protection@lic.html
- shard-kbl: NOTRUN -> [TIMEOUT][60] ([i915#1319])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl6/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [fdo#109279]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb5/igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109279]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274] / [fdo#109278])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@kms_cursor_legacy@cursorb-vs-flipb-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [PASS][66] -> [FAIL][67] ([i915#2346])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [FAIL][68] ([i915#2346])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: NOTRUN -> [FAIL][69] ([i915#2346] / [i915#533])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#426])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb4/igt@kms_dp_tiled_display@basic-test-pattern.html
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#426])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb5/igt@kms_dp_tiled_display@basic-test-pattern.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109274]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb6/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][73] -> [FAIL][74] ([i915#2598])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][75] -> [DMESG-WARN][76] ([i915#180]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][77] ([fdo#109271]) +400 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109280]) +13 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271]) +62 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#111825]) +26 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271]) +67 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk6/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_hdr@static-toggle:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#1187])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb6/igt@kms_hdr@static-toggle.html
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#1187])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@kms_hdr@static-toggle.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#533])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_cursor@pipe-d-overlay-size-256:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109278]) +11 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb8/igt@kms_plane_cursor@pipe-d-overlay-size-256.html
* igt@kms_plane_lowres@pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#112054])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@kms_plane_lowres@pipe-d-tiling-yf.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2733])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658]) +5 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk1/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109441]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb3/igt@kms_psr@psr2_primary_blt.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][94] -> [SKIP][95] ([fdo#109441]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@kms_psr@psr2_suspend.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb6/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][96] ([i915#31])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb5/igt@kms_setmode@basic.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#2530]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109278] / [i915#2530])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb3/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271]) +238 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109291]) +5 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@prime_nv_pcopy@test3_2.html
* igt@prime_nv_test@nv_i915_sharing:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109291]) +3 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@prime_nv_test@nv_i915_sharing.html
* igt@sysfs_clients@recycle:
- shard-apl: NOTRUN -> [FAIL][102] ([i915#3028])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl2/igt@sysfs_clients@recycle.html
- shard-glk: [PASS][103] -> [FAIL][104] ([i915#3028])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk7/igt@sysfs_clients@recycle.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk3/igt@sysfs_clients@recycle.html
* igt@sysfs_clients@split-10@bcs0:
- shard-apl: [PASS][105] -> [SKIP][106] ([fdo#109271] / [i915#3026])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl1/igt@sysfs_clients@split-10@bcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl8/igt@sysfs_clients@split-10@bcs0.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][107] ([i915#2846]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][109] ([i915#2842]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl3/igt@gem_exec_fair@basic-none@vcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html
- shard-glk: [FAIL][111] ([i915#2842]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][113] ([i915#2851]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
- shard-tglb: [FAIL][115] ([i915#2842]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-apl: [FAIL][117] ([i915#2389]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl6/igt@gem_exec_reloc@basic-many-active@rcs0.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl7/igt@gem_exec_reloc@basic-many-active@rcs0.html
- shard-glk: [FAIL][119] ([i915#2389]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk5/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-glk: [DMESG-WARN][121] ([i915#1610] / [i915#2803]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk3/igt@gem_exec_schedule@u-fairslice@rcs0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk2/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_workarounds@reset:
- shard-snb: [TIMEOUT][123] -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-snb7/igt@gem_workarounds@reset.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-snb2/igt@gem_workarounds@reset.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1:
- shard-glk: [FAIL][125] ([i915#2122]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk1/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-glk: [FAIL][127] ([i915#49]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-glk5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-glk5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
- shard-apl: [FAIL][129] ([i915#49]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-apl1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-apl7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
- shard-kbl: [FAIL][131] ([i915#49]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][133] ([fdo#109441]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb1/igt@kms_psr@psr2_dpms.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb2/igt@kms_psr@psr2_dpms.html
* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][135] ([i915#1542]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb2/igt@perf@polling-parameterized.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb8/igt@perf@polling-parameterized.html
* igt@sysfs_clients@recycle-many:
- shard-tglb: [FAIL][137] ([i915#3028]) -> [PASS][138] +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-tglb7/igt@sysfs_clients@recycle-many.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-tglb1/igt@sysfs_clients@recycle-many.html
#### Warnings ####
* igt@gem_exec_balancer@hang:
- shard-iclb: [INCOMPLETE][139] ([i915#1895] / [i915#3031]) -> [INCOMPLETE][140] ([i915#1895])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb4/igt@gem_exec_balancer@hang.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb1/igt@gem_exec_balancer@hang.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][141] ([i915#588]) -> [SKIP][142] ([i915#658])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][143] ([i915#1804] / [i915#2684]) -> [FAIL][144] ([i915#2680])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [INCOMPLETE][145] ([i915#155]) -> [DMESG-WARN][146] ([i915#180])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6035/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/shard-kbl7/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5616/index.html
[-- Attachment #1.2: Type: text/html, Size: 33687 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (8 preceding siblings ...)
2021-03-18 5:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2021-03-18 6:48 ` Martin Peres
2021-03-18 9:38 ` Petri Latvala
10 siblings, 0 replies; 14+ messages in thread
From: Martin Peres @ 2021-03-18 6:48 UTC (permalink / raw)
To: Lyude, nouveau, igt-dev; +Cc: Martin Peres
On 18/03/2021 00:49, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> These are just a couple of small fixes that didn't seem important
> enough to stick in their own patch series, but were various issues with
> igt that I found along the way during my recent nouveau igt work.
>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Jeremy Cline <jcline@redhat.com>
This series looks sensible to me, and do not seem to have affected
Intel's results.
I'll refrain from giving a full R-b because I lack the historical
context for some of these changes, but it seems safe to me:
Acked-by: Martin Peres <martin.peres@mupuf.org>
>
> Lyude Paul (7):
> lib/drmtest: Use igt_assert_eq() for do_or_die()
> lib/drmtest: And use do_or_die() in do_ioctl()
> lib/drmtest: Remove i915 refs in do_ioctl*() docs
> lib/igt_fb: Remove domain from igt_fb
> lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame
> lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress()
> lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs
>
> lib/drmtest.h | 8 ++++----
> lib/igt_aux.c | 2 +-
> lib/igt_debugfs.c | 2 +-
> lib/igt_debugfs.h | 3 ++-
> lib/igt_fb.c | 3 ---
> lib/igt_fb.h | 2 --
> 6 files changed, 8 insertions(+), 12 deletions(-)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die()
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
@ 2021-03-18 9:32 ` Petri Latvala
0 siblings, 0 replies; 14+ messages in thread
From: Petri Latvala @ 2021-03-18 9:32 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev, nouveau, Martin Peres, Ben Skeggs
On Wed, Mar 17, 2021 at 06:49:43PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> Noticed this while working on some nouveau tests, if we use igt_assert_eq()
> here we'll output both the expected and returned value instead of just the
> expected value.
igt_assert_eq stuffs x into an int so there's one difference.
Hmm, but generally do_or_die is used with ioctl() or something that
wraps it and it will be an int.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: Jeremy Cline <jcline@redhat.com>
> ---
> lib/drmtest.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index d393dbf1..789452ea 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -113,7 +113,7 @@ bool is_vc4_device(int fd);
> * that in any failure case the return value is non-zero and a precise error is
> * logged into errno. Uses igt_assert() internally.
A minor cosmetic change to this comment (igt_assert usage) is welcome.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> */
> -#define do_or_die(x) igt_assert((x) == 0)
> +#define do_or_die(x) igt_assert_eq((x), 0)
>
> /**
> * do_ioctl:
> --
> 2.29.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
` (9 preceding siblings ...)
2021-03-18 6:48 ` [igt-dev] [PATCH i-g-t 0/7] " Martin Peres
@ 2021-03-18 9:38 ` Petri Latvala
10 siblings, 0 replies; 14+ messages in thread
From: Petri Latvala @ 2021-03-18 9:38 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev, nouveau, Martin Peres
On Wed, Mar 17, 2021 at 06:49:42PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> These are just a couple of small fixes that didn't seem important
> enough to stick in their own patch series, but were various issues with
> igt that I found along the way during my recent nouveau igt work.
>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Jeremy Cline <jcline@redhat.com>
>
> Lyude Paul (7):
> lib/drmtest: Use igt_assert_eq() for do_or_die()
> lib/drmtest: And use do_or_die() in do_ioctl()
> lib/drmtest: Remove i915 refs in do_ioctl*() docs
> lib/igt_fb: Remove domain from igt_fb
> lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame
> lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress()
> lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs
>
> lib/drmtest.h | 8 ++++----
> lib/igt_aux.c | 2 +-
> lib/igt_debugfs.c | 2 +-
> lib/igt_debugfs.h | 3 ++-
> lib/igt_fb.c | 3 ---
> lib/igt_fb.h | 2 --
> 6 files changed, 8 insertions(+), 12 deletions(-)
>
One minor comment on one patch, otherwise LGTM.
Series is
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb Lyude
@ 2021-03-18 12:49 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2021-03-18 12:49 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev, nouveau, Martin Peres
On Wed, Mar 17, 2021 at 06:49:46PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> It doesn't look like that this is used by i915 for anything these days, so
> let's just remove this while we're at it.
I wa scurious why this is here so dug around a bit.
It was added in
commit 18d0b1efb875 ("lib/igt_fb: Fix domain tracking for GTT cairo surfaces")
then got broken again by
commit 89b3ffe02c2a ("lib: Map dumb buffers")
and later fixed again with
commit 3bd68529c464 ("lib/igt_fb: Add missing set_domain calls")
So yeah, not needed anymore.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Jeremy Cline <jcline@redhat.com>
> ---
> lib/igt_fb.c | 3 ---
> lib/igt_fb.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index f0fcd1a7..2b478887 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2491,7 +2491,6 @@ static void create_cairo_surface__gpu(int fd, struct igt_fb *fb)
> cairo_format,
> fb->width, fb->height,
> blit->linear.fb.strides[0]);
> - fb->domain = I915_GEM_DOMAIN_GTT;
>
> cairo_surface_set_user_data(fb->cairo_surface,
> (cairo_user_data_key_t *)create_cairo_surface__gpu,
> @@ -2571,8 +2570,6 @@ static void create_cairo_surface__gtt(int fd, struct igt_fb *fb)
> "Unable to create a cairo surface: %s\n",
> cairo_status_to_string(cairo_surface_status(fb->cairo_surface)));
>
> - fb->domain = I915_GEM_DOMAIN_GTT;
> -
> cairo_surface_set_user_data(fb->cairo_surface,
> (cairo_user_data_key_t *)create_cairo_surface__gtt,
> fb, destroy_cairo_surface__gtt);
> diff --git a/lib/igt_fb.h b/lib/igt_fb.h
> index 0d64898a..e4f8b2b1 100644
> --- a/lib/igt_fb.h
> +++ b/lib/igt_fb.h
> @@ -64,7 +64,6 @@ struct buf_ops;
> * @modifier: tiling mode as a DRM framebuffer modifier
> * @size: size in bytes of the underlying backing storage
> * @cairo_surface: optionally attached cairo drawing surface
> - * @domain: current domain for cache flushing tracking on i915.ko
> * @num_planes: Amount of planes on this fb. >1 for planar formats.
> * @strides: line stride for each plane in bytes
> * @offsets: Offset for each plane in bytes.
> @@ -87,7 +86,6 @@ typedef struct igt_fb {
> uint64_t modifier;
> uint64_t size;
> cairo_surface_t *cairo_surface;
> - unsigned int domain;
> unsigned int num_planes;
> uint32_t strides[4];
> uint32_t offsets[4];
> --
> 2.29.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-03-18 12:49 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 22:49 [igt-dev] [PATCH i-g-t 0/7] lib: Miscellaneous cleanups from nouveau work Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 1/7] lib/drmtest: Use igt_assert_eq() for do_or_die() Lyude
2021-03-18 9:32 ` Petri Latvala
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 2/7] lib/drmtest: And use do_or_die() in do_ioctl() Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 3/7] lib/drmtest: Remove i915 refs in do_ioctl*() docs Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 4/7] lib/igt_fb: Remove domain from igt_fb Lyude
2021-03-18 12:49 ` Ville Syrjälä
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 5/7] lib/debugfs: Fix igt_crc_t docs to mention has_valid_frame Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 6/7] lib/igt_aux: Print name of debug var in igt_debug_wait_for_keypress() Lyude
2021-03-17 22:49 ` [igt-dev] [PATCH i-g-t 7/7] lib/debugfs: Fix function name in igt_pipe_crc_get_for_frame() docs Lyude
2021-03-18 1:33 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Miscellaneous cleanups from nouveau work Patchwork
2021-03-18 5:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-03-18 6:48 ` [igt-dev] [PATCH i-g-t 0/7] " Martin Peres
2021-03-18 9:38 ` Petri Latvala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox