* [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode @ 2021-05-12 6:37 Khaled Almahallawy 2021-05-12 7:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2021-05-12 12:01 ` [igt-dev] [RFC PATCH i-g-t] " Ville Syrjälä 0 siblings, 2 replies; 4+ messages in thread From: Khaled Almahallawy @ 2021-05-12 6:37 UTC (permalink / raw) To: igt-dev; +Cc: petri.latvala Implementing: /* * FIXME test every mode we have to be more * sure everything is really getting rejected? */ Output of the test will look like the following: ... Checking pipe A connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 Checking pipe B connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 Checking pipe C connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 Checking pipe D connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 SUCCESS (0.743s) Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com> --- tests/kms_invalid_dotclock.c | 54 +++++++++++++++++------------------- 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/tests/kms_invalid_dotclock.c b/tests/kms_invalid_dotclock.c index 402629ab097f..aab765136d0e 100644 --- a/tests/kms_invalid_dotclock.c +++ b/tests/kms_invalid_dotclock.c @@ -48,9 +48,10 @@ static int test_output(data_t *data) { igt_output_t *output = data->output; - drmModeModeInfo mode; + drmModeConnector *connector = output->config.connector; + drmModeModeInfo *mode; struct igt_fb fb; - int i; + int i, j; /* * FIXME When we have a fixed mode, the kernel will ignore @@ -63,33 +64,30 @@ test_output(data_t *data) if (has_scaling_mode_prop(data)) return 0; - /* - * FIXME test every mode we have to be more - * sure everything is really getting rejected? - */ - mode = *igt_output_get_mode(output); - mode.clock = data->max_dotclock + 1; - - igt_create_fb(data->drm_fd, - mode.hdisplay, mode.vdisplay, - DRM_FORMAT_XRGB8888, - LOCAL_DRM_FORMAT_MOD_NONE, - &fb); - - for (i = 0; i < data->res->count_crtcs; i++) { - int ret; - - igt_info("Checking pipe %c connector %s with mode %s\n", - 'A'+i, output->name, mode.name); - - ret = drmModeSetCrtc(data->drm_fd, data->res->crtcs[i], - fb.fb_id, 0, 0, - &output->id, 1, &mode); - igt_assert_lt(ret, 0); + for (j = 0; j < connector->count_modes; j++) { + mode = &connector->modes[j]; + mode->clock = data->max_dotclock + 1; + + igt_create_fb(data->drm_fd, + mode->hdisplay, mode->vdisplay, + DRM_FORMAT_XRGB8888, + LOCAL_DRM_FORMAT_MOD_NONE, + &fb); + + for (i = 0; i < data->res->count_crtcs; i++) { + int ret; + + igt_info("Checking pipe %c connector %s with mode", + 'A'+i, output->name); + kmstest_dump_mode(mode); + ret = drmModeSetCrtc(data->drm_fd, data->res->crtcs[i], + fb.fb_id, 0, 0, + &output->id, 1, mode); + igt_assert_lt(ret, 0); + } + + igt_remove_fb(data->drm_fd, &fb); } - - igt_remove_fb(data->drm_fd, &fb); - return 1; } -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_invalid_dotclock: Test every mode 2021-05-12 6:37 [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode Khaled Almahallawy @ 2021-05-12 7:12 ` Patchwork 2021-05-12 12:01 ` [igt-dev] [RFC PATCH i-g-t] " Ville Syrjälä 1 sibling, 0 replies; 4+ messages in thread From: Patchwork @ 2021-05-12 7:12 UTC (permalink / raw) To: Khaled Almahallawy; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 11382 bytes --] == Series Details == Series: tests/kms_invalid_dotclock: Test every mode URL : https://patchwork.freedesktop.org/series/90053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10071 -> IGTPW_5804 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_5804 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5804, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5804: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live@coherency: - fi-icl-y: [PASS][1] -> [DMESG-WARN][2] +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-icl-y/igt@i915_selftest@live@coherency.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-icl-y/igt@i915_selftest@live@coherency.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a: - fi-elk-e7500: [PASS][3] -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - fi-bsw-kefka: [PASS][5] -> [FAIL][6] +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a.html #### Warnings #### * igt@gem_exec_gttfill@basic: - fi-elk-e7500: [FAIL][7] ([i915#3457]) -> [FAIL][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-elk-e7500/igt@gem_exec_gttfill@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-elk-e7500/igt@gem_exec_gttfill@basic.html * igt@i915_selftest@live@execlists: - fi-bsw-nick: [INCOMPLETE][9] ([i915#2782] / [i915#2940]) -> [DMESG-FAIL][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-nick/igt@i915_selftest@live@execlists.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-nick/igt@i915_selftest@live@execlists.html Known issues ------------ Here are the changes found in IGTPW_5804 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fence@basic-await@vecs0: - fi-glk-dsi: [PASS][11] -> [FAIL][12] ([i915#3457]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-glk-dsi/igt@gem_exec_fence@basic-await@vecs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-glk-dsi/igt@gem_exec_fence@basic-await@vecs0.html * igt@gem_exec_fence@nb-await@vcs0: - fi-bsw-n3050: [PASS][13] -> [FAIL][14] ([i915#3457]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-n3050/igt@gem_exec_fence@nb-await@vcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-n3050/igt@gem_exec_fence@nb-await@vcs0.html * igt@gem_exec_fence@nb-await@vecs0: - fi-bsw-kefka: [PASS][15] -> [FAIL][16] ([i915#3457]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vecs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-kefka/igt@gem_exec_fence@nb-await@vecs0.html * igt@gem_wait@busy@all: - fi-bwr-2160: [PASS][17] -> [FAIL][18] ([i915#3457]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bwr-2160/igt@gem_wait@busy@all.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bwr-2160/igt@gem_wait@busy@all.html * igt@gem_wait@wait@all: - fi-bsw-nick: [PASS][19] -> [FAIL][20] ([i915#3457]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-nick/igt@gem_wait@wait@all.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-nick/igt@gem_wait@wait@all.html * igt@i915_pm_rpm@module-reload: - fi-icl-y: [PASS][21] -> [FAIL][22] ([i915#579]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-icl-y/igt@i915_pm_rpm@module-reload.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-icl-y/igt@i915_pm_rpm@module-reload.html #### Possible fixes #### * igt@gem_exec_fence@basic-await@rcs0: - fi-glk-dsi: [FAIL][23] ([i915#3457]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-glk-dsi/igt@gem_exec_fence@basic-await@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-glk-dsi/igt@gem_exec_fence@basic-await@rcs0.html * igt@gem_exec_fence@nb-await@rcs0: - fi-bsw-nick: [FAIL][25] ([i915#3457]) -> [PASS][26] +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-nick/igt@gem_exec_fence@nb-await@rcs0.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-nick/igt@gem_exec_fence@nb-await@rcs0.html * igt@gem_wait@busy@all: - fi-bsw-kefka: [FAIL][27] ([i915#3177] / [i915#3457]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-kefka/igt@gem_wait@busy@all.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-kefka/igt@gem_wait@busy@all.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a: - fi-ilk-650: [FAIL][29] -> [PASS][30] +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-ilk-650/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-ilk-650/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: - fi-elk-e7500: [FAIL][31] -> [PASS][32] +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-elk-e7500/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-bsw-kefka: [FAIL][33] -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bsw-kefka/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html #### Warnings #### * igt@gem_exec_gttfill@basic: - fi-ilk-650: [FAIL][35] -> [FAIL][36] ([i915#3457]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-ilk-650/igt@gem_exec_gttfill@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-ilk-650/igt@gem_exec_gttfill@basic.html * igt@i915_selftest@live@execlists: - fi-cfl-8109u: [DMESG-FAIL][37] ([i915#3462]) -> [INCOMPLETE][38] ([i915#3462]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-cfl-8109u/igt@i915_selftest@live@execlists.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-cfl-8109u/igt@i915_selftest@live@execlists.html - fi-icl-u2: [INCOMPLETE][39] ([i915#2782] / [i915#3462]) -> [DMESG-FAIL][40] ([i915#3462]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-icl-u2/igt@i915_selftest@live@execlists.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-icl-u2/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@mman: - fi-bwr-2160: [DMESG-WARN][41] ([i915#3457]) -> [DMESG-FAIL][42] ([i915#3457]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-bwr-2160/igt@i915_selftest@live@mman.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-bwr-2160/igt@i915_selftest@live@mman.html * igt@runner@aborted: - fi-kbl-x1275: [FAIL][43] ([i915#1436] / [i915#3363]) -> [FAIL][44] ([i915#1436] / [i915#2426] / [i915#3363]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-kbl-x1275/igt@runner@aborted.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-kbl-x1275/igt@runner@aborted.html - fi-cfl-8109u: [FAIL][45] ([i915#2426] / [i915#3363]) -> [FAIL][46] ([i915#3363]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-cfl-8109u/igt@runner@aborted.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-cfl-8109u/igt@runner@aborted.html - fi-icl-u2: [FAIL][47] ([i915#2782] / [i915#3363]) -> [FAIL][48] ([i915#2426] / [i915#2782] / [i915#3363]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-icl-u2/igt@runner@aborted.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-icl-u2/igt@runner@aborted.html - fi-cml-s: [FAIL][49] ([i915#3363]) -> [FAIL][50] ([i915#2082] / [i915#2426] / [i915#3363]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-cml-s/igt@runner@aborted.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-cml-s/igt@runner@aborted.html - fi-cfl-guc: [FAIL][51] ([i915#3363]) -> [FAIL][52] ([i915#2426] / [i915#3363]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10071/fi-cfl-guc/igt@runner@aborted.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/fi-cfl-guc/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3177]: https://gitlab.freedesktop.org/drm/intel/issues/3177 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 [i915#3457]: https://gitlab.freedesktop.org/drm/intel/issues/3457 [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 Participating hosts (46 -> 40) ------------------------------ Missing (6): fi-rkl-11500t fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6082 -> IGTPW_5804 CI-20190529: 20190529 CI_DRM_10071: 77fc6f68ed347b0a4c6969f6adac70026d5b1449 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5804: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/index.html IGT_6082: 355269577baef0c5d8114e8851acaeac657e4fe6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5804/index.html [-- Attachment #1.2: Type: text/html, Size: 14531 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode 2021-05-12 6:37 [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode Khaled Almahallawy 2021-05-12 7:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork @ 2021-05-12 12:01 ` Ville Syrjälä 2021-05-13 1:17 ` Almahallawy, Khaled 1 sibling, 1 reply; 4+ messages in thread From: Ville Syrjälä @ 2021-05-12 12:01 UTC (permalink / raw) To: Khaled Almahallawy; +Cc: igt-dev, petri.latvala On Tue, May 11, 2021 at 11:37:42PM -0700, Khaled Almahallawy wrote: > Implementing: > > /* > * FIXME test every mode we have to be more > * sure everything is really getting rejected? > */ I don't quite recall the history of that FIXME. I guess there should be at least no real harm in doing this. However there are a bunch of other more extensive tests here: https://patchwork.freedesktop.org/series/69531/ Would be nice to get those in. Can't remember if they would conflict with this stuff... > > Output of the test will look like the following: > ... > Checking pipe A connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 > Checking pipe B connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 > Checking pipe C connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 > Checking pipe D connector DP-2 with mode 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 1305601 > SUCCESS (0.743s) > > Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com> > --- > tests/kms_invalid_dotclock.c | 54 +++++++++++++++++------------------- > 1 file changed, 26 insertions(+), 28 deletions(-) > > diff --git a/tests/kms_invalid_dotclock.c b/tests/kms_invalid_dotclock.c > index 402629ab097f..aab765136d0e 100644 > --- a/tests/kms_invalid_dotclock.c > +++ b/tests/kms_invalid_dotclock.c > @@ -48,9 +48,10 @@ static int > test_output(data_t *data) > { > igt_output_t *output = data->output; > - drmModeModeInfo mode; > + drmModeConnector *connector = output->config.connector; > + drmModeModeInfo *mode; > struct igt_fb fb; > - int i; > + int i, j; > > /* > * FIXME When we have a fixed mode, the kernel will ignore > @@ -63,33 +64,30 @@ test_output(data_t *data) > if (has_scaling_mode_prop(data)) > return 0; > > - /* > - * FIXME test every mode we have to be more > - * sure everything is really getting rejected? > - */ > - mode = *igt_output_get_mode(output); > - mode.clock = data->max_dotclock + 1; > - > - igt_create_fb(data->drm_fd, > - mode.hdisplay, mode.vdisplay, > - DRM_FORMAT_XRGB8888, > - LOCAL_DRM_FORMAT_MOD_NONE, > - &fb); > - > - for (i = 0; i < data->res->count_crtcs; i++) { > - int ret; > - > - igt_info("Checking pipe %c connector %s with mode %s\n", > - 'A'+i, output->name, mode.name); > - > - ret = drmModeSetCrtc(data->drm_fd, data->res->crtcs[i], > - fb.fb_id, 0, 0, > - &output->id, 1, &mode); > - igt_assert_lt(ret, 0); > + for (j = 0; j < connector->count_modes; j++) { > + mode = &connector->modes[j]; > + mode->clock = data->max_dotclock + 1; > + > + igt_create_fb(data->drm_fd, > + mode->hdisplay, mode->vdisplay, > + DRM_FORMAT_XRGB8888, > + LOCAL_DRM_FORMAT_MOD_NONE, > + &fb); > + > + for (i = 0; i < data->res->count_crtcs; i++) { > + int ret; > + > + igt_info("Checking pipe %c connector %s with mode", > + 'A'+i, output->name); > + kmstest_dump_mode(mode); > + ret = drmModeSetCrtc(data->drm_fd, data->res->crtcs[i], > + fb.fb_id, 0, 0, > + &output->id, 1, mode); > + igt_assert_lt(ret, 0); > + } > + > + igt_remove_fb(data->drm_fd, &fb); > } > - > - igt_remove_fb(data->drm_fd, &fb); > - > return 1; > } > > -- > 2.25.1 -- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode 2021-05-12 12:01 ` [igt-dev] [RFC PATCH i-g-t] " Ville Syrjälä @ 2021-05-13 1:17 ` Almahallawy, Khaled 0 siblings, 0 replies; 4+ messages in thread From: Almahallawy, Khaled @ 2021-05-13 1:17 UTC (permalink / raw) To: ville.syrjala@linux.intel.com Cc: igt-dev@lists.freedesktop.org, Latvala, Petri On Wed, 2021-05-12 at 15:01 +0300, Ville Syrjälä wrote: > On Tue, May 11, 2021 at 11:37:42PM -0700, Khaled Almahallawy wrote: > > Implementing: > > > > /* > > * FIXME test every mode we have to be more > > * sure everything is really getting rejected? > > */ > > I don't quite recall the history of that FIXME. I guess there > should be at least no real harm in doing this. > > However there are a bunch of other more extensive tests here: > https://patchwork.freedesktop.org/series/69531/ > Would be nice to get those in. Can't remember if they would conflict > with this stuff... Sure, I will be happy to work to get this series in. I will rebase if necessarily and test. But I'm a little confused about the process here. If everything works for me, Should I resend your entire series to the same root-mesg-id ( 20191115131520.9872-1-ville.syrjala@linux.intel.com ) from your original series or should I not resend your series? Thank you for your review ~Khaled > > > Output of the test will look like the following: > > ... > > Checking pipe A connector DP-2 with mode 720x400 70 720 738 846 > > 900 400 412 414 449 0x6 0x40 1305601 > > Checking pipe B connector DP-2 with mode 720x400 70 720 738 846 > > 900 400 412 414 449 0x6 0x40 1305601 > > Checking pipe C connector DP-2 with mode 720x400 70 720 738 846 > > 900 400 412 414 449 0x6 0x40 1305601 > > Checking pipe D connector DP-2 with mode 720x400 70 720 738 846 > > 900 400 412 414 449 0x6 0x40 1305601 > > SUCCESS (0.743s) > > > > Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com> > > --- > > tests/kms_invalid_dotclock.c | 54 +++++++++++++++++--------------- > > ---- > > 1 file changed, 26 insertions(+), 28 deletions(-) > > > > diff --git a/tests/kms_invalid_dotclock.c > > b/tests/kms_invalid_dotclock.c > > index 402629ab097f..aab765136d0e 100644 > > --- a/tests/kms_invalid_dotclock.c > > +++ b/tests/kms_invalid_dotclock.c > > @@ -48,9 +48,10 @@ static int > > test_output(data_t *data) > > { > > igt_output_t *output = data->output; > > - drmModeModeInfo mode; > > + drmModeConnector *connector = output->config.connector; > > + drmModeModeInfo *mode; > > struct igt_fb fb; > > - int i; > > + int i, j; > > > > /* > > * FIXME When we have a fixed mode, the kernel will ignore > > @@ -63,33 +64,30 @@ test_output(data_t *data) > > if (has_scaling_mode_prop(data)) > > return 0; > > > > - /* > > - * FIXME test every mode we have to be more > > - * sure everything is really getting rejected? > > - */ > > - mode = *igt_output_get_mode(output); > > - mode.clock = data->max_dotclock + 1; > > - > > - igt_create_fb(data->drm_fd, > > - mode.hdisplay, mode.vdisplay, > > - DRM_FORMAT_XRGB8888, > > - LOCAL_DRM_FORMAT_MOD_NONE, > > - &fb); > > - > > - for (i = 0; i < data->res->count_crtcs; i++) { > > - int ret; > > - > > - igt_info("Checking pipe %c connector %s with mode > > %s\n", > > - 'A'+i, output->name, mode.name); > > - > > - ret = drmModeSetCrtc(data->drm_fd, data->res->crtcs[i], > > - fb.fb_id, 0, 0, > > - &output->id, 1, &mode); > > - igt_assert_lt(ret, 0); > > + for (j = 0; j < connector->count_modes; j++) { > > + mode = &connector->modes[j]; > > + mode->clock = data->max_dotclock + 1; > > + > > + igt_create_fb(data->drm_fd, > > + mode->hdisplay, mode->vdisplay, > > + DRM_FORMAT_XRGB8888, > > + LOCAL_DRM_FORMAT_MOD_NONE, > > + &fb); > > + > > + for (i = 0; i < data->res->count_crtcs; i++) { > > + int ret; > > + > > + igt_info("Checking pipe %c connector %s with > > mode", > > + 'A'+i, output->name); > > + kmstest_dump_mode(mode); > > + ret = drmModeSetCrtc(data->drm_fd, data->res- > > >crtcs[i], > > + fb.fb_id, 0, 0, > > + &output->id, 1, mode); > > + igt_assert_lt(ret, 0); > > + } > > + > > + igt_remove_fb(data->drm_fd, &fb); > > } > > - > > - igt_remove_fb(data->drm_fd, &fb); > > - > > return 1; > > } > > > > -- > > 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-13 1:17 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-05-12 6:37 [igt-dev] [RFC PATCH i-g-t] tests/kms_invalid_dotclock: Test every mode Khaled Almahallawy 2021-05-12 7:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork 2021-05-12 12:01 ` [igt-dev] [RFC PATCH i-g-t] " Ville Syrjälä 2021-05-13 1:17 ` Almahallawy, Khaled
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox