Re: [igt-dev] [PATCH i-g-t v9 12/16] Verify execbuf ok with stale PXP buf in opt-out use

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Sep 02, 2021 at 10:30:39AM -0700, Alan Previn wrote:
> Add a check to verify that reusing a stale protected
> buffer in a gem_execbuff call, but using a regular (not-
> protected) context will succeed after a teardown event.
> Trigger the teardown via the pxp invalidation debugfs
> that simulates a HW teardown IRQ.
> 
> This ensures that user space applications that choose
> not to opt-in for strict PXP teardown awareness (by
> using a regular context) won't suffer gem_execbuff
> failures if a protected buffer was among the assets
> used in any of its rendering operations.
> 
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
>  tests/i915/gem_pxp.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/tests/i915/gem_pxp.c b/tests/i915/gem_pxp.c
> index fab8e28d..36dc5c46 100644
> --- a/tests/i915/gem_pxp.c
> +++ b/tests/i915/gem_pxp.c
> @@ -827,6 +827,27 @@ static void test_pxp_stale_buf_execution(int i915)
>  	free_exec_assets(i915, &data);
>  }
>  
> +static void test_pxp_stale_buf_optout_execution(int i915)
> +{
> +	int ret;
> +	struct simple_exec_assets data = {0};
> +
> +	/*
> +	 * Use a normal context for testing opt-out behavior
> +	 * when executing with a pxp buffer across a teardown event.
> +	 */
> +	prepare_exec_assets(i915, &data, false, true);
> +	ret = gem_execbuf_flush_store_dw(i915, data.ibb, data.ctx, data.fencebuf);
> +	igt_assert(ret == 0);
> +
> +	trigger_pxp_debugfs_forced_teardown(i915);
> +
> +	ret = gem_execbuf_flush_store_dw(i915, data.ibb, data.ctx, data.fencebuf);
> +	igt_assert_f((ret == 0), "Opt-out-execution with stale pxp buffer didn't succeed\n");

And only when I had arrived at this one I noticed my confusion and that the message was
printed on assertion failure!
Duh!


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>



> +
> +	free_exec_assets(i915, &data);
> +}
> +
>  igt_main
>  {
>  	int i915 = -1;
> @@ -920,6 +941,8 @@ igt_main
>  			test_pxp_stale_ctx_execution(i915);
>  		igt_subtest("verify-pxp-stale-buf-execution")
>  			test_pxp_stale_buf_execution(i915);
> +		igt_subtest("verify-pxp-stale-buf-optout-execution")
> +			test_pxp_stale_buf_optout_execution(i915);
>  	}
>  
>  	igt_fixture {
> -- 
> 2.25.1
>