Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Use same modifier for reference crc as for test crc
@ 2021-10-20  9:12 Juha-Pekka Heikkila
  2021-10-20 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Juha-Pekka Heikkila @ 2021-10-20  9:12 UTC (permalink / raw)
  To: igt-dev; +Cc: Juha-Pekka Heikkila

Create reference crc with same modifier as is used for testing. This
will reduce non test related anomalies.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_multiple.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index ece00097e..30e4bcc0d 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -111,10 +111,13 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
 
 	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
 			    DRM_FORMAT_XRGB8888,
-			    DRM_FORMAT_MOD_LINEAR,
+			    modifier,
 			    color->red, color->green, color->blue,
 			    &data->fb[primary->index]);
 
+	igt_skip_on(!igt_plane_has_format_mod(data->plane[primary->index],
+		    DRM_FORMAT_XRGB8888, modifier));
+
 	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
 
 	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Use same modifier for reference crc as for test crc
@ 2021-11-16 18:23 Juha-Pekka Heikkila
  0 siblings, 0 replies; 6+ messages in thread
From: Juha-Pekka Heikkila @ 2021-11-16 18:23 UTC (permalink / raw)
  To: igt-dev

Create reference crc with same modifier as is used for testing. This
will reduce non test related anomalies.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_plane_multiple.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 95e0d72ab..ebadc14be 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -109,9 +109,12 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
 
 	mode = igt_output_get_mode(output);
 
+	igt_skip_on(!igt_plane_has_format_mod(data->plane[primary->index],
+		    DRM_FORMAT_XRGB8888, modifier));
+
 	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
 			    DRM_FORMAT_XRGB8888,
-			    DRM_FORMAT_MOD_LINEAR,
+			    modifier,
 			    color->red, color->green, color->blue,
 			    &data->fb[primary->index]);
 
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-16 18:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20  9:12 [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Use same modifier for reference crc as for test crc Juha-Pekka Heikkila
2021-10-20 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-20 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-20 12:03 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2021-10-20 12:53   ` Juha-Pekka Heikkila
  -- strict thread matches above, loose matches on Subject: below --
2021-11-16 18:23 Juha-Pekka Heikkila

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox