Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [v3 0/9] Addition of new plane scaling test cases
@ 2022-02-08  5:50 Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 1/9] tests/kms_plane_scaling: Removal of plane-scaling subtest Swati Sharma
                   ` (12 more replies)
  0 siblings, 13 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

In this series, combination of downscaling and upscaling
testcases are added. Also, code refactoring is done for
existing code.

    v2:-Minor fixes, to prevent CI crashes
    v3:-Added subtests for testing upscaling/downscaling for
        each plane individually (Ville)
       -Modified existing subtests for each N plane scaling
        combo (Ville)

TODO: crc based validation (once this series is merged, will
work for crc based validation for all subtests, if possible)

Swati Sharma (9):
  tests/kms_plane_scaling: Removal of plane-scaling subtest
  tests/kms_plane_scaling: Add output name in dynamic subtests
  tests/kms_plane_scaling: Upscaling each plane
  tests/kms_plane_scaling: Downscaling each plane
  tests/kms_plane_scaling: Upscaling on 2 planes
  tests/kms_plane_scaling: Downscaling on 2 planes
  tests/kms_plane_scaling: Upscaling and downscaling scenario
  tests/kms_plane_scaling: Add negative test to check num of scalers
  tests/kms_plane_scaling: Refactor clipping-clamping subtest

 tests/kms_plane_scaling.c | 766 ++++++++++++++++++++++++--------------
 1 file changed, 494 insertions(+), 272 deletions(-)

-- 
2.25.1

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 1/9] tests/kms_plane_scaling: Removal of plane-scaling subtest
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 2/9] tests/kms_plane_scaling: Add output name in dynamic subtests Swati Sharma
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

The test case has dead code, primary_plane_scaling is always 0.
Also, upscaling and downscaling scenarios seems little bit messy.
Lets simplify those scenarios by introducing new subtests covering both
upscaling and downscaling.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 179 --------------------------------------
 1 file changed, 179 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 85db11ee..4e2be7f2 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -323,178 +323,6 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
 	}
 }
 
-/* does iterative scaling on plane2 */
-static void iterate_plane_scaling(data_t *d, drmModeModeInfo *mode)
-{
-	igt_display_t *display = &d->display;
-
-	if (mode->hdisplay >= d->fb[1].width) {
-		int w, h;
-		/* fixed fb */
-		igt_fb_set_position(&d->fb[1], d->plane2, 0, 0);
-		igt_fb_set_size(&d->fb[1], d->plane2, d->fb[1].width, d->fb[1].height);
-		igt_plane_set_position(d->plane2, 0, 0);
-
-		/* adjust plane size */
-		for (w = d->fb[1].width; w <= mode->hdisplay; w+=10) {
-			h = w * d->fb[1].height / d->fb[1].width;
-			igt_plane_set_size(d->plane2, w, h);
-			igt_display_commit2(display, COMMIT_ATOMIC);
-		}
-	} else {
-		int w, h;
-		/* fixed plane */
-		igt_plane_set_position(d->plane2, 0, 0);
-		igt_plane_set_size(d->plane2, mode->hdisplay, mode->vdisplay);
-		igt_fb_set_position(&d->fb[1], d->plane2, 0, 0);
-
-		/* adjust fb size */
-		for (w = mode->hdisplay; w <= d->fb[1].width; w+=10) {
-			/* Source coordinates must not be clipped. */
-			h = min(w * mode->hdisplay / mode->vdisplay, d->fb[1].height);
-			igt_fb_set_size(&d->fb[1], d->plane2, w, h);
-			igt_display_commit2(display, COMMIT_ATOMIC);
-		}
-	}
-}
-
-static void
-test_plane_scaling_on_pipe(data_t *d, enum pipe pipe, igt_output_t *output)
-{
-	igt_display_t *display = &d->display;
-	igt_pipe_t *pipe_obj = &display->pipes[pipe];
-	drmModeModeInfo *mode;
-	int primary_plane_scaling = 0; /* For now */
-	uint64_t modifier = is_i915_device(display->drm_fd) ?
-		I915_FORMAT_MOD_X_TILED : DRM_FORMAT_MOD_LINEAR;
-
-	igt_require(get_num_scalers(d, pipe) > 0);
-
-	igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
-						modifier));
-
-	mode = igt_output_get_mode(output);
-
-	/* Set up display with plane 1 */
-	d->plane1 = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_PRIMARY);
-	prepare_crtc(d, output, pipe, d->plane1, mode);
-
-	igt_create_color_pattern_fb(display->drm_fd, 600, 600,
-				    DRM_FORMAT_XRGB8888,
-				    modifier,
-				    .5, .5, .5, &d->fb[1]);
-
-	igt_create_pattern_fb(d->drm_fd,
-			      mode->hdisplay, mode->vdisplay,
-			      DRM_FORMAT_XRGB8888,
-			      modifier,
-			      &d->fb[2]);
-
-	if (primary_plane_scaling) {
-		/* Primary plane upscaling */
-		igt_fb_set_position(&d->fb[0], d->plane1, 100, 100);
-		igt_fb_set_size(&d->fb[0], d->plane1, 500, 500);
-		igt_plane_set_position(d->plane1, 0, 0);
-		igt_plane_set_size(d->plane1, mode->hdisplay, mode->vdisplay);
-		igt_display_commit2(display, COMMIT_ATOMIC);
-
-		/* Primary plane 1:1 no scaling */
-		igt_fb_set_position(&d->fb[0], d->plane1, 0, 0);
-		igt_fb_set_size(&d->fb[0], d->plane1, d->fb[0].width, d->fb[0].height);
-		igt_plane_set_position(d->plane1, 0, 0);
-		igt_plane_set_size(d->plane1, mode->hdisplay, mode->vdisplay);
-		igt_display_commit2(display, COMMIT_ATOMIC);
-	}
-
-	/* Set up fb[1]->plane2 mapping. */
-	d->plane2 = igt_pipe_get_plane_type_index(pipe_obj,
-						  DRM_PLANE_TYPE_OVERLAY, 0);
-
-	if (!d->plane2) {
-		igt_debug("Plane-2 doesnt exist on pipe %s\n", kmstest_pipe_name(pipe));
-		return;
-	}
-
-	igt_plane_set_fb(d->plane2, &d->fb[1]);
-
-	/* 2nd plane windowed */
-	igt_fb_set_position(&d->fb[1], d->plane2, 100, 100);
-	igt_fb_set_size(&d->fb[1], d->plane2, d->fb[1].width-200, d->fb[1].height-200);
-	igt_plane_set_position(d->plane2, 100, 100);
-	igt_plane_set_size(d->plane2, mode->hdisplay-200, mode->vdisplay-200);
-	igt_display_commit2(display, COMMIT_ATOMIC);
-
-	iterate_plane_scaling(d, mode);
-
-	/* 2nd plane up scaling */
-	igt_fb_set_position(&d->fb[1], d->plane2, 100, 100);
-	igt_fb_set_size(&d->fb[1], d->plane2, 500, 500);
-	igt_plane_set_position(d->plane2, 10, 10);
-	igt_plane_set_size(d->plane2, mode->hdisplay-20, mode->vdisplay-20);
-	igt_display_commit2(display, COMMIT_ATOMIC);
-
-	/* 2nd plane downscaling */
-	igt_fb_set_position(&d->fb[1], d->plane2, 0, 0);
-	igt_fb_set_size(&d->fb[1], d->plane2, d->fb[1].width, d->fb[1].height);
-	igt_plane_set_position(d->plane2, 10, 10);
-
-	/* Downscale (10/9)x of original image */
-	igt_plane_set_size(d->plane2, (d->fb[1].width * 10)/9, (d->fb[1].height * 10)/9);
-	igt_display_commit2(display, COMMIT_ATOMIC);
-
-	if (primary_plane_scaling) {
-		/* Primary plane up scaling */
-		igt_fb_set_position(&d->fb[0], d->plane1, 100, 100);
-		igt_fb_set_size(&d->fb[0], d->plane1, 500, 500);
-		igt_plane_set_position(d->plane1, 0, 0);
-		igt_plane_set_size(d->plane1, mode->hdisplay, mode->vdisplay);
-		igt_display_commit2(display, COMMIT_ATOMIC);
-	}
-
-	/* Set up fb[2]->plane3 mapping. */
-	d->plane3 = igt_pipe_get_plane_type_index(pipe_obj,
-						  DRM_PLANE_TYPE_OVERLAY, 1);
-	if(!d->plane3) {
-		igt_debug("Plane-3 doesnt exist on pipe %s\n", kmstest_pipe_name(pipe));
-		return;
-	}
-
-	igt_plane_set_fb(d->plane3, &d->fb[2]);
-
-	/* 3rd plane windowed - no scaling */
-	igt_fb_set_position(&d->fb[2], d->plane3, 100, 100);
-	igt_fb_set_size(&d->fb[2], d->plane3, d->fb[2].width-300, d->fb[2].height-300);
-	igt_plane_set_position(d->plane3, 100, 100);
-	igt_plane_set_size(d->plane3, mode->hdisplay-300, mode->vdisplay-300);
-	igt_display_commit2(display, COMMIT_ATOMIC);
-
-	/* Switch scaler from plane 2 to plane 3 */
-	igt_fb_set_position(&d->fb[1], d->plane2, 100, 100);
-	igt_fb_set_size(&d->fb[1], d->plane2, d->fb[1].width-200, d->fb[1].height-200);
-	igt_plane_set_position(d->plane2, 100, 100);
-	igt_plane_set_size(d->plane2, d->fb[1].width-200, d->fb[1].height-200);
-
-	igt_fb_set_position(&d->fb[2], d->plane3, 100, 100);
-	igt_fb_set_size(&d->fb[2], d->plane3, d->fb[2].width-400, d->fb[2].height-400);
-	igt_plane_set_position(d->plane3, 10, 10);
-	igt_plane_set_size(d->plane3, mode->hdisplay-300, mode->vdisplay-300);
-	igt_display_commit2(display, COMMIT_ATOMIC);
-
-	if (primary_plane_scaling) {
-		/* Switch scaler from plane 1 to plane 2 */
-		igt_fb_set_position(&d->fb[0], d->plane1, 0, 0);
-		igt_fb_set_size(&d->fb[0], d->plane1, d->fb[0].width, d->fb[0].height);
-		igt_plane_set_position(d->plane1, 0, 0);
-		igt_plane_set_size(d->plane1, mode->hdisplay, mode->vdisplay);
-
-		igt_fb_set_position(&d->fb[1], d->plane2, 100, 100);
-		igt_fb_set_size(&d->fb[1], d->plane2, d->fb[1].width-500,d->fb[1].height-500);
-		igt_plane_set_position(d->plane2, 100, 100);
-		igt_plane_set_size(d->plane2, mode->hdisplay-200, mode->vdisplay-200);
-		igt_display_commit2(display, COMMIT_ATOMIC);
-	}
-}
-
 static void
 __test_scaler_with_clipping_clamping_scenario(data_t *d, drmModeModeInfo *mode)
 {
@@ -719,13 +547,6 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_subtest_group {
 		igt_output_t *output;
 
-		igt_describe("Tests plane scaling per pipe.");
-		igt_subtest_with_dynamic("plane-scaling") {
-			for_each_pipe_with_single_output(&data.display, pipe, output)
-				igt_dynamic_f("pipe-%s-plane-scaling", kmstest_pipe_name(pipe))
-					test_plane_scaling_on_pipe(&data, pipe, output);
-		}
-
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 2/9] tests/kms_plane_scaling: Add output name in dynamic subtests
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 1/9] tests/kms_plane_scaling: Removal of plane-scaling subtest Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane Swati Sharma
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4e2be7f2..1cf62841 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -550,21 +550,21 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-				igt_dynamic_f("pipe-%s-scaler-with-pixel-format", kmstest_pipe_name(pipe))
+				igt_dynamic_f("pipe-%s-%s-scaler-with-pixel-format", kmstest_pipe_name(pipe), igt_output_name(output))
 					test_scaler_with_pixel_format_pipe(&data, pipe, output);
 		}
 
 		igt_describe("Tests scaling with tiling rotation.");
 		igt_subtest_with_dynamic("scaler-with-rotation") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-				igt_dynamic_f("pipe-%s-scaler-with-rotation", kmstest_pipe_name(pipe))
+				igt_dynamic_f("pipe-%s-%s-scaler-with-rotation", kmstest_pipe_name(pipe), igt_output_name(output))
 					test_scaler_with_rotation_pipe(&data, pipe, output);
 		}
 
 		igt_describe("Tests scaling with clipping and clamping.");
 		igt_subtest_with_dynamic("scaler-with-clipping-clamping") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-				igt_dynamic_f("pipe-%s-scaler-with-clipping-clamping", kmstest_pipe_name(pipe))
+				igt_dynamic_f("pipe-%s-%s-scaler-with-clipping-clamping", kmstest_pipe_name(pipe), igt_output_name(output))
 					test_scaler_with_clipping_clamping_scenario(&data, pipe, output);
 		}
 	}
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 1/9] tests/kms_plane_scaling: Removal of plane-scaling subtest Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 2/9] tests/kms_plane_scaling: Add output name in dynamic subtests Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-09  8:26   ` Ville Syrjälä
  2022-02-08  5:50 ` [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
                   ` (9 subsequent siblings)
  12 siblings, 1 reply; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Subtest for testing upscaling for each plane
individually (checked 1 plane per "class" like
we do in other tests)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 65 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 1cf62841..25e91659 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -230,6 +230,64 @@ static bool test_format(data_t *data,
 	return true;
 }
 
+static void
+__test_plane_upscaling(data_t *d, igt_plane_t *plane,
+		       enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	int width, height;
+	drmModeModeInfo *mode;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width = height = 20;
+
+	igt_create_color_pattern_fb(display->drm_fd,
+                                    width, height,
+                                    DRM_FORMAT_XRGB8888,
+                                    I915_TILING_NONE,
+                                    1.0, 0.0, 0.0, &d->fb[0]);
+
+	igt_plane_set_fb(plane, &d->fb[0]);
+	igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	igt_plane_set_fb(plane, NULL);
+	igt_remove_fb(display->drm_fd, &d->fb[0]);
+}
+
+static void
+test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	igt_plane_t *plane;
+	uint64_t modifier = is_i915_device(d->drm_fd) ?
+		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
+
+	igt_require(get_num_scalers(d, pipe) > 0);
+
+	for_each_plane_on_pipe(display, pipe, plane) {
+		struct igt_vec tested_formats;
+
+		if (plane->type == DRM_PLANE_TYPE_CURSOR)
+			continue;
+
+		igt_vec_init(&tested_formats, sizeof(uint32_t));
+
+		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
+			uint32_t format = plane->drm_plane->formats[j];
+			if (test_format(d, &tested_formats, format) &&
+			    igt_plane_has_format_mod(plane, format, modifier) &&
+			    can_scale(d, format))
+					__test_plane_upscaling(d, plane, pipe, output);
+		}
+
+		igt_vec_fini(&tested_formats);
+	}
+}
+
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 {
 	if (!is_i915_device(data->drm_fd) ||
@@ -547,6 +605,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_subtest_group {
 		igt_output_t *output;
 
+		igt_describe("Tests plane upscaling.");
+		igt_subtest_with_dynamic("plane-upscaling") {
+			for_each_pipe_with_single_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-upscaling", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_plane_upscaling(&data, pipe, output);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling each plane
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (2 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-09  8:31   ` Ville Syrjälä
  2022-02-08  5:50 ` [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes Swati Sharma
                   ` (8 subsequent siblings)
  12 siblings, 1 reply; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Subtest for testing downscaling for each plane
individually (checked 1 plane per "class" like
we do in other tests).

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 77 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 25e91659..22563fac 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -288,6 +288,76 @@ test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
 	}
 }
 
+static void
+__test_plane_downscaling(data_t *d, igt_plane_t *plane,
+		         enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	int width, height;
+	drmModeModeInfo *mode;
+	bool test_complete = false;
+	int scaling = 50;
+	int ret;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width = mode->hdisplay;
+	height = mode->vdisplay;
+
+	while(!test_complete) {
+
+		igt_create_color_pattern_fb(display->drm_fd,
+					    width, height,
+					    DRM_FORMAT_XRGB8888,
+					    I915_TILING_NONE,
+					    1.0, 0.0, 0.0, &d->fb[0]);
+
+		igt_plane_set_fb(plane, &d->fb[0]);
+		igt_plane_set_size(plane, (width * scaling) / 100, (height * scaling) / 100);
+		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+		if (ret != -EINVAL)
+			test_complete = true;
+
+		scaling += 5;
+
+		igt_plane_set_fb(plane, NULL);
+		igt_remove_fb(display->drm_fd, &d->fb[0]);
+	}
+}
+
+static void
+test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	igt_plane_t *plane;
+	uint64_t modifier = is_i915_device(d->drm_fd) ?
+		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
+
+	igt_require(get_num_scalers(d, pipe) > 0);
+
+	for_each_plane_on_pipe(display, pipe, plane) {
+		struct igt_vec tested_formats;
+
+		if (plane->type == DRM_PLANE_TYPE_CURSOR)
+			continue;
+
+		igt_vec_init(&tested_formats, sizeof(uint32_t));
+
+		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
+			uint32_t format = plane->drm_plane->formats[j];
+			if (test_format(d, &tested_formats, format) &&
+			    igt_plane_has_format_mod(plane, format, modifier) &&
+			    can_scale(d, format))
+					__test_plane_downscaling(d, plane, pipe, output);
+		}
+
+		igt_vec_fini(&tested_formats);
+	}
+}
+
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 {
 	if (!is_i915_device(data->drm_fd) ||
@@ -612,6 +682,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 					test_plane_upscaling(&data, pipe, output);
 		}
 
+		igt_describe("Tests plane downscaling.");
+		igt_subtest_with_dynamic("plane-downscaling") {
+			for_each_pipe_with_single_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-downscaling", kmstest_pipe_name(pipe), igt_output_name(output))
+					test_plane_downscaling(&data, pipe, output);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (3 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-09  8:36   ` Ville Syrjälä
  2022-02-08  5:50 ` [igt-dev] [v3 6/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
                   ` (7 subsequent siblings)
  12 siblings, 1 reply; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

i915 driver supports 2 scalers per pipe. Added test case
to upscale 2 overlay planes simultaneously on single pipe.

v2: -add check for min 2 scalers
    -add igt_require() for overlay planes, fixes CRASH on KBL

v3: -test modified for n planes (Ville)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 74 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 22563fac..f813c5b4 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -29,6 +29,11 @@
 
 IGT_TEST_DESCRIPTION("Test display plane scaling");
 
+/* Test flags. */
+enum {
+        TEST_UP_UP_SCALING = 1 << 0,
+};
+
 typedef struct {
 	uint32_t devid;
 	int drm_fd;
@@ -358,6 +363,67 @@ test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
 	}
 }
 
+static void
+__test_plane_up_up_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	drmModeModeInfo *mode;
+	int width, height;
+	igt_display_t *display = &d->display;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width = height = 20;
+
+	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
+		igt_plane_t *plane1, *plane2;
+
+		plane1 = &display->pipes[pipe].planes[k];
+		igt_require(plane1);
+		plane2 = &display->pipes[pipe].planes[k+1];
+		igt_require(plane2);
+
+		if (plane1->type == DRM_PLANE_TYPE_PRIMARY  || plane1->type == DRM_PLANE_TYPE_CURSOR ||
+		    plane2->type == DRM_PLANE_TYPE_PRIMARY || plane2->type ==DRM_PLANE_TYPE_CURSOR)
+				continue;
+
+		igt_create_color_pattern_fb(display->drm_fd,
+					    width, height,
+					    DRM_FORMAT_XRGB8888,
+					    I915_TILING_NONE,
+					    1.0, 0.0, 0.0, &d->fb[1]);
+		igt_create_color_pattern_fb(display->drm_fd,
+					    width, height,
+					    DRM_FORMAT_XRGB8888,
+					    I915_TILING_NONE,
+					    0.0, 1.0, 0.0, &d->fb[2]);
+
+		igt_plane_set_fb(plane1, &d->fb[1]);
+		igt_plane_set_fb(plane2, &d->fb[2]);
+
+		/* 1st overlay plane upscaling */
+		igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
+		/* 2nd overlay plane upscaling */
+		igt_plane_set_size(plane2, mode->hdisplay - 20, mode->vdisplay - 20);
+		igt_display_commit2(display, COMMIT_ATOMIC);
+
+		igt_plane_set_fb(plane1, NULL);
+		igt_plane_set_fb(plane2, NULL);
+		igt_remove_fb(display->drm_fd, &d->fb[1]);
+		igt_remove_fb(display->drm_fd, &d->fb[2]);
+	}
+}
+
+static void
+test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32_t flags)
+{
+	igt_require(get_num_scalers(d, pipe) >= 2);
+
+	if (flags & TEST_UP_UP_SCALING)
+		__test_plane_up_up_scaling(d, pipe, output);
+}
+
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 {
 	if (!is_i915_device(data->drm_fd) ||
@@ -689,6 +755,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 					test_plane_downscaling(&data, pipe, output);
 		}
 
+		igt_describe("Tests upscaling of 2 overlay planes.");
+		igt_subtest_with_dynamic("plane-up-up-scaling") {
+			for_each_pipe_with_single_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-plane-up-up-scaling",
+					      kmstest_pipe_name(pipe), igt_output_name(output))
+					test_plane_scaling_combo(&data, pipe, output, TEST_UP_UP_SCALING);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 6/9] tests/kms_plane_scaling: Downscaling on 2 planes
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (4 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 7/9] tests/kms_plane_scaling: Upscaling and downscaling scenario Swati Sharma
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Added test case to downscale 2 planes simultaneously.
i915 driver supports max of 3:1 downscaling limit.

v2: -add check for min 2 scalers
    -add igt_require() for overlay planes, fixes CRASH on KBL

v3: -test modified for n planes (Ville)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 79 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index f813c5b4..5dac5fb3 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -32,6 +32,7 @@ IGT_TEST_DESCRIPTION("Test display plane scaling");
 /* Test flags. */
 enum {
         TEST_UP_UP_SCALING = 1 << 0,
+        TEST_DOWN_DOWN_SCALING = 1 << 1,
 };
 
 typedef struct {
@@ -415,6 +416,74 @@ __test_plane_up_up_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
 	}
 }
 
+static void
+__test_plane_down_down_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	drmModeModeInfo *mode;
+	bool test_complete;
+	int width, height;
+	int scaling;
+	int ret;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width = mode->hdisplay;
+	height = mode->vdisplay;
+
+	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
+		test_complete = false;
+		scaling = 50;
+
+		while (!test_complete) {
+			igt_plane_t *plane1, *plane2;
+
+			plane1 = &display->pipes[pipe].planes[k];
+			igt_require(plane1);
+			plane2 = &display->pipes[pipe].planes[k+1];
+			igt_require(plane2);
+
+			if (plane1->type == DRM_PLANE_TYPE_PRIMARY || plane1->type == DRM_PLANE_TYPE_CURSOR ||
+			    plane2->type == DRM_PLANE_TYPE_PRIMARY || plane2->type ==DRM_PLANE_TYPE_CURSOR)
+					break;
+
+			igt_create_color_pattern_fb(display->drm_fd,
+						    width, height,
+						    DRM_FORMAT_XRGB8888,
+						    I915_TILING_NONE,
+						    1.0, 0.0, 0.0, &d->fb[1]);
+			igt_create_color_pattern_fb(display->drm_fd,
+						    width, height,
+						    DRM_FORMAT_XRGB8888,
+						    I915_TILING_NONE,
+						    0.0, 1.0, 0.0, &d->fb[2]);
+
+			igt_plane_set_fb(plane1, &d->fb[1]);
+			igt_plane_set_fb(plane2, &d->fb[2]);
+
+			/* 1st overlay plane downscaling */
+			igt_plane_set_size(plane1, (width * scaling) / 100, (height * scaling) / 100);
+			/* 2nd overlay plane downscaling */
+			igt_plane_set_size(plane2, (width * scaling) / 100, (height * scaling) / 100);
+
+			ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+			if (ret != -EINVAL)
+				test_complete = true;
+
+			scaling += 5;
+
+			/* cleanup */
+			igt_plane_set_fb(plane1, NULL);
+			igt_plane_set_fb(plane2, NULL);
+			igt_remove_fb(display->drm_fd, &d->fb[1]);
+			igt_remove_fb(display->drm_fd, &d->fb[2]);
+		}
+	}
+}
+
 static void
 test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32_t flags)
 {
@@ -422,6 +491,8 @@ test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32
 
 	if (flags & TEST_UP_UP_SCALING)
 		__test_plane_up_up_scaling(d, pipe, output);
+	if (flags & TEST_DOWN_DOWN_SCALING)
+		__test_plane_down_down_scaling(d, pipe, output);
 }
 
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
@@ -763,6 +834,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 					test_plane_scaling_combo(&data, pipe, output, TEST_UP_UP_SCALING);
 		}
 
+		igt_describe("Tests downscaling of 2 overlay planes.");
+		igt_subtest_with_dynamic("plane-down-down-scaling") {
+			for_each_pipe_with_valid_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-plane-down-down-scaling",
+					      kmstest_pipe_name(pipe), igt_output_name(output))
+					test_plane_scaling_combo(&data, pipe, output, TEST_DOWN_DOWN_SCALING);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 7/9] tests/kms_plane_scaling: Upscaling and downscaling scenario
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (5 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 6/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 8/9] tests/kms_plane_scaling: Add negative test to check num of scalers Swati Sharma
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Upscaling on first overlay plane and downscaling on second
overlay plane.

v2: -add check for min 2 scalers
    -add igt_require() for overlay planes, fixes CRASH on KBL

v3: -test modified for n planes (Ville)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 80 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 5dac5fb3..882859ab 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -33,6 +33,7 @@ IGT_TEST_DESCRIPTION("Test display plane scaling");
 enum {
         TEST_UP_UP_SCALING = 1 << 0,
         TEST_DOWN_DOWN_SCALING = 1 << 1,
+        TEST_UP_DOWN_SCALING = 1 << 2,
 };
 
 typedef struct {
@@ -484,6 +485,75 @@ __test_plane_down_down_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
 	}
 }
 
+static void
+__test_plane_up_down_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	int width1, height1, width2, height2;
+	drmModeModeInfo *mode;
+	bool test_complete;
+	int scaling;
+	int ret;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width1 = mode->hdisplay;
+	height1 = mode->vdisplay;
+	width2 = height2 = 20;
+
+	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
+		test_complete = false;
+		scaling = 50;
+
+		while (!test_complete) {
+			igt_plane_t *plane1, *plane2;
+
+			plane1 = &display->pipes[pipe].planes[k];
+			igt_require(plane1);
+			plane2 = &display->pipes[pipe].planes[k+1];
+			igt_require(plane2);
+
+			if (plane1->type == DRM_PLANE_TYPE_PRIMARY || plane1->type == DRM_PLANE_TYPE_CURSOR ||
+			    plane2->type == DRM_PLANE_TYPE_PRIMARY || plane2->type ==DRM_PLANE_TYPE_CURSOR)
+					break;
+
+			igt_create_color_pattern_fb(display->drm_fd,
+						    width1, height1,
+						    DRM_FORMAT_XRGB8888,
+						    I915_TILING_NONE,
+						    1.0, 0.0, 0.0, &d->fb[1]);
+			igt_create_color_pattern_fb(display->drm_fd,
+						    width2, height2,
+						    DRM_FORMAT_XRGB8888,
+						    I915_TILING_NONE,
+						    0.0, 1.0, 0.0, &d->fb[2]);
+
+			igt_plane_set_fb(plane1, &d->fb[1]);
+			igt_plane_set_fb(plane2, &d->fb[2]);
+
+			/* 1st overlay plane downscaling */
+			igt_plane_set_size(plane1, (width1 * scaling) / 100, (height1 * scaling) / 100);
+			/* 2nd overlay plane upscaling */
+			igt_plane_set_size(plane2, width1, height1);
+
+			ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+			if (ret != -EINVAL)
+				test_complete = true;
+
+			scaling += 5;
+
+			/* cleanup */
+			igt_plane_set_fb(plane1, NULL);
+			igt_plane_set_fb(plane2, NULL);
+			igt_remove_fb(display->drm_fd, &d->fb[1]);
+			igt_remove_fb(display->drm_fd, &d->fb[2]);
+		}
+	}
+}
+
 static void
 test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32_t flags)
 {
@@ -493,6 +563,8 @@ test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32
 		__test_plane_up_up_scaling(d, pipe, output);
 	if (flags & TEST_DOWN_DOWN_SCALING)
 		__test_plane_down_down_scaling(d, pipe, output);
+	if (flags & TEST_UP_DOWN_SCALING)
+		__test_plane_up_down_scaling(d, pipe, output);
 }
 
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
@@ -842,6 +914,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 					test_plane_scaling_combo(&data, pipe, output, TEST_DOWN_DOWN_SCALING);
 		}
 
+		igt_describe("Tests upscaling and downscaling of overlay planes.");
+		igt_subtest_with_dynamic("plane-up-down-scaling") {
+			for_each_pipe_with_valid_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-plane-up-down-scaling",
+					       kmstest_pipe_name(pipe), igt_output_name(output))
+					test_plane_scaling_combo(&data, pipe, output, TEST_UP_DOWN_SCALING);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 8/9] tests/kms_plane_scaling: Add negative test to check num of scalers
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (6 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 7/9] tests/kms_plane_scaling: Upscaling and downscaling scenario Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  5:50 ` [igt-dev] [v3 9/9] tests/kms_plane_scaling: Refactor clipping-clamping subtest Swati Sharma
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

To validate i915 supports max of 2 scalers, applied upscaling on
3 planes simultaneously. This is a negative test and commit is expected
to fail.

v2: -add check for min 2 scalers
    -add igt_require() for overlay planes, fixes CRASH on KBL

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 73 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 882859ab..29e85aa3 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -567,6 +567,71 @@ test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32
 		__test_plane_up_down_scaling(d, pipe, output);
 }
 
+static void
+test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+	igt_display_t *display = &d->display;
+	igt_pipe_t *pipe_obj = &display->pipes[pipe];
+	drmModeModeInfo *mode;
+	int width, height;
+
+	cleanup_crtc(d);
+
+	igt_require(get_num_scalers(d, pipe) >= 2);
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
+	width = height = 20;
+
+	d->plane1 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 0);
+	igt_require(d->plane1);
+	d->plane2 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 1);
+	igt_require(d->plane2);
+	d->plane3 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 2);
+	igt_require(d->plane3);
+
+	igt_create_color_pattern_fb(display->drm_fd,
+                                    width, height,
+                                    DRM_FORMAT_XRGB8888,
+                                    I915_TILING_NONE,
+                                    1.0, 0.0, 0.0, &d->fb[1]);
+	igt_create_color_pattern_fb(display->drm_fd,
+                                    width, height,
+                                    DRM_FORMAT_XRGB8888,
+                                    I915_TILING_NONE,
+                                    0.0, 1.0, 0.0, &d->fb[2]);
+	igt_create_color_pattern_fb(display->drm_fd,
+                                    width, height,
+                                    DRM_FORMAT_XRGB8888,
+                                    I915_TILING_NONE,
+                                    0.0, 0.0, 1.0, &d->fb[3]);
+
+	igt_plane_set_fb(d->plane1, &d->fb[1]);
+	igt_plane_set_fb(d->plane2, &d->fb[2]);
+	igt_plane_set_fb(d->plane3, &d->fb[3]);
+
+	/* 1st plane upscaling */
+	igt_plane_set_size(d->plane1, mode->hdisplay, mode->vdisplay);
+
+	/* 2nd plane upscaling */
+	igt_plane_set_size(d->plane2, mode->hdisplay, mode->vdisplay);
+
+	/* 3rd plane upscaling */
+	igt_plane_set_size(d->plane3, mode->hdisplay, mode->vdisplay);
+
+	/* This commit is expectd to fail as we can have max 2 scalers/pipe
+	 * In dmesg, you can find: Too many scaling requests 3 > 2
+	 * */
+	igt_assert_eq(igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL), -EINVAL);
+
+	/* cleanup */
+	igt_plane_set_fb(d->plane1, NULL);
+	igt_plane_set_fb(d->plane2, NULL);
+	igt_plane_set_fb(d->plane3, NULL);
+	igt_remove_fb(display->drm_fd, &d->fb[1]);
+	igt_remove_fb(display->drm_fd, &d->fb[2]);
+	igt_remove_fb(display->drm_fd, &d->fb[3]);
+}
+
 static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 {
 	if (!is_i915_device(data->drm_fd) ||
@@ -922,6 +987,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 					test_plane_scaling_combo(&data, pipe, output, TEST_UP_DOWN_SCALING);
 		}
 
+		igt_describe("Negative test for number of scalers per pipe.");
+		igt_subtest_with_dynamic("invalid-num-scalers") {
+			for_each_pipe_with_valid_output(&data.display, pipe, output)
+				igt_dynamic_f("pipe-%s-%s-invalid-num-scalers",
+					       kmstest_pipe_name(pipe), igt_output_name(output))
+					test_invalid_num_scalers(&data, pipe, output);
+		}
+
 		igt_describe("Tests scaling with pixel formats.");
 		igt_subtest_with_dynamic("scaler-with-pixel-format") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [v3 9/9] tests/kms_plane_scaling: Refactor clipping-clamping subtest
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (7 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 8/9] tests/kms_plane_scaling: Add negative test to check num of scalers Swati Sharma
@ 2022-02-08  5:50 ` Swati Sharma
  2022-02-08  6:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev3) Patchwork
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Swati Sharma @ 2022-02-08  5:50 UTC (permalink / raw)
  To: igt-dev

Reused same logic as other subtests (tiling, pixel-format)
to make it consistent. Now, this subtest is tested for
all planes.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_plane_scaling.c | 159 ++++++++++++++------------------------
 1 file changed, 56 insertions(+), 103 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 29e85aa3..cd5a04b3 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -84,45 +84,16 @@ static void cleanup_crtc(data_t *data)
 	cleanup_fbs(data);
 }
 
-static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
-			igt_plane_t *plane, drmModeModeInfo *mode)
+static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
 {
-	igt_display_t *display = &data->display;
-	uint64_t modifier = is_i915_device(data->drm_fd) ?
-		I915_FORMAT_MOD_X_TILED : DRM_FORMAT_MOD_LINEAR;
-
-	cleanup_crtc(data);
-
-	igt_output_set_pipe(output, pipe);
+	if (!is_i915_device(data->drm_fd) ||
+	    data->extended)
+		return true;
 
-	igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
-						modifier));
+	if ((pipe > PIPE_B) && (iteration >= 2))
+		return false;
 
-	/* allocate fb for plane 1 */
-	igt_create_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
-			      DRM_FORMAT_XRGB8888,
-			      modifier,
-			      &data->fb[0]);
-
-	igt_plane_set_fb(plane, &data->fb[0]);
-
-	if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
-		igt_plane_t *primary;
-		int ret;
-
-		/* Do we succeed without enabling the primary plane? */
-		ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
-		if (!ret)
-			return;
-
-		/*
-		 * Fallback: set the primary plane to actually enable the pipe.
-		 * Some drivers always require the primary plane to be enabled.
-		 */
-		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-		igt_plane_set_fb(primary, &data->fb[0]);
-	}
-	igt_display_commit2(display, COMMIT_ATOMIC);
+	return true;
 }
 
 static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
@@ -632,18 +603,6 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
 	igt_remove_fb(display->drm_fd, &d->fb[3]);
 }
 
-static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
-{
-	if (!is_i915_device(data->drm_fd) ||
-	    data->extended)
-		return true;
-
-	if ((pipe > PIPE_B) && (iteration >= 2))
-		return false;
-
-	return true;
-}
-
 static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
 					   igt_output_t *output)
 {
@@ -726,89 +685,83 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
 }
 
 static void
-__test_scaler_with_clipping_clamping_scenario(data_t *d, drmModeModeInfo *mode)
+__test_scaler_with_clipping_clamping(data_t *d, igt_plane_t *plane,
+				     uint32_t pixel_format,
+				     uint64_t modifier, enum pipe pipe,
+				     igt_output_t *output,
+				     igt_rotation_t rot)
+
 {
-	igt_plane_set_fb(d->plane1, &d->fb[1]);
-	igt_plane_set_fb(d->plane2, &d->fb[2]);
+	igt_display_t *display = &d->display;
+	int width, height;
+	drmModeModeInfo *mode;
+
+	cleanup_crtc(d);
+
+	igt_output_set_pipe(output, pipe);
+	mode = igt_output_get_mode(output);
 
-	igt_fb_set_position(&d->fb[1], d->plane1, 0, 0);
-	igt_fb_set_size(&d->fb[1], d->plane1, 300, 300);
-	igt_plane_set_position(d->plane1, 100, 400);
-	igt_fb_set_position(&d->fb[2], d->plane2, 0, 0);
-	igt_fb_set_size(&d->fb[2], d->plane2, 400, 400);
-	igt_plane_set_position(d->plane2, 100, 100);
+	width = mode->hdisplay;
+	height = mode->vdisplay;
+	igt_create_color_fb(display->drm_fd, width, height,
+			    pixel_format, modifier, 0.0, 1.0, 0.0, &d->fb[0]);
+	igt_plane_set_fb(plane, &d->fb[0]);
 
 	/* scaled window size is outside the modeset area.*/
-	igt_plane_set_size(d->plane1, mode->hdisplay + 200,
-					    mode->vdisplay + 200);
-	igt_plane_set_size(d->plane2, mode->hdisplay + 100,
-					    mode->vdisplay + 100);
+	igt_plane_set_size(plane, mode->hdisplay + 200, mode->vdisplay + 200);
+	igt_plane_set_rotation(plane, rot);
 
 	/*
 	 * Can't guarantee that the clipped coordinates are
 	 * suitably aligned for yuv. So allow the commit to fail.
 	 */
-	if (igt_format_is_yuv(d->fb[1].drm_format) ||
-	    igt_format_is_yuv(d->fb[2].drm_format))
+	if (igt_format_is_yuv(d->fb[0].drm_format))
 		igt_display_try_commit2(&d->display, COMMIT_ATOMIC);
 	else
 		igt_display_commit2(&d->display, COMMIT_ATOMIC);
+
+	igt_plane_set_fb(plane, NULL);
+	igt_remove_fb(display->drm_fd, &d->fb[0]);
 }
 
 static void
-test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_output_t *output)
+test_scaler_with_clipping_clamping(data_t *d, enum pipe pipe, igt_output_t *output)
 {
-	igt_pipe_t *pipe_obj = &d->display.pipes[pipe];
-	drmModeModeInfo *mode;
-	struct igt_vec tested_formats1;
-
-	igt_require(get_num_scalers(d, pipe) >= 2);
-
-	mode = igt_output_get_mode(output);
-	d->plane1 = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_PRIMARY);
-	d->plane2 = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_OVERLAY);
-	prepare_crtc(d, output, pipe, d->plane1, mode);
+	igt_display_t *display = &d->display;
+	igt_plane_t *plane;
 
-	igt_vec_init(&tested_formats1, sizeof(uint32_t));
+	igt_require(get_num_scalers(d, pipe) > 0);
 
-	for (int i = 0; i < d->plane1->drm_plane->count_formats; i++) {
-		unsigned f1 = d->plane1->drm_plane->formats[i];
-		struct igt_vec tested_formats2;
+	igt_output_set_pipe(output, pipe);
 
-		if (!test_pipe_iteration(d, pipe, i))
+	for_each_plane_on_pipe(display, pipe, plane) {
+		if (plane->type == DRM_PLANE_TYPE_CURSOR)
 			continue;
 
-		if (!test_format(d, &tested_formats1, f1) ||
-		    !can_scale(d, f1))
-			continue;
 
-		igt_vec_init(&tested_formats2, sizeof(uint32_t));
+		for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
+			uint64_t modifier = modifiers[i];
+			struct igt_vec tested_formats;
 
-		igt_create_pattern_fb(d->drm_fd,
-				      mode->hdisplay, mode->vdisplay, f1,
-				      I915_FORMAT_MOD_X_TILED, &d->fb[1]);
+			igt_vec_init(&tested_formats, sizeof(uint32_t));
 
-		for (int j = 0; j < d->plane2->drm_plane->count_formats; j++) {
-			unsigned f2 = d->plane2->drm_plane->formats[j];
+			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
+				uint32_t format = plane->drm_plane->formats[j];
 
-			if (!test_format(d, &tested_formats2, f2) ||
-			    !can_scale(d, f2))
-				continue;
+				if (!test_pipe_iteration(d, pipe, j))
+					continue;
 
-			igt_create_pattern_fb(d->drm_fd,
-					      mode->hdisplay, mode->vdisplay, f2,
-					      I915_FORMAT_MOD_Y_TILED,
-					      &d->fb[2]);
+				if (test_format(d, &tested_formats, format) &&
+				    igt_plane_has_format_mod(plane, format, modifier) &&
+				    can_scale(d, format))
+						__test_scaler_with_clipping_clamping(d, plane,
+										     format, modifier,
+										     pipe, output, IGT_ROTATION_0);
+			}
 
-			__test_scaler_with_clipping_clamping_scenario(d, mode);
-			igt_remove_fb(d->drm_fd, &d->fb[2]);
+			igt_vec_fini(&tested_formats);
 		}
-		igt_remove_fb(d->drm_fd, &d->fb[1]);
-
-		igt_vec_fini(&tested_formats2);
 	}
-
-	igt_vec_fini(&tested_formats1);
 }
 
 static void find_connected_pipe(igt_display_t *display, bool second, enum pipe *pipe, igt_output_t **output)
@@ -1013,7 +966,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		igt_subtest_with_dynamic("scaler-with-clipping-clamping") {
 			for_each_pipe_with_single_output(&data.display, pipe, output)
 				igt_dynamic_f("pipe-%s-%s-scaler-with-clipping-clamping", kmstest_pipe_name(pipe), igt_output_name(output))
-					test_scaler_with_clipping_clamping_scenario(&data, pipe, output);
+					test_scaler_with_clipping_clamping(&data, pipe, output);
 		}
 	}
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev3)
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (8 preceding siblings ...)
  2022-02-08  5:50 ` [igt-dev] [v3 9/9] tests/kms_plane_scaling: Refactor clipping-clamping subtest Swati Sharma
@ 2022-02-08  6:25 ` Patchwork
  2022-02-08  9:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev4) Patchwork
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-02-08  6:25 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 5378 bytes --]

== Series Details ==

Series: Addition of new plane scaling test cases (rev3)
URL   : https://patchwork.freedesktop.org/series/98333/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11199 -> IGTPW_6602
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6602 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6602, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/index.html

Participating hosts (48 -> 41)
------------------------------

  Missing    (7): fi-kbl-soraka fi-rkl-guc shard-tglu fi-icl-u2 fi-bsw-cyan shard-rkl shard-dg1 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6602:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - fi-bdw-5557u:       NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_exec_suspend@basic-s3@smem:
    - {fi-rkl-11600}:     [PASS][2] -> [INCOMPLETE][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html

  
Known issues
------------

  Here are the changes found in IGTPW_6602 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-skl-6600u:       NOTRUN -> [INCOMPLETE][4] ([i915#4547])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@requests:
    - fi-blb-e6850:       [PASS][5] -> [DMESG-FAIL][6] ([i915#5026])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-blb-e6850/igt@i915_selftest@live@requests.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-blb-e6850/igt@i915_selftest@live@requests.html

  * igt@kms_chamelium@vga-edid-read:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-bdw-5557u/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_psr@cursor_plane_move:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][8] ([fdo#109271]) +13 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

  * igt@runner@aborted:
    - fi-blb-e6850:       NOTRUN -> [FAIL][9] ([fdo#109271] / [i915#2403] / [i915#2426] / [i915#4312])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-blb-e6850/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-bdw-5557u:       [INCOMPLETE][10] ([i915#146]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cml-u2:          [DMESG-WARN][12] ([i915#4269]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11199/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
  [i915#5026]: https://gitlab.freedesktop.org/drm/intel/issues/5026


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6341 -> IGTPW_6602

  CI-20190529: 20190529
  CI_DRM_11199: e74a41add451a1ff1e15abe5985a1324e4c328d9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6602: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/index.html
  IGT_6341: a96674e747ea2f2431bbf8813156adc44ec3162a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git



== Testlist changes ==

+igt@kms_plane_scaling@invalid-num-scalers
+igt@kms_plane_scaling@plane-downscaling
+igt@kms_plane_scaling@plane-down-down-scaling
+igt@kms_plane_scaling@plane-upscaling
+igt@kms_plane_scaling@plane-up-down-scaling
+igt@kms_plane_scaling@plane-up-up-scaling
-igt@kms_plane_scaling@plane-scaling

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6602/index.html

[-- Attachment #2: Type: text/html, Size: 6396 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev4)
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (9 preceding siblings ...)
  2022-02-08  6:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev3) Patchwork
@ 2022-02-08  9:47 ` Patchwork
  2022-02-08 22:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Addition of new plane scaling test cases (rev5) Patchwork
  2022-02-08 23:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  12 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-02-08  9:47 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 12738 bytes --]

== Series Details ==

Series: Addition of new plane scaling test cases (rev4)
URL   : https://patchwork.freedesktop.org/series/98333/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11200 -> IGTPW_6603
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6603 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6603, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/index.html

Participating hosts (41 -> 43)
------------------------------

  Additional (4): fi-kbl-soraka fi-icl-u2 bat-adlp-4 fi-pnv-d510 
  Missing    (2): fi-bxt-dsi shard-tglu 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6603:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - fi-bdw-5557u:       NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
    - fi-icl-u2:          NOTRUN -> [DMESG-WARN][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2:
    - fi-icl-u2:          NOTRUN -> [INCOMPLETE][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html

  
Known issues
------------

  Here are the changes found in IGTPW_6603 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-multi-fence:
    - fi-blb-e6850:       NOTRUN -> [SKIP][4] ([fdo#109271]) +17 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-blb-e6850/igt@amdgpu/amd_basic@cs-multi-fence.html

  * igt@gem_exec_fence@basic-busy@bcs0:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][5] ([fdo#109271]) +8 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-skl-6600u:       NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
    - fi-icl-u2:          NOTRUN -> [SKIP][8] ([i915#2190])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - bat-adlp-4:         NOTRUN -> [SKIP][9] ([i915#4613]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@gem_lmem_swapping@basic.html
    - fi-kbl-soraka:      NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-icl-u2:          NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@verify-random:
    - fi-skl-6600u:       NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +3 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_tiled_pread_basic:
    - bat-adlp-4:         NOTRUN -> [SKIP][13] ([i915#3282])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@gem_tiled_pread_basic.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][14] ([i915#1886] / [i915#2291])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@requests:
    - fi-pnv-d510:        NOTRUN -> [DMESG-FAIL][15] ([i915#2927] / [i915#4528])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-pnv-d510/igt@i915_selftest@live@requests.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@dp-crc-fast:
    - bat-adlp-4:         NOTRUN -> [SKIP][17] ([fdo#111827]) +8 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
    - fi-bdw-5557u:       NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          NOTRUN -> [SKIP][19] ([fdo#111827]) +8 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_chamelium@vga-edid-read:
    - fi-skl-6600u:       NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-icl-u2:          NOTRUN -> [SKIP][21] ([fdo#109278]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - fi-skl-6600u:       NOTRUN -> [SKIP][22] ([fdo#109271]) +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-adlp-4:         NOTRUN -> [SKIP][23] ([i915#4103]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_flip@basic-plain-flip@d-edp1:
    - bat-adlp-4:         NOTRUN -> [DMESG-WARN][24] ([i915#3576]) +7 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@kms_flip@basic-plain-flip@d-edp1.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-adlp-4:         NOTRUN -> [SKIP][25] ([fdo#109285])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - bat-adlp-4:         NOTRUN -> [DMESG-FAIL][26] ([i915#3576]) +2 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
    - fi-skl-6600u:       NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#533])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
    - fi-kbl-soraka:      NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#533])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_psr@cursor_plane_move:
    - fi-bdw-5557u:       NOTRUN -> [SKIP][29] ([fdo#109271]) +13 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-6600u:       NOTRUN -> [FAIL][30] ([i915#4547])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

  * igt@prime_vgem@basic-fence-read:
    - bat-adlp-4:         NOTRUN -> [SKIP][31] ([i915#3291] / [i915#3708]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-userptr:
    - fi-pnv-d510:        NOTRUN -> [SKIP][32] ([fdo#109271]) +39 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
    - bat-adlp-4:         NOTRUN -> [SKIP][33] ([i915#3301] / [i915#3708])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/bat-adlp-4/igt@prime_vgem@basic-userptr.html

  * igt@runner@aborted:
    - fi-pnv-d510:        NOTRUN -> [FAIL][34] ([fdo#109271] / [i915#2403] / [i915#4312])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-pnv-d510/igt@runner@aborted.html
    - fi-icl-u2:          NOTRUN -> [FAIL][35] ([i915#2722] / [i915#4312])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-icl-u2/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-skl-6600u:       [INCOMPLETE][36] ([i915#4547]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11200/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@requests:
    - fi-blb-e6850:       [DMESG-FAIL][38] ([i915#4528] / [i915#5026]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11200/fi-blb-e6850/igt@i915_selftest@live@requests.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-blb-e6850/igt@i915_selftest@live@requests.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cml-u2:          [DMESG-WARN][40] ([i915#4269]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11200/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
  [i915#5026]: https://gitlab.freedesktop.org/drm/intel/issues/5026
  [i915#5068]: https://gitlab.freedesktop.org/drm/intel/issues/5068
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6341 -> IGTPW_6603

  CI-20190529: 20190529
  CI_DRM_11200: a82048d804ae32de6e00da56d2c74e449d486738 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6603: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/index.html
  IGT_6341: a96674e747ea2f2431bbf8813156adc44ec3162a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git



== Testlist changes ==

+igt@kms_plane_scaling@invalid-num-scalers
+igt@kms_plane_scaling@plane-downscaling
+igt@kms_plane_scaling@plane-down-down-scaling
+igt@kms_plane_scaling@plane-upscaling
+igt@kms_plane_scaling@plane-up-down-scaling
+igt@kms_plane_scaling@plane-up-up-scaling
-igt@kms_plane_scaling@plane-scaling

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6603/index.html

[-- Attachment #2: Type: text/html, Size: 16009 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Addition of new plane scaling test cases (rev5)
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (10 preceding siblings ...)
  2022-02-08  9:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev4) Patchwork
@ 2022-02-08 22:04 ` Patchwork
  2022-02-08 23:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  12 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-02-08 22:04 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 7062 bytes --]

== Series Details ==

Series: Addition of new plane scaling test cases (rev5)
URL   : https://patchwork.freedesktop.org/series/98333/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11205 -> IGTPW_6606
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/index.html

Participating hosts (46 -> 43)
------------------------------

  Missing    (3): fi-bsw-cyan fi-icl-u2 shard-tglu 

Known issues
------------

  Here are the changes found in IGTPW_6606 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-skl-6600u:       [PASS][1] -> [INCOMPLETE][2] ([i915#4547])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@requests:
    - fi-blb-e6850:       [PASS][3] -> [DMESG-FAIL][4] ([i915#4528] / [i915#5026])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-blb-e6850/igt@i915_selftest@live@requests.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-blb-e6850/igt@i915_selftest@live@requests.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-cml-u2:          [PASS][5] -> [DMESG-WARN][6] ([i915#4269])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html

  * igt@runner@aborted:
    - fi-blb-e6850:       NOTRUN -> [FAIL][7] ([fdo#109271] / [i915#2403] / [i915#2426] / [i915#4312])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-blb-e6850/igt@runner@aborted.html
    - fi-bdw-5557u:       NOTRUN -> [FAIL][8] ([i915#2426] / [i915#4312])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-bdw-5557u/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - fi-bdw-5557u:       [INCOMPLETE][9] ([i915#146]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
    - {bat-rpls-1}:       [INCOMPLETE][11] ([i915#4898]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_selftest@live@hangcheck:
    - bat-dg1-5:          [DMESG-FAIL][13] ([i915#4957]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/bat-dg1-5/igt@i915_selftest@live@hangcheck.html

  
#### Warnings ####

  * igt@debugfs_test@read_all_entries:
    - fi-apl-guc:         [DMESG-WARN][15] -> [DMESG-WARN][16] ([i915#1610])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-apl-guc/igt@debugfs_test@read_all_entries.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-apl-guc/igt@debugfs_test@read_all_entries.html

  * igt@i915_selftest@live@hangcheck:
    - bat-dg1-6:          [DMESG-FAIL][17] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][18] ([i915#4957])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
    - fi-hsw-4770:        [INCOMPLETE][19] ([i915#4785]) -> [INCOMPLETE][20] ([i915#3303])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
  [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
  [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
  [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
  [i915#5026]: https://gitlab.freedesktop.org/drm/intel/issues/5026


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6341 -> IGTPW_6606

  CI-20190529: 20190529
  CI_DRM_11205: 9999c764a7571bebed03bec481d6fffcb23144fe @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6606: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/index.html
  IGT_6341: a96674e747ea2f2431bbf8813156adc44ec3162a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git



== Testlist changes ==

+igt@kms_plane_scaling@invalid-num-scalers
+igt@kms_plane_scaling@plane-downscaling
+igt@kms_plane_scaling@plane-down-down-scaling
+igt@kms_plane_scaling@plane-upscaling
+igt@kms_plane_scaling@plane-up-down-scaling
+igt@kms_plane_scaling@plane-up-up-scaling
-igt@kms_plane_scaling@plane-scaling

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/index.html

[-- Attachment #2: Type: text/html, Size: 7268 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for Addition of new plane scaling test cases (rev5)
  2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
                   ` (11 preceding siblings ...)
  2022-02-08 22:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Addition of new plane scaling test cases (rev5) Patchwork
@ 2022-02-08 23:50 ` Patchwork
  12 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2022-02-08 23:50 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 30262 bytes --]

== Series Details ==

Series: Addition of new plane scaling test cases (rev5)
URL   : https://patchwork.freedesktop.org/series/98333/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11205_full -> IGTPW_6606_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6606_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6606_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/index.html

Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6606_full:

### IGT changes ###

#### Possible regressions ####

  * igt@syncobj_timeline@invalid-transfer-non-existent-point:
    - shard-apl:          NOTRUN -> [DMESG-WARN][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-apl7/igt@syncobj_timeline@invalid-transfer-non-existent-point.html

  
New tests
---------

  New tests have been introduced between CI_DRM_11205_full and IGTPW_6606_full:

### New IGT tests (131) ###

  * igt@kms_plane_scaling@invalid-num-scalers:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-a-dp-1-invalid-num-scalers:
    - Statuses : 2 skip(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-a-edp-1-invalid-num-scalers:
    - Statuses : 2 pass(s)
    - Exec time: [0.03, 0.05] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-a-hdmi-a-1-invalid-num-scalers:
    - Statuses : 1 pass(s)
    - Exec time: [0.11] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-a-hdmi-a-2-invalid-num-scalers:
    - Statuses : 1 pass(s)
    - Exec time: [0.04] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-a-vga-1-invalid-num-scalers:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-b-dp-1-invalid-num-scalers:
    - Statuses : 2 skip(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-b-edp-1-invalid-num-scalers:
    - Statuses : 2 pass(s)
    - Exec time: [0.02] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-b-hdmi-a-1-invalid-num-scalers:
    - Statuses : 1 pass(s)
    - Exec time: [0.04] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-b-hdmi-a-2-invalid-num-scalers:
    - Statuses : 1 pass(s)
    - Exec time: [0.04] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-b-vga-1-invalid-num-scalers:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-c-dp-1-invalid-num-scalers:
    - Statuses : 2 skip(s)
    - Exec time: [0.0, 0.00] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-c-edp-1-invalid-num-scalers:
    - Statuses : 2 pass(s)
    - Exec time: [0.02] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-c-hdmi-a-1-invalid-num-scalers:
    - Statuses : 1 skip(s)
    - Exec time: [0.00] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-c-hdmi-a-2-invalid-num-scalers:
    - Statuses : 1 skip(s)
    - Exec time: [0.00] s

  * igt@kms_plane_scaling@invalid-num-scalers@pipe-d-edp-1-invalid-num-scalers:
    - Statuses : 1 pass(s)
    - Exec time: [0.01] s

  * igt@kms_plane_scaling@plane-down-down-scaling:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-a-dp-1-plane-down-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.00, 0.37] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-a-edp-1-plane-down-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.47, 1.54] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-a-hdmi-a-1-plane-down-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.43] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-a-hdmi-a-2-plane-down-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.35] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-a-vga-1-plane-down-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-b-dp-1-plane-down-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.00, 0.31] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-b-edp-1-plane-down-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.41, 1.53] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-b-hdmi-a-1-plane-down-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.37] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-b-hdmi-a-2-plane-down-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.36] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-b-vga-1-plane-down-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-c-dp-1-plane-down-down-scaling:
    - Statuses : 2 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-c-edp-1-plane-down-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.41, 1.47] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-c-hdmi-a-1-plane-down-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-c-hdmi-a-2-plane-down-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-down-down-scaling@pipe-d-edp-1-plane-down-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.41] s

  * igt@kms_plane_scaling@plane-downscaling:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-a-dp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.64, 1.25] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-a-edp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [3.63, 3.77] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-a-hdmi-a-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.89, 1.92] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-a-vga-1-downscaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-b-dp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.73, 1.30] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-b-edp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [3.48, 3.88] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-b-hdmi-a-1-downscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.77] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-b-hdmi-a-2-downscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.79] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-b-vga-1-downscaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-c-dp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.63, 0.89] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-c-edp-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [3.42, 3.96] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-c-hdmi-a-1-downscaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.76, 1.78] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-d-edp-1-downscaling:
    - Statuses : 1 pass(s)
    - Exec time: [3.65] s

  * igt@kms_plane_scaling@plane-downscaling@pipe-d-hdmi-a-1-downscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.81] s

  * igt@kms_plane_scaling@plane-up-down-scaling:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-a-dp-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.0, 0.33] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-a-edp-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.40, 1.48] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-a-hdmi-a-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.22, 0.39] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-a-hdmi-a-2-plane-up-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.31] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-a-vga-1-plane-up-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-b-dp-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.0, 0.27] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-b-edp-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.34, 1.47] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-b-hdmi-a-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.19, 0.35] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-b-hdmi-a-2-plane-up-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.32] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-b-vga-1-plane-up-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-c-dp-1-plane-up-down-scaling:
    - Statuses : 2 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-c-edp-1-plane-up-down-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.34, 1.48] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-c-hdmi-a-1-plane-up-down-scaling:
    - Statuses : 1 pass(s) 1 skip(s)
    - Exec time: [0.0, 0.20] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-c-hdmi-a-2-plane-up-down-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-d-edp-1-plane-up-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.35] s

  * igt@kms_plane_scaling@plane-up-down-scaling@pipe-d-hdmi-a-1-plane-up-down-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.20] s

  * igt@kms_plane_scaling@plane-up-up-scaling:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-a-dp-1-plane-up-up-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.00, 0.13] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-a-edp-1-plane-up-up-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.21, 0.28] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-a-hdmi-a-1-plane-up-up-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.33] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-a-vga-1-plane-up-up-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-b-dp-1-plane-up-up-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.0, 0.23] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-b-edp-1-plane-up-up-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.31, 1.38] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-b-hdmi-a-2-plane-up-up-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [0.29] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-b-vga-1-plane-up-up-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-c-dp-1-plane-up-up-scaling:
    - Statuses : 2 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-c-edp-1-plane-up-up-scaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.29, 1.41] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-c-hdmi-a-1-plane-up-up-scaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-up-up-scaling@pipe-d-edp-1-plane-up-up-scaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.33] s

  * igt@kms_plane_scaling@plane-upscaling:
    - Statuses :
    - Exec time: [None] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-a-dp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.42, 0.57] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-a-edp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.56, 2.33] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-a-hdmi-a-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.02, 1.17] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-a-vga-1-upscaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-b-dp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.52, 0.68] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-b-edp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [2.89, 3.44] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-b-hdmi-a-1-upscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.25] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-b-hdmi-a-2-upscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.13] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-b-vga-1-upscaling:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-c-dp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [0.47, 0.52] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-c-edp-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [3.32, 3.44] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-c-hdmi-a-1-upscaling:
    - Statuses : 2 pass(s)
    - Exec time: [1.10, 1.22] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-d-edp-1-upscaling:
    - Statuses : 1 pass(s)
    - Exec time: [3.32] s

  * igt@kms_plane_scaling@plane-upscaling@pipe-d-hdmi-a-1-upscaling:
    - Statuses : 1 pass(s)
    - Exec time: [1.21] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-a-dp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [3.95, 10.99] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-a-edp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [30.46, 35.20] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-a-hdmi-a-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [15.61, 24.65] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-a-vga-1-scaler-with-clipping-clamping:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-dp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [4.08, 11.43] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [32.33, 36.77] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-hdmi-a-1-scaler-with-clipping-clamping:
    - Statuses : 1 pass(s)
    - Exec time: [25.15] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-hdmi-a-2-scaler-with-clipping-clamping:
    - Statuses : 1 pass(s)
    - Exec time: [15.54] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-vga-1-scaler-with-clipping-clamping:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-dp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [0.48, 0.69] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-edp-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [1.76, 2.33] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-hdmi-a-1-scaler-with-clipping-clamping:
    - Statuses : 2 pass(s)
    - Exec time: [0.57, 1.20] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-d-edp-1-scaler-with-clipping-clamping:
    - Statuses : 1 pass(s)
    - Exec time: [1.80] s

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-d-hdmi-a-1-scaler-with-clipping-clamping:
    - Statuses : 1 pass(s)
    - Exec time: [0.57] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-dp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [1.58, 2.48] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-edp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [4.62, 8.66] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-hdmi-a-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [3.49, 4.19] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-a-vga-1-scaler-with-pixel-format:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-b-dp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [1.75, 2.73] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-b-edp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [5.85, 9.78] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-b-hdmi-a-1-scaler-with-pixel-format:
    - Statuses : 1 pass(s)
    - Exec time: [4.17] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-b-hdmi-a-2-scaler-with-pixel-format:
    - Statuses : 1 pass(s)
    - Exec time: [5.03] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-b-vga-1-scaler-with-pixel-format:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-c-dp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [1.49, 1.85] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-c-edp-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [5.92, 9.80] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-c-hdmi-a-1-scaler-with-pixel-format:
    - Statuses : 2 pass(s)
    - Exec time: [4.11, 4.72] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-d-edp-1-scaler-with-pixel-format:
    - Statuses : 1 pass(s)
    - Exec time: [5.82] s

  * igt@kms_plane_scaling@scaler-with-pixel-format@pipe-d-hdmi-a-1-scaler-with-pixel-format:
    - Statuses : 1 pass(s)
    - Exec time: [4.09] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-a-dp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [2.39] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-a-edp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [6.94] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-a-hdmi-a-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [4.21] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-a-vga-1-scaler-with-rotation:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-b-dp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [2.57] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-b-edp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [8.10] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-b-hdmi-a-2-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [5.24] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-b-vga-1-scaler-with-rotation:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-c-dp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [1.76] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-c-edp-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [8.20] s

  * igt@kms_plane_scaling@scaler-with-rotation@pipe-c-hdmi-a-1-scaler-with-rotation:
    - Statuses : 1 pass(s)
    - Exec time: [5.32] s

  

Known issues
------------

  Here are the changes found in IGTPW_6606_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_param@set-priority-not-supported:
    - shard-tglb:         NOTRUN -> [SKIP][2] ([fdo#109314])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb8/igt@gem_ctx_param@set-priority-not-supported.html

  * igt@gem_ctx_persistence@hostile:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-snb6/igt@gem_ctx_persistence@hostile.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         NOTRUN -> [FAIL][4] ([i915#232])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb1/igt@gem_eio@unwedge-stress.html
    - shard-snb:          NOTRUN -> [FAIL][5] ([i915#3354])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-snb4/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_balancer@parallel-balancer:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([i915#4525])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/shard-iclb4/igt@gem_exec_balancer@parallel-balancer.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb8/igt@gem_exec_balancer@parallel-balancer.html

  * igt@gem_exec_balancer@parallel-keep-in-fence:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][8] ([i915#5076])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-kbl1/igt@gem_exec_balancer@parallel-keep-in-fence.html

  * igt@gem_exec_fair@basic-flow@rcs0:
    - shard-tglb:         [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-iclb:         NOTRUN -> [FAIL][11] ([i915#2842]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
    - shard-glk:          NOTRUN -> [FAIL][12] ([i915#2842]) +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([i915#2842])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [PASS][15] -> [FAIL][16] ([i915#2842]) +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-tglb:         NOTRUN -> [FAIL][17] ([i915#2842])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb3/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_lmem_swapping@heavy-multi:
    - shard-apl:          NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-apl8/igt@gem_lmem_swapping@heavy-multi.html

  * igt@gem_lmem_swapping@heavy-verify-multi:
    - shard-kbl:          NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613]) +3 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-kbl4/igt@gem_lmem_swapping@heavy-verify-multi.html
    - shard-glk:          NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk2/igt@gem_lmem_swapping@heavy-verify-multi.html

  * igt@gem_lmem_swapping@random-engines:
    - shard-iclb:         NOTRUN -> [SKIP][21] ([i915#4613]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb2/igt@gem_lmem_swapping@random-engines.html

  * igt@gem_lmem_swapping@verify-random:
    - shard-tglb:         NOTRUN -> [SKIP][22] ([i915#4613]) +3 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb1/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_pxp@fail-invalid-protected-context:
    - shard-tglb:         NOTRUN -> [SKIP][23] ([i915#4270]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb3/igt@gem_pxp@fail-invalid-protected-context.html

  * igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
    - shard-iclb:         NOTRUN -> [SKIP][24] ([i915#4270]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb3/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html

  * igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs:
    - shard-iclb:         NOTRUN -> [SKIP][25] ([i915#768]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb4/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-mc-ccs.html

  * igt@gem_softpin@evict-snoop-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][26] ([fdo#109312]) +1 similar issue
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb5/igt@gem_softpin@evict-snoop-interruptible.html

  * igt@gem_userptr_blits@readonly-pwrite-unsync:
    - shard-iclb:         NOTRUN -> [SKIP][27] ([i915#3297])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb5/igt@gem_userptr_blits@readonly-pwrite-unsync.html

  * igt@gem_userptr_blits@unsync-unmap-after-close:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([i915#3297]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb1/igt@gem_userptr_blits@unsync-unmap-after-close.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          NOTRUN -> [DMESG-WARN][29] ([i915#180])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-apl1/igt@gem_workarounds@suspend-resume.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-iclb:         NOTRUN -> [SKIP][30] ([i915#2856]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb7/igt@gen9_exec_parse@allowed-all.html
    - shard-tglb:         NOTRUN -> [SKIP][31] ([i915#2527] / [i915#2856]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb6/igt@gen9_exec_parse@allowed-all.html
    - shard-glk:          NOTRUN -> [DMESG-WARN][32] ([i915#1436] / [i915#716])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk4/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_pm_lpsp@screens-disabled:
    - shard-tglb:         NOTRUN -> [SKIP][33] ([i915#1902])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb2/igt@i915_pm_lpsp@screens-disabled.html

  * igt@i915_pm_rpm@pc8-residency:
    - shard-iclb:         NOTRUN -> [SKIP][34] ([fdo#109293] / [fdo#109506])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb3/igt@i915_pm_rpm@pc8-residency.html
    - shard-tglb:         NOTRUN -> [SKIP][35] ([fdo#109506] / [i915#2411])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb2/igt@i915_pm_rpm@pc8-residency.html

  * igt@kms_atomic@plane-primary-overlay-mutable-zpos:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([i915#404])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb2/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
    - shard-iclb:         NOTRUN -> [SKIP][37] ([i915#1769])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
    - shard-tglb:         NOTRUN -> [SKIP][38] ([i915#1769])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb3/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html

  * igt@kms_big_fb@linear-16bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][39] ([fdo#111614]) +2 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb3/igt@kms_big_fb@linear-16bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-180:
    - shard-glk:          [PASS][40] -> [DMESG-WARN][41] ([i915#118])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11205/shard-glk2/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][42] ([fdo#110725] / [fdo#111614]) +1 similar issue
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb4/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
    - shard-glk:          NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-glk3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
    - shard-apl:          NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3777]) +2 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-apl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
    - shard-tglb:         NOTRUN -> [SKIP][45] ([fdo#111615]) +11 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb8/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
    - shard-kbl:          NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3777]) +5 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-kbl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
    - shard-iclb:         NOTRUN -> [SKIP][47] ([fdo#110723]) +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][48] ([i915#3689] / [i915#3886]) +7 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/shard-tglb7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_ccs:

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6606/index.html

[-- Attachment #2: Type: text/html, Size: 35960 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane
  2022-02-08  5:50 ` [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane Swati Sharma
@ 2022-02-09  8:26   ` Ville Syrjälä
  2022-02-09  8:28     ` Sharma, Swati2
  0 siblings, 1 reply; 20+ messages in thread
From: Ville Syrjälä @ 2022-02-09  8:26 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

On Tue, Feb 08, 2022 at 11:20:33AM +0530, Swati Sharma wrote:
> Subtest for testing upscaling for each plane
> individually (checked 1 plane per "class" like
> we do in other tests)
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_plane_scaling.c | 65 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 1cf62841..25e91659 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -230,6 +230,64 @@ static bool test_format(data_t *data,
>  	return true;
>  }
>  
> +static void
> +__test_plane_upscaling(data_t *d, igt_plane_t *plane,
> +		       enum pipe pipe, igt_output_t *output)
> +{
> +	igt_display_t *display = &d->display;
> +	int width, height;
> +	drmModeModeInfo *mode;
> +
> +	cleanup_crtc(d);
> +
> +	igt_output_set_pipe(output, pipe);
> +	mode = igt_output_get_mode(output);
> +	width = height = 20;
> +
> +	igt_create_color_pattern_fb(display->drm_fd,
> +                                    width, height,
> +                                    DRM_FORMAT_XRGB8888,
> +                                    I915_TILING_NONE,
> +                                    1.0, 0.0, 0.0, &d->fb[0]);
> +
> +	igt_plane_set_fb(plane, &d->fb[0]);
> +	igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
> +	igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +	igt_plane_set_fb(plane, NULL);
> +	igt_remove_fb(display->drm_fd, &d->fb[0]);
> +}
> +
> +static void
> +test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
> +{
> +	igt_display_t *display = &d->display;
> +	igt_plane_t *plane;
> +	uint64_t modifier = is_i915_device(d->drm_fd) ?
> +		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;

Why should we use Y-tiling? That's just going to artifically restrict
what platforms can run this test.

> +
> +	igt_require(get_num_scalers(d, pipe) > 0);
> +
> +	for_each_plane_on_pipe(display, pipe, plane) {
> +		struct igt_vec tested_formats;
> +
> +		if (plane->type == DRM_PLANE_TYPE_CURSOR)
> +			continue;
> +
> +		igt_vec_init(&tested_formats, sizeof(uint32_t));
> +
> +		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
> +			uint32_t format = plane->drm_plane->formats[j];
> +			if (test_format(d, &tested_formats, format) &&
> +			    igt_plane_has_format_mod(plane, format, modifier) &&
> +			    can_scale(d, format))
> +					__test_plane_upscaling(d, plane, pipe, output);
> +		}
> +
> +		igt_vec_fini(&tested_formats);
> +	}
> +}
> +
>  static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>  {
>  	if (!is_i915_device(data->drm_fd) ||
> @@ -547,6 +605,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  	igt_subtest_group {
>  		igt_output_t *output;
>  
> +		igt_describe("Tests plane upscaling.");
> +		igt_subtest_with_dynamic("plane-upscaling") {
> +			for_each_pipe_with_single_output(&data.display, pipe, output)
> +				igt_dynamic_f("pipe-%s-%s-upscaling", kmstest_pipe_name(pipe), igt_output_name(output))
> +					test_plane_upscaling(&data, pipe, output);
> +		}
> +
>  		igt_describe("Tests scaling with pixel formats.");
>  		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>  			for_each_pipe_with_single_output(&data.display, pipe, output)
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane
  2022-02-09  8:26   ` Ville Syrjälä
@ 2022-02-09  8:28     ` Sharma, Swati2
  0 siblings, 0 replies; 20+ messages in thread
From: Sharma, Swati2 @ 2022-02-09  8:28 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev



On 09-Feb-22 1:56 PM, Ville Syrjälä wrote:
> On Tue, Feb 08, 2022 at 11:20:33AM +0530, Swati Sharma wrote:
>> Subtest for testing upscaling for each plane
>> individually (checked 1 plane per "class" like
>> we do in other tests)
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/kms_plane_scaling.c | 65 +++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 65 insertions(+)
>>
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> index 1cf62841..25e91659 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -230,6 +230,64 @@ static bool test_format(data_t *data,
>>   	return true;
>>   }
>>   
>> +static void
>> +__test_plane_upscaling(data_t *d, igt_plane_t *plane,
>> +		       enum pipe pipe, igt_output_t *output)
>> +{
>> +	igt_display_t *display = &d->display;
>> +	int width, height;
>> +	drmModeModeInfo *mode;
>> +
>> +	cleanup_crtc(d);
>> +
>> +	igt_output_set_pipe(output, pipe);
>> +	mode = igt_output_get_mode(output);
>> +	width = height = 20;
>> +
>> +	igt_create_color_pattern_fb(display->drm_fd,
>> +                                    width, height,
>> +                                    DRM_FORMAT_XRGB8888,
>> +                                    I915_TILING_NONE,
>> +                                    1.0, 0.0, 0.0, &d->fb[0]);
>> +
>> +	igt_plane_set_fb(plane, &d->fb[0]);
>> +	igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
>> +	igt_display_commit2(display, COMMIT_ATOMIC);
>> +
>> +	igt_plane_set_fb(plane, NULL);
>> +	igt_remove_fb(display->drm_fd, &d->fb[0]);
>> +}
>> +
>> +static void
>> +test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>> +{
>> +	igt_display_t *display = &d->display;
>> +	igt_plane_t *plane;
>> +	uint64_t modifier = is_i915_device(d->drm_fd) ?
>> +		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
> 
> Why should we use Y-tiling? That's just going to artifically restrict
> what platforms can run this test.
To make code consistent, I did this. This was used in other tests too.
I can simply make it linear.
> 
>> +
>> +	igt_require(get_num_scalers(d, pipe) > 0);
>> +
>> +	for_each_plane_on_pipe(display, pipe, plane) {
>> +		struct igt_vec tested_formats;
>> +
>> +		if (plane->type == DRM_PLANE_TYPE_CURSOR)
>> +			continue;
>> +
>> +		igt_vec_init(&tested_formats, sizeof(uint32_t));
>> +
>> +		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
>> +			uint32_t format = plane->drm_plane->formats[j];
>> +			if (test_format(d, &tested_formats, format) &&
>> +			    igt_plane_has_format_mod(plane, format, modifier) &&
>> +			    can_scale(d, format))
>> +					__test_plane_upscaling(d, plane, pipe, output);
>> +		}
>> +
>> +		igt_vec_fini(&tested_formats);
>> +	}
>> +}
>> +
>>   static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>>   {
>>   	if (!is_i915_device(data->drm_fd) ||
>> @@ -547,6 +605,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>>   	igt_subtest_group {
>>   		igt_output_t *output;
>>   
>> +		igt_describe("Tests plane upscaling.");
>> +		igt_subtest_with_dynamic("plane-upscaling") {
>> +			for_each_pipe_with_single_output(&data.display, pipe, output)
>> +				igt_dynamic_f("pipe-%s-%s-upscaling", kmstest_pipe_name(pipe), igt_output_name(output))
>> +					test_plane_upscaling(&data, pipe, output);
>> +		}
>> +
>>   		igt_describe("Tests scaling with pixel formats.");
>>   		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>>   			for_each_pipe_with_single_output(&data.display, pipe, output)
>> -- 
>> 2.25.1
> 

-- 
~Swati Sharma

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling each plane
  2022-02-08  5:50 ` [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
@ 2022-02-09  8:31   ` Ville Syrjälä
  2022-02-14 16:40     ` Sharma, Swati2
  0 siblings, 1 reply; 20+ messages in thread
From: Ville Syrjälä @ 2022-02-09  8:31 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

On Tue, Feb 08, 2022 at 11:20:34AM +0530, Swati Sharma wrote:
> Subtest for testing downscaling for each plane
> individually (checked 1 plane per "class" like
> we do in other tests).
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_plane_scaling.c | 77 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 25e91659..22563fac 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -288,6 +288,76 @@ test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>  	}
>  }
>  
> +static void
> +__test_plane_downscaling(data_t *d, igt_plane_t *plane,
> +		         enum pipe pipe, igt_output_t *output)
> +{
> +	igt_display_t *display = &d->display;
> +	int width, height;
> +	drmModeModeInfo *mode;
> +	bool test_complete = false;
> +	int scaling = 50;
> +	int ret;
> +
> +	cleanup_crtc(d);
> +
> +	igt_output_set_pipe(output, pipe);
> +	mode = igt_output_get_mode(output);
> +	width = mode->hdisplay;
> +	height = mode->vdisplay;
> +
> +	while(!test_complete) {
> +
> +		igt_create_color_pattern_fb(display->drm_fd,
> +					    width, height,
> +					    DRM_FORMAT_XRGB8888,
> +					    I915_TILING_NONE,
> +					    1.0, 0.0, 0.0, &d->fb[0]);
> +
> +		igt_plane_set_fb(plane, &d->fb[0]);
> +		igt_plane_set_size(plane, (width * scaling) / 100, (height * scaling) / 100);
> +		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> +
> +		if (ret != -EINVAL)
> +			test_complete = true;
> +
> +		scaling += 5;
> +
> +		igt_plane_set_fb(plane, NULL);
> +		igt_remove_fb(display->drm_fd, &d->fb[0]);
> +	}
> +}
> +
> +static void
> +test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
> +{
> +	igt_display_t *display = &d->display;
> +	igt_plane_t *plane;
> +	uint64_t modifier = is_i915_device(d->drm_fd) ?
> +		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;

Same Y-tile thing a sin the upscale test.

> +
> +	igt_require(get_num_scalers(d, pipe) > 0);

That i915ism shouldn't be required given you use try_commit().

> +
> +	for_each_plane_on_pipe(display, pipe, plane) {
> +		struct igt_vec tested_formats;
> +
> +		if (plane->type == DRM_PLANE_TYPE_CURSOR)
> +			continue;
> +
> +		igt_vec_init(&tested_formats, sizeof(uint32_t));
> +
> +		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
> +			uint32_t format = plane->drm_plane->formats[j];
> +			if (test_format(d, &tested_formats, format) &&
> +			    igt_plane_has_format_mod(plane, format, modifier) &&
> +			    can_scale(d, format))
> +					__test_plane_downscaling(d, plane, pipe, output);
> +		}
> +
> +		igt_vec_fini(&tested_formats);
> +	}
> +}

This whole function seems identical to the upscaling test.
Could be all shared code pretty easily.


> +
>  static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>  {
>  	if (!is_i915_device(data->drm_fd) ||
> @@ -612,6 +682,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  					test_plane_upscaling(&data, pipe, output);
>  		}
>  
> +		igt_describe("Tests plane downscaling.");
> +		igt_subtest_with_dynamic("plane-downscaling") {
> +			for_each_pipe_with_single_output(&data.display, pipe, output)
> +				igt_dynamic_f("pipe-%s-%s-downscaling", kmstest_pipe_name(pipe), igt_output_name(output))
> +					test_plane_downscaling(&data, pipe, output);
> +		}
> +
>  		igt_describe("Tests scaling with pixel formats.");
>  		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>  			for_each_pipe_with_single_output(&data.display, pipe, output)
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes
  2022-02-08  5:50 ` [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes Swati Sharma
@ 2022-02-09  8:36   ` Ville Syrjälä
  2022-02-14 16:42     ` Sharma, Swati2
  0 siblings, 1 reply; 20+ messages in thread
From: Ville Syrjälä @ 2022-02-09  8:36 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

On Tue, Feb 08, 2022 at 11:20:35AM +0530, Swati Sharma wrote:
> i915 driver supports 2 scalers per pipe. Added test case
> to upscale 2 overlay planes simultaneously on single pipe.
> 
> v2: -add check for min 2 scalers
>     -add igt_require() for overlay planes, fixes CRASH on KBL
> 
> v3: -test modified for n planes (Ville)
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_plane_scaling.c | 74 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 74 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 22563fac..f813c5b4 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -29,6 +29,11 @@
>  
>  IGT_TEST_DESCRIPTION("Test display plane scaling");
>  
> +/* Test flags. */
> +enum {
> +        TEST_UP_UP_SCALING = 1 << 0,
> +};
> +
>  typedef struct {
>  	uint32_t devid;
>  	int drm_fd;
> @@ -358,6 +363,67 @@ test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>  	}
>  }
>  
> +static void
> +__test_plane_up_up_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
> +{
> +	drmModeModeInfo *mode;
> +	int width, height;
> +	igt_display_t *display = &d->display;
> +
> +	cleanup_crtc(d);
> +
> +	igt_output_set_pipe(output, pipe);
> +	mode = igt_output_get_mode(output);
> +	width = height = 20;
> +
> +	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
> +		igt_plane_t *plane1, *plane2;
> +
> +		plane1 = &display->pipes[pipe].planes[k];
> +		igt_require(plane1);
> +		plane2 = &display->pipes[pipe].planes[k+1];
> +		igt_require(plane2);
> +
> +		if (plane1->type == DRM_PLANE_TYPE_PRIMARY  || plane1->type == DRM_PLANE_TYPE_CURSOR ||
> +		    plane2->type == DRM_PLANE_TYPE_PRIMARY || plane2->type ==DRM_PLANE_TYPE_CURSOR)
> +				continue;
> +
> +		igt_create_color_pattern_fb(display->drm_fd,
> +					    width, height,
> +					    DRM_FORMAT_XRGB8888,
> +					    I915_TILING_NONE,
> +					    1.0, 0.0, 0.0, &d->fb[1]);
> +		igt_create_color_pattern_fb(display->drm_fd,
> +					    width, height,
> +					    DRM_FORMAT_XRGB8888,
> +					    I915_TILING_NONE,
> +					    0.0, 1.0, 0.0, &d->fb[2]);

Recreating the same fbs every iteration seems pointless/expensive.

> +
> +		igt_plane_set_fb(plane1, &d->fb[1]);
> +		igt_plane_set_fb(plane2, &d->fb[2]);
> +
> +		/* 1st overlay plane upscaling */
> +		igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
> +		/* 2nd overlay plane upscaling */
> +		igt_plane_set_size(plane2, mode->hdisplay - 20, mode->vdisplay - 20);
> +		igt_display_commit2(display, COMMIT_ATOMIC);
> +
> +		igt_plane_set_fb(plane1, NULL);
> +		igt_plane_set_fb(plane2, NULL);
> +		igt_remove_fb(display->drm_fd, &d->fb[1]);
> +		igt_remove_fb(display->drm_fd, &d->fb[2]);
> +	}
> +}
> +
> +static void
> +test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32_t flags)
> +{
> +	igt_require(get_num_scalers(d, pipe) >= 2);
> +
> +	if (flags & TEST_UP_UP_SCALING)

What's the point of this flag based dispatcher thing? Just call the
right function directly?

> +		__test_plane_up_up_scaling(d, pipe, output);
> +}
> +
>  static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>  {
>  	if (!is_i915_device(data->drm_fd) ||
> @@ -689,6 +755,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  					test_plane_downscaling(&data, pipe, output);
>  		}
>  
> +		igt_describe("Tests upscaling of 2 overlay planes.");
> +		igt_subtest_with_dynamic("plane-up-up-scaling") {

Bit of a funny name that, but don't really have a great idea
how to make it any better.

> +			for_each_pipe_with_single_output(&data.display, pipe, output)
> +				igt_dynamic_f("pipe-%s-%s-plane-up-up-scaling",
> +					      kmstest_pipe_name(pipe), igt_output_name(output))
> +					test_plane_scaling_combo(&data, pipe, output, TEST_UP_UP_SCALING);
> +		}
> +
>  		igt_describe("Tests scaling with pixel formats.");
>  		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>  			for_each_pipe_with_single_output(&data.display, pipe, output)
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling each plane
  2022-02-09  8:31   ` Ville Syrjälä
@ 2022-02-14 16:40     ` Sharma, Swati2
  0 siblings, 0 replies; 20+ messages in thread
From: Sharma, Swati2 @ 2022-02-14 16:40 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev



On 09-Feb-22 2:01 PM, Ville Syrjälä wrote:
> On Tue, Feb 08, 2022 at 11:20:34AM +0530, Swati Sharma wrote:
>> Subtest for testing downscaling for each plane
>> individually (checked 1 plane per "class" like
>> we do in other tests).
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/kms_plane_scaling.c | 77 +++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 77 insertions(+)
>>
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> index 25e91659..22563fac 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -288,6 +288,76 @@ test_plane_upscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>>   	}
>>   }
>>   
>> +static void
>> +__test_plane_downscaling(data_t *d, igt_plane_t *plane,
>> +		         enum pipe pipe, igt_output_t *output)
>> +{
>> +	igt_display_t *display = &d->display;
>> +	int width, height;
>> +	drmModeModeInfo *mode;
>> +	bool test_complete = false;
>> +	int scaling = 50;
>> +	int ret;
>> +
>> +	cleanup_crtc(d);
>> +
>> +	igt_output_set_pipe(output, pipe);
>> +	mode = igt_output_get_mode(output);
>> +	width = mode->hdisplay;
>> +	height = mode->vdisplay;
>> +
>> +	while(!test_complete) {
>> +
>> +		igt_create_color_pattern_fb(display->drm_fd,
>> +					    width, height,
>> +					    DRM_FORMAT_XRGB8888,
>> +					    I915_TILING_NONE,
>> +					    1.0, 0.0, 0.0, &d->fb[0]);
>> +
>> +		igt_plane_set_fb(plane, &d->fb[0]);
>> +		igt_plane_set_size(plane, (width * scaling) / 100, (height * scaling) / 100);
>> +		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
>> +
>> +		if (ret != -EINVAL)
>> +			test_complete = true;
>> +
>> +		scaling += 5;
>> +
>> +		igt_plane_set_fb(plane, NULL);
>> +		igt_remove_fb(display->drm_fd, &d->fb[0]);
>> +	}
>> +}
>> +
>> +static void
>> +test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>> +{
>> +	igt_display_t *display = &d->display;
>> +	igt_plane_t *plane;
>> +	uint64_t modifier = is_i915_device(d->drm_fd) ?
>> +		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
> 
> Same Y-tile thing a sin the upscale test.

Done in v4. Set modifier as LINEAR.

> 
>> +
>> +	igt_require(get_num_scalers(d, pipe) > 0);
> 
> That i915ism shouldn't be required given you use try_commit().
> 

Done in v4

>> +
>> +	for_each_plane_on_pipe(display, pipe, plane) {
>> +		struct igt_vec tested_formats;
>> +
>> +		if (plane->type == DRM_PLANE_TYPE_CURSOR)
>> +			continue;
>> +
>> +		igt_vec_init(&tested_formats, sizeof(uint32_t));
>> +
>> +		for (int j = 0; j < plane->drm_plane->count_formats; j++) {
>> +			uint32_t format = plane->drm_plane->formats[j];
>> +			if (test_format(d, &tested_formats, format) &&
>> +			    igt_plane_has_format_mod(plane, format, modifier) &&
>> +			    can_scale(d, format))
>> +					__test_plane_downscaling(d, plane, pipe, output);
>> +		}
>> +
>> +		igt_vec_fini(&tested_formats);
>> +	}
>> +}
> 
> This whole function seems identical to the upscaling test.
> Could be all shared code pretty easily.

Done in v4.

> 
> 
>> +
>>   static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>>   {
>>   	if (!is_i915_device(data->drm_fd) ||
>> @@ -612,6 +682,13 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>>   					test_plane_upscaling(&data, pipe, output);
>>   		}
>>   
>> +		igt_describe("Tests plane downscaling.");
>> +		igt_subtest_with_dynamic("plane-downscaling") {
>> +			for_each_pipe_with_single_output(&data.display, pipe, output)
>> +				igt_dynamic_f("pipe-%s-%s-downscaling", kmstest_pipe_name(pipe), igt_output_name(output))
>> +					test_plane_downscaling(&data, pipe, output);
>> +		}
>> +
>>   		igt_describe("Tests scaling with pixel formats.");
>>   		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>>   			for_each_pipe_with_single_output(&data.display, pipe, output)
>> -- 
>> 2.25.1
> 

-- 
~Swati Sharma

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes
  2022-02-09  8:36   ` Ville Syrjälä
@ 2022-02-14 16:42     ` Sharma, Swati2
  0 siblings, 0 replies; 20+ messages in thread
From: Sharma, Swati2 @ 2022-02-14 16:42 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev



On 09-Feb-22 2:06 PM, Ville Syrjälä wrote:
> On Tue, Feb 08, 2022 at 11:20:35AM +0530, Swati Sharma wrote:
>> i915 driver supports 2 scalers per pipe. Added test case
>> to upscale 2 overlay planes simultaneously on single pipe.
>>
>> v2: -add check for min 2 scalers
>>      -add igt_require() for overlay planes, fixes CRASH on KBL
>>
>> v3: -test modified for n planes (Ville)
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>>   tests/kms_plane_scaling.c | 74 +++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 74 insertions(+)
>>
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> index 22563fac..f813c5b4 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -29,6 +29,11 @@
>>   
>>   IGT_TEST_DESCRIPTION("Test display plane scaling");
>>   
>> +/* Test flags. */
>> +enum {
>> +        TEST_UP_UP_SCALING = 1 << 0,
>> +};
>> +
>>   typedef struct {
>>   	uint32_t devid;
>>   	int drm_fd;
>> @@ -358,6 +363,67 @@ test_plane_downscaling(data_t *d, enum pipe pipe, igt_output_t *output)
>>   	}
>>   }
>>   
>> +static void
>> +__test_plane_up_up_scaling(data_t *d, enum pipe pipe, igt_output_t *output)
>> +{
>> +	drmModeModeInfo *mode;
>> +	int width, height;
>> +	igt_display_t *display = &d->display;
>> +
>> +	cleanup_crtc(d);
>> +
>> +	igt_output_set_pipe(output, pipe);
>> +	mode = igt_output_get_mode(output);
>> +	width = height = 20;
>> +
>> +	for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
>> +		igt_plane_t *plane1, *plane2;
>> +
>> +		plane1 = &display->pipes[pipe].planes[k];
>> +		igt_require(plane1);
>> +		plane2 = &display->pipes[pipe].planes[k+1];
>> +		igt_require(plane2);
>> +
>> +		if (plane1->type == DRM_PLANE_TYPE_PRIMARY  || plane1->type == DRM_PLANE_TYPE_CURSOR ||
>> +		    plane2->type == DRM_PLANE_TYPE_PRIMARY || plane2->type ==DRM_PLANE_TYPE_CURSOR)
>> +				continue;
>> +
>> +		igt_create_color_pattern_fb(display->drm_fd,
>> +					    width, height,
>> +					    DRM_FORMAT_XRGB8888,
>> +					    I915_TILING_NONE,
>> +					    1.0, 0.0, 0.0, &d->fb[1]);
>> +		igt_create_color_pattern_fb(display->drm_fd,
>> +					    width, height,
>> +					    DRM_FORMAT_XRGB8888,
>> +					    I915_TILING_NONE,
>> +					    0.0, 1.0, 0.0, &d->fb[2]);
> 
> Recreating the same fbs every iteration seems pointless/expensive.

Fixed in v4.

> 
>> +
>> +		igt_plane_set_fb(plane1, &d->fb[1]);
>> +		igt_plane_set_fb(plane2, &d->fb[2]);
>> +
>> +		/* 1st overlay plane upscaling */
>> +		igt_plane_set_size(plane1, mode->hdisplay, mode->vdisplay);
>> +		/* 2nd overlay plane upscaling */
>> +		igt_plane_set_size(plane2, mode->hdisplay - 20, mode->vdisplay - 20);
>> +		igt_display_commit2(display, COMMIT_ATOMIC);
>> +
>> +		igt_plane_set_fb(plane1, NULL);
>> +		igt_plane_set_fb(plane2, NULL);
>> +		igt_remove_fb(display->drm_fd, &d->fb[1]);
>> +		igt_remove_fb(display->drm_fd, &d->fb[2]);
>> +	}
>> +}
>> +
>> +static void
>> +test_plane_scaling_combo(data_t *d, enum pipe pipe, igt_output_t *output, uint32_t flags)
>> +{
>> +	igt_require(get_num_scalers(d, pipe) >= 2);
>> +
>> +	if (flags & TEST_UP_UP_SCALING)
> 
> What's the point of this flag based dispatcher thing? Just call the
> right function directly?

okay.

> 
>> +		__test_plane_up_up_scaling(d, pipe, output);
>> +}
>> +
>>   static bool test_pipe_iteration(data_t *data, enum pipe pipe, int iteration)
>>   {
>>   	if (!is_i915_device(data->drm_fd) ||
>> @@ -689,6 +755,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>>   					test_plane_downscaling(&data, pipe, output);
>>   		}
>>   
>> +		igt_describe("Tests upscaling of 2 overlay planes.");
>> +		igt_subtest_with_dynamic("plane-up-up-scaling") {
> 
> Bit of a funny name that, but don't really have a great idea
> how to make it any better.

Any suggestions now? Already tried many names, did find any less funny :p
Can we go with plane-upscaling-upscaling ?
> 
>> +			for_each_pipe_with_single_output(&data.display, pipe, output)
>> +				igt_dynamic_f("pipe-%s-%s-plane-up-up-scaling",
>> +					      kmstest_pipe_name(pipe), igt_output_name(output))
>> +					test_plane_scaling_combo(&data, pipe, output, TEST_UP_UP_SCALING);
>> +		}
>> +
>>   		igt_describe("Tests scaling with pixel formats.");
>>   		igt_subtest_with_dynamic("scaler-with-pixel-format") {
>>   			for_each_pipe_with_single_output(&data.display, pipe, output)
>> -- 
>> 2.25.1
> 

-- 
~Swati Sharma

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-02-14 16:43 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08  5:50 [igt-dev] [v3 0/9] Addition of new plane scaling test cases Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 1/9] tests/kms_plane_scaling: Removal of plane-scaling subtest Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 2/9] tests/kms_plane_scaling: Add output name in dynamic subtests Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 3/9] tests/kms_plane_scaling: Upscaling each plane Swati Sharma
2022-02-09  8:26   ` Ville Syrjälä
2022-02-09  8:28     ` Sharma, Swati2
2022-02-08  5:50 ` [igt-dev] [v3 4/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
2022-02-09  8:31   ` Ville Syrjälä
2022-02-14 16:40     ` Sharma, Swati2
2022-02-08  5:50 ` [igt-dev] [v3 5/9] tests/kms_plane_scaling: Upscaling on 2 planes Swati Sharma
2022-02-09  8:36   ` Ville Syrjälä
2022-02-14 16:42     ` Sharma, Swati2
2022-02-08  5:50 ` [igt-dev] [v3 6/9] tests/kms_plane_scaling: Downscaling " Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 7/9] tests/kms_plane_scaling: Upscaling and downscaling scenario Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 8/9] tests/kms_plane_scaling: Add negative test to check num of scalers Swati Sharma
2022-02-08  5:50 ` [igt-dev] [v3 9/9] tests/kms_plane_scaling: Refactor clipping-clamping subtest Swati Sharma
2022-02-08  6:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev3) Patchwork
2022-02-08  9:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for Addition of new plane scaling test cases (rev4) Patchwork
2022-02-08 22:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Addition of new plane scaling test cases (rev5) Patchwork
2022-02-08 23:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox