Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_exec_parallel: Add 48b flag to execbuf

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Zbigniew,

Dnia 2022-03-23 at 14:06:53 +0100, Zbigniew Kempczyński napisał(a):
> On dg2 and beyond safe alignment is bigger than on integrated so we
> can enter offset range >= 2^32. Add execbuf flag which allows using
> such offsets.
> 
See note at 1/2 patch, maybe you can improve description.

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  tests/i915/gem_exec_parallel.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
> index 36bf5f742e..1dfbaa2411 100644
> --- a/tests/i915/gem_exec_parallel.c
> +++ b/tests/i915/gem_exec_parallel.c
> @@ -150,9 +150,10 @@ static void *thread(void *data)
>  			batch[++i] = offset + 4*t->id;
>  			batch[++i] = offset >> 32;
>  			obj[0].offset = offset;
> -			obj[0].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_WRITE;
> +			obj[0].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_WRITE |
> +					EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>  			obj[1].offset = get_offset(t->ahnd, obj[1].handle, 4096, 0);
> -			obj[1].flags |= EXEC_OBJECT_PINNED;
> +			obj[1].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>  			gem_write(fd, obj[1].handle, 0, batch, sizeof(batch));
>  		}
>  
> -- 
> 2.32.0
>