[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to basic subtests.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..495748ec 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,8 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Tests execute batches using execbuf ioctl across various suspend resume "
+		     "states and validates the execution result by comparing with expected ones.");
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -296,19 +298,26 @@ igt_main
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem target "
+						"state and suspend sequence termination point set "
+						"to device suspend state." },
+		{ "basic-S3", SUSPEND, run_test, "Check with suspend-to-mem target state, perform "
+						 "a full suspend/resume cycle." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+						"target state and suspend sequence termination "
+						"point set to device suspend state." },
+		{ "basic-S4", HIBERNATE, run_test, "Check with suspend-to-disk target state, "
+						"perform a full suspend/resume cycle." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "" },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "" },
+		{ "power-S0", IDLE, power_test, "" },
+		{ "power-S3", SUSPEND, power_test, "" },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,8 +368,10 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
-- 
2.25.1

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[Kamil Konieczny]

Hi Janga,

On 2022-06-09 at 10:58:18 +0530, janga.rahul.kumar@intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> Added test description to basic subtests.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
>  tests/i915/gem_exec_suspend.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
> index 401026ef..495748ec 100644
> --- a/tests/i915/gem_exec_suspend.c
> +++ b/tests/i915/gem_exec_suspend.c
> @@ -37,6 +37,8 @@
>  #include "igt_gt.h"
>  #include "igt_sysfs.h"
>  
> +IGT_TEST_DESCRIPTION("Tests execute batches using execbuf ioctl across various suspend resume "
> +		     "states and validates the execution result by comparing with expected ones.");

Please change this description, you do not need to write down
what exact step there is in code source (which we can read it),
write what is purpose of these tests here.

I suggest reading commit descriptions with:

git log tests/i915/gem_exec_suspend.c

git log 741bf7064c467d -- tests/gem_exec_suspend.c

>  #define NOSLEEP 0
>  #define IDLE 1
>  #define SUSPEND_DEVICES 2
> @@ -296,19 +298,26 @@ igt_main
>  		const char *name;
>  		unsigned int flags;
>  		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
> +		const char *describe;
>  	} *test, tests_all_engines[] = {
> -		{ "basic", NOSLEEP, run_test },
> -		{ "basic-S0", IDLE, run_test },
> -		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
> -		{ "basic-S3", SUSPEND, run_test },
> -		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
> -		{ "basic-S4", HIBERNATE, run_test },
> +		{ "basic", NOSLEEP, run_test, "Check basic functionality." },
----------------------------------------------------------------------- ^
imho you can add "without s/r" here,
s/functionality./functionality without any suspend/resume cycle./

> +		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
> +		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem target "
> +						"state and suspend sequence termination point set "
> +						"to device suspend state." },

Please improve this description, see commit bbb950302f7c8405faa9c8018541501ee7bd335f
tests/gem_exec_suspend: Add basic S3/S4-devices subtests

> +		{ "basic-S3", SUSPEND, run_test, "Check with suspend-to-mem target state, perform "
> +						 "a full suspend/resume cycle." },

These looks a little redundant, maybe something like:
Check full cycle of suspend-to-mem.

> +		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
> +						"target state and suspend sequence termination "
> +						"point set to device suspend state." },

Change this, maybe
Check suspend-to-disk with device only.

> +		{ "basic-S4", HIBERNATE, run_test, "Check with suspend-to-disk target state, "
> +						"perform a full suspend/resume cycle." },

Please improve this one.

>  		{ }
>  	}, tests_power_hang[] = {
> -		{ "hang-S3", SUSPEND | HANG, run_test },
> -		{ "hang-S4", HIBERNATE | HANG, run_test },
> -		{ "power-S0", IDLE, power_test },
> -		{ "power-S3", SUSPEND, power_test },
> +		{ "hang-S3", SUSPEND | HANG, run_test, "" },
> +		{ "hang-S4", HIBERNATE | HANG, run_test, "" },
> +		{ "power-S0", IDLE, power_test, "" },
> +		{ "power-S3", SUSPEND, power_test, "" },

Please also fill these descriptions here.

Run test with --describe option, e.g.
sudo ./gem_exec_suspend --describe
to see what other descriptions are missing.

Regards,
Kamil
>  		{ }
>  	};
>  	const struct intel_execution_engine2 *e;
> @@ -359,8 +368,10 @@ igt_main
>  		} \
>  	}
>  
> -	for (test = tests_all_engines; test->name; test++)
> +	for (test = tests_all_engines; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	for (m = modes; m->suffix; m++) {
>  		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
> -- 
> 2.25.1
> 

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests.

v2 : Modified subtest description and added description
     to all the subtests.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 50 ++++++++++++++++++++++++-----------
 1 file changed, 34 insertions(+), 16 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..55529bb8 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,9 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Exercise simple exec-and-read, measure power across various "
+		     "suspend/resume cycles.");
+
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -286,29 +289,37 @@ igt_main
 	const struct {
 		const char *suffix;
 		unsigned mode;
+		const char *describe;
 	} modes[] = {
-		{ "", NOSLEEP },
-		{ "-S3", SUSPEND },
-		{ "-S4", HIBERNATE },
-		{ NULL, 0 }
+		{ "", NOSLEEP, "without suspend/resume cycle" },
+		{ "-S3", SUSPEND, "suspend-to-mem" },
+		{ "-S4", HIBERNATE, "suspend-to-device" },
+		{ NULL, 0, "" }
 	}, *m;
 	struct test {
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
+					      "suspend/resume cycle." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
+								 "with device only." },
+		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+								   "with device only." },
+		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
+						"susepnd-to-mem with a pending GPU hang." },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-disk with a pending GPU hang." },
+		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
+		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
+						   "suspend state." },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,20 +370,25 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
+		igt_describe_f("Check %s state with fixed object.", m->describe);
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
 			igt_require(gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode);
 		}
 
+		igt_describe_f("Check %s state with uncached object.", m->describe);
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | UNCACHED);
 		}
 
+		igt_describe_f("Check %s state with cached object.", m->describe);
 		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | CACHED);
@@ -384,8 +400,10 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
-	for (test = tests_power_hang; test->name; test++)
+	for (test = tests_power_hang; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	igt_fixture {
 		free(query_info);
-- 
2.25.1

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[Kumar, Janga Rahul]

> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Sent: 09 June 2022 16:11
> To: igt-dev@lists.freedesktop.org
> Cc: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>
> Subject: Re: [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests
> description
> 
> Hi Janga,
> 
> On 2022-06-09 at 10:58:18 +0530, janga.rahul.kumar@intel.com wrote:
> > From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> >
> > Added test description to basic subtests.
> >
> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> > ---
> >  tests/i915/gem_exec_suspend.c | 33 ++++++++++++++++++++++-----------
> >  1 file changed, 22 insertions(+), 11 deletions(-)
> >
> > diff --git a/tests/i915/gem_exec_suspend.c
> > b/tests/i915/gem_exec_suspend.c index 401026ef..495748ec 100644
> > --- a/tests/i915/gem_exec_suspend.c
> > +++ b/tests/i915/gem_exec_suspend.c
> > @@ -37,6 +37,8 @@
> >  #include "igt_gt.h"
> >  #include "igt_sysfs.h"
> >
> > +IGT_TEST_DESCRIPTION("Tests execute batches using execbuf ioctl across
> various suspend resume "
> > +		     "states and validates the execution result by comparing with
> > +expected ones.");
> 
> Please change this description, you do not need to write down what exact step
> there is in code source (which we can read it), write what is purpose of these
> tests here.
> 
> I suggest reading commit descriptions with:
> 
> git log tests/i915/gem_exec_suspend.c
> 
> git log 741bf7064c467d -- tests/gem_exec_suspend.c
> 
> >  #define NOSLEEP 0
> >  #define IDLE 1
> >  #define SUSPEND_DEVICES 2
> > @@ -296,19 +298,26 @@ igt_main
> >  		const char *name;
> >  		unsigned int flags;
> >  		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
> > +		const char *describe;
> >  	} *test, tests_all_engines[] = {
> > -		{ "basic", NOSLEEP, run_test },
> > -		{ "basic-S0", IDLE, run_test },
> > -		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
> > -		{ "basic-S3", SUSPEND, run_test },
> > -		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
> > -		{ "basic-S4", HIBERNATE, run_test },
> > +		{ "basic", NOSLEEP, run_test, "Check basic functionality." },
> ----------------------------------------------------------------------- ^ imho you can add
> "without s/r" here, s/functionality./functionality without any suspend/resume
> cycle./
> 
> > +		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target
> state." },
> > +		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with
> suspend-to-mem target "
> > +						"state and suspend sequence
> termination point set "
> > +						"to device suspend state." },
> 
> Please improve this description, see commit
> bbb950302f7c8405faa9c8018541501ee7bd335f
> tests/gem_exec_suspend: Add basic S3/S4-devices subtests
> 
> > +		{ "basic-S3", SUSPEND, run_test, "Check with suspend-to-mem
> target state, perform "
> > +						 "a full suspend/resume cycle."
> },
> 
> These looks a little redundant, maybe something like:
> Check full cycle of suspend-to-mem.
> 
> > +		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check
> with suspend-to-disk "
> > +						"target state and suspend
> sequence termination "
> > +						"point set to device suspend
> state." },
> 
> Change this, maybe
> Check suspend-to-disk with device only.
> 
> > +		{ "basic-S4", HIBERNATE, run_test, "Check with suspend-to-disk
> target state, "
> > +						"perform a full
> suspend/resume cycle." },
> 
> Please improve this one.
> 
> >  		{ }
> >  	}, tests_power_hang[] = {
> > -		{ "hang-S3", SUSPEND | HANG, run_test },
> > -		{ "hang-S4", HIBERNATE | HANG, run_test },
> > -		{ "power-S0", IDLE, power_test },
> > -		{ "power-S3", SUSPEND, power_test },
> > +		{ "hang-S3", SUSPEND | HANG, run_test, "" },
> > +		{ "hang-S4", HIBERNATE | HANG, run_test, "" },
> > +		{ "power-S0", IDLE, power_test, "" },
> > +		{ "power-S3", SUSPEND, power_test, "" },
> 
> Please also fill these descriptions here.
[Janga Rahul Kumar] Added descriptions for above tests in rev 2.
> 
> Run test with --describe option, e.g.
> sudo ./gem_exec_suspend --describe
> to see what other descriptions are missing.
> 
> Regards,
> Kamil
> >  		{ }
> >  	};
> >  	const struct intel_execution_engine2 *e; @@ -359,8 +368,10 @@
> > igt_main
> >  		} \
> >  	}
> >
> > -	for (test = tests_all_engines; test->name; test++)
> > +	for (test = tests_all_engines; test->name; test++) {
> > +		igt_describe(test->describe);
> >  		subtest_for_each_combination(test->name, intel_ctx_0(fd),
> > test->flags, test->fn);
> > +	}
> >
> >  	for (m = modes; m->suffix; m++) {
> >  		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
> > --
> > 2.25.1
> >
[Janga Rahul Kumar] 
Regards,
Rahul

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[Kamil Konieczny]

Hi Janga,

On 2022-06-22 at 14:45:21 +0530, janga.rahul.kumar@intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> Added test description to all the available subtests.
> 
> v2 : Modified subtest description and added description
>      to all the subtests.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
>  tests/i915/gem_exec_suspend.c | 50 ++++++++++++++++++++++++-----------
>  1 file changed, 34 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
> index 401026ef..55529bb8 100644
> --- a/tests/i915/gem_exec_suspend.c
> +++ b/tests/i915/gem_exec_suspend.c
> @@ -37,6 +37,9 @@
>  #include "igt_gt.h"
>  #include "igt_sysfs.h"
>  
> +IGT_TEST_DESCRIPTION("Exercise simple exec-and-read, measure power across various "
> +		     "suspend/resume cycles.");
> +

Looks better, there is still some place for improve, imho
s/simple exec-and-read, measure power/execbufs runs/

>  #define NOSLEEP 0
>  #define IDLE 1
>  #define SUSPEND_DEVICES 2
> @@ -286,29 +289,37 @@ igt_main
>  	const struct {
>  		const char *suffix;
>  		unsigned mode;
> +		const char *describe;
>  	} modes[] = {
> -		{ "", NOSLEEP },
> -		{ "-S3", SUSPEND },
> -		{ "-S4", HIBERNATE },
> -		{ NULL, 0 }
> +		{ "", NOSLEEP, "without suspend/resume cycle" },
> +		{ "-S3", SUSPEND, "suspend-to-mem" },
> +		{ "-S4", HIBERNATE, "suspend-to-device" },

s/device/disk/

> +		{ NULL, 0, "" }
>  	}, *m;
>  	struct test {
>  		const char *name;
>  		unsigned int flags;
>  		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
> +		const char *describe;
>  	} *test, tests_all_engines[] = {
> -		{ "basic", NOSLEEP, run_test },
> -		{ "basic-S0", IDLE, run_test },
> -		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
> -		{ "basic-S3", SUSPEND, run_test },
> -		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
> -		{ "basic-S4", HIBERNATE, run_test },
> +		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
> +					      "suspend/resume cycle." },
> +		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
> +		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
> +								 "with device only." },

s/device/devices/

> +		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
> +		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
> +								   "with device only." },

s/device/devices/

> +		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
>  		{ }
>  	}, tests_power_hang[] = {
> -		{ "hang-S3", SUSPEND | HANG, run_test },
> -		{ "hang-S4", HIBERNATE | HANG, run_test },
> -		{ "power-S0", IDLE, power_test },
> -		{ "power-S3", SUSPEND, power_test },
> +		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
> +						"susepnd-to-mem with a pending GPU hang." },

s/susepnd/suspend/

> +		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
> +						"suspend-to-disk with a pending GPU hang." },
> +		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
> +		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
> +						   "suspend state." },

s/suspend/suspend-to-mem/

Regards,
Kamil

>  		{ }
>  	};
>  	const struct intel_execution_engine2 *e;
> @@ -359,20 +370,25 @@ igt_main
>  		} \
>  	}
>  
> -	for (test = tests_all_engines; test->name; test++)
> +	for (test = tests_all_engines; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	for (m = modes; m->suffix; m++) {
> +		igt_describe_f("Check %s state with fixed object.", m->describe);
>  		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
>  			igt_require(gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode);
>  		}
>  
> +		igt_describe_f("Check %s state with uncached object.", m->describe);
>  		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | UNCACHED);
>  		}
>  
> +		igt_describe_f("Check %s state with cached object.", m->describe);
>  		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | CACHED);
> @@ -384,8 +400,10 @@ igt_main
>  		hang = igt_allow_hang(fd, 0, 0);
>  	}
>  
> -	for (test = tests_power_hang; test->name; test++)
> +	for (test = tests_power_hang; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	igt_fixture {
>  		free(query_info);
> -- 
> 2.25.1
> 

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests.

v2 : Modified subtest description and added description
     to all the subtests.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 50 ++++++++++++++++++++++++-----------
 1 file changed, 34 insertions(+), 16 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..55529bb8 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,9 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Exercise simple exec-and-read, measure power across various "
+		     "suspend/resume cycles.");
+
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -286,29 +289,37 @@ igt_main
 	const struct {
 		const char *suffix;
 		unsigned mode;
+		const char *describe;
 	} modes[] = {
-		{ "", NOSLEEP },
-		{ "-S3", SUSPEND },
-		{ "-S4", HIBERNATE },
-		{ NULL, 0 }
+		{ "", NOSLEEP, "without suspend/resume cycle" },
+		{ "-S3", SUSPEND, "suspend-to-mem" },
+		{ "-S4", HIBERNATE, "suspend-to-device" },
+		{ NULL, 0, "" }
 	}, *m;
 	struct test {
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
+					      "suspend/resume cycle." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
+								 "with device only." },
+		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+								   "with device only." },
+		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
+						"susepnd-to-mem with a pending GPU hang." },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-disk with a pending GPU hang." },
+		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
+		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
+						   "suspend state." },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,20 +370,25 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
+		igt_describe_f("Check %s state with fixed object.", m->describe);
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
 			igt_require(gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode);
 		}
 
+		igt_describe_f("Check %s state with uncached object.", m->describe);
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | UNCACHED);
 		}
 
+		igt_describe_f("Check %s state with cached object.", m->describe);
 		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | CACHED);
@@ -384,8 +400,10 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
-	for (test = tests_power_hang; test->name; test++)
+	for (test = tests_power_hang; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	igt_fixture {
 		free(query_info);
-- 
2.25.1

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests.

v2 : Modified subtest description and added description
     to all the subtests.
v3 : Modified description based on suggestions.
v4 : Modified test description.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 49 +++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 16 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..6c86361c 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,8 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Exercise simple execbufs runs across various suspend/resume cycles.");
+
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -286,29 +288,37 @@ igt_main
 	const struct {
 		const char *suffix;
 		unsigned mode;
+		const char *describe;
 	} modes[] = {
-		{ "", NOSLEEP },
-		{ "-S3", SUSPEND },
-		{ "-S4", HIBERNATE },
-		{ NULL, 0 }
+		{ "", NOSLEEP, "without suspend/resume cycle" },
+		{ "-S3", SUSPEND, "suspend-to-mem" },
+		{ "-S4", HIBERNATE, "suspend-to-disk" },
+		{ NULL, 0, "" }
 	}, *m;
 	struct test {
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
+					      "suspend/resume cycle." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
+								 "with devices only." },
+		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+								   "with devices only." },
+		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-mem with a pending GPU hang." },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-disk with a pending GPU hang." },
+		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
+		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
+						   "suspend-to-mem state." },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,20 +369,25 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
+		igt_describe_f("Check %s state with fixed object.", m->describe);
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
 			igt_require(gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode);
 		}
 
+		igt_describe_f("Check %s state with uncached object.", m->describe);
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | UNCACHED);
 		}
 
+		igt_describe_f("Check %s state with cached object.", m->describe);
 		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | CACHED);
@@ -384,8 +399,10 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
-	for (test = tests_power_hang; test->name; test++)
+	for (test = tests_power_hang; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	igt_fixture {
 		free(query_info);
-- 
2.25.1

[igt-dev] [PATCH 0/2] HAX add test description to gem_exec_suspend

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Add test description to gem_exec_suspend

Janga Rahul Kumar (2):
  tests/i915/gem_exec_suspend : Added subtests description
  HAX: don't do full run

 tests/i915/gem_exec_suspend.c         |  49 ++++---
 tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
 2 files changed, 34 insertions(+), 193 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests.

v2 : Modified subtest description and added description
     to all the subtests.
v3 : Modified description based on suggestions.
v4 : Modified test description.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 49 +++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 16 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..6c86361c 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,8 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Exercise simple execbufs runs across various suspend/resume cycles.");
+
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -286,29 +288,37 @@ igt_main
 	const struct {
 		const char *suffix;
 		unsigned mode;
+		const char *describe;
 	} modes[] = {
-		{ "", NOSLEEP },
-		{ "-S3", SUSPEND },
-		{ "-S4", HIBERNATE },
-		{ NULL, 0 }
+		{ "", NOSLEEP, "without suspend/resume cycle" },
+		{ "-S3", SUSPEND, "suspend-to-mem" },
+		{ "-S4", HIBERNATE, "suspend-to-disk" },
+		{ NULL, 0, "" }
 	}, *m;
 	struct test {
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
+					      "suspend/resume cycle." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
+								 "with devices only." },
+		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+								   "with devices only." },
+		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-mem with a pending GPU hang." },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
+						"suspend-to-disk with a pending GPU hang." },
+		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
+		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
+						   "suspend-to-mem state." },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,20 +369,25 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
+		igt_describe_f("Check %s state with fixed object.", m->describe);
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
 			igt_require(gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode);
 		}
 
+		igt_describe_f("Check %s state with uncached object.", m->describe);
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | UNCACHED);
 		}
 
+		igt_describe_f("Check %s state with cached object.", m->describe);
 		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | CACHED);
@@ -384,8 +399,10 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
-	for (test = tests_power_hang; test->name; test++)
+	for (test = tests_power_hang; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	igt_fixture {
 		free(query_info);
-- 
2.25.1

[igt-dev] [PATCH 2/2] HAX: don't do full run

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Just for test description, no full run is necessary.
---
 tests/intel-ci/fast-feedback.testlist | 178 +-------------------------
 1 file changed, 1 insertion(+), 177 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index bd5538a0..9f8e18ce 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,177 +1 @@
-# Try to load the driver if it's not available yet.
-igt@i915_module_load@load
-
-# Keep alphabetically sorted by default
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@i915_pciid
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor
-igt@kms_cursor_legacy@basic-flip-after-cursor
-igt@kms_cursor_legacy@basic-flip-before-cursor
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
-igt@kms_pipe_crc_basic@hang-read-crc
-igt@kms_pipe_crc_basic@nonblocking-crc
-igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
-igt@kms_pipe_crc_basic@read-crc
-igt@kms_pipe_crc_basic@read-crc-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc
+igt@meta_test@fail-result
-- 
2.25.1

[igt-dev] ✗ GitLab.Pipeline: warning for HAX add test description to gem_exec_suspend (rev5)

[Patchwork]

== Series Details ==

Series: HAX add test description to gem_exec_suspend (rev5)
URL   : https://patchwork.freedesktop.org/series/104915/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/620887 for the overview.

test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/24522779):
  Ok:                   22
  Expected Fail:         3
  Fail:                290
  Unexpected Pass:       0
  Skipped:               0
  Timeout:               0
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  section_end:1656062698:step_script
  section_start:1656062698:upload_artifacts_on_failure
  Uploading artifacts for failed job
  Uploading artifacts...
  build: found 1752 matching files and directories   
  Uploading artifacts as "archive" to coordinator... 201 Created  id=24522779 responseStatus=201 Created token=Tp6f-ZGQ
  section_end:1656062708:upload_artifacts_on_failure
  section_start:1656062708:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1656062708:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/620887

[igt-dev] ✗ Fi.CI.BAT: failure for HAX add test description to gem_exec_suspend (rev5)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7971 bytes --]

== Series Details ==

Series: HAX add test description to gem_exec_suspend (rev5)
URL   : https://patchwork.freedesktop.org/series/104915/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11803 -> IGTPW_7377
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7377 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7377, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/index.html

Participating hosts (36 -> 40)
------------------------------

  Additional (5): fi-kbl-soraka fi-bxt-dsi fi-bdw-5557u bat-adls-5 bat-dg2-9 
  Missing    (1): fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7377:

### IGT changes ###

#### Possible regressions ####

  * igt@meta_test@fail-result (NEW):
    - fi-ilk-650:         NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-ilk-650/igt@meta_test@fail-result.html
    - fi-tgl-u2:          NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-tgl-u2/igt@meta_test@fail-result.html
    - {bat-jsl-1}:        NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-jsl-1/igt@meta_test@fail-result.html
    - fi-bxt-dsi:         NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-bxt-dsi/igt@meta_test@fail-result.html
    - {fi-jsl-1}:         NOTRUN -> [FAIL][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-jsl-1/igt@meta_test@fail-result.html
    - fi-blb-e6850:       NOTRUN -> [FAIL][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-blb-e6850/igt@meta_test@fail-result.html
    - fi-skl-6600u:       NOTRUN -> [FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-skl-6600u/igt@meta_test@fail-result.html
    - fi-glk-dsi:         NOTRUN -> [FAIL][8]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-glk-dsi/igt@meta_test@fail-result.html
    - {fi-ehl-2}:         NOTRUN -> [FAIL][9]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-ehl-2/igt@meta_test@fail-result.html
    - fi-apl-guc:         NOTRUN -> [FAIL][10]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-apl-guc/igt@meta_test@fail-result.html
    - bat-dg1-5:          NOTRUN -> [FAIL][11]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-dg1-5/igt@meta_test@fail-result.html
    - fi-pnv-d510:        NOTRUN -> [FAIL][12]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-pnv-d510/igt@meta_test@fail-result.html
    - fi-bdw-5557u:       NOTRUN -> [FAIL][13]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-bdw-5557u/igt@meta_test@fail-result.html
    - fi-snb-2520m:       NOTRUN -> [FAIL][14]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-snb-2520m/igt@meta_test@fail-result.html
    - fi-glk-j4005:       NOTRUN -> [FAIL][15]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-glk-j4005/igt@meta_test@fail-result.html
    - fi-rkl-guc:         NOTRUN -> [FAIL][16]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-rkl-guc/igt@meta_test@fail-result.html
    - fi-skl-guc:         NOTRUN -> [FAIL][17]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-skl-guc/igt@meta_test@fail-result.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][18]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-kbl-soraka/igt@meta_test@fail-result.html
    - bat-dg1-6:          NOTRUN -> [FAIL][19]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-dg1-6/igt@meta_test@fail-result.html
    - fi-kbl-7567u:       NOTRUN -> [FAIL][20]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-kbl-7567u/igt@meta_test@fail-result.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][21]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-cfl-8700k/igt@meta_test@fail-result.html
    - {fi-tgl-dsi}:       NOTRUN -> [FAIL][22]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-tgl-dsi/igt@meta_test@fail-result.html
    - fi-bsw-nick:        NOTRUN -> [FAIL][23]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-bsw-nick/igt@meta_test@fail-result.html
    - fi-rkl-11600:       NOTRUN -> [FAIL][24]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-rkl-11600/igt@meta_test@fail-result.html
    - fi-hsw-g3258:       NOTRUN -> [FAIL][25]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-hsw-g3258/igt@meta_test@fail-result.html
    - {bat-adls-5}:       NOTRUN -> [FAIL][26]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-adls-5/igt@meta_test@fail-result.html
    - fi-bdw-gvtdvm:      NOTRUN -> [FAIL][27]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-bdw-gvtdvm/igt@meta_test@fail-result.html
    - fi-bsw-kefka:       NOTRUN -> [FAIL][28]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-bsw-kefka/igt@meta_test@fail-result.html
    - fi-adl-ddr5:        NOTRUN -> [FAIL][29]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-adl-ddr5/igt@meta_test@fail-result.html
    - {bat-dg2-9}:        NOTRUN -> [FAIL][30]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-dg2-9/igt@meta_test@fail-result.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][31]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-hsw-4770/igt@meta_test@fail-result.html
    - fi-skl-6700k2:      NOTRUN -> [FAIL][32]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-skl-6700k2/igt@meta_test@fail-result.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][33]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-cfl-8109u/igt@meta_test@fail-result.html
    - {bat-adln-1}:       NOTRUN -> [FAIL][34]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-adln-1/igt@meta_test@fail-result.html
    - fi-kbl-8809g:       NOTRUN -> [FAIL][35]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-kbl-8809g/igt@meta_test@fail-result.html
    - fi-ivb-3770:        NOTRUN -> [FAIL][36]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-ivb-3770/igt@meta_test@fail-result.html
    - fi-elk-e7500:       NOTRUN -> [FAIL][37]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-elk-e7500/igt@meta_test@fail-result.html
    - {bat-dg2-8}:        NOTRUN -> [FAIL][38]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/bat-dg2-8/igt@meta_test@fail-result.html
    - fi-kbl-guc:         NOTRUN -> [FAIL][39]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-kbl-guc/igt@meta_test@fail-result.html
    - fi-snb-2600:        NOTRUN -> [FAIL][40]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/fi-snb-2600/igt@meta_test@fail-result.html

  
New tests
---------

  New tests have been introduced between CI_DRM_11803 and IGTPW_7377:

### New IGT tests (1) ###

  * igt@meta_test@fail-result:
    - Statuses : 40 fail(s)
    - Exec time: [0.00, 0.37] s

  

  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).



Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6541 -> IGTPW_7377

  CI-20190529: 20190529
  CI_DRM_11803: 23f2707225ca8a6c43526d1d7c46a7dd1a5f02cf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7377: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/index.html
  IGT_6541: 02153f109bd422d93cfce7f5aa9d7b0e22fab13c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7377/index.html

[-- Attachment #2: Type: text/html, Size: 9198 bytes --]

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[Kamil Konieczny]

Hi Janga,

small nits, see below.

On 2022-06-24 at 14:20:30 +0530, janga.rahul.kumar@intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> Added test description to all the available subtests.
> 
> v2 : Modified subtest description and added description
>      to all the subtests.
> v3 : Modified description based on suggestions.
> v4 : Modified test description.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
>  tests/i915/gem_exec_suspend.c | 49 +++++++++++++++++++++++------------
>  1 file changed, 33 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
> index 401026ef..6c86361c 100644
> --- a/tests/i915/gem_exec_suspend.c
> +++ b/tests/i915/gem_exec_suspend.c
> @@ -37,6 +37,8 @@
>  #include "igt_gt.h"
>  #include "igt_sysfs.h"
>  
> +IGT_TEST_DESCRIPTION("Exercise simple execbufs runs across various suspend/resume cycles.");
> +
>  #define NOSLEEP 0
>  #define IDLE 1
>  #define SUSPEND_DEVICES 2
> @@ -286,29 +288,37 @@ igt_main
>  	const struct {
>  		const char *suffix;
>  		unsigned mode;
> +		const char *describe;
>  	} modes[] = {
> -		{ "", NOSLEEP },
> -		{ "-S3", SUSPEND },
> -		{ "-S4", HIBERNATE },
> -		{ NULL, 0 }
> +		{ "", NOSLEEP, "without suspend/resume cycle" },
> +		{ "-S3", SUSPEND, "suspend-to-mem" },
> +		{ "-S4", HIBERNATE, "suspend-to-disk" },
> +		{ NULL, 0, "" }
>  	}, *m;
>  	struct test {
>  		const char *name;
>  		unsigned int flags;
>  		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
> +		const char *describe;
>  	} *test, tests_all_engines[] = {
> -		{ "basic", NOSLEEP, run_test },
> -		{ "basic-S0", IDLE, run_test },
> -		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
> -		{ "basic-S3", SUSPEND, run_test },
> -		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
> -		{ "basic-S4", HIBERNATE, run_test },
> +		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
> +					      "suspend/resume cycle." },
> +		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
> +		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
> +								 "with devices only." },
> +		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
> +		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
> +								   "with devices only." },
> +		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
>  		{ }
>  	}, tests_power_hang[] = {
> -		{ "hang-S3", SUSPEND | HANG, run_test },
> -		{ "hang-S4", HIBERNATE | HANG, run_test },
> -		{ "power-S0", IDLE, power_test },
> -		{ "power-S3", SUSPEND, power_test },
> +		{ "hang-S3", SUSPEND | HANG, run_test, "Check performing full cycle of "
------------------------------------------------------ ^
> +						"suspend-to-mem with a pending GPU hang." },
----------------------------------------------- ^
Please align this to previous string starting column.

> +		{ "hang-S4", HIBERNATE | HANG, run_test, "Check performing full cycle of "
> +						"suspend-to-disk with a pending GPU hang." },

Same here.

You may also consider dropping "performing" word.
Rest looks good.

Regards,
Kamil

> +		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
> +		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
> +						   "suspend-to-mem state." },
>  		{ }
>  	};
>  	const struct intel_execution_engine2 *e;
> @@ -359,20 +369,25 @@ igt_main
>  		} \
>  	}
>  
> -	for (test = tests_all_engines; test->name; test++)
> +	for (test = tests_all_engines; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	for (m = modes; m->suffix; m++) {
> +		igt_describe_f("Check %s state with fixed object.", m->describe);
>  		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
>  			igt_require(gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode);
>  		}
>  
> +		igt_describe_f("Check %s state with uncached object.", m->describe);
>  		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | UNCACHED);
>  		}
>  
> +		igt_describe_f("Check %s state with cached object.", m->describe);
>  		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | CACHED);
> @@ -384,8 +399,10 @@ igt_main
>  		hang = igt_allow_hang(fd, 0, 0);
>  	}
>  
> -	for (test = tests_power_hang; test->name; test++)
> +	for (test = tests_power_hang; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	igt_fixture {
>  		free(query_info);
> -- 
> 2.25.1
> 

[igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests.

v2 : Modified subtest description and added description
     to all the subtests.
v3 : Modified description based on suggestions.
v4 : Modified test description.
v5 : Aligned description strings.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_suspend.c | 49 +++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 16 deletions(-)

diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
index 401026ef..3b59966a 100644
--- a/tests/i915/gem_exec_suspend.c
+++ b/tests/i915/gem_exec_suspend.c
@@ -37,6 +37,8 @@
 #include "igt_gt.h"
 #include "igt_sysfs.h"
 
+IGT_TEST_DESCRIPTION("Exercise simple execbufs runs across various suspend/resume cycles.");
+
 #define NOSLEEP 0
 #define IDLE 1
 #define SUSPEND_DEVICES 2
@@ -286,29 +288,37 @@ igt_main
 	const struct {
 		const char *suffix;
 		unsigned mode;
+		const char *describe;
 	} modes[] = {
-		{ "", NOSLEEP },
-		{ "-S3", SUSPEND },
-		{ "-S4", HIBERNATE },
-		{ NULL, 0 }
+		{ "", NOSLEEP, "without suspend/resume cycle" },
+		{ "-S3", SUSPEND, "suspend-to-mem" },
+		{ "-S4", HIBERNATE, "suspend-to-disk" },
+		{ NULL, 0, "" }
 	}, *m;
 	struct test {
 		const char *name;
 		unsigned int flags;
 		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
+		const char *describe;
 	} *test, tests_all_engines[] = {
-		{ "basic", NOSLEEP, run_test },
-		{ "basic-S0", IDLE, run_test },
-		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
-		{ "basic-S3", SUSPEND, run_test },
-		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
-		{ "basic-S4", HIBERNATE, run_test },
+		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
+					      "suspend/resume cycle." },
+		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
+		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
+								 "with devices only." },
+		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
+		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
+								   "with devices only." },
+		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
 		{ }
 	}, tests_power_hang[] = {
-		{ "hang-S3", SUSPEND | HANG, run_test },
-		{ "hang-S4", HIBERNATE | HANG, run_test },
-		{ "power-S0", IDLE, power_test },
-		{ "power-S3", SUSPEND, power_test },
+		{ "hang-S3", SUSPEND | HANG, run_test, "Check full cycle of suspend-to-mem with a "
+						       "pending GPU hang." },
+		{ "hang-S4", HIBERNATE | HANG, run_test, "Check full cycle of suspend-to-disk with "
+							 "a pending GPU hang." },
+		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
+		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
+						   "suspend-to-mem state." },
 		{ }
 	};
 	const struct intel_execution_engine2 *e;
@@ -359,20 +369,25 @@ igt_main
 		} \
 	}
 
-	for (test = tests_all_engines; test->name; test++)
+	for (test = tests_all_engines; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	for (m = modes; m->suffix; m++) {
+		igt_describe_f("Check %s state with fixed object.", m->describe);
 		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
 			igt_require(gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode);
 		}
 
+		igt_describe_f("Check %s state with uncached object.", m->describe);
 		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | UNCACHED);
 		}
 
+		igt_describe_f("Check %s state with cached object.", m->describe);
 		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
 			igt_require(!gem_has_lmem(fd));
 			for_each_ctx_engine_combination(m->mode | CACHED);
@@ -384,8 +399,10 @@ igt_main
 		hang = igt_allow_hang(fd, 0, 0);
 	}
 
-	for (test = tests_power_hang; test->name; test++)
+	for (test = tests_power_hang; test->name; test++) {
+		igt_describe(test->describe);
 		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
+	}
 
 	igt_fixture {
 		free(query_info);
-- 
2.25.1

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_exec_suspend : Added subtests description

[Kamil Konieczny]

On 2022-06-24 at 15:24:07 +0530, janga.rahul.kumar@intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> Added test description to all the available subtests.
> 
> v2 : Modified subtest description and added description
>      to all the subtests.
> v3 : Modified description based on suggestions.
> v4 : Modified test description.
> v5 : Aligned description strings.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

>  tests/i915/gem_exec_suspend.c | 49 +++++++++++++++++++++++------------
>  1 file changed, 33 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_suspend.c b/tests/i915/gem_exec_suspend.c
> index 401026ef..3b59966a 100644
> --- a/tests/i915/gem_exec_suspend.c
> +++ b/tests/i915/gem_exec_suspend.c
> @@ -37,6 +37,8 @@
>  #include "igt_gt.h"
>  #include "igt_sysfs.h"
>  
> +IGT_TEST_DESCRIPTION("Exercise simple execbufs runs across various suspend/resume cycles.");
> +
>  #define NOSLEEP 0
>  #define IDLE 1
>  #define SUSPEND_DEVICES 2
> @@ -286,29 +288,37 @@ igt_main
>  	const struct {
>  		const char *suffix;
>  		unsigned mode;
> +		const char *describe;
>  	} modes[] = {
> -		{ "", NOSLEEP },
> -		{ "-S3", SUSPEND },
> -		{ "-S4", HIBERNATE },
> -		{ NULL, 0 }
> +		{ "", NOSLEEP, "without suspend/resume cycle" },
> +		{ "-S3", SUSPEND, "suspend-to-mem" },
> +		{ "-S4", HIBERNATE, "suspend-to-disk" },
> +		{ NULL, 0, "" }
>  	}, *m;
>  	struct test {
>  		const char *name;
>  		unsigned int flags;
>  		void (*fn)(int, const intel_ctx_t *, unsigned, unsigned, uint32_t);
> +		const char *describe;
>  	} *test, tests_all_engines[] = {
> -		{ "basic", NOSLEEP, run_test },
> -		{ "basic-S0", IDLE, run_test },
> -		{ "basic-S3-devices", SUSPEND_DEVICES, run_test },
> -		{ "basic-S3", SUSPEND, run_test },
> -		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test },
> -		{ "basic-S4", HIBERNATE, run_test },
> +		{ "basic", NOSLEEP, run_test, "Check basic functionality without any "
> +					      "suspend/resume cycle." },
> +		{ "basic-S0", IDLE, run_test, "Check with suspend-to-idle target state." },
> +		{ "basic-S3-devices", SUSPEND_DEVICES, run_test, "Check with suspend-to-mem "
> +								 "with devices only." },
> +		{ "basic-S3", SUSPEND, run_test, "Check full cycle of suspend-to-mem." },
> +		{ "basic-S4-devices", HIBERNATE_DEVICES, run_test, "Check with suspend-to-disk "
> +								   "with devices only." },
> +		{ "basic-S4", HIBERNATE, run_test, "Check full cycle of suspend-to-disk." },
>  		{ }
>  	}, tests_power_hang[] = {
> -		{ "hang-S3", SUSPEND | HANG, run_test },
> -		{ "hang-S4", HIBERNATE | HANG, run_test },
> -		{ "power-S0", IDLE, power_test },
> -		{ "power-S3", SUSPEND, power_test },
> +		{ "hang-S3", SUSPEND | HANG, run_test, "Check full cycle of suspend-to-mem with a "
> +						       "pending GPU hang." },
> +		{ "hang-S4", HIBERNATE | HANG, run_test, "Check full cycle of suspend-to-disk with "
> +							 "a pending GPU hang." },
> +		{ "power-S0", IDLE, power_test, "Check power consumption during idle state." },
> +		{ "power-S3", SUSPEND, power_test, "Check power consumption during "
> +						   "suspend-to-mem state." },
>  		{ }
>  	};
>  	const struct intel_execution_engine2 *e;
> @@ -359,20 +369,25 @@ igt_main
>  		} \
>  	}
>  
> -	for (test = tests_all_engines; test->name; test++)
> +	for (test = tests_all_engines; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	for (m = modes; m->suffix; m++) {
> +		igt_describe_f("Check %s state with fixed object.", m->describe);
>  		igt_subtest_with_dynamic_f("fixed%s", m->suffix) {
>  			igt_require(gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode);
>  		}
>  
> +		igt_describe_f("Check %s state with uncached object.", m->describe);
>  		igt_subtest_with_dynamic_f("uncached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | UNCACHED);
>  		}
>  
> +		igt_describe_f("Check %s state with cached object.", m->describe);
>  		igt_subtest_with_dynamic_f("cached%s", m->suffix) {
>  			igt_require(!gem_has_lmem(fd));
>  			for_each_ctx_engine_combination(m->mode | CACHED);
> @@ -384,8 +399,10 @@ igt_main
>  		hang = igt_allow_hang(fd, 0, 0);
>  	}
>  
> -	for (test = tests_power_hang; test->name; test++)
> +	for (test = tests_power_hang; test->name; test++) {
> +		igt_describe(test->describe);
>  		subtest_for_each_combination(test->name, intel_ctx_0(fd), test->flags, test->fn);
> +	}
>  
>  	igt_fixture {
>  		free(query_info);
> -- 
> 2.25.1
>