Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v1] tests/kms_cursor_crc: Wait extra vblank
@ 2022-09-14 22:58 Jessica Zhang
  2022-09-15  1:04 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Jessica Zhang @ 2022-09-14 22:58 UTC (permalink / raw)
  To: igt-dev; +Cc: robdclark, petri.latvala

Wait an extra vblank for legacy cursor ioctl to finish.

Extra vblank wait is needed for both HW and SW test as the legacy cursor
ioctl is called in both cases.

Based on Rob's patch [1] and, similarly, fixes flaky results on MSM.

Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>

[1] https://patchwork.freedesktop.org/series/105999/
---
 tests/kms_cursor_crc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 53f18f4f1add..272dcb7fa0a4 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -202,8 +202,8 @@ static void do_single_test(data_t *data, int x, int y, bool hw_test,
 		igt_display_commit(display);
 
 		/* Extra vblank wait is because nonblocking cursor ioctl */
-		igt_wait_for_vblank(data->drm_fd,
-				display->pipes[data->pipe].crtc_offset);
+		igt_wait_for_vblank_count(data->drm_fd,
+				display->pipes[data->pipe].crtc_offset, 2);
 
 		igt_pipe_crc_get_current(data->drm_fd, pipe_crc, hwcrc);
 
@@ -243,8 +243,8 @@ static void do_single_test(data_t *data, int x, int y, bool hw_test,
 		igt_plane_set_fb(data->primary, &data->primary_fb[swbufidx]);
 
 		igt_display_commit(display);
-		igt_wait_for_vblank(data->drm_fd,
-				display->pipes[data->pipe].crtc_offset);
+		igt_wait_for_vblank_count(data->drm_fd,
+				display->pipes[data->pipe].crtc_offset, 2);
 
 		igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc);
 		igt_assert_crc_equal(&crc, hwcrc);
-- 
2.31.0

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-09-16 13:27 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-14 22:58 [igt-dev] [PATCH i-g-t v1] tests/kms_cursor_crc: Wait extra vblank Jessica Zhang
2022-09-15  1:04 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-09-15  2:23 ` [igt-dev] [PATCH i-g-t v1] " Rob Clark
2022-09-15 16:51 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: Wait extra vblank (rev2) Patchwork
2022-09-15 18:02 ` [igt-dev] [PATCH i-g-t v1] tests/kms_cursor_crc: Wait extra vblank Juha-Pekka Heikkila
2022-09-15 18:39   ` Rob Clark
2022-09-15 19:16     ` Juha-Pekka Heikkila
2022-09-15 19:38       ` Rob Clark
2022-09-15 20:12         ` Juha-Pekka Heikkila
2022-09-15 21:17           ` Rob Clark
2022-09-16  8:27             ` Ville Syrjälä
2022-09-16 13:27               ` Rob Clark
2022-09-15 19:58   ` Jessica Zhang
2022-09-15 20:07     ` Jessica Zhang
2022-09-16  3:00 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_cursor_crc: Wait extra vblank (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox