Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
	<katarzyna.piecielska@intel.com>, <jari.tahvanainen@intel.com>,
	<ramadevi.gandi@intel.com>, <kamil.konieczny@intel.com>
Subject: Re: [PATCH i-g-t v1] tests/intel: Update sub-category of Xe power management tests
Date: Thu, 13 Feb 2025 18:17:31 -0500	[thread overview]
Message-ID: <Z659i7WFEcPS8qbQ@intel.com> (raw)
In-Reply-To: <20250213155740.361646-1-karthik.poosa@intel.com>

On Thu, Feb 13, 2025 at 09:27:40PM +0530, Karthik Poosa wrote:
> Change sub-category of below tests from Power management tests to below:

Why?

>  * tests/intel/xe_gt_freq.c to Power DFS tests.
>  * tests/intel/xe_pm.c to Power suspend-resume tests.
>  * tests/intel/xe_pm_residency.c to Power RC6 residency tests.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>  tests/intel/xe_gt_freq.c      | 2 +-
>  tests/intel/xe_pm.c           | 2 +-
>  tests/intel/xe_pm_residency.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index 1fb6d2b53..e97195b1e 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -7,7 +7,7 @@
>   * TEST: Test Xe GT frequency request functionality
>   * Category: Core
>   * Mega feature: Power management
> - * Sub-category: Power management tests
> + * Sub-category: Power DFS tests

well, I know that we are not changing voltage, but DVFS seems more
used.
Or in other words, why DFS?
Why not Frequency management?

What are these categories getting used for?

>   * Functionality: frequency request
>   * Test category: functionality test
>   */
> diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> index c2026474d..644680893 100644
> --- a/tests/intel/xe_pm.c
> +++ b/tests/intel/xe_pm.c
> @@ -7,7 +7,7 @@
>   * TEST: Check Power Management functionality
>   * Category: Core
>   * Mega feature: Power management
> - * Sub-category: Power management tests
> + * Sub-category: Power suspend-resume tests
>   * Test category: functionality test
>   */
>  
> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> index f9e96d608..f0833eb0a 100644
> --- a/tests/intel/xe_pm_residency.c
> +++ b/tests/intel/xe_pm_residency.c
> @@ -7,7 +7,7 @@
>   * TEST: Test gtidle properties
>   * Category: Core
>   * Mega feature: Power management
> - * Sub-category: Power management tests
> + * Sub-category: Power RC6 residency tests

RC6 is old terminology... It doesn't make sense on the Media GT.

GT-C6 seems better...

>   * Functionality: GT C States
>   * Test category: functionality test
>   */
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2025-02-13 23:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 15:57 [PATCH i-g-t v1] tests/intel: Update sub-category of Xe power management tests Karthik Poosa
2025-02-13 17:07 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-02-13 17:22 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-13 23:17 ` Rodrigo Vivi [this message]
2025-02-20  6:15   ` [PATCH i-g-t v1] " Poosa, Karthik
2025-02-26  2:13     ` Rodrigo Vivi
2025-02-14 11:43 ` ✗ Xe.CI.Full: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z659i7WFEcPS8qbQ@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jari.tahvanainen@intel.com \
    --cc=kamil.konieczny@intel.com \
    --cc=karthik.poosa@intel.com \
    --cc=katarzyna.piecielska@intel.com \
    --cc=ramadevi.gandi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox