Re: [PATCH i-g-t v1] tests/intel: Update sub-category of Xe power management tests

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Feb 20, 2025 at 11:45:40AM +0530, Poosa, Karthik wrote:
> 
> On 14-02-2025 04:47, Rodrigo Vivi wrote:
> > On Thu, Feb 13, 2025 at 09:27:40PM +0530, Karthik Poosa wrote:
> > > Change sub-category of below tests from Power management tests to below:
> > Why?
> 
> These changes will facilitate tracking of sub-category tests results in
> visualization tools.
> 
> > 
> > >   * tests/intel/xe_gt_freq.c to Power DFS tests.
> > >   * tests/intel/xe_pm.c to Power suspend-resume tests.
> > >   * tests/intel/xe_pm_residency.c to Power RC6 residency tests.
> > > 
> > > Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> > > ---
> > >   tests/intel/xe_gt_freq.c      | 2 +-
> > >   tests/intel/xe_pm.c           | 2 +-
> > >   tests/intel/xe_pm_residency.c | 2 +-
> > >   3 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> > > index 1fb6d2b53..e97195b1e 100644
> > > --- a/tests/intel/xe_gt_freq.c
> > > +++ b/tests/intel/xe_gt_freq.c
> > > @@ -7,7 +7,7 @@
> > >    * TEST: Test Xe GT frequency request functionality
> > >    * Category: Core
> > >    * Mega feature: Power management
> > > - * Sub-category: Power management tests
> > > + * Sub-category: Power DFS tests
> > well, I know that we are not changing voltage, but DVFS seems more
> > used.
> > Or in other words, why DFS?
> > Why not Frequency management?
> Yup, Frequency management looks fine.
> > 
> > What are these categories getting used for?
> These will used by visualization tools, as mentioned above.
> > 
> > >    * Functionality: frequency request
> > >    * Test category: functionality test
> > >    */
> > > diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> > > index c2026474d..644680893 100644
> > > --- a/tests/intel/xe_pm.c
> > > +++ b/tests/intel/xe_pm.c
> > > @@ -7,7 +7,7 @@
> > >    * TEST: Check Power Management functionality
> > >    * Category: Core
> > >    * Mega feature: Power management
> > > - * Sub-category: Power management tests
> > > + * Sub-category: Power suspend-resume tests
> > >    * Test category: functionality test
> > >    */
> > > diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> > > index f9e96d608..f0833eb0a 100644
> > > --- a/tests/intel/xe_pm_residency.c
> > > +++ b/tests/intel/xe_pm_residency.c
> > > @@ -7,7 +7,7 @@
> > >    * TEST: Test gtidle properties
> > >    * Category: Core
> > >    * Mega feature: Power management
> > > - * Sub-category: Power management tests
> > > + * Sub-category: Power RC6 residency tests
> > RC6 is old terminology... It doesn't make sense on the Media GT.
> > 
> > GT-C6 seems better...
> How about GT  idle residency/C-states tests ?

Yeap, that works too

> > 
> > >    * Functionality: GT C States
> > >    * Test category: functionality test
> > >    */
> > > -- 
> > > 2.25.1
> > >