[igt-dev] [PATCH i-g-t 1/2] tests/kms: Cleanup to use linear modifier

[igt-dev] [PATCH i-g-t 1/2] tests/kms: Cleanup to use linear modifier

[Bhanuprakash Modem]

While creating the framebuffer use the default modifier as
DRM_FORMAT_MOD_LINEAR instead of using deprecated modifiers,
magic numbers, no_tiling modifier etc..

V2: - New patch for cairo fix (Ville)
    - Update commit message

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_ccs.c              |  4 +---
 tests/i915/kms_cdclk.c            |  4 ++--
 tests/i915/kms_pipe_b_c_ivb.c     |  2 +-
 tests/i915/kms_psr_stress_test.c  |  2 +-
 tests/kms_addfb_basic.c           | 22 +++++++++----------
 tests/kms_atomic.c                | 24 ++++++++++-----------
 tests/kms_atomic_transition.c     |  4 ++--
 tests/kms_bw.c                    |  2 +-
 tests/kms_cursor_legacy.c         | 36 ++++++++++++++++++++-----------
 tests/kms_display_modes.c         |  7 +++---
 tests/kms_force_connector_basic.c |  4 ++--
 tests/kms_getfb.c                 |  8 +++----
 tests/kms_hdr.c                   |  9 +++++---
 tests/kms_plane_cursor.c          | 12 +++++------
 tests/kms_plane_scaling.c         | 20 ++++++++---------
 tests/kms_prime.c                 |  2 +-
 tests/kms_scaling_modes.c         |  4 ++--
 tests/kms_universal_plane.c       |  4 ++--
 18 files changed, 91 insertions(+), 79 deletions(-)

diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
index 9be3fa252..18d48fb80 100644
--- a/tests/i915/kms_ccs.c
+++ b/tests/i915/kms_ccs.c
@@ -393,10 +393,8 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
 	 */
 	if (fb_flags & FB_COMPRESSED)
 		modifier = data->ccs_modifier;
-	else if (!(fb_flags & FB_HAS_PLANE))
-		modifier = DRM_FORMAT_MOD_LINEAR;
 	else
-		modifier = 0;
+		modifier = DRM_FORMAT_MOD_LINEAR;
 
 	create_fb_prepare_add(data->drm_fd, width, height,
 			      data->format, modifier,
diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
index 991a7c507..f3046c95a 100644
--- a/tests/i915/kms_cdclk.c
+++ b/tests/i915/kms_cdclk.c
@@ -158,7 +158,7 @@ static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *outpu
 		igt_create_color_pattern_fb(display->drm_fd,
 					    mode->hdisplay, mode->vdisplay,
 					    DRM_FORMAT_XRGB8888,
-					    I915_TILING_NONE,
+					    DRM_FORMAT_MOD_LINEAR,
 					    0.0, 0.0, 0.0, &fb);
 		igt_plane_set_fb(primary, &fb);
 
@@ -212,7 +212,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
 	igt_create_color_pattern_fb(display->drm_fd,
 				    mode->hdisplay, mode->vdisplay,
 				    DRM_FORMAT_XRGB8888,
-				    I915_TILING_NONE,
+				    DRM_FORMAT_MOD_LINEAR,
 				    0.0, 0.0, 0.0, &fb);
 
 	/* switch to lower resolution */
diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
index 05ac87702..af11e3262 100644
--- a/tests/i915/kms_pipe_b_c_ivb.c
+++ b/tests/i915/kms_pipe_b_c_ivb.c
@@ -92,7 +92,7 @@ set_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 
 	fb_id = igt_create_color_fb(data->drm_fd,
 				    mode->hdisplay, mode->vdisplay,
-				    DRM_FORMAT_XRGB8888, I915_TILING_NONE,
+				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
 				    1.0, 1.0, 1.0, &fb);
 	igt_assert_lte(0, fb_id);
 
diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
index daac41d44..9b7ddda84 100644
--- a/tests/i915/kms_psr_stress_test.c
+++ b/tests/i915/kms_psr_stress_test.c
@@ -374,4 +374,4 @@ igt_main
 		close(data.debugfs_fd);
 		close(data.drm_fd);
 	}
-}
\ No newline at end of file
+}
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index c58783d54..b4526eee6 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -68,10 +68,10 @@ static void invalid_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo_small);
 
 		f.handles[0] = gem_bo;
@@ -276,7 +276,7 @@ static void pitch_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 	}
 
@@ -417,10 +417,10 @@ static void size_tests(int fd)
 		igt_display_require(&display, fd);
 
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo_small);
 	}
 
@@ -513,7 +513,7 @@ static void addfb25_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 
 		memset(&f, 0, sizeof(f));
@@ -597,10 +597,10 @@ static void addfb25_ytile(int fd)
 		igt_display_require(&display, fd);
 
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo_small);
 
 		memset(&f, 0, sizeof(f));
@@ -670,7 +670,7 @@ static void addfb25_4tile(int fd)
 		igt_display_require(&display, fd);
 
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+				DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 
 		memset(&f, 0, sizeof(f));
@@ -719,7 +719,7 @@ static void prop_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 
 		f.handles[0] = gem_bo;
@@ -780,7 +780,7 @@ static void master_tests(int fd)
 
 	igt_fixture {
 		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(gem_bo);
 
 		f.handles[0] = gem_bo;
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 2a3fb74be..e7d1cbd75 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -305,12 +305,12 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
 	uint32_t h_overlay = mode->vdisplay / 2;
 
 	igt_create_color_pattern_fb(pipe->display->drm_fd,
-				    w, h, format_primary, I915_TILING_NONE,
+				    w, h, format_primary, DRM_FORMAT_MOD_LINEAR,
 				    0.2, 0.2, 0.2, &fb_primary);
 
 	igt_create_color_pattern_fb(pipe->display->drm_fd,
 				    w_overlay, h_overlay,
-				    format_overlay, I915_TILING_NONE,
+				    format_overlay, DRM_FORMAT_MOD_LINEAR,
 				    0.2, 0.2, 0.2, &fb_overlay);
 
 	/* Draw a hole in the overlay */
@@ -404,7 +404,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
 	igt_create_color_fb(display->drm_fd,
 			    w_lower, h_lower,
 			    DRM_FORMAT_XRGB8888,
-			    I915_TILING_NONE,
+			    DRM_FORMAT_MOD_LINEAR,
 			    0.0, 0.0, 0.0, &fb_ref);
 
 	/* create reference image */
@@ -444,14 +444,14 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
 	fb_id_lower = igt_create_color_fb(display->drm_fd,
 					  w_lower, h_lower,
 					  DRM_FORMAT_XRGB8888,
-					  I915_TILING_NONE,
+					  DRM_FORMAT_MOD_LINEAR,
 					  0.0, 0.0, 1.0, &fb_lower);
 	igt_assert(fb_id_lower);
 
 	fb_id_upper = igt_create_color_fb(display->drm_fd,
 					  w_upper, h_upper,
 					  DRM_FORMAT_XRGB8888,
-					  I915_TILING_NONE,
+					  DRM_FORMAT_MOD_LINEAR,
 					  1.0, 1.0, 0.0, &fb_upper);
 	igt_assert(fb_id_upper);
 
@@ -516,7 +516,7 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
 	igt_require(format != 0);
 
 	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
-			      format, I915_TILING_NONE, &fb);
+			      format, DRM_FORMAT_MOD_LINEAR, &fb);
 
 	igt_plane_set_fb(plane, &fb);
 	igt_plane_set_position(plane, w/2, h/2);
@@ -551,7 +551,7 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
 
 	igt_create_color_pattern_fb(pipe->display->drm_fd,
 				    fb->width, fb->height,
-				    fb->drm_format, I915_TILING_NONE,
+				    fb->drm_format, DRM_FORMAT_MOD_LINEAR,
 				    0.2, 0.2, 0.2, &fb2);
 
 	/* Flip the primary plane using the atomic API, and double-check
@@ -600,7 +600,7 @@ static void test_only(igt_pipe_t *pipe_obj,
 
 	igt_create_pattern_fb(pipe_obj->display->drm_fd,
 			     mode->hdisplay, mode->vdisplay,
-			     format, I915_TILING_NONE, &fb);
+			     format, DRM_FORMAT_MOD_LINEAR, &fb);
 	igt_plane_set_fb(primary, &fb);
 	igt_output_set_pipe(output, pipe_obj->pipe);
 
@@ -737,7 +737,7 @@ static void plane_invalid_params(igt_pipe_t *pipe,
 	/* Create a framebuffer too small for the plane configuration. */
 	igt_create_pattern_fb(pipe->display->drm_fd,
 			      fb->width - 1, fb->height - 1,
-			      fb->drm_format, I915_TILING_NONE, &fb2);
+			      fb->drm_format, DRM_FORMAT_MOD_LINEAR, &fb2);
 
 	igt_plane_set_prop_value(plane, IGT_PLANE_FB_ID, fb2.fb_id);
 	plane_commit_atomic_err(plane, ATOMIC_RELAX_NONE, ENOSPC);
@@ -1072,7 +1072,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
 
 	/* Color fb with white rect at center */
 	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
-			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
 			    &fb_1);
 	cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
 	igt_paint_color(cr_1, fb->width/4, fb->height/4, fb->width/2,
@@ -1111,7 +1111,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
 	 * issue plane update with damage and verify the state.
 	 */
 	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
-			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
 			    &fb_2);
 
 	damage[0].x1 = fb->width/2;
@@ -1141,7 +1141,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
 	/* Reszie fb_1 to be bigger than plane */
 	igt_remove_fb(pipe->display->drm_fd, &fb_1);
 	igt_create_color_fb(pipe->display->drm_fd, fb->width * 2, fb->height,
-			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
+			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
 			    &fb_1);
 
 	damage[0].x1 = fb->width;
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 64e7e7091..d32be0952 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -824,9 +824,9 @@ retry:
 	}
 
 	igt_create_pattern_fb(data->drm_fd, width, height,
-				   DRM_FORMAT_XRGB8888, 0, &data->fbs[0]);
+				   DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fbs[0]);
 	igt_create_color_pattern_fb(data->drm_fd, width, height,
-				    DRM_FORMAT_XRGB8888, 0, .5, .5, .5, &data->fbs[1]);
+				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &data->fbs[1]);
 
 	for_each_pipe(&data->display, i) {
 		igt_pipe_t *pipe = &data->display.pipes[i];
diff --git a/tests/kms_bw.c b/tests/kms_bw.c
index b1dfadd69..b66473e60 100644
--- a/tests/kms_bw.c
+++ b/tests/kms_bw.c
@@ -169,7 +169,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo
 
 		igt_create_color_fb(display->drm_fd, mode->hdisplay,
 				    mode->vdisplay, DRM_FORMAT_XRGB8888,
-				    DRM_FORMAT_MOD_NONE, 1.f, 0.f, 0.f,
+				    DRM_FORMAT_MOD_LINEAR, 1.f, 0.f, 0.f,
 				    &buffer[i]);
 
 		igt_output_set_pipe(output, i);
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index feea1ac83..a8862bdfb 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -193,7 +193,7 @@ static igt_output_t *set_fb_on_crtc(igt_display_t *display, enum pipe pipe, stru
 
 		igt_create_pattern_fb(display->drm_fd,
 			      mode->hdisplay, mode->vdisplay,
-			      DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
+			      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
 
 		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 		igt_plane_set_fb(primary, fb_info);
@@ -386,7 +386,7 @@ static void prepare_flip_test(igt_display_t *display,
 
 		igt_skip_on(width <= 64 && height <= 64);
 		igt_create_color_fb(display->drm_fd, width, height,
-				    DRM_FORMAT_ARGB8888, 0, 1., 0., .7, cursor_fb2);
+				    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, 1., 0., .7, cursor_fb2);
 
 		arg[0].flags = arg[1].flags = DRM_MODE_CURSOR_BO;
 		arg[1].handle = cursor_fb2->gem_handle;
@@ -412,7 +412,7 @@ static void prepare_flip_test(igt_display_t *display,
 		            display->pipes[flip_pipe].planes[1].type != DRM_PLANE_TYPE_CURSOR);
 
 		igt_create_color_pattern_fb(display->drm_fd, prim_fb->width, prim_fb->height,
-					    DRM_FORMAT_ARGB8888, 0, .1, .1, .1, argb_fb);
+					    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, argb_fb);
 	}
 }
 
@@ -458,9 +458,11 @@ static void flip(igt_display_t *display,
 		}
 	}
 
-	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
+	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height,
+			    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &cursor_fb);
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, cursor_pipe, &cursor_fb);
 	populate_cursor_args(display, cursor_pipe, arg, &cursor_fb);
 
@@ -564,7 +566,8 @@ static void basic_flip_cursor(igt_display_t *display,
 
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 
@@ -728,7 +731,8 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
 
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 
@@ -852,7 +856,8 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
 	igt_require(display->is_atomic);
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 	arg[0].flags |= DRM_MODE_CURSOR_BO;
@@ -972,7 +977,8 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
 		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
 	}
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg1, &cursor_fb);
 
@@ -1137,7 +1143,8 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 	vrefresh = igt_output_get_mode(output)->vrefresh;
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 
@@ -1249,7 +1256,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
 		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
 	}
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 
 	cursors[0] = set_cursor_on_pipe(display, pipe[0], &cursor_fb);
 	populate_cursor_args(display, pipe[0], arg[0], &cursor_fb);
@@ -1357,7 +1365,8 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
 
 	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 
 	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
@@ -1430,7 +1439,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
 	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
 				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
 
-	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
+	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
 	populate_cursor_args(display, pipe, arg, &cursor_fb);
 
 	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
index e4191811e..c2e98c3c6 100644
--- a/tests/kms_display_modes.c
+++ b/tests/kms_display_modes.c
@@ -64,9 +64,9 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
 	pipe_crc[1] = igt_pipe_crc_new(data->drm_fd, pipe2, IGT_PIPE_CRC_SOURCE_AUTO);
 
 	igt_create_color_fb(data->drm_fd, mode[0]->hdisplay, mode[0]->vdisplay,
-			     DRM_FORMAT_XRGB8888, 0, 1, 0, 0, &fbs[0]);
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fbs[0]);
 	igt_create_color_fb(data->drm_fd, mode[1]->hdisplay, mode[1]->vdisplay,
-			     DRM_FORMAT_XRGB8888, 0, 0, 0, 1, &fbs[1]);
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, 0, 1, &fbs[1]);
 
 	plane[0] = igt_pipe_get_plane_type(&display->pipes[pipe1], DRM_PLANE_TYPE_PRIMARY);
 	plane[1] = igt_pipe_get_plane_type(&display->pipes[pipe2], DRM_PLANE_TYPE_PRIMARY);
@@ -88,7 +88,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
 	width = mode[0]->hdisplay + mode[1]->hdisplay;
 	height = max(mode[0]->vdisplay, mode[1]->vdisplay);
 
-	igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888, 0, &fb);
+	igt_create_fb(data->drm_fd, width, height,
+		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
 	cr = igt_get_cairo_ctx(data->drm_fd, &fb);
 	igt_paint_color(cr, 0, 0, mode[0]->hdisplay, mode[0]->vdisplay, 1, 0, 0);
 	igt_paint_color(cr, mode[0]->hdisplay, 0, mode[1]->hdisplay, mode[1]->vdisplay, 0, 0, 1);
diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
index cde47e925..4ff1efe3b 100644
--- a/tests/kms_force_connector_basic.c
+++ b/tests/kms_force_connector_basic.c
@@ -68,8 +68,8 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
 	/* No load detect on HDMI. */
 	igt_require(connector->connector_type == DRM_MODE_CONNECTOR_VGA);
 
-	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, 0, &xrgb_fb);
-	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, 0, &argb_fb);
+	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &xrgb_fb);
+	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, &argb_fb);
 	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1) == 0);
 
 	/*
diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
index 2e4552a0c..813417e77 100644
--- a/tests/kms_getfb.c
+++ b/tests/kms_getfb.c
@@ -174,7 +174,7 @@ static void test_handle_input(int fd)
 		add.pixel_format = DRM_FORMAT_XRGB8888;
 		add.pitches[0] = 1024*4;
 		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_require(add.handles[0] != 0);
 		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
 	}
@@ -229,7 +229,7 @@ static void test_duplicate_handles(int fd)
 		add.pixel_format = DRM_FORMAT_XRGB8888;
 		add.pitches[0] = 1024*4;
 		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(add.handles[0]);
 		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
 	}
@@ -296,7 +296,7 @@ static void test_getfb2(int fd)
 		add_basic.pixel_format = DRM_FORMAT_XRGB8888;
 		add_basic.pitches[0] = 1024*4;
 		add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_assert(add_basic.handles[0]);
 		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
 
@@ -403,7 +403,7 @@ static void test_handle_protection(void) {
 		non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
 		non_master_add.pitches[0] = 1024*4;
 		non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
-			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
 		igt_require(non_master_add.handles[0] != 0);
 		do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
 	}
diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 36669ce81..23f12c14a 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -148,7 +148,8 @@ static void test_bpc_switch_on_output(data_t *data, enum pipe pipe,
 	int afb_id, ret;
 
 	/* 10-bit formats are slow, so limit the size. */
-	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
+	afb_id = igt_create_fb(data->fd, 512, 512,
+			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
 	igt_assert(afb_id);
 
 	draw_hdr_pattern(&afb);
@@ -396,7 +397,8 @@ static void test_static_toggle(data_t *data, enum pipe pipe,
 	int afb_id;
 
 	/* 10-bit formats are slow, so limit the size. */
-	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
+	afb_id = igt_create_fb(data->fd, 512, 512,
+			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
 	igt_assert(afb_id);
 
 	draw_hdr_pattern(&afb);
@@ -478,7 +480,8 @@ static void test_static_swap(data_t *data, enum pipe pipe, igt_output_t *output)
 	struct hdr_output_metadata hdr;
 
 	/* 10-bit formats are slow, so limit the size. */
-	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
+	afb_id = igt_create_fb(data->fd, 512, 512,
+			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
 	igt_assert(afb_id);
 
 	draw_hdr_pattern(&afb);
diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
index 9b27586c1..7a677ebbe 100644
--- a/tests/kms_plane_cursor.c
+++ b/tests/kms_plane_cursor.c
@@ -236,19 +236,19 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
 
 	test_cleanup(data);
 
-	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888, 0,
-			    1.0, 1.0, 1.0, &data->pfb);
+	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1.0, 1.0, 1.0, &data->pfb);
 
 	if (flags & TEST_OVERLAY) {
 		int width = (flags & TEST_VIEWPORT) ? data->or.w + pad : data->or.w;
 		int height = (flags & TEST_VIEWPORT) ? data->or.h + pad : data->or.h;
 
-		igt_create_color_fb(data->drm_fd, width, height,
-				    DRM_FORMAT_XRGB8888, 0, 0.5, 0.5, 0.5, &data->ofb);
+		igt_create_color_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.5, 0.5, 0.5, &data->ofb);
 	}
 
-	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888, 0,
-			    1.0, 0.0, 1.0, &data->cfb);
+	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888,
+			    DRM_FORMAT_MOD_LINEAR, 1.0, 0.0, 1.0, &data->cfb);
 
 	igt_plane_set_fb(data->primary, &data->pfb);
 	igt_output_set_pipe(data->output, data->pipe_id);
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index c6c6f3ec6..9e45af947 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -702,7 +702,7 @@ static void setup_fb(int fd, int width, int height,
 {
 	igt_create_color_pattern_fb(fd, width, height,
 				    DRM_FORMAT_XRGB8888,
-				    I915_TILING_NONE,
+				    DRM_FORMAT_MOD_LINEAR,
 				    r, g, b, fb);
 }
 
@@ -787,17 +787,17 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
 	igt_create_color_pattern_fb(display->drm_fd,
                                     width, height,
                                     DRM_FORMAT_XRGB8888,
-                                    I915_TILING_NONE,
+                                    DRM_FORMAT_MOD_LINEAR,
                                     1.0, 0.0, 0.0, &d->fb[0]);
 	igt_create_color_pattern_fb(display->drm_fd,
                                     width, height,
                                     DRM_FORMAT_XRGB8888,
-                                    I915_TILING_NONE,
+                                    DRM_FORMAT_MOD_LINEAR,
                                     0.0, 1.0, 0.0, &d->fb[1]);
 	igt_create_color_pattern_fb(display->drm_fd,
                                     width, height,
                                     DRM_FORMAT_XRGB8888,
-                                    I915_TILING_NONE,
+                                    DRM_FORMAT_MOD_LINEAR,
                                     0.0, 0.0, 1.0, &d->fb[2]);
 
 	igt_plane_set_fb(plane[0], &d->fb[0]);
@@ -854,16 +854,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 
 	igt_create_pattern_fb(d->drm_fd, 600, 600,
 			      DRM_FORMAT_XRGB8888,
-			      I915_TILING_NONE, &d->fb[0]);
+			      DRM_FORMAT_MOD_LINEAR, &d->fb[0]);
 	igt_create_pattern_fb(d->drm_fd, 500, 500,
 			      DRM_FORMAT_XRGB8888,
-			      I915_TILING_NONE, &d->fb[1]);
+			      DRM_FORMAT_MOD_LINEAR, &d->fb[1]);
 	igt_create_pattern_fb(d->drm_fd, 700, 700,
 			      DRM_FORMAT_XRGB8888,
-			      I915_TILING_NONE, &d->fb[2]);
+			      DRM_FORMAT_MOD_LINEAR, &d->fb[2]);
 	igt_create_pattern_fb(d->drm_fd, 400, 400,
 			      DRM_FORMAT_XRGB8888,
-			      I915_TILING_NONE, &d->fb[3]);
+			      DRM_FORMAT_MOD_LINEAR, &d->fb[3]);
 
 	igt_plane_set_fb(plane[0], &d->fb[0]);
 	igt_plane_set_fb(plane[1], &d->fb[1]);
@@ -935,7 +935,7 @@ static void invalid_parameter_tests(data_t *d)
 
 		igt_create_fb(d->drm_fd, 256, 256,
 			      DRM_FORMAT_XRGB8888,
-			      DRM_FORMAT_MOD_NONE,
+			      DRM_FORMAT_MOD_LINEAR,
 			      &fb);
 	}
 
@@ -1045,7 +1045,7 @@ static void i915_max_source_size_test(data_t *d)
 
 		igt_create_fb(d->drm_fd, 5120, 4320,
 			      DRM_FORMAT_XRGB8888,
-			      DRM_FORMAT_MOD_NONE,
+			      DRM_FORMAT_MOD_LINEAR,
 			      &fb);
 	}
 
diff --git a/tests/kms_prime.c b/tests/kms_prime.c
index ad199915b..d2a6503e5 100644
--- a/tests/kms_prime.c
+++ b/tests/kms_prime.c
@@ -119,7 +119,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
 					      scratch->size, PROT_WRITE);
 	} else {
 		igt_calc_fb_size(exporter_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
-				 DRM_FORMAT_MOD_NONE, &scratch->size, &scratch->pitch);
+				 DRM_FORMAT_MOD_LINEAR, &scratch->size, &scratch->pitch);
 		if (gem_has_lmem(exporter_fd))
 			scratch->handle = gem_create_in_memory_regions(exporter_fd, scratch->size,
 								       REGION_LMEM(0), REGION_SMEM);
diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
index 039e4a8d9..b17d00230 100644
--- a/tests/kms_scaling_modes.c
+++ b/tests/kms_scaling_modes.c
@@ -49,11 +49,11 @@ static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe
 	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
 
 	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
-			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
 			    0.f, 0.f, 1.f, &blue);
 
 	igt_create_color_fb(display->drm_fd, 640, 480,
-			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
 			    1.f, 0.f, 0.f, &red);
 
 	igt_plane_set_fb(primary, &blue);
diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index dd8fa1937..d38886f39 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -613,7 +613,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 	/* Black background FB */
 	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
 			    DRM_FORMAT_XRGB8888,
-			    false,
+			    DRM_FORMAT_MOD_LINEAR,
 			    0.0, 0.0, 0.0,
 			    &background_fb);
 
@@ -624,7 +624,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 		b = rand() % 0xFF;
 		igt_create_color_fb(data->drm_fd, 64, 64,
 				    DRM_FORMAT_ARGB8888,
-				    false,
+				    DRM_FORMAT_MOD_LINEAR,
 				    (double)r / 0xFF,
 				    (double)g / 0xFF,
 				    (double)b / 0xFF,
-- 
2.39.1

[igt-dev] [PATCH i-g-t 2/2] tests/kms: Add missing igt_put_cairo_ctx()

[Bhanuprakash Modem]

Remeber to call igt_put_cairo_ctx() after rendering to make
sure the results actually end up in the framebuffer (in case
the rendering happens to a temporary buffer and there needs
to be a copy back at the end).

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_async_flips.c | 4 ++++
 tests/kms_lease.c       | 2 +-
 tests/kms_writeback.c   | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 55be0bd87..34808f401 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -494,9 +494,11 @@ static void test_crc(data_t *data)
 
 	cr = igt_get_cairo_ctx(data->drm_fd, &data->bufs[frame]);
 	igt_paint_color(cr, 0, 0, data->bufs[frame].width, data->bufs[frame].height, 1.0, 0.0, 0.0);
+	igt_put_cairo_ctx(cr);
 
 	cr = igt_get_cairo_ctx(data->drm_fd, &data->bufs[!frame]);
 	igt_paint_color(cr, 0, 0, data->bufs[!frame].width, data->bufs[!frame].height, 1.0, 0.0, 0.0);
+	igt_put_cairo_ctx(cr);
 
 	ret = drmModeSetCrtc(data->drm_fd, data->crtc_id, data->bufs[frame].fb_id, 0, 0,
 			     &data->output->config.connector->connector_id, 1,
@@ -518,6 +520,7 @@ static void test_crc(data_t *data)
 		/* fill the next fb with the expected color */
 		cr = igt_get_cairo_ctx(data->drm_fd, &data->bufs[frame]);
 		igt_paint_color(cr, 0, 0, 1, data->bufs[frame].height, 1.0, 0.0, 0.0);
+		igt_put_cairo_ctx(cr);
 
 		data->flip_pending = true;
 		ret = drmModePageFlip(data->drm_fd, data->crtc_id, data->bufs[frame].fb_id,
@@ -530,6 +533,7 @@ static void test_crc(data_t *data)
 		frame = !frame;
 		cr = igt_get_cairo_ctx(data->drm_fd, &data->bufs[frame]);
 		igt_paint_color_rand(cr, 0, 0, 1, data->bufs[frame].height);
+		igt_put_cairo_ctx(cr);
 	}
 
 	igt_pipe_crc_stop(data->pipe_crc);
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 7eab77078..b9b669420 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -207,7 +207,7 @@ static int paint_fb(int drm_fd, struct igt_fb *fb, const char *test_name,
 	igt_cairo_printf_line(cr, align_hcenter, 10, "%s", connector_str);
 	igt_cairo_printf_line(cr, align_hcenter, 10, "%s", pipe_str);
 
-	cairo_destroy(cr);
+	igt_put_cairo_ctx(cr);
 
 	return 0;
 }
diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 9d1345857..c4808b02c 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -414,6 +414,7 @@ static void commit_and_dump_fb(igt_display_t *display, igt_output_t *output, igt
 	snprintf(filepath_out, PATH_MAX, "%s/%s.png", path_name, file_name);
 	status = cairo_surface_write_to_png(fb_surface_out, filepath_out);
 	igt_assert_eq(status, CAIRO_STATUS_SUCCESS);
+	cairo_surface_destroy(fb_surface_out);
 
 	igt_remove_fb(display->drm_fd, &output_fb);
 }
-- 
2.39.1

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5982 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier
URL   : https://patchwork.freedesktop.org/series/115032/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12842 -> IGTPW_8592
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8592 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8592, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/index.html

Participating hosts (35 -> 34)
------------------------------

  Missing    (1): fi-kbl-soraka 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8592:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@module-reload:
    - bat-dg2-11:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-dg2-11/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-dg2-11/igt@i915_pm_rpm@module-reload.html

  
Known issues
------------

  Here are the changes found in IGTPW_8592 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_lrc:
    - bat-dg2-11:         [PASS][3] -> [DMESG-WARN][4] ([i915#2867]) +4 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@hangcheck:
    - fi-skl-guc:         [PASS][5] -> [DMESG-WARN][6] ([i915#8073])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/fi-skl-guc/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7913])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-rpls-2/igt@i915_selftest@live@reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rpls-2/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-1:         NOTRUN -> [DMESG-FAIL][9] ([i915#6367] / [i915#7996])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-rplp-1:         NOTRUN -> [SKIP][10] ([i915#7828])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rplp-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - bat-rpls-1:         NOTRUN -> [SKIP][11] ([i915#7828])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-rpls-1:         NOTRUN -> [SKIP][12] ([i915#1845])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_lrc:
    - bat-rplp-1:         [INCOMPLETE][13] ([i915#4983] / [i915#7609] / [i915#7913]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-rplp-1/igt@i915_selftest@live@gt_lrc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rplp-1/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [ABORT][15] ([i915#4983]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-rpls-1/igt@i915_selftest@live@reset.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-rpls-1/igt@i915_selftest@live@reset.html

  
#### Warnings ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-nick:        [ABORT][17] ([i915#7911] / [i915#7913]) -> [INCOMPLETE][18] ([i915#7913])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/fi-bsw-nick/igt@i915_selftest@live@execlists.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/fi-bsw-nick/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [DMESG-FAIL][19] ([i915#7699]) -> [DMESG-WARN][20] ([i915#2867])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12842/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/bat-dg2-11/igt@i915_selftest@live@migrate.html

  
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
  [i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7190 -> IGTPW_8592

  CI-20190529: 20190529
  CI_DRM_12842: a8c602a36e7019429967251dd72737795ee130aa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8592: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/index.html
  IGT_7190: f9d49501eaaadd39ae471094bc45a76a1ff93e42 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8592/index.html

[-- Attachment #2: Type: text/html, Size: 7343 bytes --]

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2724 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)
URL   : https://patchwork.freedesktop.org/series/115032/
State : success

== Summary ==

CI Bug Log - changes from IGT_7191 -> IGTPW_8593
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html

Participating hosts (36 -> 35)
------------------------------

  Missing    (1): bat-atsm-1 

Known issues
------------

  Here are the changes found in IGTPW_8593 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-n3050:       [PASS][1] -> [ABORT][2] ([i915#7911])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
    - fi-bsw-nick:        [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/fi-bsw-nick/igt@i915_selftest@live@execlists.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/fi-bsw-nick/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-2:         [PASS][5] -> [ABORT][6] ([i915#4983] / [i915#7694] / [i915#7913])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/bat-rpls-2/igt@i915_selftest@live@requests.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/bat-rpls-2/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][7] -> [ABORT][8] ([i915#4983])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/bat-rpls-1/igt@i915_selftest@live@reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/bat-rpls-1/igt@i915_selftest@live@reset.html

  
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7191 -> IGTPW_8593

  CI-20190529: 20190529
  CI_DRM_12842: a8c602a36e7019429967251dd72737795ee130aa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8593: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html
  IGT_7191: a6766ee8a971366299671b06af8febc8192c0f74 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html

[-- Attachment #2: Type: text/html, Size: 3595 bytes --]

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms: Cleanup to use linear modifier

[Ville Syrjälä]

On Mon, Mar 13, 2023 at 10:26:00AM +0530, Bhanuprakash Modem wrote:
> While creating the framebuffer use the default modifier as
> DRM_FORMAT_MOD_LINEAR instead of using deprecated modifiers,
> magic numbers, no_tiling modifier etc..
> 
> V2: - New patch for cairo fix (Ville)
>     - Update commit message
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  tests/i915/kms_ccs.c              |  4 +---
>  tests/i915/kms_cdclk.c            |  4 ++--
>  tests/i915/kms_pipe_b_c_ivb.c     |  2 +-
>  tests/i915/kms_psr_stress_test.c  |  2 +-
>  tests/kms_addfb_basic.c           | 22 +++++++++----------
>  tests/kms_atomic.c                | 24 ++++++++++-----------
>  tests/kms_atomic_transition.c     |  4 ++--
>  tests/kms_bw.c                    |  2 +-
>  tests/kms_cursor_legacy.c         | 36 ++++++++++++++++++++-----------
>  tests/kms_display_modes.c         |  7 +++---
>  tests/kms_force_connector_basic.c |  4 ++--
>  tests/kms_getfb.c                 |  8 +++----
>  tests/kms_hdr.c                   |  9 +++++---
>  tests/kms_plane_cursor.c          | 12 +++++------
>  tests/kms_plane_scaling.c         | 20 ++++++++---------
>  tests/kms_prime.c                 |  2 +-
>  tests/kms_scaling_modes.c         |  4 ++--
>  tests/kms_universal_plane.c       |  4 ++--
>  18 files changed, 91 insertions(+), 79 deletions(-)
> 
> diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
> index 9be3fa252..18d48fb80 100644
> --- a/tests/i915/kms_ccs.c
> +++ b/tests/i915/kms_ccs.c
> @@ -393,10 +393,8 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
>  	 */
>  	if (fb_flags & FB_COMPRESSED)
>  		modifier = data->ccs_modifier;
> -	else if (!(fb_flags & FB_HAS_PLANE))
> -		modifier = DRM_FORMAT_MOD_LINEAR;

Explanation for this is still missing. Better make it a separate patch
as well.

>  	else
> -		modifier = 0;
> +		modifier = DRM_FORMAT_MOD_LINEAR;
>  
>  	create_fb_prepare_add(data->drm_fd, width, height,
>  			      data->format, modifier,
> diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
> index 991a7c507..f3046c95a 100644
> --- a/tests/i915/kms_cdclk.c
> +++ b/tests/i915/kms_cdclk.c
> @@ -158,7 +158,7 @@ static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *outpu
>  		igt_create_color_pattern_fb(display->drm_fd,
>  					    mode->hdisplay, mode->vdisplay,
>  					    DRM_FORMAT_XRGB8888,
> -					    I915_TILING_NONE,
> +					    DRM_FORMAT_MOD_LINEAR,
>  					    0.0, 0.0, 0.0, &fb);
>  		igt_plane_set_fb(primary, &fb);
>  
> @@ -212,7 +212,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
>  	igt_create_color_pattern_fb(display->drm_fd,
>  				    mode->hdisplay, mode->vdisplay,
>  				    DRM_FORMAT_XRGB8888,
> -				    I915_TILING_NONE,
> +				    DRM_FORMAT_MOD_LINEAR,
>  				    0.0, 0.0, 0.0, &fb);
>  
>  	/* switch to lower resolution */
> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> index 05ac87702..af11e3262 100644
> --- a/tests/i915/kms_pipe_b_c_ivb.c
> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> @@ -92,7 +92,7 @@ set_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  
>  	fb_id = igt_create_color_fb(data->drm_fd,
>  				    mode->hdisplay, mode->vdisplay,
> -				    DRM_FORMAT_XRGB8888, I915_TILING_NONE,
> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>  				    1.0, 1.0, 1.0, &fb);
>  	igt_assert_lte(0, fb_id);
>  
> diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
> index daac41d44..9b7ddda84 100644
> --- a/tests/i915/kms_psr_stress_test.c
> +++ b/tests/i915/kms_psr_stress_test.c
> @@ -374,4 +374,4 @@ igt_main
>  		close(data.debugfs_fd);
>  		close(data.drm_fd);
>  	}
> -}
> \ No newline at end of file
> +}
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index c58783d54..b4526eee6 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -68,10 +68,10 @@ static void invalid_tests(int fd)
>  
>  	igt_fixture {
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo_small);
>  
>  		f.handles[0] = gem_bo;
> @@ -276,7 +276,7 @@ static void pitch_tests(int fd)
>  
>  	igt_fixture {
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  	}
>  
> @@ -417,10 +417,10 @@ static void size_tests(int fd)
>  		igt_display_require(&display, fd);
>  
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo_small);
>  	}
>  
> @@ -513,7 +513,7 @@ static void addfb25_tests(int fd)
>  
>  	igt_fixture {
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  
>  		memset(&f, 0, sizeof(f));
> @@ -597,10 +597,10 @@ static void addfb25_ytile(int fd)
>  		igt_display_require(&display, fd);
>  
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo_small);
>  
>  		memset(&f, 0, sizeof(f));
> @@ -670,7 +670,7 @@ static void addfb25_4tile(int fd)
>  		igt_display_require(&display, fd);
>  
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +				DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  
>  		memset(&f, 0, sizeof(f));
> @@ -719,7 +719,7 @@ static void prop_tests(int fd)
>  
>  	igt_fixture {
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  
>  		f.handles[0] = gem_bo;
> @@ -780,7 +780,7 @@ static void master_tests(int fd)
>  
>  	igt_fixture {
>  		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(gem_bo);
>  
>  		f.handles[0] = gem_bo;
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index 2a3fb74be..e7d1cbd75 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -305,12 +305,12 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
>  	uint32_t h_overlay = mode->vdisplay / 2;
>  
>  	igt_create_color_pattern_fb(pipe->display->drm_fd,
> -				    w, h, format_primary, I915_TILING_NONE,
> +				    w, h, format_primary, DRM_FORMAT_MOD_LINEAR,
>  				    0.2, 0.2, 0.2, &fb_primary);
>  
>  	igt_create_color_pattern_fb(pipe->display->drm_fd,
>  				    w_overlay, h_overlay,
> -				    format_overlay, I915_TILING_NONE,
> +				    format_overlay, DRM_FORMAT_MOD_LINEAR,
>  				    0.2, 0.2, 0.2, &fb_overlay);
>  
>  	/* Draw a hole in the overlay */
> @@ -404,7 +404,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>  	igt_create_color_fb(display->drm_fd,
>  			    w_lower, h_lower,
>  			    DRM_FORMAT_XRGB8888,
> -			    I915_TILING_NONE,
> +			    DRM_FORMAT_MOD_LINEAR,
>  			    0.0, 0.0, 0.0, &fb_ref);
>  
>  	/* create reference image */
> @@ -444,14 +444,14 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>  	fb_id_lower = igt_create_color_fb(display->drm_fd,
>  					  w_lower, h_lower,
>  					  DRM_FORMAT_XRGB8888,
> -					  I915_TILING_NONE,
> +					  DRM_FORMAT_MOD_LINEAR,
>  					  0.0, 0.0, 1.0, &fb_lower);
>  	igt_assert(fb_id_lower);
>  
>  	fb_id_upper = igt_create_color_fb(display->drm_fd,
>  					  w_upper, h_upper,
>  					  DRM_FORMAT_XRGB8888,
> -					  I915_TILING_NONE,
> +					  DRM_FORMAT_MOD_LINEAR,
>  					  1.0, 1.0, 0.0, &fb_upper);
>  	igt_assert(fb_id_upper);
>  
> @@ -516,7 +516,7 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
>  	igt_require(format != 0);
>  
>  	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
> -			      format, I915_TILING_NONE, &fb);
> +			      format, DRM_FORMAT_MOD_LINEAR, &fb);
>  
>  	igt_plane_set_fb(plane, &fb);
>  	igt_plane_set_position(plane, w/2, h/2);
> @@ -551,7 +551,7 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
>  
>  	igt_create_color_pattern_fb(pipe->display->drm_fd,
>  				    fb->width, fb->height,
> -				    fb->drm_format, I915_TILING_NONE,
> +				    fb->drm_format, DRM_FORMAT_MOD_LINEAR,
>  				    0.2, 0.2, 0.2, &fb2);
>  
>  	/* Flip the primary plane using the atomic API, and double-check
> @@ -600,7 +600,7 @@ static void test_only(igt_pipe_t *pipe_obj,
>  
>  	igt_create_pattern_fb(pipe_obj->display->drm_fd,
>  			     mode->hdisplay, mode->vdisplay,
> -			     format, I915_TILING_NONE, &fb);
> +			     format, DRM_FORMAT_MOD_LINEAR, &fb);
>  	igt_plane_set_fb(primary, &fb);
>  	igt_output_set_pipe(output, pipe_obj->pipe);
>  
> @@ -737,7 +737,7 @@ static void plane_invalid_params(igt_pipe_t *pipe,
>  	/* Create a framebuffer too small for the plane configuration. */
>  	igt_create_pattern_fb(pipe->display->drm_fd,
>  			      fb->width - 1, fb->height - 1,
> -			      fb->drm_format, I915_TILING_NONE, &fb2);
> +			      fb->drm_format, DRM_FORMAT_MOD_LINEAR, &fb2);
>  
>  	igt_plane_set_prop_value(plane, IGT_PLANE_FB_ID, fb2.fb_id);
>  	plane_commit_atomic_err(plane, ATOMIC_RELAX_NONE, ENOSPC);
> @@ -1072,7 +1072,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>  
>  	/* Color fb with white rect at center */
>  	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>  			    &fb_1);
>  	cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
>  	igt_paint_color(cr_1, fb->width/4, fb->height/4, fb->width/2,
> @@ -1111,7 +1111,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>  	 * issue plane update with damage and verify the state.
>  	 */
>  	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>  			    &fb_2);
>  
>  	damage[0].x1 = fb->width/2;
> @@ -1141,7 +1141,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>  	/* Reszie fb_1 to be bigger than plane */
>  	igt_remove_fb(pipe->display->drm_fd, &fb_1);
>  	igt_create_color_fb(pipe->display->drm_fd, fb->width * 2, fb->height,
> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>  			    &fb_1);
>  
>  	damage[0].x1 = fb->width;
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 64e7e7091..d32be0952 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -824,9 +824,9 @@ retry:
>  	}
>  
>  	igt_create_pattern_fb(data->drm_fd, width, height,
> -				   DRM_FORMAT_XRGB8888, 0, &data->fbs[0]);
> +				   DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fbs[0]);
>  	igt_create_color_pattern_fb(data->drm_fd, width, height,
> -				    DRM_FORMAT_XRGB8888, 0, .5, .5, .5, &data->fbs[1]);
> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &data->fbs[1]);
>  
>  	for_each_pipe(&data->display, i) {
>  		igt_pipe_t *pipe = &data->display.pipes[i];
> diff --git a/tests/kms_bw.c b/tests/kms_bw.c
> index b1dfadd69..b66473e60 100644
> --- a/tests/kms_bw.c
> +++ b/tests/kms_bw.c
> @@ -169,7 +169,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo
>  
>  		igt_create_color_fb(display->drm_fd, mode->hdisplay,
>  				    mode->vdisplay, DRM_FORMAT_XRGB8888,
> -				    DRM_FORMAT_MOD_NONE, 1.f, 0.f, 0.f,
> +				    DRM_FORMAT_MOD_LINEAR, 1.f, 0.f, 0.f,
>  				    &buffer[i]);
>  
>  		igt_output_set_pipe(output, i);
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index feea1ac83..a8862bdfb 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -193,7 +193,7 @@ static igt_output_t *set_fb_on_crtc(igt_display_t *display, enum pipe pipe, stru
>  
>  		igt_create_pattern_fb(display->drm_fd,
>  			      mode->hdisplay, mode->vdisplay,
> -			      DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
> +			      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
>  
>  		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>  		igt_plane_set_fb(primary, fb_info);
> @@ -386,7 +386,7 @@ static void prepare_flip_test(igt_display_t *display,
>  
>  		igt_skip_on(width <= 64 && height <= 64);
>  		igt_create_color_fb(display->drm_fd, width, height,
> -				    DRM_FORMAT_ARGB8888, 0, 1., 0., .7, cursor_fb2);
> +				    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, 1., 0., .7, cursor_fb2);
>  
>  		arg[0].flags = arg[1].flags = DRM_MODE_CURSOR_BO;
>  		arg[1].handle = cursor_fb2->gem_handle;
> @@ -412,7 +412,7 @@ static void prepare_flip_test(igt_display_t *display,
>  		            display->pipes[flip_pipe].planes[1].type != DRM_PLANE_TYPE_CURSOR);
>  
>  		igt_create_color_pattern_fb(display->drm_fd, prim_fb->width, prim_fb->height,
> -					    DRM_FORMAT_ARGB8888, 0, .1, .1, .1, argb_fb);
> +					    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, argb_fb);
>  	}
>  }
>  
> @@ -458,9 +458,11 @@ static void flip(igt_display_t *display,
>  		}
>  	}
>  
> -	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height,
> +			    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &cursor_fb);
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, cursor_pipe, &cursor_fb);
>  	populate_cursor_args(display, cursor_pipe, arg, &cursor_fb);
>  
> @@ -564,7 +566,8 @@ static void basic_flip_cursor(igt_display_t *display,
>  
>  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  
> @@ -728,7 +731,8 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
>  
>  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  
> @@ -852,7 +856,8 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
>  	igt_require(display->is_atomic);
>  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>  	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  	arg[0].flags |= DRM_MODE_CURSOR_BO;
> @@ -972,7 +977,8 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
>  		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
>  	}
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>  	populate_cursor_args(display, pipe, arg1, &cursor_fb);
>  
> @@ -1137,7 +1143,8 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
>  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>  	vrefresh = igt_output_get_mode(output)->vrefresh;
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  
> @@ -1249,7 +1256,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
>  		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
>  	}
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  
>  	cursors[0] = set_cursor_on_pipe(display, pipe[0], &cursor_fb);
>  	populate_cursor_args(display, pipe[0], arg[0], &cursor_fb);
> @@ -1357,7 +1365,8 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
>  
>  	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  
>  	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> @@ -1430,7 +1439,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>  	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
>  				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
>  
> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>  	populate_cursor_args(display, pipe, arg, &cursor_fb);
>  
>  	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index e4191811e..c2e98c3c6 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -64,9 +64,9 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
>  	pipe_crc[1] = igt_pipe_crc_new(data->drm_fd, pipe2, IGT_PIPE_CRC_SOURCE_AUTO);
>  
>  	igt_create_color_fb(data->drm_fd, mode[0]->hdisplay, mode[0]->vdisplay,
> -			     DRM_FORMAT_XRGB8888, 0, 1, 0, 0, &fbs[0]);
> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fbs[0]);
>  	igt_create_color_fb(data->drm_fd, mode[1]->hdisplay, mode[1]->vdisplay,
> -			     DRM_FORMAT_XRGB8888, 0, 0, 0, 1, &fbs[1]);
> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, 0, 1, &fbs[1]);
>  
>  	plane[0] = igt_pipe_get_plane_type(&display->pipes[pipe1], DRM_PLANE_TYPE_PRIMARY);
>  	plane[1] = igt_pipe_get_plane_type(&display->pipes[pipe2], DRM_PLANE_TYPE_PRIMARY);
> @@ -88,7 +88,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
>  	width = mode[0]->hdisplay + mode[1]->hdisplay;
>  	height = max(mode[0]->vdisplay, mode[1]->vdisplay);
>  
> -	igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888, 0, &fb);
> +	igt_create_fb(data->drm_fd, width, height,
> +		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
>  	cr = igt_get_cairo_ctx(data->drm_fd, &fb);
>  	igt_paint_color(cr, 0, 0, mode[0]->hdisplay, mode[0]->vdisplay, 1, 0, 0);
>  	igt_paint_color(cr, mode[0]->hdisplay, 0, mode[1]->hdisplay, mode[1]->vdisplay, 0, 0, 1);
> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
> index cde47e925..4ff1efe3b 100644
> --- a/tests/kms_force_connector_basic.c
> +++ b/tests/kms_force_connector_basic.c
> @@ -68,8 +68,8 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
>  	/* No load detect on HDMI. */
>  	igt_require(connector->connector_type == DRM_MODE_CONNECTOR_VGA);
>  
> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, 0, &xrgb_fb);
> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, 0, &argb_fb);
> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &xrgb_fb);
> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, &argb_fb);
>  	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1) == 0);
>  
>  	/*
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index 2e4552a0c..813417e77 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -174,7 +174,7 @@ static void test_handle_input(int fd)
>  		add.pixel_format = DRM_FORMAT_XRGB8888;
>  		add.pitches[0] = 1024*4;
>  		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_require(add.handles[0] != 0);
>  		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
>  	}
> @@ -229,7 +229,7 @@ static void test_duplicate_handles(int fd)
>  		add.pixel_format = DRM_FORMAT_XRGB8888;
>  		add.pitches[0] = 1024*4;
>  		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(add.handles[0]);
>  		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
>  	}
> @@ -296,7 +296,7 @@ static void test_getfb2(int fd)
>  		add_basic.pixel_format = DRM_FORMAT_XRGB8888;
>  		add_basic.pitches[0] = 1024*4;
>  		add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_assert(add_basic.handles[0]);
>  		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
>  
> @@ -403,7 +403,7 @@ static void test_handle_protection(void) {
>  		non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
>  		non_master_add.pitches[0] = 1024*4;
>  		non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>  		igt_require(non_master_add.handles[0] != 0);
>  		do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
>  	}
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> index 36669ce81..23f12c14a 100644
> --- a/tests/kms_hdr.c
> +++ b/tests/kms_hdr.c
> @@ -148,7 +148,8 @@ static void test_bpc_switch_on_output(data_t *data, enum pipe pipe,
>  	int afb_id, ret;
>  
>  	/* 10-bit formats are slow, so limit the size. */
> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> +	afb_id = igt_create_fb(data->fd, 512, 512,
> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>  	igt_assert(afb_id);
>  
>  	draw_hdr_pattern(&afb);
> @@ -396,7 +397,8 @@ static void test_static_toggle(data_t *data, enum pipe pipe,
>  	int afb_id;
>  
>  	/* 10-bit formats are slow, so limit the size. */
> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> +	afb_id = igt_create_fb(data->fd, 512, 512,
> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>  	igt_assert(afb_id);
>  
>  	draw_hdr_pattern(&afb);
> @@ -478,7 +480,8 @@ static void test_static_swap(data_t *data, enum pipe pipe, igt_output_t *output)
>  	struct hdr_output_metadata hdr;
>  
>  	/* 10-bit formats are slow, so limit the size. */
> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> +	afb_id = igt_create_fb(data->fd, 512, 512,
> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>  	igt_assert(afb_id);
>  
>  	draw_hdr_pattern(&afb);
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 9b27586c1..7a677ebbe 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -236,19 +236,19 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
>  
>  	test_cleanup(data);
>  
> -	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888, 0,
> -			    1.0, 1.0, 1.0, &data->pfb);
> +	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 1.0, 1.0, &data->pfb);
>  
>  	if (flags & TEST_OVERLAY) {
>  		int width = (flags & TEST_VIEWPORT) ? data->or.w + pad : data->or.w;
>  		int height = (flags & TEST_VIEWPORT) ? data->or.h + pad : data->or.h;
>  
> -		igt_create_color_fb(data->drm_fd, width, height,
> -				    DRM_FORMAT_XRGB8888, 0, 0.5, 0.5, 0.5, &data->ofb);
> +		igt_create_color_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
> +				    DRM_FORMAT_MOD_LINEAR, 0.5, 0.5, 0.5, &data->ofb);
>  	}
>  
> -	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888, 0,
> -			    1.0, 0.0, 1.0, &data->cfb);
> +	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888,
> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 0.0, 1.0, &data->cfb);
>  
>  	igt_plane_set_fb(data->primary, &data->pfb);
>  	igt_output_set_pipe(data->output, data->pipe_id);
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index c6c6f3ec6..9e45af947 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -702,7 +702,7 @@ static void setup_fb(int fd, int width, int height,
>  {
>  	igt_create_color_pattern_fb(fd, width, height,
>  				    DRM_FORMAT_XRGB8888,
> -				    I915_TILING_NONE,
> +				    DRM_FORMAT_MOD_LINEAR,
>  				    r, g, b, fb);
>  }
>  
> @@ -787,17 +787,17 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
>  	igt_create_color_pattern_fb(display->drm_fd,
>                                      width, height,
>                                      DRM_FORMAT_XRGB8888,
> -                                    I915_TILING_NONE,
> +                                    DRM_FORMAT_MOD_LINEAR,
>                                      1.0, 0.0, 0.0, &d->fb[0]);
>  	igt_create_color_pattern_fb(display->drm_fd,
>                                      width, height,
>                                      DRM_FORMAT_XRGB8888,
> -                                    I915_TILING_NONE,
> +                                    DRM_FORMAT_MOD_LINEAR,
>                                      0.0, 1.0, 0.0, &d->fb[1]);
>  	igt_create_color_pattern_fb(display->drm_fd,
>                                      width, height,
>                                      DRM_FORMAT_XRGB8888,
> -                                    I915_TILING_NONE,
> +                                    DRM_FORMAT_MOD_LINEAR,
>                                      0.0, 0.0, 1.0, &d->fb[2]);
>  
>  	igt_plane_set_fb(plane[0], &d->fb[0]);
> @@ -854,16 +854,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
>  
>  	igt_create_pattern_fb(d->drm_fd, 600, 600,
>  			      DRM_FORMAT_XRGB8888,
> -			      I915_TILING_NONE, &d->fb[0]);
> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[0]);
>  	igt_create_pattern_fb(d->drm_fd, 500, 500,
>  			      DRM_FORMAT_XRGB8888,
> -			      I915_TILING_NONE, &d->fb[1]);
> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[1]);
>  	igt_create_pattern_fb(d->drm_fd, 700, 700,
>  			      DRM_FORMAT_XRGB8888,
> -			      I915_TILING_NONE, &d->fb[2]);
> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[2]);
>  	igt_create_pattern_fb(d->drm_fd, 400, 400,
>  			      DRM_FORMAT_XRGB8888,
> -			      I915_TILING_NONE, &d->fb[3]);
> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[3]);
>  
>  	igt_plane_set_fb(plane[0], &d->fb[0]);
>  	igt_plane_set_fb(plane[1], &d->fb[1]);
> @@ -935,7 +935,7 @@ static void invalid_parameter_tests(data_t *d)
>  
>  		igt_create_fb(d->drm_fd, 256, 256,
>  			      DRM_FORMAT_XRGB8888,
> -			      DRM_FORMAT_MOD_NONE,
> +			      DRM_FORMAT_MOD_LINEAR,
>  			      &fb);
>  	}
>  
> @@ -1045,7 +1045,7 @@ static void i915_max_source_size_test(data_t *d)
>  
>  		igt_create_fb(d->drm_fd, 5120, 4320,
>  			      DRM_FORMAT_XRGB8888,
> -			      DRM_FORMAT_MOD_NONE,
> +			      DRM_FORMAT_MOD_LINEAR,
>  			      &fb);
>  	}
>  
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> index ad199915b..d2a6503e5 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -119,7 +119,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
>  					      scratch->size, PROT_WRITE);
>  	} else {
>  		igt_calc_fb_size(exporter_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> -				 DRM_FORMAT_MOD_NONE, &scratch->size, &scratch->pitch);
> +				 DRM_FORMAT_MOD_LINEAR, &scratch->size, &scratch->pitch);
>  		if (gem_has_lmem(exporter_fd))
>  			scratch->handle = gem_create_in_memory_regions(exporter_fd, scratch->size,
>  								       REGION_LMEM(0), REGION_SMEM);
> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
> index 039e4a8d9..b17d00230 100644
> --- a/tests/kms_scaling_modes.c
> +++ b/tests/kms_scaling_modes.c
> @@ -49,11 +49,11 @@ static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe
>  	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
>  
>  	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>  			    0.f, 0.f, 1.f, &blue);
>  
>  	igt_create_color_fb(display->drm_fd, 640, 480,
> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>  			    1.f, 0.f, 0.f, &red);
>  
>  	igt_plane_set_fb(primary, &blue);
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> index dd8fa1937..d38886f39 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -613,7 +613,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  	/* Black background FB */
>  	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
>  			    DRM_FORMAT_XRGB8888,
> -			    false,
> +			    DRM_FORMAT_MOD_LINEAR,
>  			    0.0, 0.0, 0.0,
>  			    &background_fb);
>  
> @@ -624,7 +624,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>  		b = rand() % 0xFF;
>  		igt_create_color_fb(data->drm_fd, 64, 64,
>  				    DRM_FORMAT_ARGB8888,
> -				    false,
> +				    DRM_FORMAT_MOD_LINEAR,
>  				    (double)r / 0xFF,
>  				    (double)g / 0xFF,
>  				    (double)b / 0xFF,
> -- 
> 2.39.1

-- 
Ville Syrjälä
Intel

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms: Cleanup to use linear modifier

[Modem, Bhanuprakash]

Hi Ville,

On Mon-13-03-2023 02:25 pm, Ville Syrjälä wrote:
> On Mon, Mar 13, 2023 at 10:26:00AM +0530, Bhanuprakash Modem wrote:
>> While creating the framebuffer use the default modifier as
>> DRM_FORMAT_MOD_LINEAR instead of using deprecated modifiers,
>> magic numbers, no_tiling modifier etc..
>>
>> V2: - New patch for cairo fix (Ville)
>>      - Update commit message
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/i915/kms_ccs.c              |  4 +---
>>   tests/i915/kms_cdclk.c            |  4 ++--
>>   tests/i915/kms_pipe_b_c_ivb.c     |  2 +-
>>   tests/i915/kms_psr_stress_test.c  |  2 +-
>>   tests/kms_addfb_basic.c           | 22 +++++++++----------
>>   tests/kms_atomic.c                | 24 ++++++++++-----------
>>   tests/kms_atomic_transition.c     |  4 ++--
>>   tests/kms_bw.c                    |  2 +-
>>   tests/kms_cursor_legacy.c         | 36 ++++++++++++++++++++-----------
>>   tests/kms_display_modes.c         |  7 +++---
>>   tests/kms_force_connector_basic.c |  4 ++--
>>   tests/kms_getfb.c                 |  8 +++----
>>   tests/kms_hdr.c                   |  9 +++++---
>>   tests/kms_plane_cursor.c          | 12 +++++------
>>   tests/kms_plane_scaling.c         | 20 ++++++++---------
>>   tests/kms_prime.c                 |  2 +-
>>   tests/kms_scaling_modes.c         |  4 ++--
>>   tests/kms_universal_plane.c       |  4 ++--
>>   18 files changed, 91 insertions(+), 79 deletions(-)
>>
>> diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
>> index 9be3fa252..18d48fb80 100644
>> --- a/tests/i915/kms_ccs.c
>> +++ b/tests/i915/kms_ccs.c
>> @@ -393,10 +393,8 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
>>   	 */
>>   	if (fb_flags & FB_COMPRESSED)
>>   		modifier = data->ccs_modifier;
>> -	else if (!(fb_flags & FB_HAS_PLANE))
>> -		modifier = DRM_FORMAT_MOD_LINEAR;
> 
> Explanation for this is still missing. Better make it a separate patch
> as well.

Explanation is already there, please check
https://cgit.freedesktop.org/drm/igt-gpu-tools/tree/tests/i915/kms_ccs.c#n389

Sure, I'll float a new patch for this change.

- Bhanu

> 
>>   	else
>> -		modifier = 0;
>> +		modifier = DRM_FORMAT_MOD_LINEAR;
>>   
>>   	create_fb_prepare_add(data->drm_fd, width, height,
>>   			      data->format, modifier,
>> diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
>> index 991a7c507..f3046c95a 100644
>> --- a/tests/i915/kms_cdclk.c
>> +++ b/tests/i915/kms_cdclk.c
>> @@ -158,7 +158,7 @@ static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *outpu
>>   		igt_create_color_pattern_fb(display->drm_fd,
>>   					    mode->hdisplay, mode->vdisplay,
>>   					    DRM_FORMAT_XRGB8888,
>> -					    I915_TILING_NONE,
>> +					    DRM_FORMAT_MOD_LINEAR,
>>   					    0.0, 0.0, 0.0, &fb);
>>   		igt_plane_set_fb(primary, &fb);
>>   
>> @@ -212,7 +212,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
>>   	igt_create_color_pattern_fb(display->drm_fd,
>>   				    mode->hdisplay, mode->vdisplay,
>>   				    DRM_FORMAT_XRGB8888,
>> -				    I915_TILING_NONE,
>> +				    DRM_FORMAT_MOD_LINEAR,
>>   				    0.0, 0.0, 0.0, &fb);
>>   
>>   	/* switch to lower resolution */
>> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
>> index 05ac87702..af11e3262 100644
>> --- a/tests/i915/kms_pipe_b_c_ivb.c
>> +++ b/tests/i915/kms_pipe_b_c_ivb.c
>> @@ -92,7 +92,7 @@ set_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>   
>>   	fb_id = igt_create_color_fb(data->drm_fd,
>>   				    mode->hdisplay, mode->vdisplay,
>> -				    DRM_FORMAT_XRGB8888, I915_TILING_NONE,
>> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>>   				    1.0, 1.0, 1.0, &fb);
>>   	igt_assert_lte(0, fb_id);
>>   
>> diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
>> index daac41d44..9b7ddda84 100644
>> --- a/tests/i915/kms_psr_stress_test.c
>> +++ b/tests/i915/kms_psr_stress_test.c
>> @@ -374,4 +374,4 @@ igt_main
>>   		close(data.debugfs_fd);
>>   		close(data.drm_fd);
>>   	}
>> -}
>> \ No newline at end of file
>> +}
>> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
>> index c58783d54..b4526eee6 100644
>> --- a/tests/kms_addfb_basic.c
>> +++ b/tests/kms_addfb_basic.c
>> @@ -68,10 +68,10 @@ static void invalid_tests(int fd)
>>   
>>   	igt_fixture {
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo_small);
>>   
>>   		f.handles[0] = gem_bo;
>> @@ -276,7 +276,7 @@ static void pitch_tests(int fd)
>>   
>>   	igt_fixture {
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   	}
>>   
>> @@ -417,10 +417,10 @@ static void size_tests(int fd)
>>   		igt_display_require(&display, fd);
>>   
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo_small);
>>   	}
>>   
>> @@ -513,7 +513,7 @@ static void addfb25_tests(int fd)
>>   
>>   	igt_fixture {
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   
>>   		memset(&f, 0, sizeof(f));
>> @@ -597,10 +597,10 @@ static void addfb25_ytile(int fd)
>>   		igt_display_require(&display, fd);
>>   
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo_small);
>>   
>>   		memset(&f, 0, sizeof(f));
>> @@ -670,7 +670,7 @@ static void addfb25_4tile(int fd)
>>   		igt_display_require(&display, fd);
>>   
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +				DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   
>>   		memset(&f, 0, sizeof(f));
>> @@ -719,7 +719,7 @@ static void prop_tests(int fd)
>>   
>>   	igt_fixture {
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   
>>   		f.handles[0] = gem_bo;
>> @@ -780,7 +780,7 @@ static void master_tests(int fd)
>>   
>>   	igt_fixture {
>>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(gem_bo);
>>   
>>   		f.handles[0] = gem_bo;
>> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
>> index 2a3fb74be..e7d1cbd75 100644
>> --- a/tests/kms_atomic.c
>> +++ b/tests/kms_atomic.c
>> @@ -305,12 +305,12 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
>>   	uint32_t h_overlay = mode->vdisplay / 2;
>>   
>>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
>> -				    w, h, format_primary, I915_TILING_NONE,
>> +				    w, h, format_primary, DRM_FORMAT_MOD_LINEAR,
>>   				    0.2, 0.2, 0.2, &fb_primary);
>>   
>>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
>>   				    w_overlay, h_overlay,
>> -				    format_overlay, I915_TILING_NONE,
>> +				    format_overlay, DRM_FORMAT_MOD_LINEAR,
>>   				    0.2, 0.2, 0.2, &fb_overlay);
>>   
>>   	/* Draw a hole in the overlay */
>> @@ -404,7 +404,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>>   	igt_create_color_fb(display->drm_fd,
>>   			    w_lower, h_lower,
>>   			    DRM_FORMAT_XRGB8888,
>> -			    I915_TILING_NONE,
>> +			    DRM_FORMAT_MOD_LINEAR,
>>   			    0.0, 0.0, 0.0, &fb_ref);
>>   
>>   	/* create reference image */
>> @@ -444,14 +444,14 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>>   	fb_id_lower = igt_create_color_fb(display->drm_fd,
>>   					  w_lower, h_lower,
>>   					  DRM_FORMAT_XRGB8888,
>> -					  I915_TILING_NONE,
>> +					  DRM_FORMAT_MOD_LINEAR,
>>   					  0.0, 0.0, 1.0, &fb_lower);
>>   	igt_assert(fb_id_lower);
>>   
>>   	fb_id_upper = igt_create_color_fb(display->drm_fd,
>>   					  w_upper, h_upper,
>>   					  DRM_FORMAT_XRGB8888,
>> -					  I915_TILING_NONE,
>> +					  DRM_FORMAT_MOD_LINEAR,
>>   					  1.0, 1.0, 0.0, &fb_upper);
>>   	igt_assert(fb_id_upper);
>>   
>> @@ -516,7 +516,7 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
>>   	igt_require(format != 0);
>>   
>>   	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
>> -			      format, I915_TILING_NONE, &fb);
>> +			      format, DRM_FORMAT_MOD_LINEAR, &fb);
>>   
>>   	igt_plane_set_fb(plane, &fb);
>>   	igt_plane_set_position(plane, w/2, h/2);
>> @@ -551,7 +551,7 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
>>   
>>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
>>   				    fb->width, fb->height,
>> -				    fb->drm_format, I915_TILING_NONE,
>> +				    fb->drm_format, DRM_FORMAT_MOD_LINEAR,
>>   				    0.2, 0.2, 0.2, &fb2);
>>   
>>   	/* Flip the primary plane using the atomic API, and double-check
>> @@ -600,7 +600,7 @@ static void test_only(igt_pipe_t *pipe_obj,
>>   
>>   	igt_create_pattern_fb(pipe_obj->display->drm_fd,
>>   			     mode->hdisplay, mode->vdisplay,
>> -			     format, I915_TILING_NONE, &fb);
>> +			     format, DRM_FORMAT_MOD_LINEAR, &fb);
>>   	igt_plane_set_fb(primary, &fb);
>>   	igt_output_set_pipe(output, pipe_obj->pipe);
>>   
>> @@ -737,7 +737,7 @@ static void plane_invalid_params(igt_pipe_t *pipe,
>>   	/* Create a framebuffer too small for the plane configuration. */
>>   	igt_create_pattern_fb(pipe->display->drm_fd,
>>   			      fb->width - 1, fb->height - 1,
>> -			      fb->drm_format, I915_TILING_NONE, &fb2);
>> +			      fb->drm_format, DRM_FORMAT_MOD_LINEAR, &fb2);
>>   
>>   	igt_plane_set_prop_value(plane, IGT_PLANE_FB_ID, fb2.fb_id);
>>   	plane_commit_atomic_err(plane, ATOMIC_RELAX_NONE, ENOSPC);
>> @@ -1072,7 +1072,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>>   
>>   	/* Color fb with white rect at center */
>>   	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
>> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
>> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>>   			    &fb_1);
>>   	cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
>>   	igt_paint_color(cr_1, fb->width/4, fb->height/4, fb->width/2,
>> @@ -1111,7 +1111,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>>   	 * issue plane update with damage and verify the state.
>>   	 */
>>   	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
>> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
>> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>>   			    &fb_2);
>>   
>>   	damage[0].x1 = fb->width/2;
>> @@ -1141,7 +1141,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
>>   	/* Reszie fb_1 to be bigger than plane */
>>   	igt_remove_fb(pipe->display->drm_fd, &fb_1);
>>   	igt_create_color_fb(pipe->display->drm_fd, fb->width * 2, fb->height,
>> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
>> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
>>   			    &fb_1);
>>   
>>   	damage[0].x1 = fb->width;
>> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
>> index 64e7e7091..d32be0952 100644
>> --- a/tests/kms_atomic_transition.c
>> +++ b/tests/kms_atomic_transition.c
>> @@ -824,9 +824,9 @@ retry:
>>   	}
>>   
>>   	igt_create_pattern_fb(data->drm_fd, width, height,
>> -				   DRM_FORMAT_XRGB8888, 0, &data->fbs[0]);
>> +				   DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fbs[0]);
>>   	igt_create_color_pattern_fb(data->drm_fd, width, height,
>> -				    DRM_FORMAT_XRGB8888, 0, .5, .5, .5, &data->fbs[1]);
>> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &data->fbs[1]);
>>   
>>   	for_each_pipe(&data->display, i) {
>>   		igt_pipe_t *pipe = &data->display.pipes[i];
>> diff --git a/tests/kms_bw.c b/tests/kms_bw.c
>> index b1dfadd69..b66473e60 100644
>> --- a/tests/kms_bw.c
>> +++ b/tests/kms_bw.c
>> @@ -169,7 +169,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo
>>   
>>   		igt_create_color_fb(display->drm_fd, mode->hdisplay,
>>   				    mode->vdisplay, DRM_FORMAT_XRGB8888,
>> -				    DRM_FORMAT_MOD_NONE, 1.f, 0.f, 0.f,
>> +				    DRM_FORMAT_MOD_LINEAR, 1.f, 0.f, 0.f,
>>   				    &buffer[i]);
>>   
>>   		igt_output_set_pipe(output, i);
>> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
>> index feea1ac83..a8862bdfb 100644
>> --- a/tests/kms_cursor_legacy.c
>> +++ b/tests/kms_cursor_legacy.c
>> @@ -193,7 +193,7 @@ static igt_output_t *set_fb_on_crtc(igt_display_t *display, enum pipe pipe, stru
>>   
>>   		igt_create_pattern_fb(display->drm_fd,
>>   			      mode->hdisplay, mode->vdisplay,
>> -			      DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
>> +			      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
>>   
>>   		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>>   		igt_plane_set_fb(primary, fb_info);
>> @@ -386,7 +386,7 @@ static void prepare_flip_test(igt_display_t *display,
>>   
>>   		igt_skip_on(width <= 64 && height <= 64);
>>   		igt_create_color_fb(display->drm_fd, width, height,
>> -				    DRM_FORMAT_ARGB8888, 0, 1., 0., .7, cursor_fb2);
>> +				    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, 1., 0., .7, cursor_fb2);
>>   
>>   		arg[0].flags = arg[1].flags = DRM_MODE_CURSOR_BO;
>>   		arg[1].handle = cursor_fb2->gem_handle;
>> @@ -412,7 +412,7 @@ static void prepare_flip_test(igt_display_t *display,
>>   		            display->pipes[flip_pipe].planes[1].type != DRM_PLANE_TYPE_CURSOR);
>>   
>>   		igt_create_color_pattern_fb(display->drm_fd, prim_fb->width, prim_fb->height,
>> -					    DRM_FORMAT_ARGB8888, 0, .1, .1, .1, argb_fb);
>> +					    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, argb_fb);
>>   	}
>>   }
>>   
>> @@ -458,9 +458,11 @@ static void flip(igt_display_t *display,
>>   		}
>>   	}
>>   
>> -	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height,
>> +			    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &cursor_fb);
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, cursor_pipe, &cursor_fb);
>>   	populate_cursor_args(display, cursor_pipe, arg, &cursor_fb);
>>   
>> @@ -564,7 +566,8 @@ static void basic_flip_cursor(igt_display_t *display,
>>   
>>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   
>> @@ -728,7 +731,8 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
>>   
>>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   
>> @@ -852,7 +856,8 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
>>   	igt_require(display->is_atomic);
>>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>>   	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   	arg[0].flags |= DRM_MODE_CURSOR_BO;
>> @@ -972,7 +977,8 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
>>   		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
>>   	}
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg1, &cursor_fb);
>>   
>> @@ -1137,7 +1143,8 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
>>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>>   	vrefresh = igt_output_get_mode(output)->vrefresh;
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   
>> @@ -1249,7 +1256,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
>>   		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
>>   	}
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   
>>   	cursors[0] = set_cursor_on_pipe(display, pipe[0], &cursor_fb);
>>   	populate_cursor_args(display, pipe[0], arg[0], &cursor_fb);
>> @@ -1357,7 +1365,8 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
>>   
>>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   
>>   	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>> @@ -1430,7 +1439,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
>>   	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
>>   				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
>>   
>> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
>> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
>>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
>>   
>>   	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
>> index e4191811e..c2e98c3c6 100644
>> --- a/tests/kms_display_modes.c
>> +++ b/tests/kms_display_modes.c
>> @@ -64,9 +64,9 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
>>   	pipe_crc[1] = igt_pipe_crc_new(data->drm_fd, pipe2, IGT_PIPE_CRC_SOURCE_AUTO);
>>   
>>   	igt_create_color_fb(data->drm_fd, mode[0]->hdisplay, mode[0]->vdisplay,
>> -			     DRM_FORMAT_XRGB8888, 0, 1, 0, 0, &fbs[0]);
>> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fbs[0]);
>>   	igt_create_color_fb(data->drm_fd, mode[1]->hdisplay, mode[1]->vdisplay,
>> -			     DRM_FORMAT_XRGB8888, 0, 0, 0, 1, &fbs[1]);
>> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, 0, 1, &fbs[1]);
>>   
>>   	plane[0] = igt_pipe_get_plane_type(&display->pipes[pipe1], DRM_PLANE_TYPE_PRIMARY);
>>   	plane[1] = igt_pipe_get_plane_type(&display->pipes[pipe2], DRM_PLANE_TYPE_PRIMARY);
>> @@ -88,7 +88,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
>>   	width = mode[0]->hdisplay + mode[1]->hdisplay;
>>   	height = max(mode[0]->vdisplay, mode[1]->vdisplay);
>>   
>> -	igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888, 0, &fb);
>> +	igt_create_fb(data->drm_fd, width, height,
>> +		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
>>   	cr = igt_get_cairo_ctx(data->drm_fd, &fb);
>>   	igt_paint_color(cr, 0, 0, mode[0]->hdisplay, mode[0]->vdisplay, 1, 0, 0);
>>   	igt_paint_color(cr, mode[0]->hdisplay, 0, mode[1]->hdisplay, mode[1]->vdisplay, 0, 0, 1);
>> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
>> index cde47e925..4ff1efe3b 100644
>> --- a/tests/kms_force_connector_basic.c
>> +++ b/tests/kms_force_connector_basic.c
>> @@ -68,8 +68,8 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
>>   	/* No load detect on HDMI. */
>>   	igt_require(connector->connector_type == DRM_MODE_CONNECTOR_VGA);
>>   
>> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, 0, &xrgb_fb);
>> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, 0, &argb_fb);
>> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &xrgb_fb);
>> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, &argb_fb);
>>   	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1) == 0);
>>   
>>   	/*
>> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
>> index 2e4552a0c..813417e77 100644
>> --- a/tests/kms_getfb.c
>> +++ b/tests/kms_getfb.c
>> @@ -174,7 +174,7 @@ static void test_handle_input(int fd)
>>   		add.pixel_format = DRM_FORMAT_XRGB8888;
>>   		add.pitches[0] = 1024*4;
>>   		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_require(add.handles[0] != 0);
>>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
>>   	}
>> @@ -229,7 +229,7 @@ static void test_duplicate_handles(int fd)
>>   		add.pixel_format = DRM_FORMAT_XRGB8888;
>>   		add.pitches[0] = 1024*4;
>>   		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(add.handles[0]);
>>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
>>   	}
>> @@ -296,7 +296,7 @@ static void test_getfb2(int fd)
>>   		add_basic.pixel_format = DRM_FORMAT_XRGB8888;
>>   		add_basic.pitches[0] = 1024*4;
>>   		add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_assert(add_basic.handles[0]);
>>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
>>   
>> @@ -403,7 +403,7 @@ static void test_handle_protection(void) {
>>   		non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
>>   		non_master_add.pitches[0] = 1024*4;
>>   		non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
>> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
>> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
>>   		igt_require(non_master_add.handles[0] != 0);
>>   		do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
>>   	}
>> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
>> index 36669ce81..23f12c14a 100644
>> --- a/tests/kms_hdr.c
>> +++ b/tests/kms_hdr.c
>> @@ -148,7 +148,8 @@ static void test_bpc_switch_on_output(data_t *data, enum pipe pipe,
>>   	int afb_id, ret;
>>   
>>   	/* 10-bit formats are slow, so limit the size. */
>> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
>> +	afb_id = igt_create_fb(data->fd, 512, 512,
>> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>>   	igt_assert(afb_id);
>>   
>>   	draw_hdr_pattern(&afb);
>> @@ -396,7 +397,8 @@ static void test_static_toggle(data_t *data, enum pipe pipe,
>>   	int afb_id;
>>   
>>   	/* 10-bit formats are slow, so limit the size. */
>> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
>> +	afb_id = igt_create_fb(data->fd, 512, 512,
>> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>>   	igt_assert(afb_id);
>>   
>>   	draw_hdr_pattern(&afb);
>> @@ -478,7 +480,8 @@ static void test_static_swap(data_t *data, enum pipe pipe, igt_output_t *output)
>>   	struct hdr_output_metadata hdr;
>>   
>>   	/* 10-bit formats are slow, so limit the size. */
>> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
>> +	afb_id = igt_create_fb(data->fd, 512, 512,
>> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
>>   	igt_assert(afb_id);
>>   
>>   	draw_hdr_pattern(&afb);
>> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
>> index 9b27586c1..7a677ebbe 100644
>> --- a/tests/kms_plane_cursor.c
>> +++ b/tests/kms_plane_cursor.c
>> @@ -236,19 +236,19 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
>>   
>>   	test_cleanup(data);
>>   
>> -	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888, 0,
>> -			    1.0, 1.0, 1.0, &data->pfb);
>> +	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 1.0, 1.0, &data->pfb);
>>   
>>   	if (flags & TEST_OVERLAY) {
>>   		int width = (flags & TEST_VIEWPORT) ? data->or.w + pad : data->or.w;
>>   		int height = (flags & TEST_VIEWPORT) ? data->or.h + pad : data->or.h;
>>   
>> -		igt_create_color_fb(data->drm_fd, width, height,
>> -				    DRM_FORMAT_XRGB8888, 0, 0.5, 0.5, 0.5, &data->ofb);
>> +		igt_create_color_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
>> +				    DRM_FORMAT_MOD_LINEAR, 0.5, 0.5, 0.5, &data->ofb);
>>   	}
>>   
>> -	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888, 0,
>> -			    1.0, 0.0, 1.0, &data->cfb);
>> +	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888,
>> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 0.0, 1.0, &data->cfb);
>>   
>>   	igt_plane_set_fb(data->primary, &data->pfb);
>>   	igt_output_set_pipe(data->output, data->pipe_id);
>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> index c6c6f3ec6..9e45af947 100644
>> --- a/tests/kms_plane_scaling.c
>> +++ b/tests/kms_plane_scaling.c
>> @@ -702,7 +702,7 @@ static void setup_fb(int fd, int width, int height,
>>   {
>>   	igt_create_color_pattern_fb(fd, width, height,
>>   				    DRM_FORMAT_XRGB8888,
>> -				    I915_TILING_NONE,
>> +				    DRM_FORMAT_MOD_LINEAR,
>>   				    r, g, b, fb);
>>   }
>>   
>> @@ -787,17 +787,17 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
>>   	igt_create_color_pattern_fb(display->drm_fd,
>>                                       width, height,
>>                                       DRM_FORMAT_XRGB8888,
>> -                                    I915_TILING_NONE,
>> +                                    DRM_FORMAT_MOD_LINEAR,
>>                                       1.0, 0.0, 0.0, &d->fb[0]);
>>   	igt_create_color_pattern_fb(display->drm_fd,
>>                                       width, height,
>>                                       DRM_FORMAT_XRGB8888,
>> -                                    I915_TILING_NONE,
>> +                                    DRM_FORMAT_MOD_LINEAR,
>>                                       0.0, 1.0, 0.0, &d->fb[1]);
>>   	igt_create_color_pattern_fb(display->drm_fd,
>>                                       width, height,
>>                                       DRM_FORMAT_XRGB8888,
>> -                                    I915_TILING_NONE,
>> +                                    DRM_FORMAT_MOD_LINEAR,
>>                                       0.0, 0.0, 1.0, &d->fb[2]);
>>   
>>   	igt_plane_set_fb(plane[0], &d->fb[0]);
>> @@ -854,16 +854,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
>>   
>>   	igt_create_pattern_fb(d->drm_fd, 600, 600,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      I915_TILING_NONE, &d->fb[0]);
>> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[0]);
>>   	igt_create_pattern_fb(d->drm_fd, 500, 500,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      I915_TILING_NONE, &d->fb[1]);
>> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[1]);
>>   	igt_create_pattern_fb(d->drm_fd, 700, 700,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      I915_TILING_NONE, &d->fb[2]);
>> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[2]);
>>   	igt_create_pattern_fb(d->drm_fd, 400, 400,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      I915_TILING_NONE, &d->fb[3]);
>> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[3]);
>>   
>>   	igt_plane_set_fb(plane[0], &d->fb[0]);
>>   	igt_plane_set_fb(plane[1], &d->fb[1]);
>> @@ -935,7 +935,7 @@ static void invalid_parameter_tests(data_t *d)
>>   
>>   		igt_create_fb(d->drm_fd, 256, 256,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      DRM_FORMAT_MOD_NONE,
>> +			      DRM_FORMAT_MOD_LINEAR,
>>   			      &fb);
>>   	}
>>   
>> @@ -1045,7 +1045,7 @@ static void i915_max_source_size_test(data_t *d)
>>   
>>   		igt_create_fb(d->drm_fd, 5120, 4320,
>>   			      DRM_FORMAT_XRGB8888,
>> -			      DRM_FORMAT_MOD_NONE,
>> +			      DRM_FORMAT_MOD_LINEAR,
>>   			      &fb);
>>   	}
>>   
>> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
>> index ad199915b..d2a6503e5 100644
>> --- a/tests/kms_prime.c
>> +++ b/tests/kms_prime.c
>> @@ -119,7 +119,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
>>   					      scratch->size, PROT_WRITE);
>>   	} else {
>>   		igt_calc_fb_size(exporter_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
>> -				 DRM_FORMAT_MOD_NONE, &scratch->size, &scratch->pitch);
>> +				 DRM_FORMAT_MOD_LINEAR, &scratch->size, &scratch->pitch);
>>   		if (gem_has_lmem(exporter_fd))
>>   			scratch->handle = gem_create_in_memory_regions(exporter_fd, scratch->size,
>>   								       REGION_LMEM(0), REGION_SMEM);
>> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
>> index 039e4a8d9..b17d00230 100644
>> --- a/tests/kms_scaling_modes.c
>> +++ b/tests/kms_scaling_modes.c
>> @@ -49,11 +49,11 @@ static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe
>>   	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
>>   
>>   	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
>> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
>> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>>   			    0.f, 0.f, 1.f, &blue);
>>   
>>   	igt_create_color_fb(display->drm_fd, 640, 480,
>> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
>> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
>>   			    1.f, 0.f, 0.f, &red);
>>   
>>   	igt_plane_set_fb(primary, &blue);
>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>> index dd8fa1937..d38886f39 100644
>> --- a/tests/kms_universal_plane.c
>> +++ b/tests/kms_universal_plane.c
>> @@ -613,7 +613,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>   	/* Black background FB */
>>   	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
>>   			    DRM_FORMAT_XRGB8888,
>> -			    false,
>> +			    DRM_FORMAT_MOD_LINEAR,
>>   			    0.0, 0.0, 0.0,
>>   			    &background_fb);
>>   
>> @@ -624,7 +624,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>   		b = rand() % 0xFF;
>>   		igt_create_color_fb(data->drm_fd, 64, 64,
>>   				    DRM_FORMAT_ARGB8888,
>> -				    false,
>> +				    DRM_FORMAT_MOD_LINEAR,
>>   				    (double)r / 0xFF,
>>   				    (double)g / 0xFF,
>>   				    (double)b / 0xFF,
>> -- 
>> 2.39.1
> 

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms: Cleanup to use linear modifier

[Ville Syrjälä]

On Mon, Mar 13, 2023 at 08:46:11PM +0530, Modem, Bhanuprakash wrote:
> Hi Ville,
> 
> On Mon-13-03-2023 02:25 pm, Ville Syrjälä wrote:
> > On Mon, Mar 13, 2023 at 10:26:00AM +0530, Bhanuprakash Modem wrote:
> >> While creating the framebuffer use the default modifier as
> >> DRM_FORMAT_MOD_LINEAR instead of using deprecated modifiers,
> >> magic numbers, no_tiling modifier etc..
> >>
> >> V2: - New patch for cairo fix (Ville)
> >>      - Update commit message
> >>
> >> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> >> ---
> >>   tests/i915/kms_ccs.c              |  4 +---
> >>   tests/i915/kms_cdclk.c            |  4 ++--
> >>   tests/i915/kms_pipe_b_c_ivb.c     |  2 +-
> >>   tests/i915/kms_psr_stress_test.c  |  2 +-
> >>   tests/kms_addfb_basic.c           | 22 +++++++++----------
> >>   tests/kms_atomic.c                | 24 ++++++++++-----------
> >>   tests/kms_atomic_transition.c     |  4 ++--
> >>   tests/kms_bw.c                    |  2 +-
> >>   tests/kms_cursor_legacy.c         | 36 ++++++++++++++++++++-----------
> >>   tests/kms_display_modes.c         |  7 +++---
> >>   tests/kms_force_connector_basic.c |  4 ++--
> >>   tests/kms_getfb.c                 |  8 +++----
> >>   tests/kms_hdr.c                   |  9 +++++---
> >>   tests/kms_plane_cursor.c          | 12 +++++------
> >>   tests/kms_plane_scaling.c         | 20 ++++++++---------
> >>   tests/kms_prime.c                 |  2 +-
> >>   tests/kms_scaling_modes.c         |  4 ++--
> >>   tests/kms_universal_plane.c       |  4 ++--
> >>   18 files changed, 91 insertions(+), 79 deletions(-)
> >>
> >> diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
> >> index 9be3fa252..18d48fb80 100644
> >> --- a/tests/i915/kms_ccs.c
> >> +++ b/tests/i915/kms_ccs.c
> >> @@ -393,10 +393,8 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
> >>   	 */
> >>   	if (fb_flags & FB_COMPRESSED)
> >>   		modifier = data->ccs_modifier;
> >> -	else if (!(fb_flags & FB_HAS_PLANE))
> >> -		modifier = DRM_FORMAT_MOD_LINEAR;
> > 
> > Explanation for this is still missing. Better make it a separate patch
> > as well.
> 
> Explanation is already there, please check
> https://cgit.freedesktop.org/drm/igt-gpu-tools/tree/tests/i915/kms_ccs.c#n389

That is trying to explain something about what the original code
was doing. What is missing is the explanation for the change in this
patch.

> 
> Sure, I'll float a new patch for this change.
> 
> - Bhanu
> 
> > 
> >>   	else
> >> -		modifier = 0;
> >> +		modifier = DRM_FORMAT_MOD_LINEAR;
> >>   
> >>   	create_fb_prepare_add(data->drm_fd, width, height,
> >>   			      data->format, modifier,
> >> diff --git a/tests/i915/kms_cdclk.c b/tests/i915/kms_cdclk.c
> >> index 991a7c507..f3046c95a 100644
> >> --- a/tests/i915/kms_cdclk.c
> >> +++ b/tests/i915/kms_cdclk.c
> >> @@ -158,7 +158,7 @@ static void test_plane_scaling(data_t *data, enum pipe pipe, igt_output_t *outpu
> >>   		igt_create_color_pattern_fb(display->drm_fd,
> >>   					    mode->hdisplay, mode->vdisplay,
> >>   					    DRM_FORMAT_XRGB8888,
> >> -					    I915_TILING_NONE,
> >> +					    DRM_FORMAT_MOD_LINEAR,
> >>   					    0.0, 0.0, 0.0, &fb);
> >>   		igt_plane_set_fb(primary, &fb);
> >>   
> >> @@ -212,7 +212,7 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
> >>   	igt_create_color_pattern_fb(display->drm_fd,
> >>   				    mode->hdisplay, mode->vdisplay,
> >>   				    DRM_FORMAT_XRGB8888,
> >> -				    I915_TILING_NONE,
> >> +				    DRM_FORMAT_MOD_LINEAR,
> >>   				    0.0, 0.0, 0.0, &fb);
> >>   
> >>   	/* switch to lower resolution */
> >> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> >> index 05ac87702..af11e3262 100644
> >> --- a/tests/i915/kms_pipe_b_c_ivb.c
> >> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> >> @@ -92,7 +92,7 @@ set_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >>   
> >>   	fb_id = igt_create_color_fb(data->drm_fd,
> >>   				    mode->hdisplay, mode->vdisplay,
> >> -				    DRM_FORMAT_XRGB8888, I915_TILING_NONE,
> >> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
> >>   				    1.0, 1.0, 1.0, &fb);
> >>   	igt_assert_lte(0, fb_id);
> >>   
> >> diff --git a/tests/i915/kms_psr_stress_test.c b/tests/i915/kms_psr_stress_test.c
> >> index daac41d44..9b7ddda84 100644
> >> --- a/tests/i915/kms_psr_stress_test.c
> >> +++ b/tests/i915/kms_psr_stress_test.c
> >> @@ -374,4 +374,4 @@ igt_main
> >>   		close(data.debugfs_fd);
> >>   		close(data.drm_fd);
> >>   	}
> >> -}
> >> \ No newline at end of file
> >> +}
> >> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> >> index c58783d54..b4526eee6 100644
> >> --- a/tests/kms_addfb_basic.c
> >> +++ b/tests/kms_addfb_basic.c
> >> @@ -68,10 +68,10 @@ static void invalid_tests(int fd)
> >>   
> >>   	igt_fixture {
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo_small);
> >>   
> >>   		f.handles[0] = gem_bo;
> >> @@ -276,7 +276,7 @@ static void pitch_tests(int fd)
> >>   
> >>   	igt_fixture {
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   	}
> >>   
> >> @@ -417,10 +417,10 @@ static void size_tests(int fd)
> >>   		igt_display_require(&display, fd);
> >>   
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo_small);
> >>   	}
> >>   
> >> @@ -513,7 +513,7 @@ static void addfb25_tests(int fd)
> >>   
> >>   	igt_fixture {
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   
> >>   		memset(&f, 0, sizeof(f));
> >> @@ -597,10 +597,10 @@ static void addfb25_ytile(int fd)
> >>   		igt_display_require(&display, fd);
> >>   
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   		gem_bo_small = igt_create_bo_with_dimensions(fd, 1024, 1023,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo_small);
> >>   
> >>   		memset(&f, 0, sizeof(f));
> >> @@ -670,7 +670,7 @@ static void addfb25_4tile(int fd)
> >>   		igt_display_require(&display, fd);
> >>   
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +				DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   
> >>   		memset(&f, 0, sizeof(f));
> >> @@ -719,7 +719,7 @@ static void prop_tests(int fd)
> >>   
> >>   	igt_fixture {
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   
> >>   		f.handles[0] = gem_bo;
> >> @@ -780,7 +780,7 @@ static void master_tests(int fd)
> >>   
> >>   	igt_fixture {
> >>   		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(gem_bo);
> >>   
> >>   		f.handles[0] = gem_bo;
> >> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> >> index 2a3fb74be..e7d1cbd75 100644
> >> --- a/tests/kms_atomic.c
> >> +++ b/tests/kms_atomic.c
> >> @@ -305,12 +305,12 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output,
> >>   	uint32_t h_overlay = mode->vdisplay / 2;
> >>   
> >>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
> >> -				    w, h, format_primary, I915_TILING_NONE,
> >> +				    w, h, format_primary, DRM_FORMAT_MOD_LINEAR,
> >>   				    0.2, 0.2, 0.2, &fb_primary);
> >>   
> >>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
> >>   				    w_overlay, h_overlay,
> >> -				    format_overlay, I915_TILING_NONE,
> >> +				    format_overlay, DRM_FORMAT_MOD_LINEAR,
> >>   				    0.2, 0.2, 0.2, &fb_overlay);
> >>   
> >>   	/* Draw a hole in the overlay */
> >> @@ -404,7 +404,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
> >>   	igt_create_color_fb(display->drm_fd,
> >>   			    w_lower, h_lower,
> >>   			    DRM_FORMAT_XRGB8888,
> >> -			    I915_TILING_NONE,
> >> +			    DRM_FORMAT_MOD_LINEAR,
> >>   			    0.0, 0.0, 0.0, &fb_ref);
> >>   
> >>   	/* create reference image */
> >> @@ -444,14 +444,14 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
> >>   	fb_id_lower = igt_create_color_fb(display->drm_fd,
> >>   					  w_lower, h_lower,
> >>   					  DRM_FORMAT_XRGB8888,
> >> -					  I915_TILING_NONE,
> >> +					  DRM_FORMAT_MOD_LINEAR,
> >>   					  0.0, 0.0, 1.0, &fb_lower);
> >>   	igt_assert(fb_id_lower);
> >>   
> >>   	fb_id_upper = igt_create_color_fb(display->drm_fd,
> >>   					  w_upper, h_upper,
> >>   					  DRM_FORMAT_XRGB8888,
> >> -					  I915_TILING_NONE,
> >> +					  DRM_FORMAT_MOD_LINEAR,
> >>   					  1.0, 1.0, 0.0, &fb_upper);
> >>   	igt_assert(fb_id_upper);
> >>   
> >> @@ -516,7 +516,7 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
> >>   	igt_require(format != 0);
> >>   
> >>   	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
> >> -			      format, I915_TILING_NONE, &fb);
> >> +			      format, DRM_FORMAT_MOD_LINEAR, &fb);
> >>   
> >>   	igt_plane_set_fb(plane, &fb);
> >>   	igt_plane_set_position(plane, w/2, h/2);
> >> @@ -551,7 +551,7 @@ static void plane_primary(igt_pipe_t *pipe, igt_plane_t *plane, struct igt_fb *f
> >>   
> >>   	igt_create_color_pattern_fb(pipe->display->drm_fd,
> >>   				    fb->width, fb->height,
> >> -				    fb->drm_format, I915_TILING_NONE,
> >> +				    fb->drm_format, DRM_FORMAT_MOD_LINEAR,
> >>   				    0.2, 0.2, 0.2, &fb2);
> >>   
> >>   	/* Flip the primary plane using the atomic API, and double-check
> >> @@ -600,7 +600,7 @@ static void test_only(igt_pipe_t *pipe_obj,
> >>   
> >>   	igt_create_pattern_fb(pipe_obj->display->drm_fd,
> >>   			     mode->hdisplay, mode->vdisplay,
> >> -			     format, I915_TILING_NONE, &fb);
> >> +			     format, DRM_FORMAT_MOD_LINEAR, &fb);
> >>   	igt_plane_set_fb(primary, &fb);
> >>   	igt_output_set_pipe(output, pipe_obj->pipe);
> >>   
> >> @@ -737,7 +737,7 @@ static void plane_invalid_params(igt_pipe_t *pipe,
> >>   	/* Create a framebuffer too small for the plane configuration. */
> >>   	igt_create_pattern_fb(pipe->display->drm_fd,
> >>   			      fb->width - 1, fb->height - 1,
> >> -			      fb->drm_format, I915_TILING_NONE, &fb2);
> >> +			      fb->drm_format, DRM_FORMAT_MOD_LINEAR, &fb2);
> >>   
> >>   	igt_plane_set_prop_value(plane, IGT_PLANE_FB_ID, fb2.fb_id);
> >>   	plane_commit_atomic_err(plane, ATOMIC_RELAX_NONE, ENOSPC);
> >> @@ -1072,7 +1072,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
> >>   
> >>   	/* Color fb with white rect at center */
> >>   	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
> >> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> >> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
> >>   			    &fb_1);
> >>   	cr_1 = igt_get_cairo_ctx(pipe->display->drm_fd, &fb_1);
> >>   	igt_paint_color(cr_1, fb->width/4, fb->height/4, fb->width/2,
> >> @@ -1111,7 +1111,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
> >>   	 * issue plane update with damage and verify the state.
> >>   	 */
> >>   	igt_create_color_fb(pipe->display->drm_fd, fb->width, fb->height,
> >> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> >> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
> >>   			    &fb_2);
> >>   
> >>   	damage[0].x1 = fb->width/2;
> >> @@ -1141,7 +1141,7 @@ static void atomic_plane_damage(igt_pipe_t *pipe, igt_plane_t *plane, struct igt
> >>   	/* Reszie fb_1 to be bigger than plane */
> >>   	igt_remove_fb(pipe->display->drm_fd, &fb_1);
> >>   	igt_create_color_fb(pipe->display->drm_fd, fb->width * 2, fb->height,
> >> -			    fb->drm_format, I915_TILING_NONE, 0.2, 0.2, 0.2,
> >> +			    fb->drm_format, DRM_FORMAT_MOD_LINEAR, 0.2, 0.2, 0.2,
> >>   			    &fb_1);
> >>   
> >>   	damage[0].x1 = fb->width;
> >> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> >> index 64e7e7091..d32be0952 100644
> >> --- a/tests/kms_atomic_transition.c
> >> +++ b/tests/kms_atomic_transition.c
> >> @@ -824,9 +824,9 @@ retry:
> >>   	}
> >>   
> >>   	igt_create_pattern_fb(data->drm_fd, width, height,
> >> -				   DRM_FORMAT_XRGB8888, 0, &data->fbs[0]);
> >> +				   DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fbs[0]);
> >>   	igt_create_color_pattern_fb(data->drm_fd, width, height,
> >> -				    DRM_FORMAT_XRGB8888, 0, .5, .5, .5, &data->fbs[1]);
> >> +				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &data->fbs[1]);
> >>   
> >>   	for_each_pipe(&data->display, i) {
> >>   		igt_pipe_t *pipe = &data->display.pipes[i];
> >> diff --git a/tests/kms_bw.c b/tests/kms_bw.c
> >> index b1dfadd69..b66473e60 100644
> >> --- a/tests/kms_bw.c
> >> +++ b/tests/kms_bw.c
> >> @@ -169,7 +169,7 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo
> >>   
> >>   		igt_create_color_fb(display->drm_fd, mode->hdisplay,
> >>   				    mode->vdisplay, DRM_FORMAT_XRGB8888,
> >> -				    DRM_FORMAT_MOD_NONE, 1.f, 0.f, 0.f,
> >> +				    DRM_FORMAT_MOD_LINEAR, 1.f, 0.f, 0.f,
> >>   				    &buffer[i]);
> >>   
> >>   		igt_output_set_pipe(output, i);
> >> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> >> index feea1ac83..a8862bdfb 100644
> >> --- a/tests/kms_cursor_legacy.c
> >> +++ b/tests/kms_cursor_legacy.c
> >> @@ -193,7 +193,7 @@ static igt_output_t *set_fb_on_crtc(igt_display_t *display, enum pipe pipe, stru
> >>   
> >>   		igt_create_pattern_fb(display->drm_fd,
> >>   			      mode->hdisplay, mode->vdisplay,
> >> -			      DRM_FORMAT_XRGB8888, I915_TILING_NONE, fb_info);
> >> +			      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
> >>   
> >>   		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> >>   		igt_plane_set_fb(primary, fb_info);
> >> @@ -386,7 +386,7 @@ static void prepare_flip_test(igt_display_t *display,
> >>   
> >>   		igt_skip_on(width <= 64 && height <= 64);
> >>   		igt_create_color_fb(display->drm_fd, width, height,
> >> -				    DRM_FORMAT_ARGB8888, 0, 1., 0., .7, cursor_fb2);
> >> +				    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, 1., 0., .7, cursor_fb2);
> >>   
> >>   		arg[0].flags = arg[1].flags = DRM_MODE_CURSOR_BO;
> >>   		arg[1].handle = cursor_fb2->gem_handle;
> >> @@ -412,7 +412,7 @@ static void prepare_flip_test(igt_display_t *display,
> >>   		            display->pipes[flip_pipe].planes[1].type != DRM_PLANE_TYPE_CURSOR);
> >>   
> >>   		igt_create_color_pattern_fb(display->drm_fd, prim_fb->width, prim_fb->height,
> >> -					    DRM_FORMAT_ARGB8888, 0, .1, .1, .1, argb_fb);
> >> +					    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, argb_fb);
> >>   	}
> >>   }
> >>   
> >> @@ -458,9 +458,11 @@ static void flip(igt_display_t *display,
> >>   		}
> >>   	}
> >>   
> >> -	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height, DRM_FORMAT_ARGB8888, 0, .5, .5, .5, &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, fb_info.width, fb_info.height,
> >> +			    DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .5, .5, .5, &cursor_fb);
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, cursor_pipe, &cursor_fb);
> >>   	populate_cursor_args(display, cursor_pipe, arg, &cursor_fb);
> >>   
> >> @@ -564,7 +566,8 @@ static void basic_flip_cursor(igt_display_t *display,
> >>   
> >>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   
> >> @@ -728,7 +731,8 @@ static void flip_vs_cursor(igt_display_t *display, enum flip_test mode, int nloo
> >>   
> >>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   
> >> @@ -852,7 +856,8 @@ static void nonblocking_modeset_vs_cursor(igt_display_t *display, int loops)
> >>   	igt_require(display->is_atomic);
> >>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
> >>   	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   	arg[0].flags |= DRM_MODE_CURSOR_BO;
> >> @@ -972,7 +977,8 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
> >>   		igt_require((output2 = set_fb_on_crtc(display, pipe2, &fb2_info)));
> >>   	}
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg1, &cursor_fb);
> >>   
> >> @@ -1137,7 +1143,8 @@ static void cursor_vs_flip(igt_display_t *display, enum flip_test mode, int nloo
> >>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
> >>   	vrefresh = igt_output_get_mode(output)->vrefresh;
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	cursor = set_cursor_on_pipe(display, pipe, &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   
> >> @@ -1249,7 +1256,8 @@ static void two_screens_cursor_vs_flip(igt_display_t *display, int nloops, bool
> >>   		igt_require((outputs[1] = set_fb_on_crtc(display, pipe[1], &fb_info[1])));
> >>   	}
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   
> >>   	cursors[0] = set_cursor_on_pipe(display, pipe[0], &cursor_fb);
> >>   	populate_cursor_args(display, pipe[0], arg[0], &cursor_fb);
> >> @@ -1357,7 +1365,8 @@ static void flip_vs_cursor_crc(igt_display_t *display, bool atomic)
> >>   
> >>   	igt_require((output = set_fb_on_crtc(display, pipe, &fb_info)));
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   
> >>   	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> >> @@ -1430,7 +1439,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
> >>   	igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
> >>   				    DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED, .1, .1, .1, &fb_info[1]);
> >>   
> >> -	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888, 0, 1., 1., 1., &cursor_fb);
> >> +	igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
> >>   	populate_cursor_args(display, pipe, arg, &cursor_fb);
> >>   
> >>   	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> >> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> >> index e4191811e..c2e98c3c6 100644
> >> --- a/tests/kms_display_modes.c
> >> +++ b/tests/kms_display_modes.c
> >> @@ -64,9 +64,9 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
> >>   	pipe_crc[1] = igt_pipe_crc_new(data->drm_fd, pipe2, IGT_PIPE_CRC_SOURCE_AUTO);
> >>   
> >>   	igt_create_color_fb(data->drm_fd, mode[0]->hdisplay, mode[0]->vdisplay,
> >> -			     DRM_FORMAT_XRGB8888, 0, 1, 0, 0, &fbs[0]);
> >> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fbs[0]);
> >>   	igt_create_color_fb(data->drm_fd, mode[1]->hdisplay, mode[1]->vdisplay,
> >> -			     DRM_FORMAT_XRGB8888, 0, 0, 0, 1, &fbs[1]);
> >> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, 0, 1, &fbs[1]);
> >>   
> >>   	plane[0] = igt_pipe_get_plane_type(&display->pipes[pipe1], DRM_PLANE_TYPE_PRIMARY);
> >>   	plane[1] = igt_pipe_get_plane_type(&display->pipes[pipe2], DRM_PLANE_TYPE_PRIMARY);
> >> @@ -88,7 +88,8 @@ static void run_extendedmode_basic(data_t *data, int pipe1, int pipe2)
> >>   	width = mode[0]->hdisplay + mode[1]->hdisplay;
> >>   	height = max(mode[0]->vdisplay, mode[1]->vdisplay);
> >>   
> >> -	igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888, 0, &fb);
> >> +	igt_create_fb(data->drm_fd, width, height,
> >> +		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
> >>   	cr = igt_get_cairo_ctx(data->drm_fd, &fb);
> >>   	igt_paint_color(cr, 0, 0, mode[0]->hdisplay, mode[0]->vdisplay, 1, 0, 0);
> >>   	igt_paint_color(cr, mode[0]->hdisplay, 0, mode[1]->hdisplay, mode[1]->vdisplay, 0, 0, 1);
> >> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
> >> index cde47e925..4ff1efe3b 100644
> >> --- a/tests/kms_force_connector_basic.c
> >> +++ b/tests/kms_force_connector_basic.c
> >> @@ -68,8 +68,8 @@ static void force_load_detect(int drm_fd, drmModeConnectorPtr connector, drmMode
> >>   	/* No load detect on HDMI. */
> >>   	igt_require(connector->connector_type == DRM_MODE_CONNECTOR_VGA);
> >>   
> >> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, 0, &xrgb_fb);
> >> -	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, 0, &argb_fb);
> >> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &xrgb_fb);
> >> +	igt_create_fb(drm_fd, w, h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, &argb_fb);
> >>   	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1) == 0);
> >>   
> >>   	/*
> >> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> >> index 2e4552a0c..813417e77 100644
> >> --- a/tests/kms_getfb.c
> >> +++ b/tests/kms_getfb.c
> >> @@ -174,7 +174,7 @@ static void test_handle_input(int fd)
> >>   		add.pixel_format = DRM_FORMAT_XRGB8888;
> >>   		add.pitches[0] = 1024*4;
> >>   		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_require(add.handles[0] != 0);
> >>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
> >>   	}
> >> @@ -229,7 +229,7 @@ static void test_duplicate_handles(int fd)
> >>   		add.pixel_format = DRM_FORMAT_XRGB8888;
> >>   		add.pitches[0] = 1024*4;
> >>   		add.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(add.handles[0]);
> >>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add);
> >>   	}
> >> @@ -296,7 +296,7 @@ static void test_getfb2(int fd)
> >>   		add_basic.pixel_format = DRM_FORMAT_XRGB8888;
> >>   		add_basic.pitches[0] = 1024*4;
> >>   		add_basic.handles[0] = igt_create_bo_with_dimensions(fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_assert(add_basic.handles[0]);
> >>   		do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &add_basic);
> >>   
> >> @@ -403,7 +403,7 @@ static void test_handle_protection(void) {
> >>   		non_master_add.pixel_format = DRM_FORMAT_XRGB8888;
> >>   		non_master_add.pitches[0] = 1024*4;
> >>   		non_master_add.handles[0] = igt_create_bo_with_dimensions(non_master_fd, 1024, 1024,
> >> -			DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
> >> +			DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 0, NULL, NULL, NULL);
> >>   		igt_require(non_master_add.handles[0] != 0);
> >>   		do_ioctl(non_master_fd, DRM_IOCTL_MODE_ADDFB2, &non_master_add);
> >>   	}
> >> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> >> index 36669ce81..23f12c14a 100644
> >> --- a/tests/kms_hdr.c
> >> +++ b/tests/kms_hdr.c
> >> @@ -148,7 +148,8 @@ static void test_bpc_switch_on_output(data_t *data, enum pipe pipe,
> >>   	int afb_id, ret;
> >>   
> >>   	/* 10-bit formats are slow, so limit the size. */
> >> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> >> +	afb_id = igt_create_fb(data->fd, 512, 512,
> >> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
> >>   	igt_assert(afb_id);
> >>   
> >>   	draw_hdr_pattern(&afb);
> >> @@ -396,7 +397,8 @@ static void test_static_toggle(data_t *data, enum pipe pipe,
> >>   	int afb_id;
> >>   
> >>   	/* 10-bit formats are slow, so limit the size. */
> >> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> >> +	afb_id = igt_create_fb(data->fd, 512, 512,
> >> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
> >>   	igt_assert(afb_id);
> >>   
> >>   	draw_hdr_pattern(&afb);
> >> @@ -478,7 +480,8 @@ static void test_static_swap(data_t *data, enum pipe pipe, igt_output_t *output)
> >>   	struct hdr_output_metadata hdr;
> >>   
> >>   	/* 10-bit formats are slow, so limit the size. */
> >> -	afb_id = igt_create_fb(data->fd, 512, 512, DRM_FORMAT_XRGB2101010, 0, &afb);
> >> +	afb_id = igt_create_fb(data->fd, 512, 512,
> >> +			       DRM_FORMAT_XRGB2101010, DRM_FORMAT_MOD_LINEAR, &afb);
> >>   	igt_assert(afb_id);
> >>   
> >>   	draw_hdr_pattern(&afb);
> >> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> >> index 9b27586c1..7a677ebbe 100644
> >> --- a/tests/kms_plane_cursor.c
> >> +++ b/tests/kms_plane_cursor.c
> >> @@ -236,19 +236,19 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
> >>   
> >>   	test_cleanup(data);
> >>   
> >> -	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888, 0,
> >> -			    1.0, 1.0, 1.0, &data->pfb);
> >> +	igt_create_color_fb(data->drm_fd, sw, sh, DRM_FORMAT_XRGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 1.0, 1.0, &data->pfb);
> >>   
> >>   	if (flags & TEST_OVERLAY) {
> >>   		int width = (flags & TEST_VIEWPORT) ? data->or.w + pad : data->or.w;
> >>   		int height = (flags & TEST_VIEWPORT) ? data->or.h + pad : data->or.h;
> >>   
> >> -		igt_create_color_fb(data->drm_fd, width, height,
> >> -				    DRM_FORMAT_XRGB8888, 0, 0.5, 0.5, 0.5, &data->ofb);
> >> +		igt_create_color_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
> >> +				    DRM_FORMAT_MOD_LINEAR, 0.5, 0.5, 0.5, &data->ofb);
> >>   	}
> >>   
> >> -	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888, 0,
> >> -			    1.0, 0.0, 1.0, &data->cfb);
> >> +	igt_create_color_fb(data->drm_fd, size, size, DRM_FORMAT_ARGB8888,
> >> +			    DRM_FORMAT_MOD_LINEAR, 1.0, 0.0, 1.0, &data->cfb);
> >>   
> >>   	igt_plane_set_fb(data->primary, &data->pfb);
> >>   	igt_output_set_pipe(data->output, data->pipe_id);
> >> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> >> index c6c6f3ec6..9e45af947 100644
> >> --- a/tests/kms_plane_scaling.c
> >> +++ b/tests/kms_plane_scaling.c
> >> @@ -702,7 +702,7 @@ static void setup_fb(int fd, int width, int height,
> >>   {
> >>   	igt_create_color_pattern_fb(fd, width, height,
> >>   				    DRM_FORMAT_XRGB8888,
> >> -				    I915_TILING_NONE,
> >> +				    DRM_FORMAT_MOD_LINEAR,
> >>   				    r, g, b, fb);
> >>   }
> >>   
> >> @@ -787,17 +787,17 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
> >>   	igt_create_color_pattern_fb(display->drm_fd,
> >>                                       width, height,
> >>                                       DRM_FORMAT_XRGB8888,
> >> -                                    I915_TILING_NONE,
> >> +                                    DRM_FORMAT_MOD_LINEAR,
> >>                                       1.0, 0.0, 0.0, &d->fb[0]);
> >>   	igt_create_color_pattern_fb(display->drm_fd,
> >>                                       width, height,
> >>                                       DRM_FORMAT_XRGB8888,
> >> -                                    I915_TILING_NONE,
> >> +                                    DRM_FORMAT_MOD_LINEAR,
> >>                                       0.0, 1.0, 0.0, &d->fb[1]);
> >>   	igt_create_color_pattern_fb(display->drm_fd,
> >>                                       width, height,
> >>                                       DRM_FORMAT_XRGB8888,
> >> -                                    I915_TILING_NONE,
> >> +                                    DRM_FORMAT_MOD_LINEAR,
> >>                                       0.0, 0.0, 1.0, &d->fb[2]);
> >>   
> >>   	igt_plane_set_fb(plane[0], &d->fb[0]);
> >> @@ -854,16 +854,16 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
> >>   
> >>   	igt_create_pattern_fb(d->drm_fd, 600, 600,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      I915_TILING_NONE, &d->fb[0]);
> >> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[0]);
> >>   	igt_create_pattern_fb(d->drm_fd, 500, 500,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      I915_TILING_NONE, &d->fb[1]);
> >> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[1]);
> >>   	igt_create_pattern_fb(d->drm_fd, 700, 700,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      I915_TILING_NONE, &d->fb[2]);
> >> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[2]);
> >>   	igt_create_pattern_fb(d->drm_fd, 400, 400,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      I915_TILING_NONE, &d->fb[3]);
> >> +			      DRM_FORMAT_MOD_LINEAR, &d->fb[3]);
> >>   
> >>   	igt_plane_set_fb(plane[0], &d->fb[0]);
> >>   	igt_plane_set_fb(plane[1], &d->fb[1]);
> >> @@ -935,7 +935,7 @@ static void invalid_parameter_tests(data_t *d)
> >>   
> >>   		igt_create_fb(d->drm_fd, 256, 256,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      DRM_FORMAT_MOD_NONE,
> >> +			      DRM_FORMAT_MOD_LINEAR,
> >>   			      &fb);
> >>   	}
> >>   
> >> @@ -1045,7 +1045,7 @@ static void i915_max_source_size_test(data_t *d)
> >>   
> >>   		igt_create_fb(d->drm_fd, 5120, 4320,
> >>   			      DRM_FORMAT_XRGB8888,
> >> -			      DRM_FORMAT_MOD_NONE,
> >> +			      DRM_FORMAT_MOD_LINEAR,
> >>   			      &fb);
> >>   	}
> >>   
> >> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> >> index ad199915b..d2a6503e5 100644
> >> --- a/tests/kms_prime.c
> >> +++ b/tests/kms_prime.c
> >> @@ -119,7 +119,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> >>   					      scratch->size, PROT_WRITE);
> >>   	} else {
> >>   		igt_calc_fb_size(exporter_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888,
> >> -				 DRM_FORMAT_MOD_NONE, &scratch->size, &scratch->pitch);
> >> +				 DRM_FORMAT_MOD_LINEAR, &scratch->size, &scratch->pitch);
> >>   		if (gem_has_lmem(exporter_fd))
> >>   			scratch->handle = gem_create_in_memory_regions(exporter_fd, scratch->size,
> >>   								       REGION_LMEM(0), REGION_SMEM);
> >> diff --git a/tests/kms_scaling_modes.c b/tests/kms_scaling_modes.c
> >> index 039e4a8d9..b17d00230 100644
> >> --- a/tests/kms_scaling_modes.c
> >> +++ b/tests/kms_scaling_modes.c
> >> @@ -49,11 +49,11 @@ static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe
> >>   	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
> >>   
> >>   	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
> >> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
> >> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
> >>   			    0.f, 0.f, 1.f, &blue);
> >>   
> >>   	igt_create_color_fb(display->drm_fd, 640, 480,
> >> -			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
> >> +			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
> >>   			    1.f, 0.f, 0.f, &red);
> >>   
> >>   	igt_plane_set_fb(primary, &blue);
> >> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
> >> index dd8fa1937..d38886f39 100644
> >> --- a/tests/kms_universal_plane.c
> >> +++ b/tests/kms_universal_plane.c
> >> @@ -613,7 +613,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >>   	/* Black background FB */
> >>   	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> >>   			    DRM_FORMAT_XRGB8888,
> >> -			    false,
> >> +			    DRM_FORMAT_MOD_LINEAR,
> >>   			    0.0, 0.0, 0.0,
> >>   			    &background_fb);
> >>   
> >> @@ -624,7 +624,7 @@ cursor_leak_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> >>   		b = rand() % 0xFF;
> >>   		igt_create_color_fb(data->drm_fd, 64, 64,
> >>   				    DRM_FORMAT_ARGB8888,
> >> -				    false,
> >> +				    DRM_FORMAT_MOD_LINEAR,
> >>   				    (double)r / 0xFF,
> >>   				    (double)g / 0xFF,
> >>   				    (double)b / 0xFF,
> >> -- 
> >> 2.39.1
> > 

-- 
Ville Syrjälä
Intel

[igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier
URL   : https://patchwork.freedesktop.org/series/115032/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/828234 for the overview.

test:ninja-test has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/37958112):
  

test:ninja-test-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/37958113):
  

test:ninja-test-minimal has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/37958118):

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/828234

[igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)
URL   : https://patchwork.freedesktop.org/series/115032/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/828254 for the overview.

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/37954598):
  Preparing environment
  Running on runner-bhfwdbbc-project-3185-concurrent-0 via fdo-equinix-m3l-16...
  section_end:1678687847:prepare_script
  section_start:1678687847:get_sources
  Getting source from Git repository
  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  Checking out a320b928 as detached HEAD (ref is intel/IGTPW_8593)...
  
  Skipping Git submodules setup
  section_end:1678687848:get_sources
  section_start:1678687848:step_script
  Executing "step_script" stage of the job script
  Using docker image sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-fedora:commit-a320b9288c46479a30230a3b46fb4ffd52e35c3c with digest registry.freedesktop.org/gfx-ci/igt-ci-tags/build-fedora@sha256:17d64607d998df2bf29a56b88922d3a598e6f1daa3b51ece2a892c2f293daf83 ...
  section_end:1678687848:step_script
  section_start:1678687848:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1678687849:cleanup_file_variables
  ERROR: Job failed (system failure): Error response from daemon: no such image: docker.io/library/sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f: image not known (docker.go:534:0s)

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/37954600):
  Preparing environment
  Running on runner-bhfwdbbc-project-3185-concurrent-1 via fdo-equinix-m3l-16...
  section_end:1678687846:prepare_script
  section_start:1678687846:get_sources
  Getting source from Git repository
  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  Checking out a320b928 as detached HEAD (ref is intel/IGTPW_8593)...
  
  Skipping Git submodules setup
  section_end:1678687848:get_sources
  section_start:1678687848:step_script
  Executing "step_script" stage of the job script
  Using docker image sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-fedora:commit-a320b9288c46479a30230a3b46fb4ffd52e35c3c with digest registry.freedesktop.org/gfx-ci/igt-ci-tags/build-fedora@sha256:17d64607d998df2bf29a56b88922d3a598e6f1daa3b51ece2a892c2f293daf83 ...
  section_end:1678687848:step_script
  section_start:1678687848:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1678687849:cleanup_file_variables
  ERROR: Job failed (system failure): Error response from daemon: no such image: docker.io/library/sha256:4b3054d89ef79f9be95501786fbbbe22857d02c867fff99693808cd80909939f: image not known (docker.go:534:0s)

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/828254

[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 23595 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms: Cleanup to use linear modifier (rev2)
URL   : https://patchwork.freedesktop.org/series/115032/
State : success

== Summary ==

CI Bug Log - changes from IGT_7191_full -> IGTPW_8593_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html

Participating hosts (8 -> 8)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in IGTPW_8593_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][1] -> [FAIL][2] ([i915#2842])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-apl:          [PASS][3] -> [FAIL][4] ([i915#2842])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_lmem_swapping@heavy-verify-random-ccs:
    - shard-apl:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl3/igt@gem_lmem_swapping@heavy-verify-random-ccs.html

  * igt@gem_pread@exhaustion:
    - shard-apl:          NOTRUN -> [WARN][6] ([i915#2658])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl6/igt@gem_pread@exhaustion.html

  * igt@i915_hwmon@hwmon-read:
    - shard-glk:          NOTRUN -> [SKIP][7] ([fdo#109271])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-glk8/igt@i915_hwmon@hwmon-read.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][8] -> [FAIL][9] ([i915#4275])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl4/igt@i915_pm_dc@dc9-dpms.html

  * igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][11] -> [FAIL][12] ([i915#2346])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@vc4/vc4_perfmon@create-single-perfmon:
    - shard-apl:          NOTRUN -> [SKIP][13] ([fdo#109271]) +27 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl2/igt@vc4/vc4_perfmon@create-single-perfmon.html

  
#### Possible fixes ####

  * igt@api_intel_bb@object-reloc-keep-cache:
    - {shard-rkl}:        [SKIP][14] ([i915#3281]) -> [PASS][15] +9 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-2/igt@api_intel_bb@object-reloc-keep-cache.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-5/igt@api_intel_bb@object-reloc-keep-cache.html

  * igt@drm_fdinfo@idle@rcs0:
    - {shard-rkl}:        [FAIL][16] ([i915#7742]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-1/igt@drm_fdinfo@idle@rcs0.html

  * igt@drm_read@invalid-buffer:
    - {shard-tglu}:       [SKIP][18] ([i915#1845]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-tglu-6/igt@drm_read@invalid-buffer.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-tglu-3/igt@drm_read@invalid-buffer.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-rkl}:        [FAIL][20] ([i915#6268]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_ctx_persistence@engines-hang@bcs0:
    - {shard-rkl}:        [SKIP][22] ([i915#6252]) -> [PASS][23] +2 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-2/igt@gem_ctx_persistence@engines-hang@bcs0.html

  * igt@gem_exec_endless@dispatch@bcs0:
    - {shard-rkl}:        [SKIP][24] ([i915#6247]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-1/igt@gem_exec_endless@dispatch@bcs0.html

  * igt@gem_mmap_wc@set-cache-level:
    - {shard-tglu}:       [SKIP][26] ([i915#1850]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-tglu-6/igt@gem_mmap_wc@set-cache-level.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-tglu-3/igt@gem_mmap_wc@set-cache-level.html

  * igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
    - {shard-rkl}:        [SKIP][28] ([i915#3282]) -> [PASS][29] +5 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-apl:          [ABORT][30] ([i915#5566]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-apl7/igt@gen9_exec_parse@allowed-all.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl4/igt@gen9_exec_parse@allowed-all.html

  * igt@gen9_exec_parse@unaligned-jump:
    - {shard-rkl}:        [SKIP][32] ([i915#2527]) -> [PASS][33] +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-1/igt@gen9_exec_parse@unaligned-jump.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-5/igt@gen9_exec_parse@unaligned-jump.html

  * igt@i915_pm_dc@dc9-dpms:
    - {shard-rkl}:        [SKIP][34] ([i915#4281]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-3/igt@i915_pm_dc@dc9-dpms.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - {shard-dg1}:        [SKIP][36] ([i915#1397]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-dg1-13/igt@i915_pm_rpm@modeset-lpsp.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_suspend@fence-restore-untiled:
    - {shard-rkl}:        [FAIL][38] ([fdo#103375]) -> [PASS][39] +1 similar issue
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-4/igt@i915_suspend@fence-restore-untiled.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-1/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
    - {shard-tglu}:       [SKIP][40] ([i915#1845] / [i915#7651]) -> [PASS][41] +11 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-tglu-6/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-tglu-5/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs:
    - {shard-rkl}:        [SKIP][42] ([i915#1845] / [i915#4098]) -> [PASS][43] +21 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-2/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-glk:          [FAIL][44] ([i915#2346]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [FAIL][46] ([i915#2346]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
    - {shard-rkl}:        [SKIP][48] ([i915#1849] / [i915#4098]) -> [PASS][49] +10 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - {shard-tglu}:       [SKIP][50] ([i915#1849]) -> [PASS][51] +3 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-tglu-7/igt@kms_frontbuffer_tracking@fbc-1p-rte.html

  * igt@kms_plane@pixel-format@pipe-b-planes:
    - {shard-rkl}:        [SKIP][52] ([i915#1849]) -> [PASS][53] +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-4/igt@kms_plane@pixel-format@pipe-b-planes.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-6/igt@kms_plane@pixel-format@pipe-b-planes.html

  * igt@kms_psr@sprite_plane_onoff:
    - {shard-rkl}:        [SKIP][54] ([i915#1072]) -> [PASS][55] +1 similar issue
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-3/igt@kms_psr@sprite_plane_onoff.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html

  * igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
    - {shard-tglu}:       [SKIP][56] ([fdo#109274]) -> [PASS][57] +1 similar issue
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-tglu-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-tglu-7/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html

  * igt@kms_universal_plane@universal-plane-pipe-b-functional:
    - {shard-rkl}:        [SKIP][58] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-b-functional.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-b-functional.html

  * igt@kms_vblank@pipe-a-accuracy-idle:
    - shard-glk:          [FAIL][60] ([i915#43]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-glk5/igt@kms_vblank@pipe-a-accuracy-idle.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-glk2/igt@kms_vblank@pipe-a-accuracy-idle.html

  * igt@prime_vgem@basic-write:
    - {shard-rkl}:        [SKIP][62] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-4/igt@prime_vgem@basic-write.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-5/igt@prime_vgem@basic-write.html

  * igt@prime_vgem@coherency-gtt:
    - {shard-rkl}:        [SKIP][64] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7191/shard-rkl-3/igt@prime_vgem@coherency-gtt.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/shard-rkl-5/igt@prime_vgem@coherency-gtt.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
  [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
  [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
  [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7191 -> IGTPW_8593

  CI-20190529: 20190529
  CI_DRM_12842: a8c602a36e7019429967251dd72737795ee130aa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8593: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html
  IGT_7191: a6766ee8a971366299671b06af8febc8192c0f74 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8593/index.html

[-- Attachment #2: Type: text/html, Size: 17908 bytes --]