Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory()
Date: Tue, 4 Apr 2023 15:11:43 -0700	[thread overview]
Message-ID: <ZCygn7zOgqdKPzHL@nvishwa1-DESK> (raw)
In-Reply-To: <20230404120042.146323-1-matthew.auld@intel.com>

On Tue, Apr 04, 2023 at 01:00:41PM +0100, Matthew Auld wrote:
>It looks like this is meant to return VRAM if supported. If we call this
>on igpu it should return zero. There is at least one user relying on
>this in xe_mmap@vram, where we want to skip if the mask here is zero.
>

Below patch was sent before, but never got merged.
https://patchwork.freedesktop.org/series/115409/

There are some minor differences. Can you pick those
changes?

Also, cover letter seems to be missing for this series.
Or, we can simple merge them into a single patch as they
are related?

Niranjana

>Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
>Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>Cc: Matthew Brost <matthew.brost@intel.com>
>---
> lib/xe/xe_query.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
>index 24a258a5e..253164d6b 100644
>--- a/lib/xe/xe_query.c
>+++ b/lib/xe/xe_query.c
>@@ -380,7 +380,7 @@ uint64_t vram_memory(int fd, int gt)
> 	igt_assert(xe_dev);
> 	igt_assert(gt >= 0 && gt < xe_dev->number_gt);
>
>-	return native_region_for_gt(xe_dev->gts, gt);
>+	return native_region_for_gt(xe_dev->gts, gt) & (~0x1);
> }
>
> /**
>-- 
>2.39.2
>

  parent reply	other threads:[~2023-04-04 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
2023-04-04 12:00 ` [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible() Matthew Auld
2023-04-04 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory() Patchwork
2023-04-04 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-04 22:11 ` Niranjana Vishwanathapura [this message]
2023-04-05 13:26   ` [igt-dev] [PATCH i-g-t 1/2] " Matthew Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCygn7zOgqdKPzHL@nvishwa1-DESK \
    --to=niranjana.vishwanathapura@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox