* [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson
@ 2023-05-15 16:39 Kamil Konieczny
2023-05-15 17:32 ` Petri Latvala
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Kamil Konieczny @ 2023-05-15 16:39 UTC (permalink / raw)
To: igt-dev
Old meson 0.47.2 do not support dictionary adding so fix
testplan building.
Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
docs/testplan/meson.build | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
index 2014f91b5..6454f2933 100644
--- a/docs/testplan/meson.build
+++ b/docs/testplan/meson.build
@@ -27,12 +27,15 @@ xe_test_dict = {
'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
}
-test_dict = {
+if build_xe
+ test_dict = {
+ 'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
+ 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
+ }
+else
+ test_dict = {
'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
}
-
-if build_xe
- test_dict += xe_test_dict
endif
foreach testplan, fields: test_dict
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson 2023-05-15 16:39 [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson Kamil Konieczny @ 2023-05-15 17:32 ` Petri Latvala 2023-05-15 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Petri Latvala @ 2023-05-15 17:32 UTC (permalink / raw) To: Kamil Konieczny; +Cc: igt-dev On Mon, May 15, 2023 at 06:39:08PM +0200, Kamil Konieczny wrote: > Old meson 0.47.2 do not support dictionary adding so fix > testplan building. > > Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> > Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> Acked-by: Petri Latvala <adrinael@adrinael.net> > --- > docs/testplan/meson.build | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build > index 2014f91b5..6454f2933 100644 > --- a/docs/testplan/meson.build > +++ b/docs/testplan/meson.build > @@ -27,12 +27,15 @@ xe_test_dict = { > 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > } > > -test_dict = { > +if build_xe > + test_dict = { > + 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }, > + 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > + } > +else > + test_dict = { > 'kms_tests': { 'input': kms_test_config, 'extra_args': [] } > } > - > -if build_xe > - test_dict += xe_test_dict > endif > > foreach testplan, fields: test_dict > -- > 2.39.2 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for meson: fix testplan building for old meson 2023-05-15 16:39 [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson Kamil Konieczny 2023-05-15 17:32 ` Petri Latvala @ 2023-05-15 17:33 ` Patchwork 2023-05-15 22:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-16 6:42 ` [igt-dev] [PATCH i-g-t] " Mauro Carvalho Chehab 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2023-05-15 17:33 UTC (permalink / raw) To: Kamil Konieczny; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 11030 bytes --] == Series Details == Series: meson: fix testplan building for old meson URL : https://patchwork.freedesktop.org/series/117780/ State : success == Summary == CI Bug Log - changes from CI_DRM_13148 -> IGTPW_8961 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html Participating hosts (36 -> 35) ------------------------------ Additional (1): fi-apl-guc Missing (2): fi-snb-2520m bat-mtlp-6 Known issues ------------ Here are the changes found in IGTPW_8961 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - bat-adls-5: NOTRUN -> [SKIP][1] ([i915#7456]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@debugfs_test@basic-hwmon.html * igt@fbdev@eof: - bat-adls-5: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@fbdev@eof.html * igt@gem_exec_suspend@basic-s0@smem: - fi-rkl-11600: [PASS][3] -> [FAIL][4] ([fdo#103375] / [i915#8011]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/fi-rkl-11600/igt@gem_exec_suspend@basic-s0@smem.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/fi-rkl-11600/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_lmem_swapping@basic: - fi-apl-guc: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/fi-apl-guc/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@random-engines: - bat-adls-5: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@gem_lmem_swapping@random-engines.html * igt@gem_tiled_pread_basic: - bat-adls-5: NOTRUN -> [SKIP][7] ([i915#3282]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - bat-adls-5: NOTRUN -> [SKIP][8] ([i915#7561]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@i915_pm_backlight@basic-brightness.html * igt@i915_pm_backlight@basic-brightness@edp-1: - bat-rplp-1: NOTRUN -> [ABORT][9] ([i915#7077]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html * igt@i915_selftest@live@guc: - bat-rpls-2: NOTRUN -> [DMESG-WARN][10] ([i915#7852]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rpls-2/igt@i915_selftest@live@guc.html * igt@i915_selftest@live@hangcheck: - bat-adls-5: NOTRUN -> [DMESG-WARN][11] ([i915#5591]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@basic-s2idle-without-i915: - bat-rpls-2: NOTRUN -> [ABORT][12] ([i915#6687]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html * igt@kms_chamelium_hpd@vga-hpd-fast: - bat-adls-5: NOTRUN -> [SKIP][13] ([i915#7828]) +8 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_chamelium_hpd@vga-hpd-fast.html - fi-apl-guc: NOTRUN -> [SKIP][14] ([fdo#109271]) +20 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/fi-apl-guc/igt@kms_chamelium_hpd@vga-hpd-fast.html * igt@kms_flip@basic-flip-vs-wf_vblank: - bat-adls-5: NOTRUN -> [SKIP][15] ([i915#3637]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_flip@basic-flip-vs-wf_vblank.html * igt@kms_force_connector_basic@force-load-detect: - bat-adls-5: NOTRUN -> [SKIP][16] ([fdo#109285]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@basic: - bat-adls-5: NOTRUN -> [SKIP][17] ([i915#1849]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@read-crc-frame-sequence: - bat-adls-5: NOTRUN -> [SKIP][18] ([i915#1845]) +15 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html * igt@kms_psr@primary_mmap_gtt: - bat-rplp-1: NOTRUN -> [SKIP][19] ([i915#1072]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html * igt@kms_psr@sprite_plane_onoff: - bat-adls-5: NOTRUN -> [SKIP][20] ([i915#1072]) +3 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-rplp-1: NOTRUN -> [SKIP][21] ([i915#3555] / [i915#4579]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html - bat-adls-5: NOTRUN -> [SKIP][22] ([i915#3555] / [i915#4579]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@kms_setmode@basic-clone-single-crtc.html - fi-apl-guc: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4579]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/fi-apl-guc/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-adls-5: NOTRUN -> [SKIP][24] ([fdo#109295] / [i915#1845]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-read: - bat-adls-5: NOTRUN -> [SKIP][25] ([fdo#109295] / [i915#3291]) +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@prime_vgem@basic-read.html #### Possible fixes #### * igt@i915_module_load@load: - bat-adls-5: [ABORT][26] -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-adls-5/igt@i915_module_load@load.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-adls-5/igt@i915_module_load@load.html * igt@i915_selftest@live@requests: - {bat-mtlp-8}: [ABORT][28] ([i915#4983] / [i915#7920] / [i915#7953]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-mtlp-8/igt@i915_selftest@live@requests.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-mtlp-8/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@reset: - bat-rpls-2: [ABORT][30] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rpls-2/igt@i915_selftest@live@reset.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rpls-2/igt@i915_selftest@live@reset.html * igt@i915_selftest@live@slpc: - bat-rpls-1: [DMESG-WARN][32] ([i915#6367] / [i915#7953]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rpls-1/igt@i915_selftest@live@slpc.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rpls-1/igt@i915_selftest@live@slpc.html * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1: - bat-dg2-8: [FAIL][34] ([i915#7932]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html #### Warnings #### * igt@kms_psr@sprite_plane_onoff: - bat-rplp-1: [ABORT][36] ([i915#8442]) -> [SKIP][37] ([i915#1072]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 [i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920 [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932 [i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7290 -> IGTPW_8961 CI-20190529: 20190529 CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8961: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html IGT_7290: 0261157319fe993ccefaf270b2fc7a8ebef418ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html [-- Attachment #2: Type: text/html, Size: 13081 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for meson: fix testplan building for old meson 2023-05-15 16:39 [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson Kamil Konieczny 2023-05-15 17:32 ` Petri Latvala 2023-05-15 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-05-15 22:30 ` Patchwork 2023-05-16 6:42 ` [igt-dev] [PATCH i-g-t] " Mauro Carvalho Chehab 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2023-05-15 22:30 UTC (permalink / raw) To: Kamil Konieczny; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 15532 bytes --] == Series Details == Series: meson: fix testplan building for old meson URL : https://patchwork.freedesktop.org/series/117780/ State : success == Summary == CI Bug Log - changes from CI_DRM_13148_full -> IGTPW_8961_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in IGTPW_8961_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_lmem_swapping@smem-oom: - shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk9/igt@gem_lmem_swapping@smem-oom.html * igt@gem_pwrite@basic-exhaustion: - shard-glk: NOTRUN -> [WARN][4] ([i915#2658]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk4/igt@gem_pwrite@basic-exhaustion.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [PASS][5] -> [ABORT][6] ([i915#5566]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-glk7/igt@gen9_exec_parse@allowed-single.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk8/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_rps@reset: - shard-snb: [PASS][7] -> [INCOMPLETE][8] ([i915#7790]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-snb5/igt@i915_pm_rps@reset.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-snb2/igt@i915_pm_rps@reset.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-180: - shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271]) +42 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk4/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html * igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886]) +3 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk1/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-4_tiled_dg2_mc_ccs: - shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271]) +4 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-apl4/igt@kms_ccs@pipe-b-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode: - shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579]) +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html * igt@kms_psr2_su@page_flip-nv12: - shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#658]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk5/igt@kms_psr2_su@page_flip-nv12.html * igt@kms_vblank@pipe-a-accuracy-idle: - shard-glk: [PASS][14] -> [FAIL][15] ([i915#43]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-glk3/igt@kms_vblank@pipe-a-accuracy-idle.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk1/igt@kms_vblank@pipe-a-accuracy-idle.html * igt@v3d/v3d_wait_bo@bad-pad: - shard-snb: NOTRUN -> [SKIP][16] ([fdo#109271]) +26 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-snb2/igt@v3d/v3d_wait_bo@bad-pad.html #### Possible fixes #### * igt@drm_fdinfo@most-busy-check-all@rcs0: - {shard-rkl}: [FAIL][17] ([i915#7742]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html * igt@gem_ctx_exec@basic-nohangcheck: - {shard-tglu}: [FAIL][19] ([i915#6268]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-tglu-6/igt@gem_ctx_exec@basic-nohangcheck.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-tglu-7/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_lmem_swapping@smem-oom@lmem0: - {shard-dg1}: [DMESG-WARN][21] ([i915#4936] / [i915#5493]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-dg1-12/igt@gem_lmem_swapping@smem-oom@lmem0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - {shard-rkl}: [SKIP][23] ([i915#1397]) -> [PASS][24] +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-rkl-3/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@i915_suspend@basic-s2idle-without-i915: - shard-snb: [ABORT][25] ([i915#4528] / [i915#8213]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-snb5/igt@i915_suspend@basic-s2idle-without-i915.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-snb7/igt@i915_suspend@basic-s2idle-without-i915.html * igt@i915_suspend@basic-s3-without-i915: - {shard-rkl}: [FAIL][27] ([fdo#103375]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-rkl-7/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][29] ([i915#2346]) -> [PASS][30] +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [FAIL][31] ([i915#4767]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1: - shard-glk: [FAIL][33] ([i915#79]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html * igt@perf@stress-open-close@0-rcs0: - shard-glk: [ABORT][35] ([i915#5213] / [i915#7941]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13148/shard-glk8/igt@perf@stress-open-close@0-rcs0.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/shard-glk3/igt@perf@stress-open-close@0-rcs0.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941 [i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953 [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234 [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292 [i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7290 -> IGTPW_8961 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_13148: 57a535e042517014a85f33be6fa5ed22145c56e9 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8961: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html IGT_7290: 0261157319fe993ccefaf270b2fc7a8ebef418ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8961/index.html [-- Attachment #2: Type: text/html, Size: 11584 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson 2023-05-15 16:39 [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson Kamil Konieczny ` (2 preceding siblings ...) 2023-05-15 22:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2023-05-16 6:42 ` Mauro Carvalho Chehab 2023-05-16 13:30 ` Petri Latvala 3 siblings, 1 reply; 6+ messages in thread From: Mauro Carvalho Chehab @ 2023-05-16 6:42 UTC (permalink / raw) To: Kamil Konieczny; +Cc: igt-dev Hi Kamil, On Mon, 15 May 2023 18:39:08 +0200 Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote: > Old meson 0.47.2 do not support dictionary adding so fix > testplan building. > > Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> > Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> > --- > docs/testplan/meson.build | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build > index 2014f91b5..6454f2933 100644 > --- a/docs/testplan/meson.build > +++ b/docs/testplan/meson.build > @@ -27,12 +27,15 @@ xe_test_dict = { > 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > } > > -test_dict = { > +if build_xe > + test_dict = { > + 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }, > + 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > + } > +else > + test_dict = { > 'kms_tests': { 'input': kms_test_config, 'extra_args': [] } > } This would mean that, for every new driver with documentation we'll need two changes. It would be even harder if we ever need to add options to control other driver builds. Btw, I double-checked that, with meson, we can't update the directory with something like: xe_tests = { 'input': xe_test_config, 'extra_args': check_testlist } test_dict['xe_tests'] = xe_tests As this would generate this error: ../docs/testplan/meson.build:33:1: ERROR: Assignment target must be an id. test_dict['xe_tests'] = xe_tests ^ According to [1]: "All objects are immutable, you can not change the contents of them. You can only create new ones. (which is what += does behind the scenes)." [1] https://github.com/mesonbuild/meson/issues/3931#issuecomment-407180830 On other words, with version < 0.48, we're stuck with data or code duplication. So, IMO, we should: 1. Change the gitlab's "build:tests-fedora-oldest-meson" pipeline to honor the minimal version from meson.build file, e. g.: $ MESON_MIN_VERSION=$(perl -ne "print \$1 if (m/meson_version\s*:\s*'([^']+)/)" meson.build) $ echo $MESON_MIN_VERSION >=0.47.2 2. Update the minimal version to at least 0.48. Yet, if there are strong reasons why keeping support for such old version, feel free to add my ack: Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> # if we can't update meson_version to at least >= 0.48 Regards, Mauro ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson 2023-05-16 6:42 ` [igt-dev] [PATCH i-g-t] " Mauro Carvalho Chehab @ 2023-05-16 13:30 ` Petri Latvala 0 siblings, 0 replies; 6+ messages in thread From: Petri Latvala @ 2023-05-16 13:30 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: igt-dev On Tue, May 16, 2023 at 08:42:41AM +0200, Mauro Carvalho Chehab wrote: > Hi Kamil, > > On Mon, 15 May 2023 18:39:08 +0200 > Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote: > > > Old meson 0.47.2 do not support dictionary adding so fix > > testplan building. > > > > Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> > > Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> > > --- > > docs/testplan/meson.build | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build > > index 2014f91b5..6454f2933 100644 > > --- a/docs/testplan/meson.build > > +++ b/docs/testplan/meson.build > > @@ -27,12 +27,15 @@ xe_test_dict = { > > 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > > } > > > > -test_dict = { > > +if build_xe > > + test_dict = { > > + 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }, > > + 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist } > > + } > > +else > > + test_dict = { > > 'kms_tests': { 'input': kms_test_config, 'extra_args': [] } > > } > > This would mean that, for every new driver with documentation we'll > need two changes. It would be even harder if we ever need to add options > to control other driver builds. > > Btw, I double-checked that, with meson, we can't update the directory > with something like: > > xe_tests = { 'input': xe_test_config, 'extra_args': check_testlist } > test_dict['xe_tests'] = xe_tests > > As this would generate this error: > > ../docs/testplan/meson.build:33:1: ERROR: Assignment target must be an id. > test_dict['xe_tests'] = xe_tests > ^ > > According to [1]: > > "All objects are immutable, you can not change the contents > of them. You can only create new ones. > (which is what += does behind the scenes)." > > [1] https://github.com/mesonbuild/meson/issues/3931#issuecomment-407180830 > > On other words, with version < 0.48, we're stuck with data or code > duplication. > > So, IMO, we should: > > 1. Change the gitlab's "build:tests-fedora-oldest-meson" pipeline > to honor the minimal version from meson.build file, e. g.: > > $ MESON_MIN_VERSION=$(perl -ne "print \$1 if (m/meson_version\s*:\s*'([^']+)/)" meson.build) > $ echo $MESON_MIN_VERSION > >=0.47.2 > > 2. Update the minimal version to at least 0.48. > > Yet, if there are strong reasons why keeping support for such old version, > feel free to add my ack: > > Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> # if we can't update meson_version to at least >= 0.48 The ideal fix for this is indeed bumping the minimum required version to the oldest that's in Ubuntu LTS / Debian Stable / etc. However that requires changing the docker image building in gitlab-CI to use the new version and no one has had time to look into why any changes there break all kinds of stuff. In other words: Not impossible, just not possible quickly. -- Petri Latvala ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-16 13:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-15 16:39 [igt-dev] [PATCH i-g-t] meson: fix testplan building for old meson Kamil Konieczny 2023-05-15 17:32 ` Petri Latvala 2023-05-15 17:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2023-05-15 22:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-16 6:42 ` [igt-dev] [PATCH i-g-t] " Mauro Carvalho Chehab 2023-05-16 13:30 ` Petri Latvala
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox