* [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init
@ 2023-06-06 21:29 Umesh Nerlige Ramappa
2023-06-06 22:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-06-06 21:29 UTC (permalink / raw)
To: Tvrtko Ursulin, Ashutosh Dixit, igt-dev
When run as a regular user, we see an assert instead of a proper error
message. Propagate errors correctly to caller.
Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/139
Fixes: (c67825ba40de: intel_gpu_top: Determine number of tiles)
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tools/intel_gpu_top.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7018499c..24fba88b 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -536,7 +536,7 @@ static void imc_reads_open(struct pmu_counter *pmu, struct engines *engines)
imc_open(pmu, "data_reads", engines);
}
-static int get_num_gts(uint64_t type)
+static int get_num_gts(uint64_t type, int *num_gts)
{
int fd, cnt;
@@ -548,11 +548,13 @@ static int get_num_gts(uint64_t type)
close(fd);
}
- assert(!errno || errno == ENOENT);
+ if (errno && errno != ENOENT)
+ return fd;
+
assert(cnt > 0);
- errno = 0;
+ *num_gts = cnt;
- return cnt;
+ return 0;
}
static void init_aggregate_counters(struct engines *engines)
@@ -578,12 +580,14 @@ static void init_aggregate_counters(struct engines *engines)
static int pmu_init(struct engines *engines)
{
unsigned int i;
- int fd;
+ int fd, ret;
uint64_t type = igt_perf_type_id(engines->device);
engines->fd = -1;
engines->num_counters = 0;
- engines->num_gts = get_num_gts(type);
+ ret = get_num_gts(type, &engines->num_gts);
+ if (ret)
+ return ret;
engines->irq.config = I915_PMU_INTERRUPTS;
fd = _open_pmu(type, engines->num_counters, &engines->irq, engines->fd);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_top: Return the error to the caller of pmu_init
2023-06-06 21:29 [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init Umesh Nerlige Ramappa
@ 2023-06-06 22:13 ` Patchwork
2023-06-07 8:10 ` [igt-dev] [PATCH] " Kamil Konieczny
2023-06-07 13:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-06 22:13 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5572 bytes --]
== Series Details ==
Series: tools/intel_gpu_top: Return the error to the caller of pmu_init
URL : https://patchwork.freedesktop.org/series/118973/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13238 -> IGTPW_9122
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
Participating hosts (41 -> 38)
------------------------------
Missing (3): bat-rpls-2 fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in IGTPW_9122 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][3] -> [ABORT][4] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/bat-rpls-1/igt@i915_selftest@live@reset.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][5] ([i915#7828])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-adlm-1: NOTRUN -> [SKIP][6] ([i915#7828])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-adlm-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][7] -> [FAIL][8] ([i915#7932])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-adlm-1: NOTRUN -> [SKIP][9] ([i915#1845])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-adlm-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [ABORT][10] ([i915#7913] / [i915#7979]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@workarounds:
- bat-adlm-1: [INCOMPLETE][12] ([i915#4983] / [i915#7677]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/bat-adlm-1/igt@i915_selftest@live@workarounds.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-adlm-1/igt@i915_selftest@live@workarounds.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5:
- {bat-adlp-11}: [ABORT][14] -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9122
CI-20190529: 20190529
CI_DRM_13238: 8c0b302811d744b945dcb6d78164a76188914db9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9122: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@i915_pm_freq_api@freq-suspend
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
[-- Attachment #2: Type: text/html, Size: 5970 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init
2023-06-06 21:29 [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init Umesh Nerlige Ramappa
2023-06-06 22:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-07 8:10 ` Kamil Konieczny
2023-06-07 20:45 ` Umesh Nerlige Ramappa
2023-06-07 13:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Kamil Konieczny @ 2023-06-07 8:10 UTC (permalink / raw)
To: igt-dev
On 2023-06-06 at 21:29:30 +0000, Umesh Nerlige Ramappa wrote:
> When run as a regular user, we see an assert instead of a proper error
> message. Propagate errors correctly to caller.
>
> Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/139
- ^
Maybe Closes: ?
> Fixes: (c67825ba40de: intel_gpu_top: Determine number of tiles)
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> tools/intel_gpu_top.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 7018499c..24fba88b 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -536,7 +536,7 @@ static void imc_reads_open(struct pmu_counter *pmu, struct engines *engines)
> imc_open(pmu, "data_reads", engines);
> }
>
> -static int get_num_gts(uint64_t type)
> +static int get_num_gts(uint64_t type, int *num_gts)
> {
> int fd, cnt;
>
> @@ -548,11 +548,13 @@ static int get_num_gts(uint64_t type)
>
> close(fd);
> }
> - assert(!errno || errno == ENOENT);
> + if (errno && errno != ENOENT)
> + return fd;
What happens for ENOENT ?
Regards,
Kamil
> +
> assert(cnt > 0);
> - errno = 0;
> + *num_gts = cnt;
>
> - return cnt;
> + return 0;
> }
>
> static void init_aggregate_counters(struct engines *engines)
> @@ -578,12 +580,14 @@ static void init_aggregate_counters(struct engines *engines)
> static int pmu_init(struct engines *engines)
> {
> unsigned int i;
> - int fd;
> + int fd, ret;
> uint64_t type = igt_perf_type_id(engines->device);
>
> engines->fd = -1;
> engines->num_counters = 0;
> - engines->num_gts = get_num_gts(type);
> + ret = get_num_gts(type, &engines->num_gts);
> + if (ret)
> + return ret;
>
> engines->irq.config = I915_PMU_INTERRUPTS;
> fd = _open_pmu(type, engines->num_counters, &engines->irq, engines->fd);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tools/intel_gpu_top: Return the error to the caller of pmu_init
2023-06-06 21:29 [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init Umesh Nerlige Ramappa
2023-06-06 22:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-07 8:10 ` [igt-dev] [PATCH] " Kamil Konieczny
@ 2023-06-07 13:08 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-07 13:08 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 16437 bytes --]
== Series Details ==
Series: tools/intel_gpu_top: Return the error to the caller of pmu_init
URL : https://patchwork.freedesktop.org/series/118973/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13238_full -> IGTPW_9122_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_9122_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_9122_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9122_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_timelines:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-glk3/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-glk5/igt@i915_selftest@live@gt_timelines.html
Known issues
------------
Here are the changes found in IGTPW_9122_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-hang:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-snb2/igt@gem_ctx_persistence@engines-hang.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][6] -> [ABORT][7] ([i915#5566])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-glk8/igt@gen9_exec_parse@allowed-single.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-glk4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4579]) +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-snb2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_rc_ccs:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +56 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-snb6/igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_rc_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][12] ([i915#7461] / [i915#8234]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-dg1-18/igt@gem_barrier_race@remote-request@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-dg1-15/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][14] ([i915#6786]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-dg1-16/igt@gem_ctx_freq@sysfs.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-dg1-18/igt@gem_ctx_freq@sysfs.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][16] ([i915#2846]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][20] ([i915#2842]) -> [PASS][21] +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][22] ([i915#2842]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-rkl-7/igt@gem_exec_fair@basic-throttle@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-rkl-7/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@i915_module_load@reload:
- shard-snb: [ABORT][24] ([i915#4528]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-snb5/igt@i915_module_load@reload.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-snb6/igt@i915_module_load@reload.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][26] ([fdo#109271]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][28] ([i915#3591]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][30] ([i915#1397]) -> [PASS][31] +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-dg1-17/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- {shard-rkl}: [SKIP][32] ([i915#1397]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-rkl-2/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][34] ([i915#7790]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-snb1/igt@i915_pm_rps@reset.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-snb5/igt@i915_pm_rps@reset.html
* igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-dg1}: [INCOMPLETE][36] ([i915#8011] / [i915#8347]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-dg1-19/igt@kms_cursor_legacy@forked-move@pipe-b.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-dg1-17/igt@kms_cursor_legacy@forked-move@pipe-b.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][38] ([i915#4767]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
#### Warnings ####
* igt@kms_content_protection@lic@pipe-a-dp-1:
- shard-apl: [TIMEOUT][40] ([i915#7173]) -> [FAIL][41] ([i915#7173])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13238/shard-apl3/igt@kms_content_protection@lic@pipe-a-dp-1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/shard-apl2/igt@kms_content_protection@lic@pipe-a-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9122
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13238: 8c0b302811d744b945dcb6d78164a76188914db9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9122: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9122/index.html
[-- Attachment #2: Type: text/html, Size: 12160 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init
2023-06-07 8:10 ` [igt-dev] [PATCH] " Kamil Konieczny
@ 2023-06-07 20:45 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 5+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-06-07 20:45 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Tvrtko Ursulin, Ashutosh Dixit
On Wed, Jun 07, 2023 at 10:10:51AM +0200, Kamil Konieczny wrote:
>On 2023-06-06 at 21:29:30 +0000, Umesh Nerlige Ramappa wrote:
>> When run as a regular user, we see an assert instead of a proper error
>> message. Propagate errors correctly to caller.
>>
>> Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/139
>- ^
>Maybe Closes: ?
right. I get confused often on this. Will change to Closes.
>
>> Fixes: (c67825ba40de: intel_gpu_top: Determine number of tiles)
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> ---
>> tools/intel_gpu_top.c | 16 ++++++++++------
>> 1 file changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 7018499c..24fba88b 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -536,7 +536,7 @@ static void imc_reads_open(struct pmu_counter *pmu, struct engines *engines)
>> imc_open(pmu, "data_reads", engines);
>> }
>>
>> -static int get_num_gts(uint64_t type)
>> +static int get_num_gts(uint64_t type, int *num_gts)
>> {
>> int fd, cnt;
>>
>> @@ -548,11 +548,13 @@ static int get_num_gts(uint64_t type)
>>
>> close(fd);
>> }
>> - assert(!errno || errno == ENOENT);
>> + if (errno && errno != ENOENT)
>> + return fd;
>
>What happens for ENOENT ?
KMD implements the frequency event only for available GTs and returns an
ENOENT if user passes an event that is not available.
ENOENT is used to dynamically determine how many GTs there are.
This resolves the bug, but ideally, I think the original message that
was printed by intel_gpu_top stating that CAP_PERFMON is required should
check for EPERM, but I am looking for more comments on that.
Regards,
Umesh
>
>Regards,
>Kamil
>
>> +
>> assert(cnt > 0);
>> - errno = 0;
>> + *num_gts = cnt;
>>
>> - return cnt;
>> + return 0;
>> }
>>
>> static void init_aggregate_counters(struct engines *engines)
>> @@ -578,12 +580,14 @@ static void init_aggregate_counters(struct engines *engines)
>> static int pmu_init(struct engines *engines)
>> {
>> unsigned int i;
>> - int fd;
>> + int fd, ret;
>> uint64_t type = igt_perf_type_id(engines->device);
>>
>> engines->fd = -1;
>> engines->num_counters = 0;
>> - engines->num_gts = get_num_gts(type);
>> + ret = get_num_gts(type, &engines->num_gts);
>> + if (ret)
>> + return ret;
>>
>> engines->irq.config = I915_PMU_INTERRUPTS;
>> fd = _open_pmu(type, engines->num_counters, &engines->irq, engines->fd);
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-07 20:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-06 21:29 [igt-dev] [PATCH] tools/intel_gpu_top: Return the error to the caller of pmu_init Umesh Nerlige Ramappa
2023-06-06 22:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-07 8:10 ` [igt-dev] [PATCH] " Kamil Konieczny
2023-06-07 20:45 ` Umesh Nerlige Ramappa
2023-06-07 13:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox