Re: [igt-dev] [PATCH i-g-t 2/4] lib/igt_sysfs: Don't assert in igt_sysfs_dir_id_to_name

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

On Mon, Jun 05, 2023 at 06:21:48PM -0700, Ashutosh Dixit wrote:
>Old platforms (BLB/ELK) don't have any freq attributes even in legacy
>per-device sysfs. Asserting for this platforms shows up as a CI
>regression. So don't assert, just return the device level attribute and let
>file open on the non-existent attribute fail to preserve previous behavior.
>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>---
> lib/igt_sysfs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
>index 8021ba9cbb2e..35a4faa9aab5 100644
>--- a/lib/igt_sysfs.c
>+++ b/lib/igt_sysfs.c
>@@ -115,10 +115,8 @@ const char *igt_sysfs_dir_id_to_name(int dir, enum i915_attr_id id)
>
> 	if (igt_sysfs_has_attr(dir, i915_attr_name[RPS][id]))
> 		return i915_attr_name[RPS][id];
>-	if (igt_sysfs_has_attr(dir, i915_attr_name[GT][id]))
>-		return i915_attr_name[GT][id];
>
>-	igt_assert_f(0, "attr_id not found %d\n", id);
>+	return i915_attr_name[GT][id];

lgtm,

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

> }
>
> /**
>-- 
>2.38.0
>