Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array()
Date: Thu, 15 Jun 2023 21:37:30 +0000	[thread overview]
Message-ID: <ZIuEmrfWr/4xbiqk@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20230615213622.24857-1-niranjana.vishwanathapura@intel.com>

On Thu, Jun 15, 2023 at 02:36:22PM -0700, Niranjana Vishwanathapura wrote:
> Initialize bind_ops array to 0 in test_bind_array() function.
> 
> This addresses the vm_bind ioctl failure with below dmesg error.
> "[drm] Ioctl argument check failed at drivers/gpu/drm/xe/xe_vm.c:2955: (*bind_ops)[i].pad"
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  tests/xe/xe_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c
> index 861822b48..819dbaab7 100644
> --- a/tests/xe/xe_vm.c
> +++ b/tests/xe/xe_vm.c
> @@ -875,7 +875,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
>  	};
>  	uint32_t engine, bind_engine = 0;
>  #define BIND_ARRAY_MAX_N_EXEC	16
> -	struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC];
> +	struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC] = { };
>  	size_t bo_size;
>  	uint32_t bo = 0;
>  	struct {
> -- 
> 2.21.0.rc0.32.g243a4c7e27
> 

  reply	other threads:[~2023-06-15 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 21:36 [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array() Niranjana Vishwanathapura
2023-06-15 21:37 ` Matthew Brost [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-15 22:07 Niranjana Vishwanathapura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIuEmrfWr/4xbiqk@DUT025-TGLU.fm.intel.com \
    --to=matthew.brost@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=niranjana.vishwanathapura@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox