* [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array()
@ 2023-06-15 21:36 Niranjana Vishwanathapura
2023-06-15 21:37 ` Matthew Brost
0 siblings, 1 reply; 3+ messages in thread
From: Niranjana Vishwanathapura @ 2023-06-15 21:36 UTC (permalink / raw)
To: igt-dev
Initialize bind_ops array to 0 in test_bind_array() function.
This addresses the vm_bind ioctl failure with below dmesg error.
"[drm] Ioctl argument check failed at drivers/gpu/drm/xe/xe_vm.c:2955: (*bind_ops)[i].pad"
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
tests/xe/xe_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c
index 861822b48..819dbaab7 100644
--- a/tests/xe/xe_vm.c
+++ b/tests/xe/xe_vm.c
@@ -875,7 +875,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
};
uint32_t engine, bind_engine = 0;
#define BIND_ARRAY_MAX_N_EXEC 16
- struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC];
+ struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC] = { };
size_t bo_size;
uint32_t bo = 0;
struct {
--
2.21.0.rc0.32.g243a4c7e27
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array()
2023-06-15 21:36 [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array() Niranjana Vishwanathapura
@ 2023-06-15 21:37 ` Matthew Brost
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Brost @ 2023-06-15 21:37 UTC (permalink / raw)
To: Niranjana Vishwanathapura; +Cc: igt-dev
On Thu, Jun 15, 2023 at 02:36:22PM -0700, Niranjana Vishwanathapura wrote:
> Initialize bind_ops array to 0 in test_bind_array() function.
>
> This addresses the vm_bind ioctl failure with below dmesg error.
> "[drm] Ioctl argument check failed at drivers/gpu/drm/xe/xe_vm.c:2955: (*bind_ops)[i].pad"
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> tests/xe/xe_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c
> index 861822b48..819dbaab7 100644
> --- a/tests/xe/xe_vm.c
> +++ b/tests/xe/xe_vm.c
> @@ -875,7 +875,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
> };
> uint32_t engine, bind_engine = 0;
> #define BIND_ARRAY_MAX_N_EXEC 16
> - struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC];
> + struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC] = { };
> size_t bo_size;
> uint32_t bo = 0;
> struct {
> --
> 2.21.0.rc0.32.g243a4c7e27
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array()
@ 2023-06-15 22:07 Niranjana Vishwanathapura
0 siblings, 0 replies; 3+ messages in thread
From: Niranjana Vishwanathapura @ 2023-06-15 22:07 UTC (permalink / raw)
To: igt-dev
Initialize bind_ops array to 0 in test_bind_array() function.
This addresses the vm_bind ioctl failure with below dmesg error.
"[drm] Ioctl argument check failed at drivers/gpu/drm/xe/xe_vm.c:2955: (*bind_ops)[i].pad"
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
tests/xe/xe_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c
index 861822b48..819dbaab7 100644
--- a/tests/xe/xe_vm.c
+++ b/tests/xe/xe_vm.c
@@ -875,7 +875,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
};
uint32_t engine, bind_engine = 0;
#define BIND_ARRAY_MAX_N_EXEC 16
- struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC];
+ struct drm_xe_vm_bind_op bind_ops[BIND_ARRAY_MAX_N_EXEC] = { };
size_t bo_size;
uint32_t bo = 0;
struct {
--
2.21.0.rc0.32.g243a4c7e27
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-15 22:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 21:36 [igt-dev] [PATCH i-g-t] tests/xe/xe_vm: Initialize variable in test_bind_array() Niranjana Vishwanathapura
2023-06-15 21:37 ` Matthew Brost
-- strict thread matches above, loose matches on Subject: below --
2023-06-15 22:07 Niranjana Vishwanathapura
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox