Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 6/9] intel/gem_compute: Add test which runs compute workload on i915
Date: Fri, 8 Sep 2023 11:15:46 +0200	[thread overview]
Message-ID: <ZPrmQvmQGuRjn3DN@fdugast-desk.home> (raw)
In-Reply-To: <20230905133309.365109-7-zbigniew.kempczynski@intel.com>

On Tue, Sep 05, 2023 at 03:33:06PM +0200, Zbigniew Kempczyński wrote:
> This test is verbatim copy of xe_compute with driver open exception
> (it opens i915 drm fd instead xe). Technically it is possible to
> create single test code (open would try DEVICE_INTEL | DEVICE_XE)
> but I resisted to that distinguishing i915 and xe version.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Christoph Manszewski <christoph.manszewski@intel.com>
> Cc: Francois Dugast <francois.dugast@intel.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  tests/intel/gem_compute.c | 46 +++++++++++++++++++++++++++++++++++++++
>  tests/meson.build         |  1 +
>  2 files changed, 47 insertions(+)
>  create mode 100644 tests/intel/gem_compute.c
> 
> diff --git a/tests/intel/gem_compute.c b/tests/intel/gem_compute.c
> new file mode 100644
> index 0000000000..b408efee16
> --- /dev/null
> +++ b/tests/intel/gem_compute.c
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +/**
> + * TEST: Check compute-related functionality
> + * Category: Hardware building block
> + * Sub-category: compute
> + * Test category: functionality test
> + * Run type: BAT
> + */
> +
> +#include <string.h>
> +
> +#include "igt.h"
> +#include "intel_compute.h"
> +
> +/**
> + * SUBTEST: compute-square
> + * GPU requirement: only works on TGL
> + * Description:
> + *	Run an openCL Kernel that returns output[i] = input[i] * input[i],
> + *	for an input dataset..
> + * Functionality: compute openCL kernel
> + * TODO: extend test to cover other platforms
> + */
> +static void
> +test_compute_square(int fd)
> +{
> +	igt_require_f(run_compute_kernel(fd), "GPU not supported\n");
> +}
> +
> +igt_main
> +{
> +	int i915;
> +
> +	igt_fixture
> +		i915 = drm_open_driver(DRIVER_INTEL);
> +
> +	igt_subtest("compute-square")
> +		test_compute_square(i915);
> +
> +	igt_fixture
> +		drm_close_driver(i915);
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index aa8e3434ce..03bb7785c3 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -105,6 +105,7 @@ intel_i915_progs = [
>  	'gem_ccs',
>  	'gem_close',
>  	'gem_close_race',
> +	'gem_compute',
>  	'gem_concurrent_blit',
>  	'gem_cs_tlb',
>  	'gem_ctx_bad_destroy',
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-09-08  9:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 13:33 [igt-dev] [PATCH i-g-t v2 0/9] Extend compute square to i915 and Xe Zbigniew Kempczyński
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 1/9] lib/intel_compute: Migrate xe_compute library to intel_compute Zbigniew Kempczyński
2023-09-06 16:42   ` Kamil Konieczny
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 2/9] lib/intel_compute: Add compatibility flags for running compute Zbigniew Kempczyński
2023-09-08  9:03   ` Francois Dugast
2023-09-08 11:07     ` Zbigniew Kempczyński
2023-09-08 11:29     ` Mauro Carvalho Chehab
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 3/9] lib/intel_compute: Reorganize the code for i915 version preparation Zbigniew Kempczyński
2023-09-08  9:05   ` Francois Dugast
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 4/9] lib/intel_compute: Add name field for debugging purposes Zbigniew Kempczyński
2023-09-08  9:05   ` Francois Dugast
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 5/9] lib/intel_compute: Add i915 path in compute library Zbigniew Kempczyński
2023-09-08  9:13   ` Francois Dugast
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 6/9] intel/gem_compute: Add test which runs compute workload on i915 Zbigniew Kempczyński
2023-09-08  9:15   ` Francois Dugast [this message]
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 7/9] lib/intel_compute: Add XeHP implementation of compute pipeline Zbigniew Kempczyński
2023-09-08 13:55   ` Francois Dugast
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 8/9] lib/intel_compute: Adding pvc compute pipeline implementation Zbigniew Kempczyński
2023-09-08 13:56   ` Francois Dugast
2023-09-05 13:33 ` [igt-dev] [PATCH i-g-t v2 9/9] tests/gem|xe_compute: Update documentation regarding test requirements Zbigniew Kempczyński
2023-09-08 13:56   ` Francois Dugast
2023-09-05 18:23 ` [igt-dev] ✗ Fi.CI.BAT: failure for Extend compute square to i915 and Xe (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPrmQvmQGuRjn3DN@fdugast-desk.home \
    --to=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox