Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH 1/2] xe_exec_threads: Use DRM_XE_VM_CREATE_COMPUTE_MODE when creating a compute VM
Date: Wed, 13 Sep 2023 15:05:54 -0700	[thread overview]
Message-ID: <ZQIyQraq5sRTzH8m@nvishwa1-DESK> (raw)
In-Reply-To: <20230912234954.2110973-2-matthew.brost@intel.com>

On Tue, Sep 12, 2023 at 04:49:53PM -0700, Matthew Brost wrote:
>XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE was used creating a compute VM.
>This just happened to work as it is same value as
>DRM_XE_VM_CREATE_COMPUTE_MODE. Fix this and use correct flag,
>DRM_XE_VM_CREATE_COMPUTE_MODE.
>

Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

>Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>---
> tests/intel/xe_exec_threads.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tests/intel/xe_exec_threads.c b/tests/intel/xe_exec_threads.c
>index ae4da0568a..34bcb3d4d5 100644
>--- a/tests/intel/xe_exec_threads.c
>+++ b/tests/intel/xe_exec_threads.c
>@@ -286,7 +286,7 @@ test_compute_mode(int fd, uint32_t vm, uint64_t addr, uint64_t userptr,
>
> 	if (!vm) {
> 		vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS |
>-				  XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, 0);
>+				  DRM_XE_VM_CREATE_COMPUTE_MODE, 0);
> 		owns_vm = true;
> 	}
>
>@@ -1075,7 +1075,7 @@ static void threads(int fd, int flags)
> 					      to_user_pointer(&ext));
> 		vm_compute_mode = xe_vm_create(fd,
> 					       DRM_XE_VM_CREATE_ASYNC_BIND_OPS |
>-					       XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE,
>+					       DRM_XE_VM_CREATE_COMPUTE_MODE,
> 					       0);
>
> 		vm_err_thread.capture = &capture;
>-- 
>2.34.1
>

  reply	other threads:[~2023-09-13 22:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 23:49 [igt-dev] [PATCH 0/2] Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from Xe uAPI Matthew Brost
2023-09-12 23:49 ` [igt-dev] [PATCH 1/2] xe_exec_threads: Use DRM_XE_VM_CREATE_COMPUTE_MODE when creating a compute VM Matthew Brost
2023-09-13 22:05   ` Niranjana Vishwanathapura [this message]
2023-09-12 23:49 ` [igt-dev] [PATCH 2/2] xe: Update uAPI and remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE Matthew Brost
2023-09-13 22:06   ` Niranjana Vishwanathapura
2023-09-14 10:54     ` Francois Dugast
2023-09-13  0:40 ` [igt-dev] ✓ Fi.CI.BAT: success for Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from Xe uAPI Patchwork
2023-09-13  1:09 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-09-13  1:54 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQIyQraq5sRTzH8m@nvishwa1-DESK \
    --to=niranjana.vishwanathapura@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox