Re: [PATCH i-g-t 03/28] lib/xe/oa: Add OA LNL metrics (oa_lnl.xml)

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

On Thu, Jun 20, 2024 at 01:00:28PM -0700, Ashutosh Dixit wrote:
>$ mdapi-xml-convert.py --guids=guids.xml MetricsXML_P31.xml > oa-lnl.xml
>
>Note: The metrics XML's consist of (a) the registers (in this case NOA or
>mux registers) to be programmed (b) the metrics themselves which specify
>how the counters in the reports should be combined to construct the
>metrics.  The changes in mdapi-xml-convert.py in this patch completely
>ignore (b) since they are not relevant for IGT. (a) is needed for IGT LNL
>OAG uses "576B_PEC64LL" format which is not available on previous platforms
>so we cannot use metrics for a previous platform such as MTL to generate
>LNL OAG data.
>
>Note: LNL media guids had issues after running mdapi-convert-xml.py so have
>not been added, revisit this.
>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

>---
> lib/xe/oa-configs/mdapi-xml-convert.py |   25 +
> lib/xe/oa-configs/oa-lnl.xml           | 2799 ++++++++++++++++++++++++
> 2 files changed, 2824 insertions(+)
> create mode 100644 lib/xe/oa-configs/oa-lnl.xml
>
>diff --git a/lib/xe/oa-configs/mdapi-xml-convert.py b/lib/xe/oa-configs/mdapi-xml-convert.py
>index 5903ef4d35..ab4747ddd1 100755
>--- a/lib/xe/oa-configs/mdapi-xml-convert.py
>+++ b/lib/xe/oa-configs/mdapi-xml-convert.py
>@@ -149,6 +149,21 @@ mtl_chipset_oam_samedia_params = {
>     }
> }
>
>+# FIXME: everything except oa_report_size is incorrect here
>+xe2_chipset_params = {
>+    'a_offset': 16,
>+    'b_offset': 192,
>+    'c_offset': 224,
>+    'oa_report_size': 576,
>+    'config_reg_blacklist': {
>+        0x2364, # OACTXID
>+    },
>+    'register_offsets': {
>+        0x1b0: 'PERFCNT 0',
>+        0x1b8: 'PERFCNT 1',
>+    }
>+}
>+
...