Re: [PATCH i-g-t 05/28] lib/xe/oa: Generate LNL metrics/registers files

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 20 Jun 2024 14:52:51 -0700, Umesh Nerlige Ramappa wrote:
>
> On Thu, Jun 20, 2024 at 01:00:30PM -0700, Ashutosh Dixit wrote:
> > @@ -138,9 +138,22 @@ def generate_metric_sets(args, gen):
> >                     metric_set->c_offset = metric_set->b_offset + 8;
> >                     metric_set->perfcnt_offset = metric_set->c_offset + 8;
> >                 """))
> > +        elif gen.chipset == "lnl":
> > +            c(textwrap.dedent("""\
> > +                metric_set->perf_oa_format = XE_OA_FORMAT_PEC64u64;
> > +
> > +                metric_set->perf_raw_size = 576;
> > +                metric_set->gpu_time_offset = 0;
> > +                metric_set->gpu_clock_offset = 1;
> > +                metric_set->a_offset = 2;
> > +                // metric_set->b_offset = metric_set->a_offset + 38;
> > +                // metric_set->c_offset = metric_set->b_offset + 8;
>
> Above 2 lines can be dropped if unused
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Jose has added a 4 patches to the series. The patch
"xe/oa/oa-metricset-codegen: Fix XE_OA_FORMAT_PEC64u64 offsets" deletes
these lines, so maybe ok to leave as is. Thanks.