Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/intel/xe_create: Remove the elapsed time validation
@ 2024-08-01 12:33 Balasubramani Vivekanandan
  2024-08-01 14:30 ` ✓ CI.xeBAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Balasubramani Vivekanandan @ 2024-08-01 12:33 UTC (permalink / raw)
  To: igt-dev; +Cc: Balasubramani Vivekanandan

Time check used is incorrect. Time limit used for validation is
arbitrarily chosen as 5 seconds with no real resoning behind it.
With different execution environments taking different execution times,
limit can't be fixed and leads to unnecessary hacks.
So remove this time check completely.

Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
---
 tests/intel/xe_create.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
index 76ffdcef2..80de07789 100644
--- a/tests/intel/xe_create.c
+++ b/tests/intel/xe_create.c
@@ -157,7 +157,6 @@ enum vm_count {
 };
 
 #define MAXEXECQUEUES 2048
-#define MAXTIME 5
 
 /**
  * SUBTEST: create-execqueues-%s
@@ -175,10 +174,8 @@ enum vm_count {
 static void create_execqueues(int fd, enum exec_queue_destroy ed,
 			      enum vm_count vc)
 {
-	struct timespec tv = { };
 	uint32_t num_engines, exec_queues_per_process, vm;
-	int nproc = sysconf(_SC_NPROCESSORS_ONLN), seconds;
-	int real_timeout = MAXTIME * (vc == SHARED ? 4 : 1);
+	int nproc = sysconf(_SC_NPROCESSORS_ONLN);
 
 	if (vc == SHARED) {
 		fd = drm_reopen_driver(fd);
@@ -189,8 +186,6 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed,
 	exec_queues_per_process = max_t(uint32_t, 1, MAXEXECQUEUES / nproc);
 	igt_debug("nproc: %u, exec_queues per process: %u\n", nproc, exec_queues_per_process);
 
-	igt_nsec_elapsed(&tv);
-
 	igt_fork(n, nproc) {
 		struct drm_xe_engine *engine;
 		uint32_t exec_queue, exec_queues[exec_queues_per_process];
@@ -236,16 +231,6 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed,
 		xe_vm_destroy(fd, vm);
 		drm_close_driver(fd);
 	}
-
-	seconds = igt_seconds_elapsed(&tv);
-	if (seconds > real_timeout) {
-		if (igt_run_in_simulation())
-			igt_info("Creating %d exec_queues took too long: %d [limit: %d] seconds\n",
-				 MAXEXECQUEUES, seconds, real_timeout);
-		else
-			igt_assert_f(false, "Creating %d exec_queues took too long: %d [limit: %d] seconds\n",
-				     MAXEXECQUEUES, seconds, real_timeout);
-	}
 }
 
 /**
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-08-05  8:35 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 12:33 [PATCH] tests/intel/xe_create: Remove the elapsed time validation Balasubramani Vivekanandan
2024-08-01 14:30 ` ✓ CI.xeBAT: success for " Patchwork
2024-08-01 14:46 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-01 16:15 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-05  8:34   ` Vivekanandan, Balasubramani
2024-08-02  5:12 ` [PATCH] " Zbigniew Kempczyński
2024-08-02  9:13   ` Vivekanandan, Balasubramani
2024-08-05  7:12     ` Zbigniew Kempczyński
2024-08-02  7:52 ` ✗ Fi.CI.IGT: failure for " Patchwork
2024-08-05  8:32   ` Vivekanandan, Balasubramani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox