From: Andi Shyti <andi.shyti@linux.intel.com>
To: Peter Senna Tschudin <peter.senna@linux.intel.com>
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org,
"Andi Shyti" <andi.shyti@linux.intel.com>
Subject: Re: [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro
Date: Tue, 13 Aug 2024 21:51:40 +0200 [thread overview]
Message-ID: <Zru5TDSV47bEHjmo@ashyti-mobl2.lan> (raw)
In-Reply-To: <e53f5016-c1ea-4401-91e2-efd025bde585@linux.intel.com>
Hi Peter and Zbigniew,
On Tue, Aug 13, 2024 at 04:12:30PM +0200, Peter Senna Tschudin wrote:
> On 13.08.2024 15:56, Zbigniew Kempczyński wrote:
> > On Tue, Aug 13, 2024 at 03:36:50PM +0200, Peter Senna Tschudin wrote:
> >> Please do not apply this patch. I am working on a proper fix.
> >
> > Applying fix stops you from working on a your fix?
>
> Please do not fix a pothole just before I replace the road.
The patch is correct and Zbigniew's fix looks straight forward.
What is your fix aiming at? Can it go on top of this one?
Andi
next prev parent reply other threads:[~2024-08-13 19:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 12:45 [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro Zbigniew Kempczyński
2024-08-13 13:00 ` ✗ GitLab.Pipeline: warning for " Patchwork
2024-08-13 13:13 ` ✗ CI.xeBAT: failure " Patchwork
2024-08-13 13:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-13 13:36 ` [PATCH i-g-t] " Peter Senna Tschudin
2024-08-13 13:56 ` Zbigniew Kempczyński
2024-08-13 14:12 ` Peter Senna Tschudin
2024-08-13 19:51 ` Andi Shyti [this message]
2024-08-14 7:11 ` Peter Senna Tschudin
2024-08-14 9:34 ` Andi Shyti
2024-08-13 14:55 ` ✗ CI.xeBAT: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-13 15:06 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-13 16:18 ` ✗ CI.xeFULL: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro Patchwork
2024-08-14 8:52 ` Zbigniew Kempczyński
2024-08-13 17:14 ` ✗ CI.xeFULL: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-13 19:49 ` ✓ Fi.CI.IGT: success for lib|tests: Don't dereference engine outside for_each_ctx_engine macro Patchwork
2024-08-13 22:49 ` ✗ Fi.CI.IGT: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-14 8:50 ` Zbigniew Kempczyński
2024-08-14 7:10 ` [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zru5TDSV47bEHjmo@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=peter.senna@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox