From: Andi Shyti <andi.shyti@linux.intel.com>
To: Peter Senna Tschudin <peter.senna@linux.intel.com>
Cc: "Andi Shyti" <andi.shyti@linux.intel.com>,
"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro
Date: Wed, 14 Aug 2024 11:34:09 +0200 [thread overview]
Message-ID: <Zrx6Ed0gjy2AU6Nf@ashyti-mobl2.lan> (raw)
In-Reply-To: <b2fba84c-281e-4d0c-ae4f-0e5542a0de19@linux.intel.com>
Hi Peter,
On Wed, Aug 14, 2024 at 09:11:22AM +0200, Peter Senna Tschudin wrote:
> On 13.08.2024 21:51, Andi Shyti wrote:
> > On Tue, Aug 13, 2024 at 04:12:30PM +0200, Peter Senna Tschudin wrote:
> >> On 13.08.2024 15:56, Zbigniew Kempczyński wrote:
> >>> On Tue, Aug 13, 2024 at 03:36:50PM +0200, Peter Senna Tschudin wrote:
> >>>> Please do not apply this patch. I am working on a proper fix.
> >>>
> >>> Applying fix stops you from working on a your fix?
> >>
> >> Please do not fix a pothole just before I replace the road.
> >
> > The patch is correct and Zbigniew's fix looks straight forward.
> >
> > What is your fix aiming at? Can it go on top of this one?
>
> Please ignore this. I have reviewed and compile tested the patch. Sorry for the noise.
if you have more fixes, please send them.
I was the originator of the for_each_ctx_engine() and I knew that
it was a big monster that needed some cleanups.
Thanks,
Andi
next prev parent reply other threads:[~2024-08-14 9:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 12:45 [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro Zbigniew Kempczyński
2024-08-13 13:00 ` ✗ GitLab.Pipeline: warning for " Patchwork
2024-08-13 13:13 ` ✗ CI.xeBAT: failure " Patchwork
2024-08-13 13:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-13 13:36 ` [PATCH i-g-t] " Peter Senna Tschudin
2024-08-13 13:56 ` Zbigniew Kempczyński
2024-08-13 14:12 ` Peter Senna Tschudin
2024-08-13 19:51 ` Andi Shyti
2024-08-14 7:11 ` Peter Senna Tschudin
2024-08-14 9:34 ` Andi Shyti [this message]
2024-08-13 14:55 ` ✗ CI.xeBAT: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-13 15:06 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-13 16:18 ` ✗ CI.xeFULL: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro Patchwork
2024-08-14 8:52 ` Zbigniew Kempczyński
2024-08-13 17:14 ` ✗ CI.xeFULL: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-13 19:49 ` ✓ Fi.CI.IGT: success for lib|tests: Don't dereference engine outside for_each_ctx_engine macro Patchwork
2024-08-13 22:49 ` ✗ Fi.CI.IGT: failure for lib|tests: Don't dereference engine outside for_each_ctx_engine macro (rev2) Patchwork
2024-08-14 8:50 ` Zbigniew Kempczyński
2024-08-14 7:10 ` [PATCH i-g-t] lib|tests: Don't dereference engine outside for_each_ctx_engine macro Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrx6Ed0gjy2AU6Nf@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=peter.senna@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox