From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Aurabindo Pillai <aurabindo.pillai@amd.com>,
igt-dev@lists.freedesktop.org
Cc: hersenxs.wu@amd.com
Subject: Re: [igt-dev] [PATCH v2 3/3] lib/amdgpu: checkpatch.pl fixes
Date: Tue, 29 Aug 2023 08:37:52 -0600 [thread overview]
Message-ID: <a00653fc-951d-4a68-872e-a6c7848778b0@amd.com> (raw)
In-Reply-To: <20230825135053.196364-3-aurabindo.pillai@amd.com>
On 8/25/23 07:50, Aurabindo Pillai wrote:
> fix checkpatch.pl identified issue: typo and braces
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> lib/igt_amd.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_amd.c b/lib/igt_amd.c
> index b67cc9be0..84c6d7545 100644
> --- a/lib/igt_amd.c
> +++ b/lib/igt_amd.c
> @@ -1154,7 +1154,8 @@ void igt_amd_allow_edp_hotplug_detect(int drm_fd, char *connector_name, bool ena
> close(hpd_fd);
> }
>
> -static bool get_dm_capabilites(int drm_fd, char *buf, size_t size) {
> +static bool get_dm_capabilities(int drm_fd, char *buf, size_t size)
> +{
> int ret, fd;
> bool has_capablities = amd_has_debugfs(drm_fd, DEBUGFS_DM_CAPABILITIES);
>
> @@ -1183,7 +1184,7 @@ static bool get_dm_capabilites(int drm_fd, char *buf, size_t size) {
> *
> * @param drm_fd DRM file descriptor
> * @return true if dm capabilities interface exists and MALL is supported
> - * @return false if capabilites could not be read.
> + * @return false if capabilities could not be read.
> */
> void igt_amd_get_mall_status(int drm_fd, bool *supported, bool *enabled)
> {
> @@ -1193,7 +1194,7 @@ void igt_amd_get_mall_status(int drm_fd, bool *supported, bool *enabled)
> *supported = false;
> *enabled = false;
>
> - if (!get_dm_capabilites(drm_fd, buf, 1024))
> + if (!get_dm_capabilities(drm_fd, buf, 1024))
> return;
>
> mall_loc = strstr(buf, "mall supported: yes");
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
next prev parent reply other threads:[~2023-08-29 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 13:50 [igt-dev] [PATCH v2 1/3] tests/amdgpu/amd_mall: Add crc check Aurabindo Pillai
2023-08-25 13:50 ` [igt-dev] [PATCH v2 2/3] tests/amdgpu/amd_mall: remove UMR dependency Aurabindo Pillai
2023-08-29 14:36 ` Rodrigo Siqueira Jordao
2023-08-25 13:50 ` [igt-dev] [PATCH v2 3/3] lib/amdgpu: checkpatch.pl fixes Aurabindo Pillai
2023-08-29 14:37 ` Rodrigo Siqueira Jordao [this message]
2023-08-25 14:35 ` [igt-dev] ✓ CI.xeBAT: success for series starting with [v2,1/3] tests/amdgpu/amd_mall: Add crc check Patchwork
2023-08-25 14:50 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-08-26 5:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-29 14:27 ` [igt-dev] [PATCH v2 1/3] " Rodrigo Siqueira Jordao
2023-08-29 14:28 ` Rodrigo Siqueira Jordao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a00653fc-951d-4a68-872e-a6c7848778b0@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox