Re: [igt-dev] [PATCH v2 1/3] tests/amdgpu/amd_mall: Add crc check

[Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>]

On 8/25/23 07:50, Aurabindo Pillai wrote:
> In addition to checking whether display scanout from MALL cache is
> triggered, double check that the same pattern is being displayed. This
> can detect any corruption due to incorrect MALL size calculations
> 
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>   tests/amdgpu/amd_mall.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/amdgpu/amd_mall.c b/tests/amdgpu/amd_mall.c
> index c50d046ee..6016d5e8c 100644
> --- a/tests/amdgpu/amd_mall.c
> +++ b/tests/amdgpu/amd_mall.c
> @@ -117,6 +117,7 @@ static void test_mall_ss(data_t *data)
>   	igt_fb_t rfb;
>   	int exec_ret;
>   	struct line_check line = {0};
> +	igt_crc_t test_crc, ref_crc;
>   
>   	test_init(data);
>   
> @@ -124,6 +125,7 @@ static void test_mall_ss(data_t *data)
>   	igt_plane_set_fb(data->primary, &rfb);
>   	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
>   
> +	igt_pipe_crc_collect_crc(data->pipe_crc, &ref_crc);
>   	sleep(MALL_SETTLE_DELAY);
>   
>   	igt_system_cmd(exec_ret, "umr -O bits -r *.*.HUBP0_HUBP_MALL_STATUS | grep MALL_IN_USE");
> @@ -135,6 +137,10 @@ static void test_mall_ss(data_t *data)
>   
>   	igt_assert_eq(line.found, 1);
>   
> +	igt_pipe_crc_collect_crc(data->pipe_crc, &test_crc);
> +
> +	igt_assert_crc_equal(&ref_crc, &test_crc);
> +
>   	igt_remove_fb(data->fd, &rfb);
>   	test_fini(data);
>   }

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>