Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH v2 1/3] tests/amdgpu/amd_mall: Add crc check
@ 2023-08-25 13:50 Aurabindo Pillai
  2023-08-25 13:50 ` [igt-dev] [PATCH v2 2/3] tests/amdgpu/amd_mall: remove UMR dependency Aurabindo Pillai
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Aurabindo Pillai @ 2023-08-25 13:50 UTC (permalink / raw)
  To: igt-dev; +Cc: hersenxs.wu

In addition to checking whether display scanout from MALL cache is
triggered, double check that the same pattern is being displayed. This
can detect any corruption due to incorrect MALL size calculations

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 tests/amdgpu/amd_mall.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/amdgpu/amd_mall.c b/tests/amdgpu/amd_mall.c
index c50d046ee..6016d5e8c 100644
--- a/tests/amdgpu/amd_mall.c
+++ b/tests/amdgpu/amd_mall.c
@@ -117,6 +117,7 @@ static void test_mall_ss(data_t *data)
 	igt_fb_t rfb;
 	int exec_ret;
 	struct line_check line = {0};
+	igt_crc_t test_crc, ref_crc;
 
 	test_init(data);
 
@@ -124,6 +125,7 @@ static void test_mall_ss(data_t *data)
 	igt_plane_set_fb(data->primary, &rfb);
 	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 
+	igt_pipe_crc_collect_crc(data->pipe_crc, &ref_crc);
 	sleep(MALL_SETTLE_DELAY);
 
 	igt_system_cmd(exec_ret, "umr -O bits -r *.*.HUBP0_HUBP_MALL_STATUS | grep MALL_IN_USE");
@@ -135,6 +137,10 @@ static void test_mall_ss(data_t *data)
 
 	igt_assert_eq(line.found, 1);
 
+	igt_pipe_crc_collect_crc(data->pipe_crc, &test_crc);
+
+	igt_assert_crc_equal(&ref_crc, &test_crc);
+
 	igt_remove_fb(data->fd, &rfb);
 	test_fini(data);
 }
-- 
2.41.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-08-29 14:37 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 13:50 [igt-dev] [PATCH v2 1/3] tests/amdgpu/amd_mall: Add crc check Aurabindo Pillai
2023-08-25 13:50 ` [igt-dev] [PATCH v2 2/3] tests/amdgpu/amd_mall: remove UMR dependency Aurabindo Pillai
2023-08-29 14:36   ` Rodrigo Siqueira Jordao
2023-08-25 13:50 ` [igt-dev] [PATCH v2 3/3] lib/amdgpu: checkpatch.pl fixes Aurabindo Pillai
2023-08-29 14:37   ` Rodrigo Siqueira Jordao
2023-08-25 14:35 ` [igt-dev] ✓ CI.xeBAT: success for series starting with [v2,1/3] tests/amdgpu/amd_mall: Add crc check Patchwork
2023-08-25 14:50 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-08-26  5:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-29 14:27 ` [igt-dev] [PATCH v2 1/3] " Rodrigo Siqueira Jordao
2023-08-29 14:28 ` Rodrigo Siqueira Jordao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox