Re: [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include

[Aurabindo Pillai <aurabindo.pillai@amd.com>]

On 2023-08-22 16:47, Kamil Konieczny wrote:
> Hi Aurabindo,
> 
> On 2023-08-22 at 16:18:33 -0400, Aurabindo Pillai wrote:
>> Remove the external file include that causes build error
>> on certain systems configured in the CI.
>>
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>> ---
>>   tests/amdgpu/amd_odm.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/amdgpu/amd_odm.c b/tests/amdgpu/amd_odm.c
>> index 2781ad1c2..839f2de3f 100644
>> --- a/tests/amdgpu/amd_odm.c
>> +++ b/tests/amdgpu/amd_odm.c
>> @@ -5,7 +5,6 @@
>>   
>>   #include <fcntl.h>
>>   #include <stdio.h>
>> -#include <xf86drmMode.h>
> 
> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
> Will this test work without xf86drmMode.h?
> If it is kms test you may just include igt_kms.h but first
> apply fix (or revert).

Yes, looks like IGT already includes all the necessary headers.

> 
> Regards,
> Kamil
> 
>>   
>>   #include "igt.h"
>>   #include "igt_amd.h"
>> -- 
>> 2.41.0
>>

-- 
--

Thanks & Regards,
Jay