Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_writeback: fix kms_writeback failure for XRGB8888 only devices
@ 2023-11-30  3:21 Abhinav Kumar
  2023-11-30  4:27 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Abhinav Kumar @ 2023-11-30  3:21 UTC (permalink / raw)
  To: igt-dev; +Cc: petri.latvala, quic_parellan

commit ac56ba97248b ("tests/kms_writeback: support DRM_FORMAT_XRGB2101010
for writeback") seems to have broken kms_writeback for devices which
support only XRGB8888 because check_writeback_config() will return a value
based on the last format in the fourcc[] array.

For devices such as MSM which do not support DRM_FORMAT_XRGB2101010, this
will return an error and overall kms_writeback_get_output() will not
return a valid output for the writeback connector.

Change the return of check_writeback_config() to return based on the
supported_colors bitmask so that only when neither XRGB8888 or
DRM_FORMAT_XRGB2101010 is supported, then the test is skipped.

Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
 tests/kms_writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 25b49eccdbd3..f6e55c809de1 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -171,7 +171,7 @@ static bool check_writeback_config(igt_display_t *display, igt_output_t *output,
 			data.supported_colors |= 1 << i;
 	}
 
-	return !ret;
+	return data.supported_colors;
 }
 
 static igt_output_t *kms_writeback_get_output(igt_display_t *display)
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-12-02 22:55 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30  3:21 [igt-dev] [PATCH i-g-t] tests/kms_writeback: fix kms_writeback failure for XRGB8888 only devices Abhinav Kumar
2023-11-30  4:27 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-11-30  4:34 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-30 14:07   ` Kamil Konieczny
2023-12-01 11:07     ` Illipilli, TejasreeX
2023-11-30  6:27 ` [igt-dev] [PATCH i-g-t] " Alex Hung
2023-11-30 23:10 ` Jessica Zhang
2023-12-01 10:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-12-01 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-12-02 22:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox