[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Swati Sharma]

if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
returns NULL, it leads to seg fault as below:

root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
./tests/kms_big_fb
IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
Max driver framebuffer size 8192x8192
RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
MiB
Received signal SIGSEGV.
Stack trace:
 #0 [fatal_sig_handler+0x77]
 #1 [killpg+0x40]
 #2 [drm_intel_bo_alloc+0x0]
 #3 [intel_batchbuffer_reset+0x33]
 #4 [intel_batchbuffer_alloc+0x34]
 #5 [__real_main603+0x3e9]
 #6 [main+0x23]
 #7 [__libc_start_main+0xf0]
 #8 [_start+0x29]
 #9 [<unknown>+0x29]
Segmentation fault (core dumped)

To prevent this igt_assert() is added for both the functions.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_big_fb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index c3498c6..69061a6 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -648,7 +648,10 @@ igt_main
 			data.render_copy = igt_get_render_copyfunc(data.devid);
 
 		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
+		igt_assert(data.bufmgr);
+
 		data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
+		igt_assert(data.batch);
 	}
 
 	/*
-- 
1.9.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Patchwork]

== Series Details ==

Series: tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage
URL   : https://patchwork.freedesktop.org/series/64904/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6656 -> IGTPW_3325
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/64904/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3325 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_execlists:
    - fi-skl-gvtdvm:      [PASS][1] -> [DMESG-FAIL][2] ([fdo#111108])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][3] -> [FAIL][4] ([fdo#109485])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [INCOMPLETE][5] ([fdo#107718]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live_execlists:
    - fi-bwr-2160:        [DMESG-WARN][7] ([fdo#111115]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-bwr-2160/igt@i915_selftest@live_execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-bwr-2160/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_hangcheck:
    - fi-bwr-2160:        [DMESG-FAIL][9] ([fdo#111115]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-bwr-2160/igt@i915_selftest@live_hangcheck.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-icl-u3:          [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
  [fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115


Participating hosts (55 -> 47)
------------------------------

  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5125 -> IGTPW_3325

  CI-20190529: 20190529
  CI_DRM_6656: 15b120eed3331e5a6614a94159b6fae46fd8f28d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3325: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/
  IGT_5125: 35d81d01b1599b4bc4df0e09e25f6f531eed4f8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Patchwork]

== Series Details ==

Series: tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage
URL   : https://patchwork.freedesktop.org/series/64904/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6656_full -> IGTPW_3325_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3325_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3325_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/64904/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3325_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_schedule@pi-ringfull-bsd:
    - shard-iclb:         [PASS][1] -> [SKIP][2] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb3/igt@gem_exec_schedule@pi-ringfull-bsd.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb1/igt@gem_exec_schedule@pi-ringfull-bsd.html

  
Known issues
------------

  Here are the changes found in IGTPW_3325_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_schedule@deep-bsd:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#111325]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb5/igt@gem_exec_schedule@deep-bsd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb4/igt@gem_exec_schedule@deep-bsd.html

  * igt@i915_hangman@error-state-capture-vcs0:
    - shard-hsw:          [PASS][5] -> [INCOMPLETE][6] ([fdo#103540])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-hsw7/igt@i915_hangman@error-state-capture-vcs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-hsw5/igt@i915_hangman@error-state-capture-vcs0.html

  * igt@i915_pm_rpm@i2c:
    - shard-hsw:          [PASS][7] -> [FAIL][8] ([fdo#104097])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-hsw6/igt@i915_pm_rpm@i2c.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-hsw1/igt@i915_pm_rpm@i2c.html

  * igt@i915_pm_rpm@system-suspend:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#103313] / [fdo#103558] / [fdo#105079] / [fdo#105602])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl4/igt@i915_pm_rpm@system-suspend.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@i915_pm_rpm@system-suspend.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-apl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +4 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl4/igt@i915_suspend@fence-restore-untiled.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl3/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen:
    - shard-iclb:         [PASS][13] -> [INCOMPLETE][14] ([fdo#107713])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103167]) +6 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-kbl:          [PASS][17] -> [INCOMPLETE][18] ([fdo#103665])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-apl:          [PASS][19] -> [FAIL][20] ([fdo#110038])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl4/igt@kms_plane@plane-position-covered-pipe-a-planes.html
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#110038])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl4/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl7/igt@kms_plane@plane-position-covered-pipe-a-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103166])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][27] -> [FAIL][28] ([fdo#99912])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl1/igt@kms_setmode@basic.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl5/igt@kms_setmode@basic.html

  * igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
    - shard-kbl:          [PASS][29] -> [DMESG-WARN][30] ([fdo#103313] / [fdo#103558] / [fdo#105602]) +37 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl4/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html

  * igt@perf_pmu@rc6:
    - shard-kbl:          [PASS][31] -> [SKIP][32] ([fdo#109271])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl2/igt@perf_pmu@rc6.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl1/igt@perf_pmu@rc6.html

  * igt@prime_busy@wait-after-bsd2:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109276]) +11 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb4/igt@prime_busy@wait-after-bsd2.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb8/igt@prime_busy@wait-after-bsd2.html

  
#### Possible fixes ####

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][35] ([fdo#110854]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb8/igt@gem_exec_balancer@smoke.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb1/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_schedule@preempt-other-bsd1:
    - shard-iclb:         [SKIP][37] ([fdo#109276]) -> [PASS][38] +11 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb7/igt@gem_exec_schedule@preempt-other-bsd1.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb4/igt@gem_exec_schedule@preempt-other-bsd1.html

  * igt@gem_exec_schedule@promotion-bsd:
    - shard-iclb:         [SKIP][39] ([fdo#111325]) -> [PASS][40] +4 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb4/igt@gem_exec_schedule@promotion-bsd.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb8/igt@gem_exec_schedule@promotion-bsd.html

  * igt@gem_exec_schedule@semaphore-noskip:
    - shard-iclb:         [FAIL][41] ([fdo#110946]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@gem_exec_schedule@semaphore-noskip.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb7/igt@gem_exec_schedule@semaphore-noskip.html

  * igt@i915_pm_rps@reset:
    - shard-apl:          [FAIL][43] ([fdo#102250]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl1/igt@i915_pm_rps@reset.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl6/igt@i915_pm_rps@reset.html

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
    - shard-kbl:          [FAIL][45] ([fdo#109660]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl7/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl4/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [INCOMPLETE][47] ([fdo#103665]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
    - shard-kbl:          [FAIL][49] ([fdo#103232]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
    - shard-apl:          [FAIL][51] ([fdo#103232]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl5/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html

  * igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge:
    - shard-apl:          [DMESG-WARN][53] ([fdo#111317]) -> [PASS][54] +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl6/igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl4/igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [FAIL][55] ([fdo#103355]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
    - shard-glk:          [FAIL][57] ([fdo#103060]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-glk8/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-glk2/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [FAIL][59] ([fdo#105363]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          [INCOMPLETE][61] ([fdo#105411]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-snb1/igt@kms_flip@flip-vs-suspend.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-snb2/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +5 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [FAIL][65] ([fdo#103167]) -> [PASS][66] +4 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-apl:          [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +2 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_psr@psr2_sprite_mmap_cpu:
    - shard-iclb:         [SKIP][69] ([fdo#109441]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_cpu.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [SKIP][71] ([fdo#109276]) -> [FAIL][72] ([fdo#111329])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_exec_schedule@independent-bsd2:
    - shard-iclb:         [SKIP][73] ([fdo#109276]) -> [FAIL][74] ([fdo#110946])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html

  * igt@gem_mocs_settings@mocs-isolation-bsd2:
    - shard-iclb:         [SKIP][75] ([fdo#109276]) -> [FAIL][76] ([fdo#111330]) +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb7/igt@gem_mocs_settings@mocs-isolation-bsd2.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html

  * igt@gem_mocs_settings@mocs-reset-bsd2:
    - shard-iclb:         [FAIL][77] ([fdo#111330]) -> [SKIP][78] ([fdo#109276])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb6/igt@gem_mocs_settings@mocs-reset-bsd2.html

  * igt@gem_mocs_settings@mocs-settings-bsd2:
    - shard-iclb:         [FAIL][79] -> [SKIP][80] ([fdo#109276])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-iclb2/igt@gem_mocs_settings@mocs-settings-bsd2.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-iclb5/igt@gem_mocs_settings@mocs-settings-bsd2.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
    - shard-kbl:          [SKIP][81] ([fdo#109271]) -> [SKIP][82] ([fdo#105602] / [fdo#109271]) +26 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f:
    - shard-kbl:          [SKIP][83] ([fdo#109271] / [fdo#109278]) -> [SKIP][84] ([fdo#105602] / [fdo#109271] / [fdo#109278]) +3 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-f.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
    - shard-kbl:          [FAIL][85] ([fdo#108145]) -> [DMESG-FAIL][86] ([fdo#103313] / [fdo#103558] / [fdo#105602] / [fdo#108145])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6656/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/shard-kbl2/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html

  
  [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
  [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
  [fdo#111317]: https://bugs.freedesktop.org/show_bug.cgi?id=111317
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5125 -> IGTPW_3325
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_6656: 15b120eed3331e5a6614a94159b6fae46fd8f28d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3325: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/
  IGT_5125: 35d81d01b1599b4bc4df0e09e25f6f531eed4f8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3325/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Ser, Simon]

On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
> if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
> returns NULL, it leads to seg fault as below:
> 
> root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
> ./tests/kms_big_fb
> IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
> Max driver framebuffer size 8192x8192
> RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
> MiB
> Received signal SIGSEGV.
> Stack trace:
>  #0 [fatal_sig_handler+0x77]
>  #1 [killpg+0x40]
>  #2 [drm_intel_bo_alloc+0x0]
>  #3 [intel_batchbuffer_reset+0x33]
>  #4 [intel_batchbuffer_alloc+0x34]
>  #5 [__real_main603+0x3e9]
>  #6 [main+0x23]
>  #7 [__libc_start_main+0xf0]
>  #8 [_start+0x29]
>  #9 [<unknown>+0x29]
> Segmentation fault (core dumped)
> 
> To prevent this igt_assert() is added for both the functions.

I'm not sure I understand why this segfault happens. Seems like
drm_intel_bufmgr_gem_init can return NULL in the following cases:

* No compiled with libdrm_intel support, in which case the tests should
  be skipped
* Allocation failure or pthread mutex failure, which are unlikely to
  happen (but it would be nice to log something when those fail)
* DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
  stderr, it doesn't seem like this is the case here)

Am I missing something?

> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_big_fb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index c3498c6..69061a6 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -648,7 +648,10 @@ igt_main
>  			data.render_copy = igt_get_render_copyfunc(data.devid);
>  
>  		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
> +		igt_assert(data.bufmgr);
> +
>  		data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
> +		igt_assert(data.batch);
>  	}
>  
>  	/*
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Chris Wilson]

Quoting Ser, Simon (2019-08-13 11:28:54)
> On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
> > if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
> > returns NULL, it leads to seg fault as below:
> > 
> > root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
> > ./tests/kms_big_fb
> > IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
> > Max driver framebuffer size 8192x8192
> > RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
> > MiB
> > Received signal SIGSEGV.
> > Stack trace:
> >  #0 [fatal_sig_handler+0x77]
> >  #1 [killpg+0x40]
> >  #2 [drm_intel_bo_alloc+0x0]
> >  #3 [intel_batchbuffer_reset+0x33]
> >  #4 [intel_batchbuffer_alloc+0x34]
> >  #5 [__real_main603+0x3e9]
> >  #6 [main+0x23]
> >  #7 [__libc_start_main+0xf0]
> >  #8 [_start+0x29]
> >  #9 [<unknown>+0x29]
> > Segmentation fault (core dumped)
> > 
> > To prevent this igt_assert() is added for both the functions.
> 
> I'm not sure I understand why this segfault happens. Seems like
> drm_intel_bufmgr_gem_init can return NULL in the following cases:
> 
> * No compiled with libdrm_intel support, in which case the tests should
>   be skipped
> * Allocation failure or pthread mutex failure, which are unlikely to
>   happen (but it would be nice to log something when those fail)
> * DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
>   stderr, it doesn't seem like this is the case here)
> 
> Am I missing something?

Usual cause is unrecognised GPU by libdrm. In which case it should be an
igt_require_f(data.bufmgr, "Update libdrm for %s support\n", intel_chipset_get_name(devid))
Roll that up into an <somename>_wrapper and spread far and wide.
(Although I prefer the option of not using libdrm_intel in the first
place.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Sharma, Swati2]

[-- Attachment #1.1: Type: text/plain, Size: 1966 bytes --]

On 13-Aug-19 4:08 PM, Chris Wilson wrote:
> Quoting Ser, Simon (2019-08-13 11:28:54)
>> On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
>>> if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
>>> returns NULL, it leads to seg fault as below:
>>>
>>> root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
>>> ./tests/kms_big_fb
>>> IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
>>> Max driver framebuffer size 8192x8192
>>> RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
>>> MiB
>>> Received signal SIGSEGV.
>>> Stack trace:
>>>   #0 [fatal_sig_handler+0x77]
>>>   #1 [killpg+0x40]
>>>   #2 [drm_intel_bo_alloc+0x0]
>>>   #3 [intel_batchbuffer_reset+0x33]
>>>   #4 [intel_batchbuffer_alloc+0x34]
>>>   #5 [__real_main603+0x3e9]
>>>   #6 [main+0x23]
>>>   #7 [__libc_start_main+0xf0]
>>>   #8 [_start+0x29]
>>>   #9 [<unknown>+0x29]
>>> Segmentation fault (core dumped)
>>>
>>> To prevent this igt_assert() is added for both the functions.
>> I'm not sure I understand why this segfault happens. Seems like
>> drm_intel_bufmgr_gem_init can return NULL in the following cases:
>>
>> * No compiled with libdrm_intel support, in which case the tests should
>>    be skipped
>> * Allocation failure or pthread mutex failure, which are unlikely to
>>    happen (but it would be nice to log something when those fail)
>> * DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
>>    stderr, it doesn't seem like this is the case here)
>>
>> Am I missing something?
> Usual cause is unrecognised GPU by libdrm. In which case it should be an
> igt_require_f(data.bufmgr, "Update libdrm for %s support\n", intel_chipset_get_name(devid))
> Roll that up into an <somename>_wrapper and spread far and wide.
> (Although I prefer the option of not using libdrm_intel in the first
> place.)
> -Chris
Shouldn't we add igt_assert() and instead add wrapper func to check bufmgr?


-- 
~Swati Sharma


[-- Attachment #1.2: Type: text/html, Size: 2778 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Petri Latvala]

On Wed, Sep 04, 2019 at 01:40:36AM +0530, Sharma, Swati2 wrote:
> On 13-Aug-19 4:08 PM, Chris Wilson wrote:
> > Quoting Ser, Simon (2019-08-13 11:28:54)
> > > On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
> > > > if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
> > > > returns NULL, it leads to seg fault as below:
> > > > 
> > > > root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
> > > > ./tests/kms_big_fb
> > > > IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
> > > > Max driver framebuffer size 8192x8192
> > > > RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
> > > > MiB
> > > > Received signal SIGSEGV.
> > > > Stack trace:
> > > >   #0 [fatal_sig_handler+0x77]
> > > >   #1 [killpg+0x40]
> > > >   #2 [drm_intel_bo_alloc+0x0]
> > > >   #3 [intel_batchbuffer_reset+0x33]
> > > >   #4 [intel_batchbuffer_alloc+0x34]
> > > >   #5 [__real_main603+0x3e9]
> > > >   #6 [main+0x23]
> > > >   #7 [__libc_start_main+0xf0]
> > > >   #8 [_start+0x29]
> > > >   #9 [<unknown>+0x29]
> > > > Segmentation fault (core dumped)
> > > > 
> > > > To prevent this igt_assert() is added for both the functions.
> > > I'm not sure I understand why this segfault happens. Seems like
> > > drm_intel_bufmgr_gem_init can return NULL in the following cases:
> > > 
> > > * No compiled with libdrm_intel support, in which case the tests should
> > >    be skipped
> > > * Allocation failure or pthread mutex failure, which are unlikely to
> > >    happen (but it would be nice to log something when those fail)
> > > * DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
> > >    stderr, it doesn't seem like this is the case here)
> > > 
> > > Am I missing something?
> > Usual cause is unrecognised GPU by libdrm. In which case it should be an
> > igt_require_f(data.bufmgr, "Update libdrm for %s support\n", intel_chipset_get_name(devid))
> > Roll that up into an <somename>_wrapper and spread far and wide.
> > (Although I prefer the option of not using libdrm_intel in the first
> > place.)
> > -Chris
> Shouldn't we add igt_assert() and instead add wrapper func to check bufmgr?

That would lead to fails. The thumb rule is that fails happen from
kernel bugs, skips happen from untestable configurations (hardware &
software). igt_require is more suitable for this.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Sharma, Swati2]

On 04-Sep-19 3:05 PM, Petri Latvala wrote:
> On Wed, Sep 04, 2019 at 01:40:36AM +0530, Sharma, Swati2 wrote:
>> On 13-Aug-19 4:08 PM, Chris Wilson wrote:
>>> Quoting Ser, Simon (2019-08-13 11:28:54)
>>>> On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
>>>>> if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
>>>>> returns NULL, it leads to seg fault as below:
>>>>>
>>>>> root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
>>>>> ./tests/kms_big_fb
>>>>> IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
>>>>> Max driver framebuffer size 8192x8192
>>>>> RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
>>>>> MiB
>>>>> Received signal SIGSEGV.
>>>>> Stack trace:
>>>>>    #0 [fatal_sig_handler+0x77]
>>>>>    #1 [killpg+0x40]
>>>>>    #2 [drm_intel_bo_alloc+0x0]
>>>>>    #3 [intel_batchbuffer_reset+0x33]
>>>>>    #4 [intel_batchbuffer_alloc+0x34]
>>>>>    #5 [__real_main603+0x3e9]
>>>>>    #6 [main+0x23]
>>>>>    #7 [__libc_start_main+0xf0]
>>>>>    #8 [_start+0x29]
>>>>>    #9 [<unknown>+0x29]
>>>>> Segmentation fault (core dumped)
>>>>>
>>>>> To prevent this igt_assert() is added for both the functions.
>>>> I'm not sure I understand why this segfault happens. Seems like
>>>> drm_intel_bufmgr_gem_init can return NULL in the following cases:
>>>>
>>>> * No compiled with libdrm_intel support, in which case the tests should
>>>>     be skipped
>>>> * Allocation failure or pthread mutex failure, which are unlikely to
>>>>     happen (but it would be nice to log something when those fail)
>>>> * DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
>>>>     stderr, it doesn't seem like this is the case here)
>>>>
>>>> Am I missing something?
>>> Usual cause is unrecognised GPU by libdrm. In which case it should be an
>>> igt_require_f(data.bufmgr, "Update libdrm for %s support\n", intel_chipset_get_name(devid))
>>> Roll that up into an <somename>_wrapper and spread far and wide.
>>> (Although I prefer the option of not using libdrm_intel in the first
>>> place.)
>>> -Chris
>> Shouldn't we add igt_assert() and instead add wrapper func to check bufmgr?
> 
> That would lead to fails. The thumb rule is that fails happen from
> kernel bugs, skips happen from untestable configurations (hardware &
> software). igt_require is more suitable for this.
> 
> 
I have one query, why there isn't the generic rule for this. For IGTs
such as gem_write_read_ring_switch, gem_unref_active_buffers, etc we 
have igt_assert() whereas you will find few IGTs like 
gem_unfence_active_buffers, gem_tiled_partial_pwrite_pread, etc which 
doesn't even have igt_assert(). What should be done?

-- 
~Swati Sharma
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add assert for drm_intel_bufmgr and intel_batchbuffer before usage

[Petri Latvala]

On Fri, Sep 06, 2019 at 01:30:45AM +0530, Sharma, Swati2 wrote:
> On 04-Sep-19 3:05 PM, Petri Latvala wrote:
> > On Wed, Sep 04, 2019 at 01:40:36AM +0530, Sharma, Swati2 wrote:
> > > On 13-Aug-19 4:08 PM, Chris Wilson wrote:
> > > > Quoting Ser, Simon (2019-08-13 11:28:54)
> > > > > On Thu, 2019-08-08 at 18:04 +0530, Swati Sharma wrote:
> > > > > > if drm_intel_bufmgr_gem_init() or intel_batchbuffer_alloc()
> > > > > > returns NULL, it leads to seg fault as below:
> > > > > > 
> > > > > > root@testrunner:/home/testrunner/swati/otc_gen_graphics-intel-gpu-tools#
> > > > > > ./tests/kms_big_fb
> > > > > > IGT-Version: 1.24-g976db91 (x86_64) (Linux: 5.1.0-rc6+ x86_64)
> > > > > > Max driver framebuffer size 8192x8192
> > > > > > RAM: 2749 MiB, GPU address space: 134217728 MiB, GGTT mappable size: 256
> > > > > > MiB
> > > > > > Received signal SIGSEGV.
> > > > > > Stack trace:
> > > > > >    #0 [fatal_sig_handler+0x77]
> > > > > >    #1 [killpg+0x40]
> > > > > >    #2 [drm_intel_bo_alloc+0x0]
> > > > > >    #3 [intel_batchbuffer_reset+0x33]
> > > > > >    #4 [intel_batchbuffer_alloc+0x34]
> > > > > >    #5 [__real_main603+0x3e9]
> > > > > >    #6 [main+0x23]
> > > > > >    #7 [__libc_start_main+0xf0]
> > > > > >    #8 [_start+0x29]
> > > > > >    #9 [<unknown>+0x29]
> > > > > > Segmentation fault (core dumped)
> > > > > > 
> > > > > > To prevent this igt_assert() is added for both the functions.
> > > > > I'm not sure I understand why this segfault happens. Seems like
> > > > > drm_intel_bufmgr_gem_init can return NULL in the following cases:
> > > > > 
> > > > > * No compiled with libdrm_intel support, in which case the tests should
> > > > >     be skipped
> > > > > * Allocation failure or pthread mutex failure, which are unlikely to
> > > > >     happen (but it would be nice to log something when those fail)
> > > > > * DRM_IOCTL_I915_GEM_APERTURE fails (but something is printed to
> > > > >     stderr, it doesn't seem like this is the case here)
> > > > > 
> > > > > Am I missing something?
> > > > Usual cause is unrecognised GPU by libdrm. In which case it should be an
> > > > igt_require_f(data.bufmgr, "Update libdrm for %s support\n", intel_chipset_get_name(devid))
> > > > Roll that up into an <somename>_wrapper and spread far and wide.
> > > > (Although I prefer the option of not using libdrm_intel in the first
> > > > place.)
> > > > -Chris
> > > Shouldn't we add igt_assert() and instead add wrapper func to check bufmgr?
> > 
> > That would lead to fails. The thumb rule is that fails happen from
> > kernel bugs, skips happen from untestable configurations (hardware &
> > software). igt_require is more suitable for this.
> > 
> > 
> I have one query, why there isn't the generic rule for this. For IGTs
> such as gem_write_read_ring_switch, gem_unref_active_buffers, etc we have
> igt_assert() whereas you will find few IGTs like gem_unfence_active_buffers,
> gem_tiled_partial_pwrite_pread, etc which doesn't even have igt_assert().
> What should be done?


They should be unified in some manner. We either drop libdrm_intel
usage and write a helper, or make all usage of it uniform with a
helper, so in any case it looks like a wrapper helper is in order.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev