Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing
@ 2021-05-31 13:41 Tejas Upadhyay
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps " Tejas Upadhyay
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Tejas Upadhyay @ 2021-05-31 13:41 UTC (permalink / raw)
  To: igt-dev

lib/i915: find timeslicing cap
tests/gem_exec_schedule: Check for timeslicing as kernel explicitely
reports timeslicing

Tejas Upadhyay (2):
  lib/i915: find scheduler caps for timeslicing
  i915/gem_exec_schedule: Check for timeslicing

 lib/i915/gem_scheduler.c       | 21 +++++++++++++++++++++
 lib/i915/gem_scheduler.h       |  1 +
 tests/i915/gem_exec_schedule.c | 17 ++++++-----------
 3 files changed, 28 insertions(+), 11 deletions(-)

-- 
2.31.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
@ 2021-05-31 13:41 ` Tejas Upadhyay
  2021-06-01 10:07   ` Tvrtko Ursulin
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 2/2] i915/gem_exec_schedule: Check " Tejas Upadhyay
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 11+ messages in thread
From: Tejas Upadhyay @ 2021-05-31 13:41 UTC (permalink / raw)
  To: igt-dev

Check scheduler capability for timeslicing in appropriate
way, which requires wrappers to be created for IGT.

V3:
    removed conditional error - petri
V2: has_timeslice = has_semaphore && has_preemption ||
    has_guc_submission - Tvrtko

Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
 lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
 lib/i915/gem_scheduler.h |  1 +
 2 files changed, 22 insertions(+)

diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c
index 184da843..f59c451f 100644
--- a/lib/i915/gem_scheduler.c
+++ b/lib/i915/gem_scheduler.c
@@ -29,6 +29,7 @@
 #include "ioctl_wrappers.h"
 
 #include "i915/gem_scheduler.h"
+#include "i915/gem_submission.h"
 
 /**
  * SECTION:gem_scheduler
@@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int fd)
 		I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
 }
 
+/**
+ * gem_scheduler_has_timeslicing:
+ * @fd: open i915 drm file descriptor
+ *
+ * Feature test macro to query whether the driver supports using HW preemption
+ * to implement timeslicing of userspace batches. This allows userspace to
+ * implement micro-level scheduling within their own batches.
+ */
+bool gem_scheduler_has_timeslicing(int fd)
+{
+	return ((gem_scheduler_capability(fd) &
+	        (I915_SCHEDULER_CAP_PREEMPTION |
+		 I915_SCHEDULER_CAP_SEMAPHORES))
+		|| gem_has_guc_submission(fd));
+}
+
 /**
  * gem_scheduler_print_capability:
  * @fd: open i915 drm file descriptor
@@ -151,4 +168,8 @@ void gem_scheduler_print_capability(int fd)
 		igt_info(" - With HW semaphores enabled\n");
 	if (caps & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS)
 		igt_info(" - With engine busy statistics\n");
+	if ((caps & (I915_SCHEDULER_CAP_PREEMPTION
+		  | I915_SCHEDULER_CAP_SEMAPHORES))
+		|| gem_has_guc_submission(fd))
+		igt_info(" - With user timeslicing enabled\n");
 }
diff --git a/lib/i915/gem_scheduler.h b/lib/i915/gem_scheduler.h
index 14bd4cac..d43e84bd 100644
--- a/lib/i915/gem_scheduler.h
+++ b/lib/i915/gem_scheduler.h
@@ -32,6 +32,7 @@ bool gem_scheduler_has_ctx_priority(int fd);
 bool gem_scheduler_has_preemption(int fd);
 bool gem_scheduler_has_semaphores(int fd);
 bool gem_scheduler_has_engine_busy_stats(int fd);
+bool gem_scheduler_has_timeslicing(int fd);
 void gem_scheduler_print_capability(int fd);
 
 #endif /* GEM_SCHEDULER_H */
-- 
2.31.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [i-g-t V3 2/2] i915/gem_exec_schedule: Check for timeslicing
  2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps " Tejas Upadhyay
@ 2021-05-31 13:41 ` Tejas Upadhyay
  2021-05-31 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Tejas Upadhyay @ 2021-05-31 13:41 UTC (permalink / raw)
  To: igt-dev

Userspace semaphores (with arbitrary deadlock as soon by this test)
can only be handled if the kernel supports timeslicing. Now that we
explicitly report timeslicing capabilities, check for that cap.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
 tests/i915/gem_exec_schedule.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
index 6147ff96..e205f272 100644
--- a/tests/i915/gem_exec_schedule.c
+++ b/tests/i915/gem_exec_schedule.c
@@ -505,8 +505,7 @@ static void timeslice(int i915, unsigned int engine)
 	 * switch to the other batch in order to advance.
 	 */
 
-	igt_require(gem_scheduler_has_semaphores(i915));
-	igt_require(gem_scheduler_has_preemption(i915));
+	igt_require(gem_scheduler_has_timeslicing(i915));
 	igt_require(intel_gen(intel_get_drm_devid(i915)) >= 8);
 
 	obj.handle = timeslicing_batches(i915, &offset);
@@ -602,8 +601,7 @@ static void timesliceN(int i915, unsigned int engine, int count)
 	 * switch to the other batch in order to advance.
 	 */
 
-	igt_require(gem_scheduler_has_semaphores(i915));
-	igt_require(gem_scheduler_has_preemption(i915));
+	igt_require(gem_scheduler_has_timeslicing(i915));
 	igt_require(intel_gen(intel_get_drm_devid(i915)) >= 8);
 
 	/* No coupling between requests; free to timeslice */
@@ -635,8 +633,7 @@ static void lateslice(int i915, unsigned int engine, unsigned long flags)
 	igt_spin_t *spin[3];
 	uint32_t ctx;
 
-	igt_require(gem_scheduler_has_semaphores(i915));
-	igt_require(gem_scheduler_has_preemption(i915));
+	igt_require(gem_scheduler_has_timeslicing(i915));
 	igt_require(intel_gen(intel_get_drm_devid(i915)) >= 8);
 
 	ctx = gem_context_create(i915);
@@ -742,8 +739,7 @@ static void submit_slice(int i915,
 	 * especially when that work is coperating with the spinner.
 	 */
 
-	igt_require(gem_scheduler_has_semaphores(i915));
-	igt_require(gem_scheduler_has_preemption(i915));
+	igt_require(gem_scheduler_has_timeslicing(i915));
 	igt_require(intel_gen(intel_get_drm_devid(i915)) >= 8);
 
 	__for_each_physical_engine(i915, cancel) {
@@ -820,7 +816,7 @@ static void semaphore_userlock(int i915, unsigned long flags)
 	igt_spin_t *spin = NULL;
 	uint32_t scratch;
 
-	igt_require(gem_scheduler_has_semaphores(i915));
+	igt_require(gem_scheduler_has_timeslicing(i915));
 
 	/*
 	 * Given the use of semaphores to govern parallel submission
@@ -2873,8 +2869,7 @@ igt_main
 
 		igt_subtest_group {
 			igt_fixture {
-				igt_require(gem_scheduler_has_semaphores(fd));
-				igt_require(gem_scheduler_has_preemption(fd));
+				igt_require(gem_scheduler_has_timeslicing(fd));
 				igt_require(intel_gen(intel_get_drm_devid(fd)) >= 8);
 			}
 
-- 
2.31.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_schedule: Report and check for timeslicing (rev4)
  2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps " Tejas Upadhyay
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 2/2] i915/gem_exec_schedule: Check " Tejas Upadhyay
@ 2021-05-31 14:32 ` Patchwork
  2021-05-31 15:10 ` [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Petri Latvala
  2021-05-31 17:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork
  4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-05-31 14:32 UTC (permalink / raw)
  To: Tejas Upadhyay; +Cc: igt-dev


[-- Attachment #1.1: Type: text/plain, Size: 6072 bytes --]

== Series Details ==

Series: gem_exec_schedule: Report and check for timeslicing (rev4)
URL   : https://patchwork.freedesktop.org/series/90471/
State : success

== Summary ==

CI Bug Log - changes from IGT_6097 -> IGTPW_5866
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/index.html

Known issues
------------

  Here are the changes found in IGTPW_5866 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@hangcheck:
    - fi-snb-2600:        [PASS][1] -> [INCOMPLETE][2] ([i915#2782])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-snb-2600/igt@i915_selftest@live@hangcheck.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-tgl-u2:          [PASS][3] -> [FAIL][4] ([i915#2416])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][5] ([i915#49]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-guc:         [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([i915#3049])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live@execlists:
    - fi-tgl-u2:          [DMESG-FAIL][9] ([i915#3462]) -> [INCOMPLETE][10] ([i915#3462])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-tgl-u2/igt@i915_selftest@live@execlists.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-tgl-u2/igt@i915_selftest@live@execlists.html
    - fi-cml-s:           [DMESG-FAIL][11] ([i915#3462]) -> [INCOMPLETE][12] ([i915#3462])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-cml-s/igt@i915_selftest@live@execlists.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-cml-s/igt@i915_selftest@live@execlists.html

  * igt@runner@aborted:
    - fi-cfl-8700k:       [FAIL][13] ([i915#3363]) -> [FAIL][14] ([i915#2426] / [i915#3363])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-cfl-8700k/igt@runner@aborted.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-cfl-8700k/igt@runner@aborted.html
    - fi-kbl-soraka:      [FAIL][15] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][16] ([i915#1436] / [i915#3363])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-kbl-soraka/igt@runner@aborted.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-kbl-soraka/igt@runner@aborted.html
    - fi-kbl-7500u:       [FAIL][17] ([i915#1436] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#2426] / [i915#3363])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-kbl-7500u/igt@runner@aborted.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-kbl-7500u/igt@runner@aborted.html
    - fi-kbl-guc:         [FAIL][19] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][20] ([i915#1436] / [i915#3363])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-kbl-guc/igt@runner@aborted.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-kbl-guc/igt@runner@aborted.html
    - fi-cml-u2:          [FAIL][21] ([i915#3363] / [i915#3462]) -> [FAIL][22] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-cml-u2/igt@runner@aborted.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-cml-u2/igt@runner@aborted.html
    - fi-kbl-7567u:       [FAIL][23] ([i915#1436] / [i915#3363]) -> [FAIL][24] ([i915#1436] / [i915#2426] / [i915#3363])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/fi-kbl-7567u/igt@runner@aborted.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/fi-kbl-7567u/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
  [i915#2416]: https://gitlab.freedesktop.org/drm/intel/issues/2416
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
  [i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
  [i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
  [i915#3049]: https://gitlab.freedesktop.org/drm/intel/issues/3049
  [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
  [i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49


Participating hosts (46 -> 41)
------------------------------

  Missing    (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6097 -> IGTPW_5866

  CI-20190529: 20190529
  CI_DRM_10152: 020097b0f0866462560dc328d3b963fa69fad472 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_5866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/index.html
  IGT_6097: f823d8ec14b34a6dd2c0804c684b07b0a50f7bb7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/index.html

[-- Attachment #1.2: Type: text/html, Size: 8586 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing
  2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
                   ` (2 preceding siblings ...)
  2021-05-31 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork
@ 2021-05-31 15:10 ` Petri Latvala
  2021-05-31 17:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork
  4 siblings, 0 replies; 11+ messages in thread
From: Petri Latvala @ 2021-05-31 15:10 UTC (permalink / raw)
  To: Tejas Upadhyay, Tvrtko Ursulin; +Cc: igt-dev

On Mon, May 31, 2021 at 07:11:37PM +0530, Tejas Upadhyay wrote:
> lib/i915: find timeslicing cap
> tests/gem_exec_schedule: Check for timeslicing as kernel explicitely
> reports timeslicing
> 
> Tejas Upadhyay (2):
>   lib/i915: find scheduler caps for timeslicing
>   i915/gem_exec_schedule: Check for timeslicing
> 
>  lib/i915/gem_scheduler.c       | 21 +++++++++++++++++++++
>  lib/i915/gem_scheduler.h       |  1 +
>  tests/i915/gem_exec_schedule.c | 17 ++++++-----------
>  3 files changed, 28 insertions(+), 11 deletions(-)

The series does what it says on the tin so
Acked-by: Petri Latvala <petri.latvala@intel.com>

Tvrtko, can you give an additional pair of eyes on this to verify this
matches what kernel side wants to do, I lost track of that
conversation?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for gem_exec_schedule: Report and check for timeslicing (rev4)
  2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
                   ` (3 preceding siblings ...)
  2021-05-31 15:10 ` [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Petri Latvala
@ 2021-05-31 17:45 ` Patchwork
  4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-05-31 17:45 UTC (permalink / raw)
  To: Tejas Upadhyay; +Cc: igt-dev


[-- Attachment #1.1: Type: text/plain, Size: 30276 bytes --]

== Series Details ==

Series: gem_exec_schedule: Report and check for timeslicing (rev4)
URL   : https://patchwork.freedesktop.org/series/90471/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6097_full -> IGTPW_5866_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_5866_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_5866_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_5866_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
    - shard-glk:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-glk7/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html

  * igt@kms_plane_lowres@pipe-c-tiling-y:
    - shard-iclb:         NOTRUN -> [SKIP][3] +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@kms_plane_lowres@pipe-c-tiling-y.html
    - shard-tglb:         NOTRUN -> [SKIP][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb2/igt@kms_plane_lowres@pipe-c-tiling-y.html

  
Known issues
------------

  Here are the changes found in IGTPW_5866_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@display-2x:
    - shard-tglb:         NOTRUN -> [SKIP][5] ([i915#1839])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb5/igt@feature_discovery@display-2x.html
    - shard-iclb:         NOTRUN -> [SKIP][6] ([i915#1839])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb7/igt@feature_discovery@display-2x.html

  * igt@gem_create@create-massive:
    - shard-iclb:         NOTRUN -> [DMESG-WARN][7] ([i915#3002])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@gem_create@create-massive.html
    - shard-tglb:         NOTRUN -> [DMESG-WARN][8] ([i915#3002])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@gem_create@create-massive.html
    - shard-glk:          NOTRUN -> [DMESG-WARN][9] ([i915#3002])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk1/igt@gem_create@create-massive.html
    - shard-apl:          NOTRUN -> [DMESG-WARN][10] ([i915#3002])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl6/igt@gem_create@create-massive.html

  * igt@gem_ctx_persistence@legacy-engines-mixed:
    - shard-snb:          NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +6 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html

  * igt@gem_ctx_shared@q-smoketest-all:
    - shard-glk:          [PASS][12] -> [DMESG-WARN][13] ([i915#118] / [i915#95])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-glk6/igt@gem_ctx_shared@q-smoketest-all.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk6/igt@gem_ctx_shared@q-smoketest-all.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-apl:          NOTRUN -> [FAIL][14] ([i915#2846])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl6/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-kbl:          NOTRUN -> [FAIL][15] ([i915#2842]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-tglb:         NOTRUN -> [FAIL][16] ([i915#2842]) +5 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-pace@vcs1:
    - shard-iclb:         NOTRUN -> [FAIL][17] ([i915#2842]) +4 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-glk:          NOTRUN -> [FAIL][18] ([i915#2842]) +3 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk7/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_huc_copy@huc-copy:
    - shard-kbl:          NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@gem_huc_copy@huc-copy.html

  * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
    - shard-snb:          NOTRUN -> [INCOMPLETE][20] ([i915#2055] / [i915#3468])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
    - shard-kbl:          NOTRUN -> [INCOMPLETE][21] ([i915#3468])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl3/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html

  * igt@gem_mmap_gtt@cpuset-medium-copy:
    - shard-iclb:         [PASS][22] -> [FAIL][23] ([i915#307])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-iclb7/igt@gem_mmap_gtt@cpuset-medium-copy.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy.html

  * igt@gem_mmap_gtt@cpuset-medium-copy-xy:
    - shard-tglb:         NOTRUN -> [INCOMPLETE][24] ([i915#3468] / [i915#750])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb8/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
    - shard-glk:          NOTRUN -> [INCOMPLETE][25] ([i915#3468])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk2/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html

  * igt@gem_mmap_gtt@fault-concurrent:
    - shard-iclb:         NOTRUN -> [INCOMPLETE][26] ([i915#3468])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb7/igt@gem_mmap_gtt@fault-concurrent.html

  * igt@gem_mmap_gtt@fault-concurrent-x:
    - shard-snb:          NOTRUN -> [INCOMPLETE][27] ([i915#3485])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb5/igt@gem_mmap_gtt@fault-concurrent-x.html
    - shard-apl:          NOTRUN -> [INCOMPLETE][28] ([i915#3468])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl1/igt@gem_mmap_gtt@fault-concurrent-x.html

  * igt@gem_mmap_gtt@medium-copy-xy:
    - shard-iclb:         NOTRUN -> [INCOMPLETE][29] ([i915#2502] / [i915#3468])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@gem_mmap_gtt@medium-copy-xy.html
    - shard-kbl:          NOTRUN -> [INCOMPLETE][30] ([i915#2502] / [i915#3468])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl4/igt@gem_mmap_gtt@medium-copy-xy.html

  * igt@gem_pread@exhaustion:
    - shard-snb:          NOTRUN -> [WARN][31] ([i915#2658])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb5/igt@gem_pread@exhaustion.html

  * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
    - shard-kbl:          NOTRUN -> [SKIP][32] ([fdo#109271]) +192 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl1/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html

  * igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
    - shard-glk:          NOTRUN -> [SKIP][33] ([fdo#109271]) +91 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk8/igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled.html

  * igt@gem_render_copy@yf-tiled-to-vebox-y-tiled:
    - shard-iclb:         NOTRUN -> [SKIP][34] ([i915#768]) +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb1/igt@gem_render_copy@yf-tiled-to-vebox-y-tiled.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-apl:          NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3323])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl1/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@readonly-pwrite-unsync:
    - shard-iclb:         NOTRUN -> [SKIP][36] ([i915#3297]) +3 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb1/igt@gem_userptr_blits@readonly-pwrite-unsync.html

  * igt@gem_userptr_blits@unsync-unmap-after-close:
    - shard-tglb:         NOTRUN -> [SKIP][37] ([i915#3297]) +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb2/igt@gem_userptr_blits@unsync-unmap-after-close.html

  * igt@gem_userptr_blits@vma-merge:
    - shard-snb:          NOTRUN -> [FAIL][38] ([i915#2724])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb5/igt@gem_userptr_blits@vma-merge.html
    - shard-apl:          NOTRUN -> [FAIL][39] ([i915#3318])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl3/igt@gem_userptr_blits@vma-merge.html
    - shard-tglb:         NOTRUN -> [FAIL][40] ([i915#3318])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@gem_userptr_blits@vma-merge.html

  * igt@gen3_render_tiledx_blits:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109289]) +4 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@gen3_render_tiledx_blits.html

  * igt@gen7_exec_parse@cmd-crossing-page:
    - shard-tglb:         NOTRUN -> [SKIP][42] ([fdo#109289]) +5 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@gen7_exec_parse@cmd-crossing-page.html

  * igt@gen9_exec_parse@bb-large:
    - shard-tglb:         NOTRUN -> [SKIP][43] ([i915#2527])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@gen9_exec_parse@bb-large.html
    - shard-kbl:          NOTRUN -> [FAIL][44] ([i915#3296])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl3/igt@gen9_exec_parse@bb-large.html
    - shard-iclb:         NOTRUN -> [SKIP][45] ([i915#2527])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb8/igt@gen9_exec_parse@bb-large.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-kbl:          NOTRUN -> [FAIL][46] ([i915#454])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl7/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
    - shard-kbl:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#1937])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
    - shard-apl:          NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#1937])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-glk:          NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#1937])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([fdo#109289] / [fdo#111719])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb8/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-tglb:         NOTRUN -> [SKIP][51] ([fdo#111644] / [i915#1397] / [i915#2411])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
    - shard-iclb:         NOTRUN -> [SKIP][52] ([fdo#110892])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@i915_selftest@live@hangcheck:
    - shard-snb:          NOTRUN -> [INCOMPLETE][53] ([i915#2782])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb2/igt@i915_selftest@live@hangcheck.html

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-iclb:         NOTRUN -> [SKIP][54] ([i915#1769])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb8/igt@kms_atomic_transition@plane-all-modeset-transition.html
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#1769])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@kms_atomic_transition@plane-all-modeset-transition.html

  * igt@kms_big_fb@linear-16bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][56] ([fdo#111614]) +3 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_big_fb@linear-16bpp-rotate-270.html

  * igt@kms_big_fb@x-tiled-16bpp-rotate-270:
    - shard-iclb:         NOTRUN -> [SKIP][57] ([fdo#110725] / [fdo#111614]) +3 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
    - shard-iclb:         NOTRUN -> [SKIP][58] ([fdo#110723])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html

  * igt@kms_big_joiner@basic:
    - shard-tglb:         NOTRUN -> [SKIP][59] ([i915#2705])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_big_joiner@basic.html
    - shard-kbl:          NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2705])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_big_joiner@basic.html
    - shard-iclb:         NOTRUN -> [SKIP][61] ([i915#2705])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@kms_big_joiner@basic.html
    - shard-glk:          NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2705])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk7/igt@kms_big_joiner@basic.html
    - shard-apl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2705])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl2/igt@kms_big_joiner@basic.html

  * igt@kms_chamelium@dp-frame-dump:
    - shard-glk:          NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +11 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk8/igt@kms_chamelium@dp-frame-dump.html

  * igt@kms_chamelium@vga-hpd-with-enabled-mode:
    - shard-iclb:         NOTRUN -> [SKIP][65] ([fdo#109284] / [fdo#111827]) +12 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@kms_chamelium@vga-hpd-with-enabled-mode.html

  * igt@kms_color@pipe-d-ctm-negative:
    - shard-iclb:         NOTRUN -> [SKIP][66] ([fdo#109278] / [i915#1149]) +1 similar issue
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb5/igt@kms_color@pipe-d-ctm-negative.html

  * igt@kms_color@pipe-d-degamma:
    - shard-tglb:         NOTRUN -> [FAIL][67] ([i915#1149])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@kms_color@pipe-d-degamma.html

  * igt@kms_color_chamelium@pipe-b-ctm-0-25:
    - shard-kbl:          NOTRUN -> [SKIP][68] ([fdo#109271] / [fdo#111827]) +20 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_color_chamelium@pipe-b-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-b-ctm-0-5:
    - shard-apl:          NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +25 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl3/igt@kms_color_chamelium@pipe-b-ctm-0-5.html

  * igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
    - shard-snb:          NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827]) +23 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb2/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html

  * igt@kms_color_chamelium@pipe-d-ctm-0-25:
    - shard-iclb:         NOTRUN -> [SKIP][71] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +2 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
    - shard-tglb:         NOTRUN -> [SKIP][72] ([fdo#109284] / [fdo#111827]) +17 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb8/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html

  * igt@kms_content_protection@atomic:
    - shard-kbl:          NOTRUN -> [TIMEOUT][73] ([i915#1319])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_content_protection@atomic.html

  * igt@kms_content_protection@lic:
    - shard-apl:          NOTRUN -> [TIMEOUT][74] ([i915#1319])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl2/igt@kms_content_protection@lic.html

  * igt@kms_content_protection@uevent:
    - shard-kbl:          NOTRUN -> [FAIL][75] ([i915#2105])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl7/igt@kms_content_protection@uevent.html
    - shard-tglb:         NOTRUN -> [SKIP][76] ([fdo#111828])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb5/igt@kms_content_protection@uevent.html
    - shard-iclb:         NOTRUN -> [SKIP][77] ([fdo#109300] / [fdo#111066])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][78] -> [DMESG-WARN][79] ([i915#180])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement:
    - shard-tglb:         NOTRUN -> [SKIP][80] ([i915#3319])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen:
    - shard-iclb:         NOTRUN -> [SKIP][81] ([fdo#109278] / [fdo#109279])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb1/igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen:
    - shard-tglb:         NOTRUN -> [SKIP][82] ([i915#3359]) +6 similar issues
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-512x512-random:
    - shard-tglb:         NOTRUN -> [SKIP][83] ([fdo#109279] / [i915#3359]) +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html

  * igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge:
    - shard-iclb:         NOTRUN -> [SKIP][84] ([fdo#109278]) +34 similar issues
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb8/igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-legacy:
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109274] / [fdo#109278]) +3 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb1/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html

  * igt@kms_cursor_legacy@pipe-d-torture-bo:
    - shard-glk:          NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533]) +2 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk7/igt@kms_cursor_legacy@pipe-d-torture-bo.html

  * igt@kms_flip@2x-wf_vblank-ts-check:
    - shard-iclb:         NOTRUN -> [SKIP][87] ([fdo#109274])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@kms_flip@2x-wf_vblank-ts-check.html

  * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
    - shard-glk:          [PASS][88] -> [FAIL][89] ([i915#79])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][90] ([i915#180]) +7 similar issues
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-apl:          [PASS][91] -> [DMESG-WARN][92] ([i915#180])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
    - shard-apl:          NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2672]) +1 similar issue
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-snb:          NOTRUN -> [SKIP][94] ([fdo#109271]) +414 similar issues
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-snb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
    - shard-tglb:         NOTRUN -> [SKIP][95] ([i915#2587])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
    - shard-apl:          NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2642])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
    - shard-kbl:          NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2642]) +1 similar issue
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
    - shard-glk:          [PASS][98] -> [FAIL][99] ([i915#49])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
    - shard-iclb:         [PASS][100] -> [FAIL][101] ([i915#49])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
    - shard-tglb:         NOTRUN -> [SKIP][102] ([fdo#111825]) +46 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-iclb:         NOTRUN -> [SKIP][103] ([fdo#109280]) +31 similar issues
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-tglb:         NOTRUN -> [SKIP][104] ([i915#1187])
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@kms_hdr@static-toggle-suspend.html
    - shard-iclb:         NOTRUN -> [SKIP][105] ([i915#1187])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
    - shard-kbl:          NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#533]) +3 similar issues
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          NOTRUN -> [FAIL][107] ([fdo#108145] / [i915#265]) +5 similar issues
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
    - shard-glk:          NOTRUN -> [FAIL][108] ([fdo#108145] / [i915#265])
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk2/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-kbl:          NOTRUN -> [FAIL][109] ([fdo#108145] / [i915#265]) +2 similar issues
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
    - shard-kbl:          NOTRUN -> [FAIL][110] ([i915#265])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html

  * igt@kms_plane_lowres@pipe-b-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][111] ([fdo#111615]) +3 similar issues
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb8/igt@kms_plane_lowres@pipe-b-tiling-yf.html

  * igt@kms_prime@basic-crc@first-to-second:
    - shard-iclb:         NOTRUN -> [SKIP][112] ([i915#1836])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb8/igt@kms_prime@basic-crc@first-to-second.html
    - shard-tglb:         NOTRUN -> [SKIP][113] ([i915#1836])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb3/igt@kms_prime@basic-crc@first-to-second.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][114] ([i915#2920])
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
    - shard-glk:          NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#658]) +1 similar issue
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-glk9/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
    - shard-tglb:         NOTRUN -> [SKIP][116] ([i915#2920]) +3 similar issues
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
    - shard-kbl:          NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658]) +1 similar issue
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
    - shard-iclb:         NOTRUN -> [SKIP][118] ([i915#658]) +2 similar issues
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
    - shard-apl:          NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658]) +5 similar issues
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [PASS][120] -> [SKIP][121] ([fdo#109441]) +1 similar issue
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-iclb2/igt@kms_psr@psr2_basic.html
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb6/igt@kms_psr@psr2_basic.html

  * igt@kms_psr@psr2_primary_page_flip:
    - shard-iclb:         NOTRUN -> [SKIP][122] ([fdo#109441])
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html

  * igt@kms_psr@psr2_primary_render:
    - shard-tglb:         NOTRUN -> [FAIL][123] ([i915#132] / [i915#3467]) +1 similar issue
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb7/igt@kms_psr@psr2_primary_render.html

  * igt@kms_psr@psr2_suspend:
    - shard-tglb:         NOTRUN -> [FAIL][124] ([i915#132])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@kms_psr@psr2_suspend.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-kbl:          [PASS][125] -> [INCOMPLETE][126] ([i915#155] / [i915#2828] / [i915#794])
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6097/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-d-wait-idle:
    - shard-apl:          NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#533]) +3 similar issues
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl7/igt@kms_vblank@pipe-d-wait-idle.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-kbl:          NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#2437])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-kbl3/igt@kms_writeback@writeback-fb-id.html

  * igt@kms_writeback@writeback-pixel-formats:
    - shard-apl:          NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2437])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-apl2/igt@kms_writeback@writeback-pixel-formats.html

  * igt@nouveau_crc@pipe-a-ctx-flip-detection:
    - shard-iclb:         NOTRUN -> [SKIP][130] ([i915#2530]) +1 similar issue
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-iclb3/igt@nouveau_crc@pipe-a-ctx-flip-detection.html

  * igt@nouveau_crc@pipe-d-ctx-flip-detection:
    - shard-tglb:         NOTRUN -> [SKIP][131] ([i915#2530]) +5 similar issues
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/shard-tglb1/igt@nouveau_crc@pipe-d-ctx-flip-detection.html

  * igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame:
    - shard-iclb:         NOTRUN -> [SKIP][132] ([fdo#109278] / [i915#2530]) +1 similar issue
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTP

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5866/index.html

[-- Attachment #1.2: Type: text/html, Size: 34048 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-05-31 13:41 ` [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps " Tejas Upadhyay
@ 2021-06-01 10:07   ` Tvrtko Ursulin
  2021-06-01 10:10     ` Surendrakumar Upadhyay, TejaskumarX
  0 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-06-01 10:07 UTC (permalink / raw)
  To: Tejas Upadhyay, igt-dev


On 31/05/2021 14:41, Tejas Upadhyay wrote:
> Check scheduler capability for timeslicing in appropriate
> way, which requires wrappers to be created for IGT.
> 
> V3:
>      removed conditional error - petri
> V2: has_timeslice = has_semaphore && has_preemption ||
>      has_guc_submission - Tvrtko
> 
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>   lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
>   lib/i915/gem_scheduler.h |  1 +
>   2 files changed, 22 insertions(+)
> 
> diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c
> index 184da843..f59c451f 100644
> --- a/lib/i915/gem_scheduler.c
> +++ b/lib/i915/gem_scheduler.c
> @@ -29,6 +29,7 @@
>   #include "ioctl_wrappers.h"
>   
>   #include "i915/gem_scheduler.h"
> +#include "i915/gem_submission.h"
>   
>   /**
>    * SECTION:gem_scheduler
> @@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int fd)
>   		I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
>   }
>   
> +/**
> + * gem_scheduler_has_timeslicing:
> + * @fd: open i915 drm file descriptor
> + *
> + * Feature test macro to query whether the driver supports using HW preemption
> + * to implement timeslicing of userspace batches. This allows userspace to
> + * implement micro-level scheduling within their own batches.
> + */
> +bool gem_scheduler_has_timeslicing(int fd)
> +{
> +	return ((gem_scheduler_capability(fd) &
> +	        (I915_SCHEDULER_CAP_PREEMPTION |
> +		 I915_SCHEDULER_CAP_SEMAPHORES))
> +		|| gem_has_guc_submission(fd));
> +}
> +
>   /**
>    * gem_scheduler_print_capability:
>    * @fd: open i915 drm file descriptor
> @@ -151,4 +168,8 @@ void gem_scheduler_print_capability(int fd)
>   		igt_info(" - With HW semaphores enabled\n");
>   	if (caps & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS)
>   		igt_info(" - With engine busy statistics\n");
> +	if ((caps & (I915_SCHEDULER_CAP_PREEMPTION
> +		  | I915_SCHEDULER_CAP_SEMAPHORES))
> +		|| gem_has_guc_submission(fd))
> +		igt_info(" - With user timeslicing enabled\n");

I don't think it's "user timeslicing" but just timeslicing. Otherwise 
looks okay.

Regards,

Tvrtko

>   }
> diff --git a/lib/i915/gem_scheduler.h b/lib/i915/gem_scheduler.h
> index 14bd4cac..d43e84bd 100644
> --- a/lib/i915/gem_scheduler.h
> +++ b/lib/i915/gem_scheduler.h
> @@ -32,6 +32,7 @@ bool gem_scheduler_has_ctx_priority(int fd);
>   bool gem_scheduler_has_preemption(int fd);
>   bool gem_scheduler_has_semaphores(int fd);
>   bool gem_scheduler_has_engine_busy_stats(int fd);
> +bool gem_scheduler_has_timeslicing(int fd);
>   void gem_scheduler_print_capability(int fd);
>   
>   #endif /* GEM_SCHEDULER_H */
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-06-01 10:07   ` Tvrtko Ursulin
@ 2021-06-01 10:10     ` Surendrakumar Upadhyay, TejaskumarX
  2021-06-01 10:24       ` Tvrtko Ursulin
  0 siblings, 1 reply; 11+ messages in thread
From: Surendrakumar Upadhyay, TejaskumarX @ 2021-06-01 10:10 UTC (permalink / raw)
  To: Tvrtko Ursulin, igt-dev@lists.freedesktop.org



> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: 01 June 2021 15:38
> To: Surendrakumar Upadhyay, TejaskumarX
> <tejaskumarx.surendrakumar.upadhyay@intel.com>; igt-
> dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
> 
> 
> On 31/05/2021 14:41, Tejas Upadhyay wrote:
> > Check scheduler capability for timeslicing in appropriate way, which
> > requires wrappers to be created for IGT.
> >
> > V3:
> >      removed conditional error - petri
> > V2: has_timeslice = has_semaphore && has_preemption ||
> >      has_guc_submission - Tvrtko
> >
> > Signed-off-by: Tejas Upadhyay
> > <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > ---
> >   lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
> >   lib/i915/gem_scheduler.h |  1 +
> >   2 files changed, 22 insertions(+)
> >
> > diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c index
> > 184da843..f59c451f 100644
> > --- a/lib/i915/gem_scheduler.c
> > +++ b/lib/i915/gem_scheduler.c
> > @@ -29,6 +29,7 @@
> >   #include "ioctl_wrappers.h"
> >
> >   #include "i915/gem_scheduler.h"
> > +#include "i915/gem_submission.h"
> >
> >   /**
> >    * SECTION:gem_scheduler
> > @@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int
> fd)
> >   		I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
> >   }
> >
> > +/**
> > + * gem_scheduler_has_timeslicing:
> > + * @fd: open i915 drm file descriptor
> > + *
> > + * Feature test macro to query whether the driver supports using HW
> > +preemption
> > + * to implement timeslicing of userspace batches. This allows
> > +userspace to
> > + * implement micro-level scheduling within their own batches.
> > + */
> > +bool gem_scheduler_has_timeslicing(int fd) {
> > +	return ((gem_scheduler_capability(fd) &
> > +	        (I915_SCHEDULER_CAP_PREEMPTION |
> > +		 I915_SCHEDULER_CAP_SEMAPHORES))
> > +		|| gem_has_guc_submission(fd));
> > +}
> > +
> >   /**
> >    * gem_scheduler_print_capability:
> >    * @fd: open i915 drm file descriptor @@ -151,4 +168,8 @@ void
> > gem_scheduler_print_capability(int fd)
> >   		igt_info(" - With HW semaphores enabled\n");
> >   	if (caps & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS)
> >   		igt_info(" - With engine busy statistics\n");
> > +	if ((caps & (I915_SCHEDULER_CAP_PREEMPTION
> > +		  | I915_SCHEDULER_CAP_SEMAPHORES))
> > +		|| gem_has_guc_submission(fd))
> > +		igt_info(" - With user timeslicing enabled\n");
> 
> I don't think it's "user timeslicing" but just timeslicing. Otherwise looks okay.

I think this is what it was before, I have not changed print. Do you want to change it?

Thanks,
Tejas
> 
> Regards,
> 
> Tvrtko
> 
> >   }
> > diff --git a/lib/i915/gem_scheduler.h b/lib/i915/gem_scheduler.h index
> > 14bd4cac..d43e84bd 100644
> > --- a/lib/i915/gem_scheduler.h
> > +++ b/lib/i915/gem_scheduler.h
> > @@ -32,6 +32,7 @@ bool gem_scheduler_has_ctx_priority(int fd);
> >   bool gem_scheduler_has_preemption(int fd);
> >   bool gem_scheduler_has_semaphores(int fd);
> >   bool gem_scheduler_has_engine_busy_stats(int fd);
> > +bool gem_scheduler_has_timeslicing(int fd);
> >   void gem_scheduler_print_capability(int fd);
> >
> >   #endif /* GEM_SCHEDULER_H */
> >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-06-01 10:10     ` Surendrakumar Upadhyay, TejaskumarX
@ 2021-06-01 10:24       ` Tvrtko Ursulin
  2021-06-03 14:50         ` Chris Wilson
  0 siblings, 1 reply; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-06-01 10:24 UTC (permalink / raw)
  To: Surendrakumar Upadhyay, TejaskumarX,
	igt-dev@lists.freedesktop.org


On 01/06/2021 11:10, Surendrakumar Upadhyay, TejaskumarX wrote:
>> -----Original Message-----
>> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Sent: 01 June 2021 15:38
>> To: Surendrakumar Upadhyay, TejaskumarX
>> <tejaskumarx.surendrakumar.upadhyay@intel.com>; igt-
>> dev@lists.freedesktop.org
>> Subject: Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
>>
>>
>> On 31/05/2021 14:41, Tejas Upadhyay wrote:
>>> Check scheduler capability for timeslicing in appropriate way, which
>>> requires wrappers to be created for IGT.
>>>
>>> V3:
>>>       removed conditional error - petri
>>> V2: has_timeslice = has_semaphore && has_preemption ||
>>>       has_guc_submission - Tvrtko
>>>
>>> Signed-off-by: Tejas Upadhyay
>>> <tejaskumarx.surendrakumar.upadhyay@intel.com>
>>> ---
>>>    lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
>>>    lib/i915/gem_scheduler.h |  1 +
>>>    2 files changed, 22 insertions(+)
>>>
>>> diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c index
>>> 184da843..f59c451f 100644
>>> --- a/lib/i915/gem_scheduler.c
>>> +++ b/lib/i915/gem_scheduler.c
>>> @@ -29,6 +29,7 @@
>>>    #include "ioctl_wrappers.h"
>>>
>>>    #include "i915/gem_scheduler.h"
>>> +#include "i915/gem_submission.h"
>>>
>>>    /**
>>>     * SECTION:gem_scheduler
>>> @@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int
>> fd)
>>>    		I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
>>>    }
>>>
>>> +/**
>>> + * gem_scheduler_has_timeslicing:
>>> + * @fd: open i915 drm file descriptor
>>> + *
>>> + * Feature test macro to query whether the driver supports using HW
>>> +preemption
>>> + * to implement timeslicing of userspace batches. This allows
>>> +userspace to
>>> + * implement micro-level scheduling within their own batches.
>>> + */
>>> +bool gem_scheduler_has_timeslicing(int fd) {
>>> +	return ((gem_scheduler_capability(fd) &
>>> +	        (I915_SCHEDULER_CAP_PREEMPTION |
>>> +		 I915_SCHEDULER_CAP_SEMAPHORES))
>>> +		|| gem_has_guc_submission(fd));
>>> +}
>>> +
>>>    /**
>>>     * gem_scheduler_print_capability:
>>>     * @fd: open i915 drm file descriptor @@ -151,4 +168,8 @@ void
>>> gem_scheduler_print_capability(int fd)
>>>    		igt_info(" - With HW semaphores enabled\n");
>>>    	if (caps & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS)
>>>    		igt_info(" - With engine busy statistics\n");
>>> +	if ((caps & (I915_SCHEDULER_CAP_PREEMPTION
>>> +		  | I915_SCHEDULER_CAP_SEMAPHORES))
>>> +		|| gem_has_guc_submission(fd))
>>> +		igt_info(" - With user timeslicing enabled\n");
>>
>> I don't think it's "user timeslicing" but just timeslicing. Otherwise looks okay.
> 
> I think this is what it was before, I have not changed print. Do you want to change it?

I don't care hugely. It is just not clear to me reader of this banner 
will have any idea what is "user timeslicing" versus just timeslicing.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-06-01 10:24       ` Tvrtko Ursulin
@ 2021-06-03 14:50         ` Chris Wilson
  2021-06-04  8:21           ` Petri Latvala
  0 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2021-06-03 14:50 UTC (permalink / raw)
  To: Surendrakumar Upadhyay, TejaskumarX, Tvrtko Ursulin, igt-dev

Quoting Tvrtko Ursulin (2021-06-01 11:24:00)
> 
> On 01/06/2021 11:10, Surendrakumar Upadhyay, TejaskumarX wrote:
> >> -----Original Message-----
> >> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> >> Sent: 01 June 2021 15:38
> >> To: Surendrakumar Upadhyay, TejaskumarX
> >> <tejaskumarx.surendrakumar.upadhyay@intel.com>; igt-
> >> dev@lists.freedesktop.org
> >> Subject: Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
> >>
> >>
> >> On 31/05/2021 14:41, Tejas Upadhyay wrote:
> >>> Check scheduler capability for timeslicing in appropriate way, which
> >>> requires wrappers to be created for IGT.
> >>>
> >>> V3:
> >>>       removed conditional error - petri
> >>> V2: has_timeslice = has_semaphore && has_preemption ||
> >>>       has_guc_submission - Tvrtko
> >>>
> >>> Signed-off-by: Tejas Upadhyay
> >>> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> >>> ---
> >>>    lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
> >>>    lib/i915/gem_scheduler.h |  1 +
> >>>    2 files changed, 22 insertions(+)
> >>>
> >>> diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c index
> >>> 184da843..f59c451f 100644
> >>> --- a/lib/i915/gem_scheduler.c
> >>> +++ b/lib/i915/gem_scheduler.c
> >>> @@ -29,6 +29,7 @@
> >>>    #include "ioctl_wrappers.h"
> >>>
> >>>    #include "i915/gem_scheduler.h"
> >>> +#include "i915/gem_submission.h"
> >>>
> >>>    /**
> >>>     * SECTION:gem_scheduler
> >>> @@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int
> >> fd)
> >>>             I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
> >>>    }
> >>>
> >>> +/**
> >>> + * gem_scheduler_has_timeslicing:
> >>> + * @fd: open i915 drm file descriptor
> >>> + *
> >>> + * Feature test macro to query whether the driver supports using HW
> >>> +preemption
> >>> + * to implement timeslicing of userspace batches. This allows
> >>> +userspace to
> >>> + * implement micro-level scheduling within their own batches.
> >>> + */
> >>> +bool gem_scheduler_has_timeslicing(int fd) {
> >>> +   return ((gem_scheduler_capability(fd) &
> >>> +           (I915_SCHEDULER_CAP_PREEMPTION |
> >>> +            I915_SCHEDULER_CAP_SEMAPHORES))

This bitwise or is incorrect, both are required.

> >>> +           || gem_has_guc_submission(fd));

This is not always true.

And it removes the clarity of being a simple wrapper.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
  2021-06-03 14:50         ` Chris Wilson
@ 2021-06-04  8:21           ` Petri Latvala
  0 siblings, 0 replies; 11+ messages in thread
From: Petri Latvala @ 2021-06-04  8:21 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

On Thu, Jun 03, 2021 at 03:50:32PM +0100, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2021-06-01 11:24:00)
> > 
> > On 01/06/2021 11:10, Surendrakumar Upadhyay, TejaskumarX wrote:
> > >> -----Original Message-----
> > >> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > >> Sent: 01 June 2021 15:38
> > >> To: Surendrakumar Upadhyay, TejaskumarX
> > >> <tejaskumarx.surendrakumar.upadhyay@intel.com>; igt-
> > >> dev@lists.freedesktop.org
> > >> Subject: Re: [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps for timeslicing
> > >>
> > >>
> > >> On 31/05/2021 14:41, Tejas Upadhyay wrote:
> > >>> Check scheduler capability for timeslicing in appropriate way, which
> > >>> requires wrappers to be created for IGT.
> > >>>
> > >>> V3:
> > >>>       removed conditional error - petri
> > >>> V2: has_timeslice = has_semaphore && has_preemption ||
> > >>>       has_guc_submission - Tvrtko
> > >>>
> > >>> Signed-off-by: Tejas Upadhyay
> > >>> <tejaskumarx.surendrakumar.upadhyay@intel.com>
> > >>> ---
> > >>>    lib/i915/gem_scheduler.c | 21 +++++++++++++++++++++
> > >>>    lib/i915/gem_scheduler.h |  1 +
> > >>>    2 files changed, 22 insertions(+)
> > >>>
> > >>> diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c index
> > >>> 184da843..f59c451f 100644
> > >>> --- a/lib/i915/gem_scheduler.c
> > >>> +++ b/lib/i915/gem_scheduler.c
> > >>> @@ -29,6 +29,7 @@
> > >>>    #include "ioctl_wrappers.h"
> > >>>
> > >>>    #include "i915/gem_scheduler.h"
> > >>> +#include "i915/gem_submission.h"
> > >>>
> > >>>    /**
> > >>>     * SECTION:gem_scheduler
> > >>> @@ -129,6 +130,22 @@ bool gem_scheduler_has_engine_busy_stats(int
> > >> fd)
> > >>>             I915_SCHEDULER_CAP_ENGINE_BUSY_STATS;
> > >>>    }
> > >>>
> > >>> +/**
> > >>> + * gem_scheduler_has_timeslicing:
> > >>> + * @fd: open i915 drm file descriptor
> > >>> + *
> > >>> + * Feature test macro to query whether the driver supports using HW
> > >>> +preemption
> > >>> + * to implement timeslicing of userspace batches. This allows
> > >>> +userspace to
> > >>> + * implement micro-level scheduling within their own batches.
> > >>> + */
> > >>> +bool gem_scheduler_has_timeslicing(int fd) {
> > >>> +   return ((gem_scheduler_capability(fd) &
> > >>> +           (I915_SCHEDULER_CAP_PREEMPTION |
> > >>> +            I915_SCHEDULER_CAP_SEMAPHORES))
> 
> This bitwise or is incorrect, both are required.

Yes, I had a brainfart and didn't spot it.


Revert inc.

-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-06-04  8:19 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-31 13:41 [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Tejas Upadhyay
2021-05-31 13:41 ` [igt-dev] [i-g-t V3 1/2] lib/i915: find scheduler caps " Tejas Upadhyay
2021-06-01 10:07   ` Tvrtko Ursulin
2021-06-01 10:10     ` Surendrakumar Upadhyay, TejaskumarX
2021-06-01 10:24       ` Tvrtko Ursulin
2021-06-03 14:50         ` Chris Wilson
2021-06-04  8:21           ` Petri Latvala
2021-05-31 13:41 ` [igt-dev] [i-g-t V3 2/2] i915/gem_exec_schedule: Check " Tejas Upadhyay
2021-05-31 14:32 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork
2021-05-31 15:10 ` [igt-dev] [i-g-t V3 0/2] gem_exec_schedule: Report and check for timeslicing Petri Latvala
2021-05-31 17:45 ` [igt-dev] ✗ Fi.CI.IGT: failure for gem_exec_schedule: Report and check for timeslicing (rev4) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox