Re: [PATCH i-g-t 0/7] igt: Help out coccinelle

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Nov 25, 2025 at 02:44:27PM +0100, Kamil Konieczny wrote:
> Hi Ville,
> On 2025-11-20 at 21:14:08 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Coccinelle has trouble parsing a lot of the magic macros
> > used throughout igt. Convert some of the macros to a form
> > coccinelle understands, and provide a pre-made iterators.cocci
> > script that people can include in their own scripts to help
> > coccinelle with the iterator macros.
> > 
> > Ville Syrjälä (7):
> >   igt: Make igt_fixture look like an iterator
> >   igt: Make igt_subtest_group look like an iterator
> >   igt: Make igt_main look more like a function
> >   igt: Make igt_simple_main look more like a function
> >   igt: Make igt_main*() look like normal function definition
> >   igt: Make igt_simple_main*() look like normal function definition
> >   scripts/cocci: Add iterators.cocci
> 
> All of those changes are mostly one-line sed modifications,
> could they be just a part of bigger script to prepare
> sources in some temporary place and then just run
> cocinnelle over it? And moving those changes back into
> igt source.
> 
> Or prepare changes in-place, do actual work and then reversing
> sed changes in generated patches.

Why on earth would we want to undo the sed changes? That would
just mean you have to redo and undo them every time you run
cocci.

The sane thing is to make the syntax closer to standard
C so that normal tools can parse it. And that is what this
series does.

-- 
Ville Syrjälä
Intel