public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <saurabhg.gupta@intel.com>,
	<alex.zuo@intel.com>, <priyanka.dandamudi@intel.com>,
	<stuart.summers@intel.com>
Subject: Re: [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected
Date: Thu, 15 Jan 2026 12:07:49 -0800	[thread overview]
Message-ID: <aWlJFR7xsFZPMSGs@nvishwa1-desk> (raw)
In-Reply-To: <20260113211558.149105-2-jonathan.cavitt@intel.com>

On Tue, Jan 13, 2026 at 09:15:59PM +0000, Jonathan Cavitt wrote:
>In the xe_exec_multi_queue@virtual test, we currently assert that at
>least one engine with a given class on a given GT ID exists.  However,
>the way we generate these class and GT ID pairs is through brute-force
>(I.E. list all engine classes that support multi queue, then list all GT
>IDs, to generate all pairs).  This frequently results in invalid class
>and GT pairs (E.G. attempting to find RCS on GT ID 1).
>

NIT...we can remove below example as RCS doesn't support multi-queue.
"(E.G. attempting to find RCS on GT ID 1)"
The rest of the commit text here is descriptive enough.

In anycase,
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

>While a smart solution that only generates valid class and GT ID
>pairings would be preferred here, doing so would probably be overkill,
>so just remove the igt_assert case and exit silently if no engines are
>found.
>
>Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>Cc: Stuart Summers <stuart.summers@intel.com>
>---
> tests/intel/xe_exec_multi_queue.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/tests/intel/xe_exec_multi_queue.c b/tests/intel/xe_exec_multi_queue.c
>index 6bc6f9f63b..9a02744967 100644
>--- a/tests/intel/xe_exec_multi_queue.c
>+++ b/tests/intel/xe_exec_multi_queue.c
>@@ -995,7 +995,9 @@ test_exec_virtual(int fd, int gt, int class)
>
> 		eci[n++] = *hwe;
> 	}
>-	igt_assert(n);
>+
>+	if (!n)
>+		return;
>
> 	test_exec(fd, eci, n, n, n, 0);
> 	test_exec(fd, eci, n, n, n, PREEMPT_MODE);
>-- 
>2.43.0
>

  parent reply	other threads:[~2026-01-15 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 21:15 [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected Jonathan Cavitt
2026-01-13 21:46 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-01-13 22:14 ` ✗ i915.CI.BAT: failure " Patchwork
2026-01-14  6:55 ` ✗ Xe.CI.Full: " Patchwork
2026-01-15 20:07 ` Niranjana Vishwanathapura [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-01-15 20:18 [PATCH] " Jonathan Cavitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWlJFR7xsFZPMSGs@nvishwa1-desk \
    --to=niranjana.vishwanathapura@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=priyanka.dandamudi@intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox