Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC.
@ 2021-03-23 15:08 Mark Yacoub
  2021-03-24  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC. (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Mark Yacoub @ 2021-03-23 15:08 UTC (permalink / raw)
  To: igt-dev; +Cc: seanpaul, petri.latvala, Mark Yacoub

From: Mark Yacoub <markyacoub@google.com>

Setup all plane params before committing anything.
Do not disable Primary Plane whenever a CRTC is getting enabled.

AMD Driver requires the primary plane to be enabled whenever the CRTC is, otherwise
drm_mode_cursor_universal may end up trying to enable the cursor plane while all other
planes are disabled, which is not supported by the hardware.

Tested on Delbin and Volteer with no regression or added latency.

---
 tests/kms_atomic_transition.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index 9689bf4d..cfa04dcd 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -172,7 +172,7 @@ wm_setup_plane(data_t *data, enum pipe pipe,
 			continue;
 
 		if (!mask || !(parms[i].mask & mask)) {
-			if (plane->values[IGT_PLANE_FB_ID]) {
+			if (plane->values[IGT_PLANE_FB_ID] && plane->type != DRM_PLANE_TYPE_PRIMARY) {
 				igt_plane_set_fb(plane, NULL);
 				planes_set_up++;
 			}
@@ -516,10 +516,9 @@ run_transition_test(data_t *data, enum pipe pipe, igt_output_t *output,
 		igt_output_set_pipe(output, pipe);
 	}
 
-	igt_display_commit2(&data->display, COMMIT_ATOMIC);
-
 	setup_parms(data, pipe, mode, &fb, &argb_fb, &sprite_fb, parms, &iter_max);
-
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	
 	/*
 	 * In some configurations the tests may not run to completion with all
 	 * sprite planes lit up at 4k resolution, try decreasing width/size of secondary
-- 
2.31.0.rc2.261.g7f71774620-goog

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-04-12 16:21 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-23 15:08 [igt-dev] [PATCH] tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC Mark Yacoub
2021-03-24  9:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC. (rev2) Patchwork
2021-03-24 20:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-25 16:59   ` Mark Yacoub
2021-03-26  9:25     ` Petri Latvala
2021-03-26 17:39       ` Vudum, Lakshminarayana
2021-03-29 14:10         ` Mark Yacoub
2021-03-29 14:19           ` Petri Latvala
2021-03-29 14:24             ` Mark Yacoub
2021-04-05 18:36               ` Mark Yacoub
2021-04-05 18:57                 ` Vudum, Lakshminarayana
2021-03-26 16:35 ` Patchwork
2021-03-26 17:23 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2021-04-12 16:21 ` [igt-dev] [PATCH] tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC Mark Yacoub

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox