* [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds
@ 2018-01-31 19:39 Antonio Argenziano
2018-01-31 19:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Antonio Argenziano @ 2018-01-31 19:39 UTC (permalink / raw)
To: igt-dev; +Cc: Joonas Lahtinen
Subtest 'secure-non-master' tries to drop drm-master privileges on a
non drm-master fd. Instead drop master privileges after the subtest
acquires it so that other subtests are not affected by it.
Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
tests/gem_exec_params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
index e1c48b40..dbd89e7c 100644
--- a/tests/gem_exec_params.c
+++ b/tests/gem_exec_params.c
@@ -343,13 +343,13 @@ igt_main
}
igt_subtest("secure-non-master") {
- igt_device_drop_master(fd);
execbuf.flags = I915_EXEC_RENDER | I915_EXEC_SECURE;
RUN_FAIL(EPERM);
igt_device_set_master(fd);
igt_assert(drmIoctl(fd,
DRM_IOCTL_I915_GEM_EXECBUFFER2,
&execbuf) == 0);
+ igt_device_drop_master(fd); /* Only needs temporary master */
}
/* HANDLE_LUT and NO_RELOC are already exercised by gem_exec_lut_handle,
--
2.14.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_exec_params: Drop drm master privileges only on drm master fds
2018-01-31 19:39 [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds Antonio Argenziano
@ 2018-01-31 19:58 ` Patchwork
2018-01-31 20:52 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-01-31 21:38 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-01-31 19:58 UTC (permalink / raw)
To: Antonio Argenziano; +Cc: igt-dev
== Series Details ==
Series: igt/gem_exec_params: Drop drm master privileges only on drm master fds
URL : https://patchwork.freedesktop.org/series/37434/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
7f0be0e7d9becb79630093bf0e6daeadcd937062 tools/intel_reg: Add reading and writing registers through engine
with latest DRM-Tip kernel build CI_DRM_3708
ae93f9b9acf3 drm-tip: 2018y-01m-31d-16h-31m-38s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test kms_chamelium:
Subgroup common-hpd-after-suspend:
dmesg-warn -> PASS (fi-skl-6700k2) fdo#104108
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:427s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:427s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:283s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:482s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:487s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:469s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:455s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:574s
fi-elk-e7500 total:224 pass:168 dwarn:9 dfail:1 fail:0 skip:45
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:282s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:511s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:400s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:417s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:458s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:411s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:460s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:498s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:452s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:498s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:578s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:434s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:525s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:485s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:489s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:416s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:427s
fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:402s
Blacklisted hosts:
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:476s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_843/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds
2018-01-31 19:39 [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds Antonio Argenziano
2018-01-31 19:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-31 20:52 ` Chris Wilson
2018-01-31 21:07 ` Chris Wilson
2018-01-31 21:38 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-01-31 20:52 UTC (permalink / raw)
To: Antonio Argenziano, igt-dev; +Cc: Joonas Lahtinen
Quoting Antonio Argenziano (2018-01-31 19:39:01)
> Subtest 'secure-non-master' tries to drop drm-master privileges on a
> non drm-master fd. Instead drop master privileges after the subtest
> acquires it so that other subtests are not affected by it.
>
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> tests/gem_exec_params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index e1c48b40..dbd89e7c 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -343,13 +343,13 @@ igt_main
> }
>
> igt_subtest("secure-non-master") {
igt_require(iamroot());
> - igt_device_drop_master(fd);
Hmm, we shouldn't have to assume we are master here, so
__igt_device_drop_master(fd)? That documents the intent of the test more
carefully that even root with non-master is prohibited from frobbing
privileged registers (which include display registers, hence the master
restriction).
> execbuf.flags = I915_EXEC_RENDER | I915_EXEC_SECURE;
> RUN_FAIL(EPERM);
> igt_device_set_master(fd);
> igt_assert(drmIoctl(fd,
> DRM_IOCTL_I915_GEM_EXECBUFFER2,
> &execbuf) == 0);
> + igt_device_drop_master(fd); /* Only needs temporary master */
Ok.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds
2018-01-31 20:52 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-01-31 21:07 ` Chris Wilson
2018-01-31 21:21 ` Antonio Argenziano
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-01-31 21:07 UTC (permalink / raw)
To: Antonio Argenziano, igt-dev; +Cc: Joonas Lahtinen
Quoting Chris Wilson (2018-01-31 20:52:45)
> Quoting Antonio Argenziano (2018-01-31 19:39:01)
> > Subtest 'secure-non-master' tries to drop drm-master privileges on a
> > non drm-master fd. Instead drop master privileges after the subtest
> > acquires it so that other subtests are not affected by it.
> >
> > Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > ---
> > tests/gem_exec_params.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > index e1c48b40..dbd89e7c 100644
> > --- a/tests/gem_exec_params.c
> > +++ b/tests/gem_exec_params.c
> > @@ -343,13 +343,13 @@ igt_main
> > }
> >
> > igt_subtest("secure-non-master") {
>
> igt_require(iamroot());
>
> > - igt_device_drop_master(fd);
Or maybe:
igt_require(__igt_device_set_master(fd)); /* requires root privilege */
igt_device_drop_master(fd);
?
To verify we can obtain DRM_MASTER if we wanted it, and assert that we
don't have it for the actual test.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds
2018-01-31 21:07 ` Chris Wilson
@ 2018-01-31 21:21 ` Antonio Argenziano
0 siblings, 0 replies; 6+ messages in thread
From: Antonio Argenziano @ 2018-01-31 21:21 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: Joonas Lahtinen
On 31/01/18 13:07, Chris Wilson wrote:
> Quoting Chris Wilson (2018-01-31 20:52:45)
>> Quoting Antonio Argenziano (2018-01-31 19:39:01)
>>> Subtest 'secure-non-master' tries to drop drm-master privileges on a
>>> non drm-master fd. Instead drop master privileges after the subtest
>>> acquires it so that other subtests are not affected by it.
>>>
>>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> ---
>>> tests/gem_exec_params.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
>>> index e1c48b40..dbd89e7c 100644
>>> --- a/tests/gem_exec_params.c
>>> +++ b/tests/gem_exec_params.c
>>> @@ -343,13 +343,13 @@ igt_main
>>> }
>>>
>>> igt_subtest("secure-non-master") {
>>
>> igt_require(iamroot());
>>
>>> - igt_device_drop_master(fd);
>
> Or maybe:
> igt_require(__igt_device_set_master(fd)); /* requires root privilege */
> igt_device_drop_master(fd);
> ?
Yep, which is very similar to opening a local fd as master.
Thanks,
Antonio
>
> To verify we can obtain DRM_MASTER if we wanted it, and assert that we
> don't have it for the actual test.
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for igt/gem_exec_params: Drop drm master privileges only on drm master fds
2018-01-31 19:39 [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds Antonio Argenziano
2018-01-31 19:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-31 20:52 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-01-31 21:38 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-01-31 21:38 UTC (permalink / raw)
To: Antonio Argenziano; +Cc: igt-dev
== Series Details ==
Series: igt/gem_exec_params: Drop drm master privileges only on drm master fds
URL : https://patchwork.freedesktop.org/series/37434/
State : failure
== Summary ==
Test kms_flip:
Subgroup wf_vblank-ts-check-interruptible:
fail -> PASS (shard-apl) fdo#100368
Subgroup basic-plain-flip:
skip -> PASS (shard-apl)
Subgroup modeset-vs-vblank-race-interruptible:
fail -> PASS (shard-apl) fdo#103060
Test kms_vblank:
Subgroup pipe-b-accuracy-idle:
skip -> PASS (shard-apl)
Subgroup pipe-c-wait-forked-busy:
skip -> PASS (shard-apl)
Subgroup crtc-id:
skip -> PASS (shard-apl)
Subgroup pipe-a-query-busy:
skip -> PASS (shard-apl)
Subgroup pipe-c-ts-continuation-suspend:
dmesg-warn -> PASS (shard-apl)
Test kms_cursor_crc:
Subgroup cursor-256x256-rapid-movement:
skip -> PASS (shard-apl) fdo#103326
Subgroup cursor-128x42-random:
skip -> PASS (shard-apl)
Subgroup cursor-256x256-dpms:
skip -> PASS (shard-apl)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-c-frame-sequence:
skip -> PASS (shard-apl) fdo#103481
Subgroup read-crc-pipe-a:
skip -> PASS (shard-apl)
Subgroup read-crc-pipe-c:
skip -> PASS (shard-apl) fdo#103191
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-shrfb-draw-blt:
skip -> PASS (shard-apl) fdo#101623 +2
Subgroup fbc-1p-primscrn-spr-indfb-draw-render:
skip -> PASS (shard-apl) fdo#103167 +1
Subgroup fbc-rgb101010-draw-mmap-gtt:
skip -> PASS (shard-apl)
Test kms_color:
Subgroup pipe-a-ctm-0-75:
skip -> PASS (shard-apl)
Test kms_cursor_legacy:
Subgroup basic-flip-after-cursor-varying-size:
skip -> PASS (shard-apl) fdo#102670
Subgroup cursora-vs-flipa-atomic:
skip -> PASS (shard-apl)
Test kms_draw_crc:
Subgroup draw-method-xrgb8888-render-untiled:
skip -> PASS (shard-apl)
Subgroup draw-method-xrgb2101010-render-xtiled:
skip -> PASS (shard-apl)
Test gem_eio:
Subgroup in-flight-contexts:
fail -> PASS (shard-hsw) fdo#104676 +2
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-apl) fdo#99912
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-c:
skip -> PASS (shard-apl)
Subgroup extended-modeset-hang-oldfb-with-reset-render-c:
skip -> PASS (shard-apl) fdo#103336
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047
Test kms_chv_cursor_fail:
Subgroup pipe-a-128x128-bottom-edge:
skip -> PASS (shard-apl)
Test kms_ccs:
Subgroup pipe-b-bad-pixel-format:
skip -> PASS (shard-apl)
Test kms_plane_scaling:
Subgroup pipe-c-plane-scaling:
skip -> PASS (shard-apl)
Test gem_exec_params:
Subgroup secure-non-master:
pass -> FAIL (shard-snb)
pass -> FAIL (shard-hsw)
pass -> FAIL (shard-apl)
Test kms_plane_multiple:
Subgroup legacy-pipe-a-tiling-x:
skip -> PASS (shard-apl)
Subgroup atomic-pipe-b-tiling-yf:
fail -> PASS (shard-apl)
Test kms_rmfb:
Subgroup rmfb-ioctl:
skip -> PASS (shard-apl)
Test kms_rotation_crc:
Subgroup primary-rotation-90-y-tiled:
skip -> PASS (shard-apl)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103326 https://bugs.freedesktop.org/show_bug.cgi?id=103326
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#104676 https://bugs.freedesktop.org/show_bug.cgi?id=104676
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#103336 https://bugs.freedesktop.org/show_bug.cgi?id=103336
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:2838 pass:1751 dwarn:1 dfail:0 fail:22 skip:1064 time:12863s
shard-hsw total:2838 pass:1734 dwarn:1 dfail:0 fail:12 skip:1090 time:11994s
shard-snb total:2838 pass:1329 dwarn:1 dfail:0 fail:11 skip:1497 time:6574s
Blacklisted hosts:
shard-kbl total:2778 pass:1831 dwarn:1 dfail:0 fail:23 skip:922 time:9361s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_843/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-31 21:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-31 19:39 [igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds Antonio Argenziano
2018-01-31 19:58 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-31 20:52 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-01-31 21:07 ` Chris Wilson
2018-01-31 21:21 ` Antonio Argenziano
2018-01-31 21:38 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox