Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/i915/perf: Propagate return from unsupported_i915_perf_platform
@ 2022-11-16 17:07 Ashutosh Dixit
  2022-11-16 17:28 ` Das, Nirmoy
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ashutosh Dixit @ 2022-11-16 17:07 UTC (permalink / raw)
  To: igt-dev

NULL return from unsupported_i915_perf_platform must be propagated up the
call stack to inform callers of intel_perf_for_devinfo and
intel_perf_for_fd.

Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7358
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/i915/perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/i915/perf.c b/lib/i915/perf.c
index 28f37948e52..4a946906a84 100644
--- a/lib/i915/perf.c
+++ b/lib/i915/perf.c
@@ -366,7 +366,7 @@ intel_perf_for_devinfo(uint32_t device_id,
 			intel_perf_load_metrics_tglgt2(perf);
 			break;
 		default:
-			unsupported_i915_perf_platform(perf);
+			return unsupported_i915_perf_platform(perf);
 		}
 	} else if (devinfo->is_rocketlake) {
 		intel_perf_load_metrics_rkl(perf);
@@ -391,7 +391,7 @@ intel_perf_for_devinfo(uint32_t device_id,
 		else if (is_acm_gt3(&perf->devinfo))
 			intel_perf_load_metrics_acmgt3(perf);
 		else
-			unsupported_i915_perf_platform(perf);
+			return unsupported_i915_perf_platform(perf);
 	} else {
 		return unsupported_i915_perf_platform(perf);
 	}
-- 
2.38.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-17  2:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-16 17:07 [igt-dev] [PATCH i-g-t] lib/i915/perf: Propagate return from unsupported_i915_perf_platform Ashutosh Dixit
2022-11-16 17:28 ` Das, Nirmoy
2022-11-16 18:41 ` Lionel Landwerlin
2022-11-16 18:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-17  2:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox