Re: [PATCH i-g-t] lib/amdgpu: add GFX1153 to GFX1150 family

[vitaly prosyak <vprosyak@amd.com>]

The change looks good to me. Please create a Git patch and send it my way, or if you have the necessary access, feel free to merge it directly.

Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>

On 2024-12-30 01:56, Tim Huang wrote:
> Add GFX1153 to the amdgpu supported chip list.
>
> Signed-off-by: Tim Huang <tim.huang@amd.com>
> ---
>  lib/amdgpu/amd_family.h       | 1 +
>  lib/amdgpu/amd_ip_blocks.c    | 1 +
>  lib/amdgpu/amdgpu_asic_addr.h | 2 ++
>  3 files changed, 4 insertions(+)
>
> diff --git a/lib/amdgpu/amd_family.h b/lib/amdgpu/amd_family.h
> index 54b0ae1d8..60190c639 100644
> --- a/lib/amdgpu/amd_family.h
> +++ b/lib/amdgpu/amd_family.h
> @@ -107,6 +107,7 @@ enum radeon_family {
>  	CHIP_GFX1150,
>  	CHIP_GFX1151,
>  	CHIP_GFX1152,
> +	CHIP_GFX1153,
>  	CHIP_GFX1200,
>  	CHIP_LAST,
>  };
> diff --git a/lib/amdgpu/amd_ip_blocks.c b/lib/amdgpu/amd_ip_blocks.c
> index 980bb9b0b..cc4163bfc 100644
> --- a/lib/amdgpu/amd_ip_blocks.c
> +++ b/lib/amdgpu/amd_ip_blocks.c
> @@ -800,6 +800,7 @@ int setup_amdgpu_ip_blocks(uint32_t major, uint32_t minor, struct amdgpu_gpu_inf
>  		identify_chip(GFX1150);
>  		identify_chip(GFX1151);
>  		identify_chip(GFX1152);
> +		identify_chip(GFX1153);
>  		break;
>  	case FAMILY_GFX1200:
>  		identify_chip(GFX1200);
> diff --git a/lib/amdgpu/amdgpu_asic_addr.h b/lib/amdgpu/amdgpu_asic_addr.h
> index d5579ce4c..63cea1a5d 100644
> --- a/lib/amdgpu/amdgpu_asic_addr.h
> +++ b/lib/amdgpu/amdgpu_asic_addr.h
> @@ -110,6 +110,7 @@
>  #define AMDGPU_GFX1150_RANGE     0x01, 0x40 //# 01 <= x < 64
>  #define AMDGPU_GFX1151_RANGE     0xc0, 0xFF //# 192 <= x < 255
>  #define AMDGPU_GFX1152_RANGE     0x40, 0x50 //# 64 <= x < 80
> +#define AMDGPU_GFX1153_RANGE     0x50, 0xC0 //# 80 <= x < 192
>  #define AMDGPU_GFX1200_RANGE     0x01, 0xFF //# 01 <= x < 255
>  
>  #define AMDGPU_EXPAND_FIX(x) x
> @@ -177,6 +178,7 @@
>  #define ASICREV_IS_GFX1150(r)          ASICREV_IS(r, GFX1150)
>  #define ASICREV_IS_GFX1151(r)          ASICREV_IS(r, GFX1151)
>  #define ASICREV_IS_GFX1152(r)          ASICREV_IS(r, GFX1152)
> +#define ASICREV_IS_GFX1153(r)          ASICREV_IS(r, GFX1153)
>  #define ASICREV_IS_GFX1200(r)          ASICREV_IS(r, GFX1200)
>  
>  #endif // _AMDGPU_ASIC_ADDR_H