* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size
@ 2022-12-23 10:27 Swati Sharma
2022-12-23 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Swati Sharma @ 2022-12-23 10:27 UTC (permalink / raw)
To: igt-dev
From: Swati2 Sharma <swati2.sharma@intel.com>
Test is added for i915 devices to validate max source size.
This test is expected to pass for platforms having
11 <= display ver < 14 since for these platforms max source
size supported is 5120. For remaining platforms this test is
expected to fail since max source size supported is 4096.
In this test, we are creating 4k fb and trying to upscale it to
5k on a 5k monitor. Platforms having max source size of 5120
will be able to do it, and for remaining platforms its expected
to get -EINVAL.
Signed-off-by: Swati2 Sharma <swati2.sharma@intel.com>
---
tests/kms_plane_scaling.c | 64 +++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4c621cce..170e8c28 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -26,6 +26,8 @@
#include "igt_vec.h"
#include <math.h>
+#define HDISPLAY_5K 5120
+
IGT_TEST_DESCRIPTION("Test display plane scaling");
enum scaler_combo_test_type {
@@ -674,6 +676,49 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
igt_remove_fb(display->drm_fd, &d->fb[2]);
}
+static void
+test_max_source_size(data_t *d, enum pipe pipe, igt_output_t *output)
+{
+ igt_display_t *display = &d->display;
+ int w_4k = 4096, h_4k = 2160;
+ int w_5k = 5120, h_5k = 2880;
+ igt_plane_t *plane;
+ int ret;
+
+ cleanup_crtc(d);
+
+ igt_output_set_pipe(output, pipe);
+
+ plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_require(plane);
+
+ igt_create_color_pattern_fb(display->drm_fd,
+ w_4k, h_4k,
+ DRM_FORMAT_XRGB8888,
+ I915_TILING_NONE,
+ 1.0, 0.0, 0.0, &d->fb[0]);
+
+ igt_plane_set_fb(plane, &d->fb[0]);
+ igt_plane_set_size(plane, w_5k, h_5k);
+
+ /* This commit is expected to pass for platforms having
+ * 11 <= display ver < 14 since for these platforms max source
+ * size supported is 5120. For remaining platforms, this test is
+ * expected to fail since max source size supported is 4096.
+ * In dmesg we can find: size is out of scaler range in the case
+ * of failure.
+ * */
+ ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+ if (intel_display_ver(d->devid) >= 11 && intel_display_ver(d->devid) < 14)
+ igt_assert_eq(ret, 0);
+ else
+ igt_assert_eq(ret, -EINVAL);
+
+ igt_plane_set_fb(plane, NULL);
+ igt_remove_fb(display->drm_fd, &d->fb[0]);
+}
+
static void
test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
{
@@ -970,6 +1015,25 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
}
}
+ igt_fixture
+ igt_require_f(data.devid, "This test is valid only for i915 devices\n");
+
+ igt_describe("Test for max source size.");
+ igt_subtest_with_dynamic("max-source-size") {
+ for_each_pipe_with_valid_output(&data.display, pipe, output) {
+ drmModeModeInfo *mode;
+
+ mode = igt_output_get_mode(output);
+
+ if (mode->hdisplay < HDISPLAY_5K)
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s-max-source-size",
+ kmstest_pipe_name(pipe), igt_output_name(output))
+ test_max_source_size(&data, pipe, output);
+ }
+ }
+
igt_describe("Negative test for number of scalers per pipe.");
igt_subtest_with_dynamic("invalid-num-scalers") {
for_each_pipe_with_valid_output(&data.display, pipe, output)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Add test to validate max source size
2022-12-23 10:27 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size Swati Sharma
@ 2022-12-23 11:04 ` Patchwork
2022-12-23 12:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-12-23 11:04 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 3661 bytes --]
== Series Details ==
Series: tests/kms_plane_scaling: Add test to validate max source size
URL : https://patchwork.freedesktop.org/series/112206/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12524 -> IGTPW_8269
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
Participating hosts (45 -> 45)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_8269 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- bat-adlp-4: [PASS][1] -> [DMESG-WARN][2] ([i915#2867])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/bat-adlp-4/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/bat-adlp-4/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: [PASS][3] -> [INCOMPLETE][4] ([i915#7156])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- bat-adlp-4: [DMESG-FAIL][5] ([i915#7699]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/bat-adlp-4/igt@i915_selftest@live@migrate.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/bat-adlp-4/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@mman:
- {bat-rpls-1}: [TIMEOUT][7] ([i915#6794]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/bat-rpls-1/igt@i915_selftest@live@mman.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@workarounds:
- {bat-rpls-1}: [DMESG-WARN][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/bat-rpls-1/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/bat-rpls-1/igt@i915_selftest@live@workarounds.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7336]: https://gitlab.freedesktop.org/drm/intel/issues/7336
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7102 -> IGTPW_8269
CI-20190529: 20190529
CI_DRM_12524: a29956c69a562e85ef8657e39382bc207a339941 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8269: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_plane_scaling@max-source-size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
[-- Attachment #2: Type: text/html, Size: 4045 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_scaling: Add test to validate max source size
2022-12-23 10:27 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size Swati Sharma
2022-12-23 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-12-23 12:29 ` Patchwork
2022-12-30 10:31 ` [igt-dev] [PATCH i-g-t] " Luca Coelho
[not found] ` <23be17762e6c65a5ceebaa4a27d00b566dd9e5a2.camel@intel.com>
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-12-23 12:29 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 25397 bytes --]
== Series Details ==
Series: tests/kms_plane_scaling: Add test to validate max source size
URL : https://patchwork.freedesktop.org/series/112206/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12524_full -> IGTPW_8269_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8269_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8269_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
Participating hosts (13 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8269_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-apl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl3/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* {igt@kms_plane_scaling@max-source-size} (NEW):
- {shard-rkl}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-2/igt@kms_plane_scaling@max-source-size.html
- {shard-dg1}: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-dg1-17/igt@kms_plane_scaling@max-source-size.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_lease@lease_unleased_connector@pipe-c-hdmi-a-4:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][5] +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-dg1-17/igt@kms_lease@lease_unleased_connector@pipe-c-hdmi-a-4.html
New tests
---------
New tests have been introduced between CI_DRM_12524_full and IGTPW_8269_full:
### New IGT tests (1) ###
* igt@kms_plane_scaling@max-source-size:
- Statuses : 5 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_8269_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@multigpu-basic-process:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271]) +98 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl2/igt@gem_close_race@multigpu-basic-process.html
* igt@gem_ctx_persistence@legacy-engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-snb5/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl2/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk7/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_color_chamelium@ctm-negative:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl1/igt@kms_color_chamelium@ctm-negative.html
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-snb2/igt@kms_color_chamelium@ctm-negative.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271]) +66 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk4/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#4573]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl6/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html
* igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-b-hdmi-a-2:
- shard-glk: NOTRUN -> [FAIL][17] ([i915#4573]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk7/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-b-hdmi-a-2.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl7/igt@kms_psr2_sf@cursor-plane-update-sf.html
- shard-glk: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_rotation_crc@sprite-rotation-270:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271]) +124 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-snb4/igt@kms_rotation_crc@sprite-rotation-270.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#533])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl7/igt@kms_vblank@pipe-d-wait-idle.html
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#533])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk9/igt@kms_vblank@pipe-d-wait-idle.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2994]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl1/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@sema-10:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2994]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk2/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_ctx_persistence@engines-hang@bcs0:
- {shard-rkl}: [SKIP][25] ([i915#6252]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-1/igt@gem_ctx_persistence@engines-hang@bcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][27] ([i915#2842]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][29] ([i915#3281]) -> [PASS][30] +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-2/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl}: [SKIP][31] ([i915#1850]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-1/igt@gem_mmap_wc@set-cache-level.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@gem_mmap_wc@set-cache-level.html
* igt@gem_partial_pwrite_pread@writes-after-reads-display:
- shard-apl: [INCOMPLETE][33] ([i915#7708]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl2/igt@gem_partial_pwrite_pread@writes-after-reads-display.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl6/igt@gem_partial_pwrite_pread@writes-after-reads-display.html
* igt@gen9_exec_parse@bb-start-far:
- {shard-rkl}: [SKIP][35] ([i915#2527]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-6/igt@gen9_exec_parse@bb-start-far.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-5/igt@gen9_exec_parse@bb-start-far.html
* igt@i915_hangman@gt-engine-error@bcs0:
- {shard-rkl}: [SKIP][37] ([i915#6258]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-4/igt@i915_hangman@gt-engine-error@bcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][39] ([i915#1397]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-2/igt@i915_pm_rpm@dpms-lpsp.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][41] ([i915#1397]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-dg1-16/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_atomic@plane-overlay-legacy:
- {shard-rkl}: [SKIP][43] ([i915#1845] / [i915#4098]) -> [PASS][44] +14 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-1/igt@kms_atomic@plane-overlay-legacy.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_atomic@plane-overlay-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][45] ([i915#2346]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [FAIL][47] ([i915#2346]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@plain-flip-ts-check@c-hdmi-a1:
- shard-glk: [FAIL][49] ([i915#2122]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-glk3/igt@kms_flip@plain-flip-ts-check@c-hdmi-a1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-glk6/igt@kms_flip@plain-flip-ts-check@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- {shard-rkl}: [SKIP][51] ([i915#1849] / [i915#4098]) -> [PASS][52] +14 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][53] ([i915#1849] / [i915#3558]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-2/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@sprite_mmap_cpu:
- {shard-rkl}: [SKIP][55] ([i915#1072]) -> [PASS][56] +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-4/igt@kms_psr@sprite_mmap_cpu.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_psr@sprite_mmap_cpu.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- {shard-rkl}: [SKIP][57] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-1/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- {shard-rkl}: [SKIP][59] ([i915#4098]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-rkl-4/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
#### Warnings ####
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-apl: [INCOMPLETE][61] -> [INCOMPLETE][62] ([i915#7708])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl3/igt@gem_partial_pwrite_pread@writes-after-reads.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl2/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [FAIL][63] ([i915#4275]) -> [SKIP][64] ([fdo#109271])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [FAIL][65] ([i915#4573]) -> [DMESG-FAIL][66] ([IGT#6]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12524/shard-apl1/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/shard-apl3/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7397]: https://gitlab.freedesktop.org/drm/intel/issues/7397
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7708]: https://gitlab.freedesktop.org/drm/intel/issues/7708
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7102 -> IGTPW_8269
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12524: a29956c69a562e85ef8657e39382bc207a339941 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8269: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
IGT_7102: bacfdc84a9c02556c5441deb21e3a3f18a07347d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8269/index.html
[-- Attachment #2: Type: text/html, Size: 21519 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size
2022-12-23 10:27 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size Swati Sharma
2022-12-23 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-23 12:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-12-30 10:31 ` Luca Coelho
[not found] ` <23be17762e6c65a5ceebaa4a27d00b566dd9e5a2.camel@intel.com>
3 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2022-12-30 10:31 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
On Fri, 2022-12-23 at 15:57 +0530, Swati Sharma wrote:
> > From: Swati2 Sharma <swati2.sharma@intel.com>
> >
> > Test is added for i915 devices to validate max source size.
> > This test is expected to pass for platforms having
> > 11 <= display ver < 14 since for these platforms max source
> > size supported is 5120.
This is not entirely true, as we discussed. For display_ver <= 11, the
maximum source and destination sizes are 4K for both width and height.
> > For remaining platforms this test is
> > expected to fail since max source size supported is 4096.
Maybe it's better to specify the actual values for each platform here
(and in a comment in the code). For the record, these are the values
as we discussed:
Before Display Version 11: Max Source Width: 4K
Max Source Height: 4K
Max Dest. Width: 4K
Max Dest. Height: 4K
Display Version 11: Max Source Width: 5K
Max Source Height: 4K
Max Dest. Width: 5K
Max Dest. Height: 4K
Display Versions 12-13: Max Source Width: 5K
Max Source Height: 8K
Max Dest. Width: 8K
Max Dest. Height: 8K
Display Version 14+: Max Source Width: 4K
Max Source Height: 8K
Max Dest. Width: 8K
Max Dest. Height: 8K
> > In this test, we are creating 4k fb and trying to upscale it to
> > 5k on a 5k monitor. Platforms having max source size of 5120
> > will be able to do it, and for remaining platforms its expected
> > to get -EINVAL.
> >
> > Signed-off-by: Swati2 Sharma <swati2.sharma@intel.com>
> > ---
> > tests/kms_plane_scaling.c | 64
> > +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 64 insertions(+)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 4c621cce..170e8c28 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
[...]
> > @@ -970,6 +1015,25 @@ igt_main_args("", long_opts, help_str,
> > opt_handler, &data)
> > }
> > }
> >
> > + igt_fixture
> > + igt_require_f(data.devid, "This test is
> > valid only for i915 devices\n");
> > +
> > + igt_describe("Test for max source size.");
> > + igt_subtest_with_dynamic("max-source-size") {
> > + for_each_pipe_with_valid_output(&data.disp
> > lay, pipe, output) {
> > + drmModeModeInfo *mode;
> > +
> > + mode =
> > igt_output_get_mode(output);
> > +
> > + if (mode->hdisplay <
> > HDISPLAY_5K)
> > + continue;
For the record, I discussed this with you (Swati) and there was a
misinterpretation of the HAS. It says "4kto5k->5kto8k not supported"
and it was interpreted as if 4k source to 5k destination is not
possible, but in fact it means "from anything between 4K to 5K
(source) to anything between 5K and 8K (destination) is not supported".
Swati said she's going to update the tests accordingly and send a new
version of this patch.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size
[not found] ` <23be17762e6c65a5ceebaa4a27d00b566dd9e5a2.camel@intel.com>
@ 2022-12-30 18:57 ` Swati Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Swati Sharma @ 2022-12-30 18:57 UTC (permalink / raw)
To: Coelho, Luciano; +Cc: igt-dev@lists.freedesktop.org
Thanks Luca for the review comments.
Will make changes accordingly and float new rev.
On 30-Dec-22 3:56 PM, Coelho, Luciano wrote:
> On Fri, 2022-12-23 at 15:57 +0530, Swati Sharma wrote:
>>> From: Swati2 Sharma <swati2.sharma@intel.com>
>>>
>>> Test is added for i915 devices to validate max source size.
>>> This test is expected to pass for platforms having
>>> 11 <= display ver < 14 since for these platforms max source
>>> size supported is 5120.
>
> This is not entirely true, as we discussed. For display_ver <= 11, the
> maximum source and destination sizes are 4K for both width and height.
>
>
>>> For remaining platforms this test is
>>> expected to fail since max source size supported is 4096.
>
> Maybe it's better to specify the actual values for each platform here
> (and in a comment in the code). For the record, these are the values
> as we discussed:
>
> Before Display Version 11: Max Source Width: 4K
> Max Source Height: 4K
> Max Dest. Width: 4K
> Max Dest. Height: 4K
>
> Display Version 11: Max Source Width: 5K
> Max Source Height: 4K
>
> Max Dest. Width: 5K
> Max Dest. Height: 4K
>
>
> Display Versions 12-13: Max Source Width: 5K
> Max Source Height: 8K
>
> Max Dest. Width: 8K
> Max Dest. Height: 8K
>
> Display Version 14+: Max Source Width: 4K
> Max Source Height: 8K
> Max Dest. Width: 8K
> Max Dest. Height: 8K
>
>
>>> In this test, we are creating 4k fb and trying to upscale it to
>>> 5k on a 5k monitor. Platforms having max source size of 5120
>>> will be able to do it, and for remaining platforms its expected
>>> to get -EINVAL.
>>>
>>> Signed-off-by: Swati2 Sharma <swati2.sharma@intel.com>
>>> ---
>>> tests/kms_plane_scaling.c | 64 +++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 64 insertions(+)
>>>
>>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>>> index 4c621cce..170e8c28 100644
>>> --- a/tests/kms_plane_scaling.c
>>> +++ b/tests/kms_plane_scaling.c
>
> [...]
>
>
>>> @@ -970,6 +1015,25 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>>> }
>>> }
>>>
>>> + igt_fixture
>>> + igt_require_f(data.devid, "This test is valid only for i915 devices\n");
>>> +
>>> + igt_describe("Test for max source size.");
>>> + igt_subtest_with_dynamic("max-source-size") {
>>> + for_each_pipe_with_valid_output(&data.display, pipe, output) {
>>> + drmModeModeInfo *mode;
>>> +
>>> + mode = igt_output_get_mode(output);
>>> +
>>> + if (mode->hdisplay < HDISPLAY_5K)
>>> + continue;
>
> For the record, I discussed this with you (Swati) and there was a
> misinterpretation of the HAS. It says "4kto5k->5kto8k not supported"
> and it was interpreted as if 4k source to 5k destination is not
> possible, but in fact it means "from anything between 4K to 5K
> (source) to anything between 5K and 8K (destination) is not supported".
>
> Swati said she's going to update the tests accordingly and send a new
> version of this patch.
>
> --
> Cheers,
> Luca.
--
~Swati Sharma
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-30 18:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-23 10:27 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Add test to validate max source size Swati Sharma
2022-12-23 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-23 12:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-12-30 10:31 ` [igt-dev] [PATCH i-g-t] " Luca Coelho
[not found] ` <23be17762e6c65a5ceebaa4a27d00b566dd9e5a2.camel@intel.com>
2022-12-30 18:57 ` Swati Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox