From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v2] gem_wsim: Implement device selection
Date: Wed, 18 Nov 2020 11:56:02 +0000 [thread overview]
Message-ID: <bad6ead7-30b6-fc26-dfbb-76d1ed913c6d@linux.intel.com> (raw)
In-Reply-To: <160562198607.22621.14513375230209122787@build.alporthouse.com>
On 17/11/2020 14:06, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-11-17 13:59:18)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> -L and -D <device> on the command line.
>>
>> With no device specified tool tries to find i915 discrete or integrated in
>> that order.
>>
>> v2:
>> * Fix error handling and support render devices.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Hmm, optarg should be a pointer into the argv, so is the copy necessary?
I don't remember if I tried, and I don't see that getopt(3) explains
optarg from that angle, so probably safest to keep as is. Too lazy to
try.. Or maybe presence of strdup suggests I did already try and that
optarg is indeed temporary copy managed by getopt.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-11-18 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 11:40 [igt-dev] [PATCH i-g-t] gem_wsim: Implement device selection Tvrtko Ursulin
2020-11-17 11:51 ` [Intel-gfx] " Chris Wilson
2020-11-17 12:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-17 12:18 ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2020-11-17 12:33 ` Tvrtko Ursulin
2020-11-17 12:37 ` [igt-dev] " Chris Wilson
2020-11-17 13:59 ` [igt-dev] [PATCH i-g-t v2] " Tvrtko Ursulin
2020-11-17 14:06 ` Chris Wilson
2020-11-18 11:56 ` Tvrtko Ursulin [this message]
2020-11-17 14:04 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2020-11-17 15:27 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_wsim: Implement device selection (rev2) Patchwork
2020-11-17 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bad6ead7-30b6-fc26-dfbb-76d1ed913c6d@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox