Re: [PATCH i-g-t] tests/intel/kms_sharpness_filter: Fix redundant mode override

[Karthik B S <karthik.b.s@intel.com>]

On 4/14/2026 11:39 AM, Pranay Samala wrote:
> Move override mode into if block to avoid redundancy.
>
> Fixes: 15663498141b ("tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass")
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/intel/kms_sharpness_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
> index 15c5e6006..bdfdf1d08 100644
> --- a/tests/intel/kms_sharpness_filter.c
> +++ b/tests/intel/kms_sharpness_filter.c
> @@ -453,6 +453,8 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>   					continue;
>   				}
>   
> +				igt_output_override_mode(data->output, data->mode);
> +
>   				igt_info("Executing on non-joiner mode %dx%d@%d\n",
>   					 data->mode->hdisplay,
>   					 data->mode->vdisplay,
> @@ -461,8 +463,6 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>   				data->mode = igt_output_get_mode(data->output);
>   			}
>   
> -			igt_output_override_mode(data->output, data->mode);
> -
>   			if (!has_sharpness_filter(data->crtc)) {
>   				igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
>   				igt_crtc_name(data->crtc));