public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/intel/kms_sharpness_filter: Fix redundant mode override
Date: Tue, 14 Apr 2026 11:39:27 +0530	[thread overview]
Message-ID: <20260414060927.3182287-1-pranay.samala@intel.com> (raw)

Move override mode into if block to avoid redundancy.

Fixes: 15663498141b ("tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass")
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_sharpness_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index 15c5e6006..bdfdf1d08 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -453,6 +453,8 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 					continue;
 				}
 
+				igt_output_override_mode(data->output, data->mode);
+
 				igt_info("Executing on non-joiner mode %dx%d@%d\n",
 					 data->mode->hdisplay,
 					 data->mode->vdisplay,
@@ -461,8 +463,6 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 				data->mode = igt_output_get_mode(data->output);
 			}
 
-			igt_output_override_mode(data->output, data->mode);
-
 			if (!has_sharpness_filter(data->crtc)) {
 				igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
 				igt_crtc_name(data->crtc));
-- 
2.34.1


             reply	other threads:[~2026-04-14  5:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  6:09 Pranay Samala [this message]
2026-04-14  6:55 ` ✓ Xe.CI.BAT: success for tests/intel/kms_sharpness_filter: Fix redundant mode override Patchwork
2026-04-14  6:55 ` ✓ i915.CI.BAT: " Patchwork
2026-04-14  8:18 ` [PATCH i-g-t] " Karthik B S
2026-04-14  8:34 ` ✗ Xe.CI.FULL: failure for " Patchwork
2026-04-14 11:38 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414060927.3182287-1-pranay.samala@intel.com \
    --to=pranay.samala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox