public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/kms_sharpness_filter: Fix redundant mode override
@ 2026-04-14  6:09 Pranay Samala
  2026-04-14  6:55 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Pranay Samala @ 2026-04-14  6:09 UTC (permalink / raw)
  To: igt-dev; +Cc: pranay.samala

Move override mode into if block to avoid redundancy.

Fixes: 15663498141b ("tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass")
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/intel/kms_sharpness_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index 15c5e6006..bdfdf1d08 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -453,6 +453,8 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 					continue;
 				}
 
+				igt_output_override_mode(data->output, data->mode);
+
 				igt_info("Executing on non-joiner mode %dx%d@%d\n",
 					 data->mode->hdisplay,
 					 data->mode->vdisplay,
@@ -461,8 +463,6 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 				data->mode = igt_output_get_mode(data->output);
 			}
 
-			igt_output_override_mode(data->output, data->mode);
-
 			if (!has_sharpness_filter(data->crtc)) {
 				igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
 				igt_crtc_name(data->crtc));
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-04-14 11:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-14  6:09 [PATCH i-g-t] tests/intel/kms_sharpness_filter: Fix redundant mode override Pranay Samala
2026-04-14  6:55 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-14  6:55 ` ✓ i915.CI.BAT: " Patchwork
2026-04-14  8:18 ` [PATCH i-g-t] " Karthik B S
2026-04-14  8:34 ` ✗ Xe.CI.FULL: failure for " Patchwork
2026-04-14 11:38 ` ✓ i915.CI.Full: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox