Re: [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 10/19/2024 12:36 AM, Swati Sharma wrote:
> Added func() to print scaling mode name string.

Nitpick: use Add in commit message and the subject to maintain the 
imperative mood.

Same for previous patch.


>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   lib/igt_kms.c | 19 +++++++++++++++++++
>   lib/igt_kms.h |  1 +
>   2 files changed, 20 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 73b024e0b..08ad96d2d 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1040,6 +1040,25 @@ const char *kmstest_scaling_filter_str(int filter)
>   	return find_type_name(scaling_filter_names, filter);
>   }
>   
> +static const struct type_name scaling_modes_names[] = {
> +	{ DRM_MODE_SCALE_FULLSCREEN, "fullscreen" },
> +	{ DRM_MODE_SCALE_CENTER, "center" },
> +	{ DRM_MODE_SCALE_ASPECT, "aspect" },
> +	{ DRM_MODE_SCALE_NONE, "none" },
> +	{}
> +};
> +
> +/**
> + * kmstest_scaling_mode_str:
> + * @mode: SCALING_MODE_* mode value
> + *
> + * Returns: A string representing the scaling mode @mode.
> + */
> +const char *kmstest_scaling_mode_str(uint32_t mode)

This can simply be int. find_type_name expects int.

Otherwise looks good to me. Perhaps we can also use this in 
kms_scaling_mode, for consistency.

With above minor things fixed, this is:

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


Regards,

Ankit

> +{
> +	return find_type_name(scaling_modes_names, mode);
> +}
> +
>   static const struct type_name dsc_output_format_names[] = {
>   	{ DSC_FORMAT_RGB, "RGB" },
>   	{ DSC_FORMAT_YCBCR420, "YCBCR420" },
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 9bba0924d..cc705763f 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -142,6 +142,7 @@ const char *kmstest_encoder_type_str(int type);
>   const char *kmstest_connector_status_str(int status);
>   const char *kmstest_connector_type_str(int type);
>   const char *kmstest_scaling_filter_str(int filter);
> +const char *kmstest_scaling_mode_str(uint32_t mode);
>   const char *kmstest_dsc_output_format_str(int output_format);
>   
>   void kmstest_dump_mode(drmModeModeInfo *mode);