Re: [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 10/19/2024 12:36 AM, Swati Sharma wrote:
> Added "sharpness strength" as crtc property.
>
> v2: Replace SHARPENESS_STRENGTH with SHARPNESS_STRENGTH. (Nemesa)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

LGTM

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
>   lib/igt_kms.c | 4 ++++
>   lib/igt_kms.h | 1 +
>   2 files changed, 5 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index b40470c02..73b024e0b 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -700,6 +700,7 @@ const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
>   	[IGT_CRTC_OUT_FENCE_PTR] = "OUT_FENCE_PTR",
>   	[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
>   	[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
> +	[IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
>   };
>   
>   const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
> @@ -2562,6 +2563,9 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
>   	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SCALING_FILTER))
>   		igt_pipe_obj_set_prop_enum(pipe, IGT_CRTC_SCALING_FILTER, "Default");
>   
> +	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SHARPNESS_STRENGTH))
> +		igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_SHARPNESS_STRENGTH, 0);
> +
>   	pipe->out_fence_fd = -1;
>   }
>   
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 25ba50916..9bba0924d 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -163,6 +163,7 @@ enum igt_atomic_crtc_properties {
>          IGT_CRTC_OUT_FENCE_PTR,
>          IGT_CRTC_VRR_ENABLED,
>          IGT_CRTC_SCALING_FILTER,
> +       IGT_CRTC_SHARPNESS_STRENGTH,
>          IGT_NUM_CRTC_PROPS
>   };
>