[igt-dev] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f

[igt-dev] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f

[Chris Wilson]

A missing newline at the end of an assert, so add it for clarity in the
error message.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/perf_pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 391378139..c3993c417 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
 	} while (!obj_ptr[1]);
 
 	igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
-		     "sampling failed to start withing 10ms");
+		     "sampling failed to start withing 10ms\n");
 
 	val[0] = __pmu_read_single(fd, &ts[0]);
 	slept = measured_usleep(batch_duration_ns / 1000);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f

[Tvrtko Ursulin]

On 02/02/2019 22:36, Chris Wilson wrote:
> A missing newline at the end of an assert, so add it for clarity in the
> error message.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/perf_pmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 391378139..c3993c417 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
>   	} while (!obj_ptr[1]);
>   
>   	igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
> -		     "sampling failed to start withing 10ms");
> +		     "sampling failed to start withing 10ms\n");
>   
>   	val[0] = __pmu_read_single(fd, &ts[0]);
>   	slept = measured_usleep(batch_duration_ns / 1000);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f

[Katarzyna Dec]

On Sat, Feb 02, 2019 at 10:36:30PM +0000, Chris Wilson wrote:
> A missing newline at the end of an assert, so add it for clarity in the
> error message.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Have a nice day!
Kasia :)
> ---
>  tests/i915/perf_pmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 391378139..c3993c417 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
>  	} while (!obj_ptr[1]);
>  
>  	igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
> -		     "sampling failed to start withing 10ms");
> +		     "sampling failed to start withing 10ms\n");
>  
>  	val[0] = __pmu_read_single(fd, &ts[0]);
>  	slept = measured_usleep(batch_duration_ns / 1000);
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev