Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: nemesa.garg@intel.com
Subject: Re: [PATCH] lib: sync i915_pciids.h with kernel
Date: Wed, 13 Dec 2023 15:17:22 +0200	[thread overview]
Message-ID: <c3cae6fc-8a97-4abd-9918-bba55c1757ca@gmail.com> (raw)
In-Reply-To: <20231212090841.2060493-1-chaitanya.kumar.borah@intel.com>

This is not correct. This does not synchronize with kernel commit. 
i915_pciids.h is supposed to be copied as is from kernel. Also don't do 
other changes in same patch, put intel_device_info.c changes into their 
own patch.

You can see "git log lib/i915_pciids.h" for examples, sans two latest 
changes into the file. Two two latest changes are broken.

/Juha-Pekka

On 12.12.2023 11.08, Chaitanya Kumar Borah wrote:
> This synchronizes with kernel commit
> 
> 8940da9fe5f27 ("drm/i915/mtl: Adding DeviceID for Arrowlake-S under MTL")
> to bring in ARL-S PCI IDs.
> 
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   lib/i915_pciids.h       | 4 ++++
>   lib/intel_device_info.c | 1 +
>   2 files changed, 5 insertions(+)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index bee58554d..106e42f84 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -750,6 +750,10 @@
>   	INTEL_MTL_M_IDS(info), \
>   	INTEL_MTL_P_IDS(info)
>   
> +/* ARL-S */
> +#define INTEL_ARLS_IDS(info) \
> +	INTEL_VGA_DEVICE(0x7D67, info)
> +
>   /* PVC */
>   #define INTEL_PVC_IDS(info) \
>   	INTEL_VGA_DEVICE(0x0BD0, info),	\
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 34817f7b6..48036bec5 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -614,6 +614,7 @@ static const struct pci_id_match intel_device_match[] = {
>   	INTEL_ATS_M_IDS(&intel_ats_m_info),
>   
>   	INTEL_MTL_IDS(&intel_meteorlake_info),
> +	INTEL_ARLS_IDS(&intel_meteorlake_info),
>   
>   	INTEL_PVC_IDS(&intel_pontevecchio_info),
>   

  parent reply	other threads:[~2023-12-13 13:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  9:08 [PATCH] lib: sync i915_pciids.h with kernel Chaitanya Kumar Borah
2023-12-12 10:24 ` ✗ CI.xeBAT: failure for lib: sync i915_pciids.h with kernel (rev14) Patchwork
2023-12-13 13:17 ` Juha-Pekka Heikkila [this message]
2023-12-14  4:48   ` [PATCH] lib: sync i915_pciids.h with kernel Borah, Chaitanya Kumar
2023-12-14 14:36     ` Kamil Konieczny
2023-12-18 10:14       ` Borah, Chaitanya Kumar
2023-12-18 16:19         ` Kamil Konieczny
2023-12-19  5:43           ` Borah, Chaitanya Kumar
2023-12-19  7:00             ` Kamil Konieczny
2023-12-22 12:18               ` Lionel Landwerlin
2024-01-05 13:26                 ` Jani Nikula
2024-01-05 13:35                   ` Lionel Landwerlin
2024-01-05 13:47                     ` Jani Nikula
2023-12-14  5:03 ` ✗ Fi.CI.BUILD: failure for lib: sync i915_pciids.h with kernel (rev15) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-03-27 20:12 [PATCH] lib: sync i915_pciids.h with kernel Ravi Kumar Vodapalli
2024-03-28 19:32 ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3cae6fc-8a97-4abd-9918-bba55c1757ca@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox